[pgadmin-hackers] pgAdmin 4 commit: Fixes #2328

Fixes #2328 1) Fixed issue of opening Query Tool and Debugger in new Tab with QT 5.8 and annulen webkit 2) Moved unload event of window from javascript files to html. 3) Change alertify messages for debugger. 4) Closed all connections created by debugger. Previously only one connection has be

Re: [pgadmin-hackers] [pgAdmin4][runtime]: RM #2328 - Unable to launch query tool and debugger in new browser tab

Thanks patch applied. On Mon, May 8, 2017 at 3:21 PM, Dave Page wrote: > Akshay, could you review this please? > > Thanks. > > On Fri, May 5, 2017 at 11:53 AM, Neel Patel > wrote: > >> Hi, >> >> Please find attached patch file with the fix of RM #2328 - [Runtime]: >> Unable to launch query tool

Re: [pgadmin-hackers] [pgAdmin4][runtime]: RM #2328 - Unable to launch query tool and debugger in new browser tab

This appears to have made Jenkins get all angry and red :-( https://jenkins.pgadmin.org/ On Tue, May 9, 2017 at 8:39 AM, Akshay Joshi wrote: > Thanks patch applied. > > On Mon, May 8, 2017 at 3:21 PM, Dave Page wrote: > >> Akshay, could you review this please? >> >> Thanks. >> >> On Fri, May 5

Re: [pgadmin-hackers] [pgAdmin4][runtime]: RM #2328 - Unable to launch query tool and debugger in new browser tab

Hi On Tue, May 9, 2017 at 1:42 PM, Dave Page wrote: > This appears to have made Jenkins get all angry and red :-( > > https://jenkins.pgadmin.org/ > We(Neel and I) have tested it and working fine. > > > On Tue, May 9, 2017 at 8:39 AM, Akshay Joshi < > akshay.jo...@enterprisedb.com> wrote: >

Re: [pgadmin-hackers] Autoformatting

On Mon, May 8, 2017 at 3:50 PM, Robert Eckhardt wrote: > Over the weekend I created some options for formatting. certainly this > isn't complete but I hope it is a good starting point for the conversation. > Copy and paste lost syntax highlighting but please assume that will be > included. > > /*

Re: [pgadmin-hackers] [pgAdmin4][runtime]: RM #2328 - Unable to launch query tool and debugger in new browser tab

On Tue, May 9, 2017 at 9:18 AM, Akshay Joshi wrote: > Hi > > On Tue, May 9, 2017 at 1:42 PM, Dave Page > wrote: > >> This appears to have made Jenkins get all angry and red :-( >> >> https://jenkins.pgadmin.org/ >> > >We(Neel and I) have tested it and working fine. > It clearly doesn't comp

Re: [pgadmin-hackers] [pgAdmin4][runtime]: RM #2328 - Unable to launch query tool and debugger in new browser tab

Hi Dave, Yes, It looks like compilation fails on Qt4. We will fix this issue but which version of Qt4 we are using in Jenkins ? Thanks, Neel Patel On Tue, May 9, 2017 at 1:56 PM, Dave Page wrote: > > > On Tue, May 9, 2017 at 9:18 AM, Akshay Joshi < > akshay.jo...@enterprisedb.com> wrote: > >>

Re: [pgadmin-hackers] [pgAdmin4][runtime]: RM #2328 - Unable to launch query tool and debugger in new browser tab

It's running CentOS 7.3, with packages from EPEL: [dpage@jenkins ~]$ rpm -qa |grep qt qt5-qtbase-common-5.6.1-10.el7.noarch qt5-qtbase-devel-5.6.1-10.el7.x86_64 qt-4.8.5-13.el7.x86_64 qt5-qtbase-5.6.1-10.el7.x86_64 qt5-qtxmlpatterns-5.6.1-10.el7.x86_64 qt5-qtwebchannel-5.6.1-10.el7.x86_64 qt5-qtwe

Re: [pgadmin-hackers] [pgAdmin4][runtime]: RM #2328 - Unable to launch query tool and debugger in new browser tab

Hi Dave, Here there are 2 compilation issue. We have fixed 'QNetworkCookieJar' related compilation error in Qt4. BUT Below compilation error is coming because we have not applied the latest patch of webkit which was fixed in annulen/webkit repo which was raised at below path. https://github.com/

[pgadmin-hackers] [pgAdmin4][PATCH] To add handling of BOM character in query tool

Hi, Please find patch to fix the issue handling BOM characters in user files when they load their sql files in query tool. RM#2369 FYI, I have attached sample BOM file in redmine for testing. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Compan

Re: [pgadmin-hackers] [pgAdmin4][runtime]: RM #2328 - Unable to launch query tool and debugger in new browser tab

Hi On Tue, May 9, 2017 at 10:28 AM, Neel Patel wrote: > Hi Dave, > > Here there are 2 compilation issue. We have fixed 'QNetworkCookieJar' > related compilation error in Qt4. BUT > > Below compilation error is coming because we have not applied the latest > patch of webkit which was fixed in ann

Re: [pgadmin-hackers] [pgAdmin4][runtime]: RM #2328 - Unable to launch query tool and debugger in new browser tab

Hi Dave, On Tue, May 9, 2017 at 3:08 PM, Dave Page wrote: > Hi > > On Tue, May 9, 2017 at 10:28 AM, Neel Patel > wrote: > >> Hi Dave, >> >> Here there are 2 compilation issue. We have fixed 'QNetworkCookieJar' >> related compilation error in Qt4. BUT >> >> Below compilation error is coming beca

Re: [pgadmin-hackers][patch] Dependents and Dependencies in GreenPlum

Hi Sarah Below are my review comments on the latest patch: - Some test file names ended with "*_sql_template.py*" do we need to add that string ? - Files "test_column_acl_sql_template.py" and "test_column_properties_sql _template.py" should be moved from tables->tests to tables->co

Re: [pgadmin-hackers] [pgAdmin4][Patch][RM2257]: Query tool - Insert row doesn't use default values

Hi Dave, On Mon, May 8, 2017 at 4:37 PM, Dave Page wrote: > > > On Mon, May 8, 2017 at 11:51 AM, Surinder Kumar < > surinder.ku...@enterprisedb.com> wrote: > >> Hi >> >> On Mon, May 8, 2017 at 3:51 PM, Dave Page wrote: >> >>> Hi >>> >>> On Mon, May 8, 2017 at 11:13 AM, Surinder Kumar < >>> suri

Re: [pgadmin-hackers] [pgAdmin4][Patch][RM2257]: Query tool - Insert row doesn't use default values

On Tue, May 9, 2017 at 11:03 AM, Surinder Kumar < surinder.ku...@enterprisedb.com> wrote: > Hi Dave, > > On Mon, May 8, 2017 at 4:37 PM, Dave Page wrote: > >> >> >> On Mon, May 8, 2017 at 11:51 AM, Surinder Kumar < >> surinder.ku...@enterprisedb.com> wrote: >> >>> Hi >>> >>> On Mon, May 8, 2017 a

Re: [pgadmin-hackers] [pgAdmin4][PATCH] To add handling of BOM character in query tool

Thanks, patch applied. On Tue, May 9, 2017 at 10:33 AM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi, > > Please find patch to fix the issue handling BOM characters in user files > when they load their sql files in query tool. > RM#2369 > > FYI, > I have attached sample BOM

[pgadmin-hackers] pgAdmin 4 commit: Support loading files with Unicode BOMs. Fixes #2369

Support loading files with Unicode BOMs. Fixes #2369 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=13f4432bbdf2c8eb502d2677f7a31cecf17574b5 Author: Murtuza Zabuawala Modified Files -- web/pgadmin/misc/file_manager/__init__.py |

[pgadmin-hackers] Build failed in Jenkins: pgadmin4-master-python26 #215

See Changes: [Dave Page] Support loading files with Unicode BOMs. Fixes #2369 -- [...truncated 293.17 KB...] copying images... [ 34%] images/query_output_messages

[pgadmin-hackers] Build failed in Jenkins: pgadmin4-master-python36 #99

See Changes: [Dave Page] Support loading files with Unicode BOMs. Fixes #2369 -- [...truncated 287.14 KB...] copying images... [ 28%] images/foreign_key_sql.png co

[pgadmin-hackers] Build failed in Jenkins: pgadmin4-master-python34 #97

See Changes: [Dave Page] Support loading files with Unicode BOMs. Fixes #2369 -- [...truncated 287.15 KB...] copying images... [ 28%] images/foreign_table_definiti

[pgadmin-hackers] Build failed in Jenkins: pgadmin4-master-python33 #99

See Changes: [Dave Page] Support loading files with Unicode BOMs. Fixes #2369 -- [...truncated 287.16 KB...] copying images... [ 28%] images/database_general.png c

[pgadmin-hackers] Relax version dependency on psycopg2

Right now psycopg2 is required to be exactly version 2.6.2, which makes it mostly impossible to install pgadmin4 without having the postgresql C development packages installed (since you need to rebuild psycopg2 from source to make that work, given that few platforms ship *exactly* that version).

[pgadmin-hackers] Build failed in Jenkins: pgadmin4-master-python27 #106

See Changes: [Dave Page] Support loading files with Unicode BOMs. Fixes #2369 -- [...truncated 287.16 KB...] copying images... [ 28%] images/package_sql.png copyi

Re: [pgadmin-hackers] Relax version dependency on psycopg2

Thanks, patch applied. On Tue, May 9, 2017 at 12:28 PM, Magnus Hagander wrote: > Right now psycopg2 is required to be exactly version 2.6.2, which makes it > mostly impossible to install pgadmin4 without having the postgresql C > development packages installed (since you need to rebuild psycopg2

[pgadmin-hackers] pgAdmin 4 commit: Relax version dependency on psycopg2

Relax version dependency on psycopg2 Right now psycopg2 is required to be exactly version 2.6.2, which makes it mostly impossible to install pgadmin4 without having the postgresql C development packages installed (since you need to rebuild psycopg2 from source to make that work, given that few

[pgadmin-hackers] Build failed in Jenkins: pgadmin4-master-python35 #97

See Changes: [Dave Page] Support loading files with Unicode BOMs. Fixes #2369 -- [...truncated 287.21 KB...] copying images... [ 28%] images/restore_miscellaneous.

[pgadmin-hackers] Build failed in Jenkins: pgadmin4-master-python33 #100

See Changes: [Dave Page] Relax version dependency on psycopg2 -- [...truncated 287.18 KB...] copying images... [ 28%] images/pgagent_schedule_exceptions.png copyi

[pgadmin-hackers] Build failed in Jenkins: pgadmin4-master-python34 #98

See Changes: [Dave Page] Relax version dependency on psycopg2 -- [...truncated 287.20 KB...] copying images... [ 28%] images/domain_constraints.png copying images.

[pgadmin-hackers] Build failed in Jenkins: pgadmin4-master-python36 #100

See Changes: [Dave Page] Relax version dependency on psycopg2 -- [...truncated 287.25 KB...] copying images... [ 28%] images/foreign_key_sql.png copying images...

[pgadmin-hackers] Build failed in Jenkins: pgadmin4-master-python27 #107

See Changes: [Dave Page] Relax version dependency on psycopg2 -- [...truncated 287.20 KB...] copying images... [ 28%] images/package_sql.png copying images... [ 2

[pgadmin-hackers] Build failed in Jenkins: pgadmin4-master-python35 #98

See Changes: [Dave Page] Relax version dependency on psycopg2 -- [...truncated 287.33 KB...] copying images... [ 28%] images/database_parameters.png copying images

[pgadmin-hackers] Build failed in Jenkins: pgadmin4-master-python26 #216

See Changes: [Dave Page] Relax version dependency on psycopg2 -- [...truncated 291.21 KB...] copying images... [ 34%] images/query_output_messages.png copying ima

[pgadmin-hackers] [pgAdmin4][PATCH] To fix the of issue in table node

Hi, PFA minor patch to fix the issue in table node where it fails to create table when user provides numeric table name eg: 123. RM#2284 Issue is when use json.loads() it converts string "123" into integer 123. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterpris

Re: [pgadmin-hackers] [pgAdmin4][PATCH] To fix the of issue in table node

Hi, Please find updated patch. Updated logic to convert name only if name is of type int/long/float (Python2) or of type int/float (Python3) instead of blindly convert it to string. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Tue,

Re: [pgadmin-hackers][patch] Dependents and Dependencies in GreenPlum

Hi Akshay! > Some test file names ended with "*_sql_template.py*" do we need to add > that string ? we added this suffix after moving the tests up a level to tables/tests to clarify what subject they applied to. we changed the suffix to "_sql.py" - Files "test_column_acl_sql_template.py" and "t

Re: [pgadmin-hackers] Re: Server side cursor limitations for on demand loading of data in query tool [RM2137] [pgAdmin4]

Hi, -- *Harshal Dhumal* *Sr. Software Engineer* EnterpriseDB India: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Tue, May 9, 2017 at 1:08 AM, Sarah McAlear wrote: > Hi Harshal! > > We applied your patch and ran the Javascript tests and realized there are > 6 tests failing.

[pgadmin-hackers] [pgAdmin4][PATCH] To fix the of issue in Trigger node

Hi, Please find minor patch to fix the issue in trigger node where user tries to update name/comments on the trigger which is set to disable, it changes the icon of the trigger which displays it as enabled in browser tree. RM#2271 -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprised

Re: [pgadmin-hackers] [pgAdmin4][runtime]: RM #2328 - Unable to launch query tool and debugger in new browser tab

Hi, Please find attached patch file with the fix of compilation issues with Qt4. Tested with both the version of Qt4 and Qt5 webkit and it is working now. As triggerAction code will not be applicable for Qt4 so we made conditional macro for Qt5 version check and for backward compatibility webkit

Re: [pgadmin-hackers][patch] Dependents and Dependencies in GreenPlum

Hi Sarah On Tue, May 9, 2017 at 9:03 PM, Sarah McAlear wrote: > Hi Akshay! > > >> Some test file names ended with "*_sql_template.py*" do we need to add >> that string ? > > we added this suffix after moving the tests up a level to tables/tests to > clarify what subject they applied to. we chang

Re: [pgadmin-hackers] [pgAdmin4][runtime]: RM #2328 - Unable to launch query tool and debugger in new browser tab

Hi What happens on a standard QtWebKit if we try to trigger QWebPage::ToggleVideoFullscreen + 1? Does it error, or get silently ignored? -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK:http://www.enterprisedb.com The Enterprise PostgreSQL Company > On 10 May 2