Re: [pgadmin-hackers] [patch] upgrade slickgrid

2017-05-18 Thread Dave Page
Hi On Wed, May 17, 2017 at 4:45 PM, Matthew Kleiman wrote: > Hi Dave > > Have you confirmed that removing the changes we made to shorten the class >> names used for rows and cells doesn't affect the performance or memory >> utilisation of the grid? > > > We haven't noticed any performance issues

[pgadmin-hackers] [patch] update table name in confirmation dialog for 'Reset Statistics' and 'Truncate Table'

2017-05-18 Thread Akshay Joshi
Hi All I have found one issue where table name is not displaying in the confirmation dialog when user click on "Reset Statistics" and "Truncate/Truncate cascade". Confirmation dialog shows below message: - Are you sure you want to truncate table {}? - Are you sure you want to reset the stat

Re: [pgadmin-hackers] [pgAdmin4] [PATCH] History Tab rewrite in React

2017-05-18 Thread Dave Page
Hi On Thu, May 18, 2017 at 9:56 AM, Murtuza Zabuawala wrote: > > Go to 'pgadmin4/web' directory > > Try running, > > run 'yarn install' > > (if you have installed globally) > then run 'grunt' > OR > run './node_modules/grunt-cli/bin/grunt' > > > Then run pgAdmin4 > OK, that worked - though pgAd

Re: [pgadmin-hackers] [patch] update table name in confirmation dialog for 'Reset Statistics' and 'Truncate Table'

2017-05-18 Thread Dave Page
Hi Please see the discussion here: https://redmine.postgresql.org/issues/2308 Would moving to the client-side translation mechanism help here? We need to do that anyway - and it's been added since the previous discussion. On Thu, May 18, 2017 at 10:17 AM, Akshay Joshi < akshay.jo...@enterprisedb

Re: [pgadmin-hackers] [patch] update table name in confirmation dialog for 'Reset Statistics' and 'Truncate Table'

2017-05-18 Thread Akshay Joshi
On Thu, May 18, 2017 at 3:00 PM, Dave Page wrote: > Hi > > Please see the discussion here: https://redmine.postgresql.org/issues/2308 > > Would moving to the client-side translation mechanism help here? We need > to do that anyway - and it's been added since the previous discussion. > OK, at

Re: [pgadmin-hackers] [patch] update table name in confirmation dialog for 'Reset Statistics' and 'Truncate Table'

2017-05-18 Thread Dave Page
On Thu, May 18, 2017 at 10:37 AM, Akshay Joshi < akshay.jo...@enterprisedb.com> wrote: > > > On Thu, May 18, 2017 at 3:00 PM, Dave Page wrote: > >> Hi >> >> Please see the discussion here: https://redmine.postgres >> ql.org/issues/2308 >> >> Would moving to the client-side translation mechanism h

[pgadmin-hackers] Fix for RM2421 [pgAdmin4][patch]

2017-05-18 Thread Harshal Dhumal
Hi, Please find attached patch for RM2421 Issue fixed: 1. Integer/numeric Validation is not working properly. 2. Wrong CPU rate unit -- *Harshal Dhumal* *Sr. Software Engineer* EnterpriseDB India: http://www.enterprisedb.com The Enterprise PostgreSQL Company diff --git a/web/pgadmin/browser/ser

Re: [pgadmin-hackers] [patch] update table name in confirmation dialog for 'Reset Statistics' and 'Truncate Table'

2017-05-18 Thread Akshay Joshi
On Thu, May 18, 2017 at 3:23 PM, Dave Page wrote: > > > On Thu, May 18, 2017 at 10:37 AM, Akshay Joshi < > akshay.jo...@enterprisedb.com> wrote: > >> >> >> On Thu, May 18, 2017 at 3:00 PM, Dave Page wrote: >> >>> Hi >>> >>> Please see the discussion here: https://redmine.postgres >>> ql.org/issu

Re: [pgadmin-hackers] [patch] update table name in confirmation dialog for 'Reset Statistics' and 'Truncate Table'

2017-05-18 Thread Dave Page
On Thu, May 18, 2017 at 11:03 AM, Akshay Joshi < akshay.jo...@enterprisedb.com> wrote: > > > On Thu, May 18, 2017 at 3:23 PM, Dave Page wrote: > >> >> >> On Thu, May 18, 2017 at 10:37 AM, Akshay Joshi < >> akshay.jo...@enterprisedb.com> wrote: >> >>> >>> >>> On Thu, May 18, 2017 at 3:00 PM, Dave

Re: [pgadmin-hackers] [patch] upgrade slickgrid

2017-05-18 Thread Robert Eckhardt
On Thu, May 18, 2017 at 4:42 AM, Dave Page wrote: > > > Feel like putting that in your backlog? :-) > Interesting you say that. It is either going to be trivial to do or we won't have the context on which vendored libraries have been changed. We have a task to try and see if it is trivial. If it

Re: [pgadmin-hackers] [patch] upgrade slickgrid

2017-05-18 Thread Dave Page
On Thu, May 18, 2017 at 2:04 PM, Robert Eckhardt wrote: > > > On Thu, May 18, 2017 at 4:42 AM, Dave Page wrote: > >> >> >> Feel like putting that in your backlog? :-) >> > > Interesting you say that. It is either going to be trivial to do or we > won't have the context on which vendored librarie

Re: [pgadmin-hackers] [pgAdmin4][Patch][RM_2400]: Columns with defaults set to NULL when removing contents after pasting in the edit grid

2017-05-18 Thread Joao Pedro De Almeida Pereira
Hello Hackers, We reviewed the PR, and there are a lot of new lines of code in this patch, are we sure that we can have a good coverage of the functionality just by doing feature tests? Adding more code to a 3.5k+ lines file doesn't look like a good option, do you think it is possible to extract s

Re: [pgadmin-hackers] Fix for RM2421 [pgAdmin4][patch]

2017-05-18 Thread Joao Pedro De Almeida Pereira
Hello Harshal, We review the patch and have some questions: 1) Is there any particular reason to initialize variables and functions in the same place? We believe that it would be more readable there were no chaining of variable creation, specially if those variables are functions. Check line: +++

[pgadmin-hackers] [pgAdmin4][runtime][patch]: RM#2398 - Proxy not bypassed for embedded server in runtime on Windows

2017-05-18 Thread Neel Patel
Hi Dave, Please find attached patch for the fix of RM#2398 - "Proxy not bypassed for embedded server in runtime on Windows". *Observation:-* We have observed this issue only with Qt WebEngine. We have not observed this issue with Webkit ( Tested with Qt 5.3 ). *Issue:-* If user set option "Bypas

Re: [pgadmin-hackers] [pgAdmin4][PATCH] To fix the issue with Node rename

2017-05-18 Thread Joao Pedro De Almeida Pereira
Hello Hackers, @Dave, @Murtuza We do understand that the changes are tightly coupled with the tree, but if we want to be able to upgrade our tree menu in the future, we need to start decoupling functionality and the underlaying tree. Another step that we can take is to change our variable naming c

Re: [pgadmin-hackers] [pgAdmin4] [PATCH] History Tab rewrite in React

2017-05-18 Thread Matthew Kleiman
Dave, Can you try running grunt tests on the command line? The tests task will run the eslint and karma grunt tasks, which should automatically webpack the React components before running the jasmine tests in karma. If it still fails, send us the output of that. Thanks, Matt On Thu, May 18, 20

Re: [pgadmin-hackers] Fix for RM2421 [pgAdmin4][patch]

2017-05-18 Thread Harshal Dhumal
Hi, On Thu, May 18, 2017 at 7:57 PM, Joao Pedro De Almeida Pereira < jdealmeidapere...@pivotal.io> wrote: > Hello Harshal, > > We review the patch and have some questions: > 1) Is there any particular reason to initialize variables and functions in > the same place? We believe that it would be mo