Re: [pgadmin-hackers] Declarative partitioning in pgAdmin4

2017-05-24 Thread Akshay Joshi
Hi Shirley On Tue, May 23, 2017 at 7:39 PM, Shirley Wang wrote: > It's less about implementing what's easy, and more about implementing what > we know for sure will provide user value. > Agreed, but if that feature(expression) is available in postgresql then users/QA will ask why that is not

Re: [pgadmin-hackers] Declarative partitioning in pgAdmin4

2017-05-24 Thread Akshay Joshi
Hi Robert On Tue, May 23, 2017 at 8:09 PM, Robert Eckhardt wrote: > > > On Tue, May 23, 2017 at 10:09 AM, Shirley Wang wrote: > >> >> It's possible to design for the range and list partitions and know we can >> achieve success because we understand how users would go through this >> workflow. N

Re: [pgadmin-hackers] [pgAdmin4][runtime][patch]: RM#2398 - Proxy not bypassed for embedded server in runtime on Windows

2017-05-24 Thread Neel Patel
Hi, After debugging the issue in windows, we came to know that "random port" generation logic in runtime is getting failed if we configured proxy server in windows. Below are the code where we are finding random free port and use with our URL "localhost:". Below code return "0" as port value so a

Re: [pgadmin-hackers] [pgAdmin4][PATCH] Improvements to Query Results Grid User Experience

2017-05-24 Thread Dave Page
Hi We don't want this to be committed, even to a local tree (as there's a risk it may inadvertently get pushed). These patches are for review only at this stage. Once they are ready, they may or may not be committed individually, and even then it's very unlikely that we'll want to use the supplied

Re: [pgadmin-hackers] [pgAdmin4] [PATCH] History Tab rewrite in React

2017-05-24 Thread Matthew Kleiman
Hi Dave, This one is our bad! We didn't create a grunt task to run the tests only once, as you would in CI. grunt tests currently runs the tests and continues to watch for changes, running the tests again each time the source code is modified. We will create a task that is suitable to run in CI.

Re: [pgadmin-hackers] Declarative partitioning in pgAdmin4

2017-05-24 Thread Robert Eckhardt
On Wed, May 24, 2017 at 3:35 AM, Akshay Joshi wrote: > >Taking average of two columns is just an example/representation of > expression, there is no use case of that. As I am also in learning phase. > Below are some use case that I can think of: > >- > >Partitions based on first lette

Re: [pgadmin-hackers] [pgAdmin4][runtime][patch]: RM#2398 - Proxy not bypassed for embedded server in runtime on Windows

2017-05-24 Thread Dave Page
Good catch - thanks Neel. I don't have my main dev laptop with me, so I'll have to test this next week. Watch this space :-) On Wed, May 24, 2017 at 4:22 AM, Neel Patel wrote: > Hi, > > After debugging the issue in windows, we came to know that "random port" > generation logic in runtime is getti