Re: [pgadmin-hackers] Fix for RM2421 [pgAdmin4][patch]

Hi, On Mon, Jun 5, 2017 at 9:25 PM, Dave Page wrote: > Hi > > With this patch applied, it uses the field names instead of the labels > in error messages - e.g. > > 'dirty_rate_limit' must be numeric > > instead of: > > 'Dirty Rate Limit (KB)' must be numeric. > Fixed. Please

[pgadmin-hackers] pgAdmin 4 commit: Properly refresh the parent node when renaming childr

Properly refresh the parent node when renaming children. Fixes #2355 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=0bc9997a95114fd8d023d3369b186d9ba843a1ad Author: Murtuza Zabuawala Modified Files

Re: [pgadmin-hackers] [pgAdmin4][PATCH] To enable dialog help option for Language and Foreign table node

Thanks, applied. On Wed, May 31, 2017 at 7:26 AM, Murtuza Zabuawala wrote: > Hi, > > PFA minor patch to enable dialog help option for Language and Foreign table > node. > RM#2116 > > -- > Regards, > Murtuza Zabuawala > EnterpriseDB: http://www.enterprisedb.com

Re: [pgadmin-hackers] [pgAdmin4][Patch]: Fixed RM #2425 : Can't delete rows when using composite primary key

Thanks, applied. On Wed, May 31, 2017 at 11:01 AM, Khushboo Vashi wrote: > Hi, > > Please find the attached patch to fix RM #2425 : Can't delete rows when > using composite primary key. > > The grid selection checking for Primary key does not honour the

[pgadmin-hackers] pgAdmin 4 commit: Handle composite primary keys correctly when deleting

Handle composite primary keys correctly when deleting rows in the Edit Grid. Fixes #2425 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=d21cbb8b1ffbd011cd5238f637580963504e3bb0 Author: Khushboo Vashi

Re: [pgadmin-hackers] Re: [pgAdmin4][Patch][Feature #1971]: Remember column sizes between executions of the same query in the query tool

Hi All, Please find updated patch which includes Jasmine test cases for functions getHash and calculateColumnWidth Thanks, Surinder On Mon, Jun 5, 2017 at 11:38 PM, Shruti B Iyer wrote: > Hi Surinder! > > We reviewed this patch. The changes look good and we especially like

[pgadmin-hackers] Build failed in Jenkins: pgadmin4-master-python36 #135

See Changes: [Dave Page] Handle composite primary keys correctly when deleting rows in the Edit -- [...truncated 254.58 KB...] runTest

Re: [pgadmin-hackers] [pgAdmin4][Patch][RM_2448]: Multiple button presses to switch boolean fields

Thanks, applied. On Fri, Jun 2, 2017 at 11:20 AM, Surinder Kumar wrote: > Hi > > The behaviour for checkbox click will go "false -> true -> null ->" > > Please find attached patch and review. > > Thanks, > Surinder Kumar > > > -- > Sent via pgadmin-hackers

[pgadmin-hackers] pgAdmin 4 commit: Make $ quoting consistent. Fixes #1525

Make $ quoting consistent. Fixes #1525 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=cd3484d936ec76f654918c4fe7c812257b631dcd Author: Murtuza Zabuawala Modified Files --

Re: [pgadmin-hackers] [pgAdmin4][PATCH] To make $ quoting consistent

Thanks, patch applied. On Fri, Jun 2, 2017 at 1:12 PM, Murtuza Zabuawala wrote: > Hi, > > PFA patch to make to $ quoting consistent. in Function node > RM#1525 > > -- > Regards, > Murtuza Zabuawala > EnterpriseDB: http://www.enterprisedb.com > The Enterprise

Re: [pgadmin-hackers] Declarative partitioning in pgAdmin4

On Mon, Jun 5, 2017 at 5:17 PM, Robert Eckhardt wrote: > On Mon, Jun 5, 2017 at 11:45 AM, Dave Page wrote: > >> >> >> The former is what I was bleating about when I said we needed to expose >> partitions to the user. The latter isn't relevant -

[pgadmin-hackers] pgAdmin 4 commit: Enable dialogue help buttons on Language and Foreign

Enable dialogue help buttons on Language and Foreign Table dialogues. Fixes #2116 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=4b74a5ff3585b862c75a7ce4e9c37d6675be724f Author: Murtuza Zabuawala

Re: [pgadmin-hackers] Declarative partitioning in pgAdmin4

On Tue, Jun 6, 2017 at 4:32 AM, Dave Page wrote: > > For roll up this pattern seems obvious, identify the n partitions you >> need/want to combine and then run a job to combine them. >> > > You're thinking Greenplum :-). There is no roll up in PostgreSQL, unless > you're

Re: [pgadmin-hackers] [pgAdmin4][Patch]: Fixed RM 2324 - PostGIS datatypes not showing up properly on SQL tab.

On Tue, Jun 6, 2017 at 1:23 PM, Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > > > On 6 Jun 2017 17:42, "Dave Page" wrote: > > Hi > > The table and column dialogues seem to have related problems. For example, > the table dialogue shows the length of the geometry

Re: [pgadmin-hackers] [pgAdmin4][PATCH] To fix the issue in procedure debugging in EPAS

Thanks, patch applied. On Mon, Jun 5, 2017 at 8:13 AM, Murtuza Zabuawala wrote: > Hi, > > PFA patch to fix the issue where debugger module is not throwing proper > error for unsupported argument mode type in procedure. > RM#1466 > > @Neel, > Can you please do

Re: [pgadmin-hackers] [pgAdmin4][Patch]: Fixed RM 2324 - PostGIS datatypes not showing up properly on SQL tab.

On 6 Jun 2017 17:42, "Dave Page" wrote: Hi The table and column dialogues seem to have related problems. For example, the table dialogue shows the length of the geometry field in the test case as 847,380, whilst the column dialogue shows no length at all. What should be

[pgadmin-hackers] Jenkins build is back to normal : pgadmin4-master-python27 #143

See -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers] [pgAdmin4][Patch][RM_2400]: Columns with defaults set to NULL when removing contents after pasting in the edit grid

Thanks, patch applied. On Fri, Jun 2, 2017 at 8:55 PM, Surinder Kumar wrote: > Hi Dave, > > Please find updated patch with following changes: > > 1) Locate grid row by div's style attribute 'top'(i.e. 'top:0px' for first > row), instead of by div class-name

[pgadmin-hackers] pgAdmin 4 commit: Prevent attempts to debug procedures with variadic ar

Prevent attempts to debug procedures with variadic arguments. Fixes #1466 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=7e9f82bc1787ff300dbe319f18c8f9eb9dd928d3 Author: Murtuza Zabuawala Modified Files

Re: [pgadmin-hackers] [pgAdmin4][PATCH] To fix the issue in index or exclusion contrarians node

Thanks applied. On Wed, May 31, 2017 at 1:31 PM, Murtuza Zabuawala wrote: > Hi, > > PFA patch to fix the issue in index or exclusion contrarians node where it > was throwing "can't execute an empty query" error due to incorrect > validation logic for edit

[pgadmin-hackers] pgAdmin 4 commit: Correct the validation logic when modifying indexes/e

Correct the validation logic when modifying indexes/exclusion constraints. Fixes #2113 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=4c2004d479a9401523374299791a41cb163702fa Modified Files -- .../js/exclusion_constraint.js

[pgadmin-hackers] pgAdmin 4 commit: Fix default values and SQL formatting for event trigg

Fix default values and SQL formatting for event triggers. Fixes #1229 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=e6aa3e14947a0e415465fc0a96b67843e90d00ba Author: Murtuza Zabuawala Modified Files

Re: [pgadmin-hackers] [pgAdmin4][PATCH] To fix the spacing issue in SQL for Event trigger

Thanks, applied. On Fri, Jun 2, 2017 at 6:13 AM, Murtuza Zabuawala wrote: > Hi, > > PFA minor patch to fix the issue of extra spacing in generated SQL in Event > trigger. > RM#1229 > > -- > Regards, > Murtuza Zabuawala > EnterpriseDB:

[pgadmin-hackers] Jenkins build is back to normal : pgadmin4-master-python36 #136

See -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] pgAdmin 4 commit: Properly display security labels on EPAS 9.2+. Fixes

Properly display security labels on EPAS 9.2+. Fixes #1575 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=9803468a771f979cd2d1e44782f9fa89eefc4e6b Author: Murtuza Zabuawala Modified Files --

Re: [pgadmin-hackers] [pgAdmin4][PATCH] Display Security Labels in SQL (PPAS9.2+)

Thanks, applied. On Fri, Jun 2, 2017 at 4:22 PM, Murtuza Zabuawala wrote: > Hi, > > PFA minor patch to fix the issue where Security Labels were not displaying > in Reversed engineered schema SQL for PPAS9.2+. > RM#1575 > > -- > Regards, > Murtuza Zabuawala >

[pgadmin-hackers] Build failed in Jenkins: pgadmin4-master-python27 #142

See Changes: [Dave Page] Correct the validation logic when modifying indexes/exclusion [Dave Page] Fix default values and SQL formatting for event triggers. Fixes #1229 [Dave Page] Fix validation for

[pgadmin-hackers] [pgAdmin4][Patch][RM_2461]: Unable to drop defaut value from the column in table

Hi Add drop column syntax for dropping default value of a column if default value is kept empty. Please find attached patch and review. Thanks, Surinder RM_2461.patch Description: Binary data -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your

Re: [pgadmin-hackers] [pgAdmin4][PATCH] To fix the validation in Types node

Thanks, applied. On Fri, Jun 2, 2017 at 10:19 AM, Murtuza Zabuawala wrote: > Hi, > > PFA patch to fix the validation issues with Range & External type in Types > node. > RM#1795 > > -- > Regards, > Murtuza Zabuawala > EnterpriseDB: http://www.enterprisedb.com

[pgadmin-hackers] pgAdmin 4 commit: Fix validation for external and range types. Fixes #1

Fix validation for external and range types. Fixes #1795 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=bf06d828707f965eaa76aa5c8660efc43d05d6fd Author: Murtuza Zabuawala Modified Files --

[pgadmin-hackers] pgAdmin 4 commit: Ensure that boolean checkboxes cycle values in the co

Ensure that boolean checkboxes cycle values in the correct order. Fixes #2448 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=b82e00147879c2c3a670342263954bff72e211c9 Author: Surinder Kumar Modified Files

Re: [pgadmin-hackers] [pgAdmin4][Patch]: Fixed RM 2324 - PostGIS datatypes not showing up properly on SQL tab.

On 6 Jun 2017 18:36, "Dave Page" wrote: On Tue, Jun 6, 2017 at 1:23 PM, Khushboo Vashi wrote: > > > On 6 Jun 2017 17:42, "Dave Page" wrote: > > Hi > > The table and column dialogues seem to have related problems. For

Re: [pgadmin-hackers] [pgAdmin4][Patch]: Fixed RM 2324 - PostGIS datatypes not showing up properly on SQL tab.

On Tue, Jun 6, 2017 at 2:15 PM, Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > > > On 6 Jun 2017 18:36, "Dave Page" wrote: > > > > On Tue, Jun 6, 2017 at 1:23 PM, Khushboo Vashi < > khushboo.va...@enterprisedb.com> wrote: > >> >> >> On 6 Jun 2017 17:42, "Dave Page"