[pgadmin-hackers] SVN Commit by dpage: r4878 - in branches/REL-1_4_0_PATCHES/pgadmin3: . src/frm

2006-01-09 Thread svn
Author: dpage
Date: 2006-01-09 08:45:14 + (Mon, 09 Jan 2006)
New Revision: 4878

Modified:
   branches/REL-1_4_0_PATCHES/pgadmin3/CHANGELOG.txt
   branches/REL-1_4_0_PATCHES/pgadmin3/src/frm/frmExport.cpp
Log:
Set the initial Unicode/Local charset options correctly in the Export dialogue 
[Magnus Hagander]

Modified: branches/REL-1_4_0_PATCHES/pgadmin3/CHANGELOG.txt
===
--- branches/REL-1_4_0_PATCHES/pgadmin3/CHANGELOG.txt   2006-01-08 14:45:38 UTC 
(rev 4877)
+++ branches/REL-1_4_0_PATCHES/pgadmin3/CHANGELOG.txt   2006-01-09 08:45:14 UTC 
(rev 4878)
@@ -18,6 +18,7 @@
 /ul
 br
 ul
+li2006-01-09 DP  1.4.2  Set the initial Unicode/Local charset options 
correctly in the Export dialogue [Magnus Hagander]
 li2005-12-23 DP  1.4.2  Use ELSIF not ELSEIF in pgagent.sql for 
compatibility with 7.x servers [Glen Sasek]
 li2005-12-15 DP  1.4.2  Exclude system schemas by name rather than OID, 
so that 'public' can be safely renamed.
 li2005-12-12 AP  1.4.2  fix slony node statistics

Modified: branches/REL-1_4_0_PATCHES/pgadmin3/src/frm/frmExport.cpp
===
--- branches/REL-1_4_0_PATCHES/pgadmin3/src/frm/frmExport.cpp   2006-01-08 
14:45:38 UTC (rev 4877)
+++ branches/REL-1_4_0_PATCHES/pgadmin3/src/frm/frmExport.cpp   2006-01-09 
08:45:14 UTC (rev 4878)
@@ -64,7 +64,7 @@
 
 bool uc=settings-GetExportUnicode();
 rbUnicode-SetValue(uc);
-rbLocal-SetValue(uc);
+rbLocal-SetValue(!uc);
 
 bool isCrLf=settings-GetExportRowSeparator() == wxT(\r\n);
 rbCRLF-SetValue(isCrLf);


---(end of broadcast)---
TIP 6: explain analyze is your friend


[pgadmin-hackers] SVN Commit by dpage: r4879 - in trunk/pgadmin3: . src/frm

2006-01-09 Thread svn
Author: dpage
Date: 2006-01-09 08:46:40 + (Mon, 09 Jan 2006)
New Revision: 4879

Modified:
   trunk/pgadmin3/CHANGELOG.txt
   trunk/pgadmin3/src/frm/frmExport.cpp
Log:
Set the initial Unicode/Local charset options correctly in the Export dialogue 
[Magnus Hagander]

Modified: trunk/pgadmin3/CHANGELOG.txt
===
--- trunk/pgadmin3/CHANGELOG.txt2006-01-09 08:45:14 UTC (rev 4878)
+++ trunk/pgadmin3/CHANGELOG.txt2006-01-09 08:46:40 UTC (rev 4879)
@@ -18,8 +18,9 @@
 /ul
 br
 ul
-li2005-12-26 AP  1.4.2  Fix PK detection in EditGrid [Andrus Moor]
-li2005-12-26 AP  1.4.2  Fix Bitmap Index explain [Alexander Kirpa]
+li2006-01-09 DP  1.4.2  Set the initial Unicode/Local charset options 
correctly in the Export dialogue [Magnus Hagander]
+li2005-12-26 AP  1.4.2  Fix PK detection in EditGrid per Andrus Moor
+li2005-12-26 AP  1.4.2  Fix Bitmap Index explain per Alexander Kirpa
 li2005-12-23 DP  1.4.2  Use ELSIF not ELSEIF in pgagent.sql for 
compatibility with 7.x servers [Glen Sasek]
 li2005-12-22 HS dlgLanguage name+comment, dlgDatabase comment
 li2005-12-15 DP  1.4.2  Exclude system schemas by name rather than OID, 
so that 'public' can be safely renamed.

Modified: trunk/pgadmin3/src/frm/frmExport.cpp
===
--- trunk/pgadmin3/src/frm/frmExport.cpp2006-01-09 08:45:14 UTC (rev 
4878)
+++ trunk/pgadmin3/src/frm/frmExport.cpp2006-01-09 08:46:40 UTC (rev 
4879)
@@ -64,7 +64,7 @@
 
 bool uc=settings-GetExportUnicode();
 rbUnicode-SetValue(uc);
-rbLocal-SetValue(uc);
+rbLocal-SetValue(!uc);
 
 bool isCrLf=settings-GetExportRowSeparator() == wxT(\r\n);
 rbCRLF-SetValue(isCrLf);


---(end of broadcast)---
TIP 6: explain analyze is your friend


[pgadmin-hackers] SVN Commit by dpage: r4880 - branches/REL-1_4_0_PATCHES/pgadmin3

2006-01-09 Thread svn
Author: dpage
Date: 2006-01-09 08:47:06 + (Mon, 09 Jan 2006)
New Revision: 4880

Modified:
   branches/REL-1_4_0_PATCHES/pgadmin3/CHANGELOG.txt
Log:
Add a couple of missing items.

Modified: branches/REL-1_4_0_PATCHES/pgadmin3/CHANGELOG.txt
===
--- branches/REL-1_4_0_PATCHES/pgadmin3/CHANGELOG.txt   2006-01-09 08:46:40 UTC 
(rev 4879)
+++ branches/REL-1_4_0_PATCHES/pgadmin3/CHANGELOG.txt   2006-01-09 08:47:06 UTC 
(rev 4880)
@@ -19,6 +19,8 @@
 br
 ul
 li2006-01-09 DP  1.4.2  Set the initial Unicode/Local charset options 
correctly in the Export dialogue [Magnus Hagander]
+li2005-12-26 AP  1.4.2  Fix PK detection in EditGrid per Andrus Moor
+li2005-12-26 AP  1.4.2  Fix Bitmap Index explain per Alexander Kirpa
 li2005-12-23 DP  1.4.2  Use ELSIF not ELSEIF in pgagent.sql for 
compatibility with 7.x servers [Glen Sasek]
 li2005-12-15 DP  1.4.2  Exclude system schemas by name rather than OID, 
so that 'public' can be safely renamed.
 li2005-12-12 AP  1.4.2  fix slony node statistics


---(end of broadcast)---
TIP 5: don't forget to increase your free space map settings


Re: [pgadmin-hackers] Patch: Export unicode typo

2006-01-09 Thread Dave Page
Thanks, patch applied.

Regards, Dave 

 -Original Message-
 From: [EMAIL PROTECTED] 
 [mailto:[EMAIL PROTECTED] On Behalf Of 
 Magnus Hagander
 Sent: 08 January 2006 14:50
 To: pgadmin-hackers@postgresql.org
 Subject: [pgadmin-hackers] Patch: Export unicode typo
 
 Attached patch fixes what looks like a typo in the reading of previous
 unicode settings when exporting files from the query editor.
 
 Also, I sent a rather large patch yesterday, that has yet to 
 show up on
 the list. I assume there is a size limit, which puts it on 
 hold? Please
 let it through :P
 
 I'll send a couple of patches now, but send them as separate 
 mails just
 in case ;-)
 
 //Magnus
 

---(end of broadcast)---
TIP 5: don't forget to increase your free space map settings


[pgadmin-hackers] SVN Commit by dpage: r4881 - in trunk/pgadmin3: . src/ctl src/frm src/include src/include/ctl

2006-01-09 Thread svn
Author: dpage
Date: 2006-01-09 09:11:33 + (Mon, 09 Jan 2006)
New Revision: 4881

Modified:
   trunk/pgadmin3/CHANGELOG.txt
   trunk/pgadmin3/src/ctl/ctlSQLResult.cpp
   trunk/pgadmin3/src/frm/frmQuery.cpp
   trunk/pgadmin3/src/include/ctl/ctlSQLResult.h
   trunk/pgadmin3/src/include/frmQuery.h
   trunk/pgadmin3/src/include/menu.h
Log:
Use Ctrl-A to select all results in the query results pane. [Magnus Hagander]

Modified: trunk/pgadmin3/CHANGELOG.txt
===
--- trunk/pgadmin3/CHANGELOG.txt2006-01-09 08:47:06 UTC (rev 4880)
+++ trunk/pgadmin3/CHANGELOG.txt2006-01-09 09:11:33 UTC (rev 4881)
@@ -18,6 +18,7 @@
 /ul
 br
 ul
+li2006-01-09 DP Use Ctrl-A to select all results in the query 
results pane. [Magnus Hagander]
 li2006-01-09 DP  1.4.2  Set the initial Unicode/Local charset options 
correctly in the Export dialogue [Magnus Hagander]
 li2005-12-26 AP  1.4.2  Fix PK detection in EditGrid per Andrus Moor
 li2005-12-26 AP  1.4.2  Fix Bitmap Index explain per Alexander Kirpa

Modified: trunk/pgadmin3/src/ctl/ctlSQLResult.cpp
===
--- trunk/pgadmin3/src/ctl/ctlSQLResult.cpp 2006-01-09 08:47:06 UTC (rev 
4880)
+++ trunk/pgadmin3/src/ctl/ctlSQLResult.cpp 2006-01-09 09:11:33 UTC (rev 
4881)
@@ -40,6 +40,12 @@
 }
 
 
+void ctlSQLResult::SelectAll()
+{
+   for (int i = 0; i  GetItemCount(); i++)
+   Select(i);
+}
+
 bool ctlSQLResult::Export()
 {
 if (rowsRetrieved0 || (thread  thread-DataSet()-NumRows()  0))

Modified: trunk/pgadmin3/src/frm/frmQuery.cpp
===
--- trunk/pgadmin3/src/frm/frmQuery.cpp 2006-01-09 08:47:06 UTC (rev 4880)
+++ trunk/pgadmin3/src/frm/frmQuery.cpp 2006-01-09 09:11:33 UTC (rev 4881)
@@ -73,6 +73,7 @@
 EVT_MENU(MNU_HELP,  frmQuery::OnHelp)
 EVT_MENU(MNU_CLEARHISTORY,  frmQuery::OnClearHistory)
 EVT_MENU(MNU_SAVEHISTORY,   frmQuery::OnSaveHistory)
+   EVT_MENU(MNU_SELECTALL, frmQuery::OnSelectAll)
 EVT_ACTIVATE(   frmQuery::OnActivate)
 EVT_STC_MODIFIED(CTL_SQLQUERY,  frmQuery::OnChangeStc)
 EVT_STC_UPDATEUI(CTL_SQLQUERY,  frmQuery::OnPositionStc)
@@ -158,7 +159,7 @@
 
 UpdateRecentFiles();
 
-wxAcceleratorEntry entries[9];
+wxAcceleratorEntry entries[10];
 
 entries[0].Set(wxACCEL_CTRL,(int)'E',  MNU_EXECUTE);
 entries[1].Set(wxACCEL_CTRL,(int)'O',  MNU_OPEN);
@@ -168,9 +169,10 @@
 entries[5].Set(wxACCEL_NORMAL,  WXK_F5,MNU_EXECUTE);
 entries[6].Set(wxACCEL_NORMAL,  WXK_F7,MNU_EXPLAIN);
 entries[7].Set(wxACCEL_ALT, WXK_PAUSE, MNU_CANCEL);
-entries[8].Set(wxACCEL_NORMAL,  WXK_F1,MNU_HELP);
+   entries[8].Set(wxACCEL_CTRL,(int)'A',   
   MNU_SELECTALL);
+entries[9].Set(wxACCEL_NORMAL,  WXK_F1,MNU_HELP);
 
-wxAcceleratorTable accel(8, entries);
+wxAcceleratorTable accel(9, entries);
 SetAcceleratorTable(accel);
 
 queryMenu-Enable(MNU_CANCEL, false);
@@ -630,6 +632,20 @@
 msgHistory-Clear();
 }
 
+void frmQuery::OnSelectAll(wxCommandEvent ev)
+{
+   wxWindow *wnd=currentControl();
+
+   if (wnd == sqlQuery)
+   sqlQuery-SelectAll();
+   else if (wnd == msgResult)
+   msgResult-SelectAll();
+   else if (wnd == msgHistory)
+   msgHistory-SelectAll();
+   else if (wnd == sqlResult)
+   sqlResult-SelectAll();
+}
+
 void frmQuery::OnFind(wxCommandEvent ev)
 {
   sqlQuery-OnFind(ev);

Modified: trunk/pgadmin3/src/include/ctl/ctlSQLResult.h
===
--- trunk/pgadmin3/src/include/ctl/ctlSQLResult.h   2006-01-09 08:47:06 UTC 
(rev 4880)
+++ trunk/pgadmin3/src/include/ctl/ctlSQLResult.h   2006-01-09 09:11:33 UTC 
(rev 4881)
@@ -41,6 +41,8 @@
 int RetrieveOne();
 int Abort();
 
+   void SelectAll();
+
 bool Export();
 bool CanExport() { return rowsRetrieved0  colNames.GetCount()  0; }
 

Modified: trunk/pgadmin3/src/include/frmQuery.h
===
--- trunk/pgadmin3/src/include/frmQuery.h   2006-01-09 08:47:06 UTC (rev 
4880)
+++ trunk/pgadmin3/src/include/frmQuery.h   2006-01-09 09:11:33 UTC (rev 
4881)
@@ -65,6 +65,7 @@
 void OnClearHistory(wxCommandEvent event);
 void OnActivate(wxActivateEvent event);
 void OnFocus(wxFocusEvent event);
+   void OnSelectAll(wxCommandEvent event);
 
 bool CheckChanged(bool canVeto);
 void OpenLastFile();

Modified: trunk/pgadmin3/src/include/menu.h
===
--- trunk/pgadmin3/src/include/menu.h   

Re: [pgadmin-hackers] Patch: Select all in result pane

2006-01-09 Thread Dave Page
Thanks - patch applied. 

Regards, Dave 

 -Original Message-
 From: [EMAIL PROTECTED] 
 [mailto:[EMAIL PROTECTED] On Behalf Of 
 Magnus Hagander
 Sent: 08 January 2006 14:55
 To: pgadmin-hackers@postgresql.org
 Subject: [pgadmin-hackers] Patch: Select all in result pane
 
 This patch implements the ability to hit Ctrl-A to select all 
 results in
 the query result pane.
 
 //Magnus
 
 

---(end of broadcast)---
TIP 6: explain analyze is your friend


[pgadmin-hackers] SVN Commit by dpage: r4882 - in branches/REL-1_4_0_PATCHES/pgadmin3: . src/ctl

2006-01-09 Thread svn
Author: dpage
Date: 2006-01-09 09:22:29 + (Mon, 09 Jan 2006)
New Revision: 4882

Modified:
   branches/REL-1_4_0_PATCHES/pgadmin3/CHANGELOG.txt
   branches/REL-1_4_0_PATCHES/pgadmin3/src/ctl/ctlSQLResult.cpp
Log:
Honour the copy quoting setting properly in the SQL results pane [Magnus 
Hagander]

Modified: branches/REL-1_4_0_PATCHES/pgadmin3/CHANGELOG.txt
===
--- branches/REL-1_4_0_PATCHES/pgadmin3/CHANGELOG.txt   2006-01-09 09:11:33 UTC 
(rev 4881)
+++ branches/REL-1_4_0_PATCHES/pgadmin3/CHANGELOG.txt   2006-01-09 09:22:29 UTC 
(rev 4882)
@@ -18,6 +18,7 @@
 /ul
 br
 ul
+li2006-01-09 DP  1.4.2  Honour the copy quoting setting properly in the 
SQL results pane [Magnus Hagander]
 li2006-01-09 DP  1.4.2  Set the initial Unicode/Local charset options 
correctly in the Export dialogue [Magnus Hagander]
 li2005-12-26 AP  1.4.2  Fix PK detection in EditGrid per Andrus Moor
 li2005-12-26 AP  1.4.2  Fix Bitmap Index explain per Alexander Kirpa

Modified: branches/REL-1_4_0_PATCHES/pgadmin3/src/ctl/ctlSQLResult.cpp
===
--- branches/REL-1_4_0_PATCHES/pgadmin3/src/ctl/ctlSQLResult.cpp
2006-01-09 09:11:33 UTC (rev 4881)
+++ branches/REL-1_4_0_PATCHES/pgadmin3/src/ctl/ctlSQLResult.cpp
2006-01-09 09:22:29 UTC (rev 4882)
@@ -72,19 +72,25 @@
 
 wxString text=GetItemText(row, col);
 
-bool needQuote=(settings-GetExportQuoting()  1);
+   bool needQuote  = false;
+   if (settings-GetExportQuoting() == 1)
+   {
+   /* Quote strings only */
+   switch (colTypClasses.Item(col))
+   {
+   case PGTYPCLASS_NUMERIC:
+   case PGTYPCLASS_BOOL:
+   break;
+   default:
+   needQuote=true;
+   break;
+   }
+   }
+   else if (settings-GetExportQuoting() == 2)
+   /* Quote everything */
+   needQuote = true;
 
-
-switch (colTypClasses.Item(col))
-{
-case PGTYPCLASS_NUMERIC:
-case PGTYPCLASS_BOOL:
-break;
-default:
-needQuote=true;
-break;
-}
-if (needQuote)
+   if (needQuote)
 str.Append(settings-GetExportQuoteChar());
 str.Append(text);
 if (needQuote)


---(end of broadcast)---
TIP 5: don't forget to increase your free space map settings


[pgadmin-hackers] SVN Commit by dpage: r4883 - in trunk/pgadmin3: . src/ctl

2006-01-09 Thread svn
Author: dpage
Date: 2006-01-09 09:31:15 + (Mon, 09 Jan 2006)
New Revision: 4883

Modified:
   trunk/pgadmin3/CHANGELOG.txt
   trunk/pgadmin3/src/ctl/ctlSQLResult.cpp
Log:
Honour the copy quoting setting properly in the SQL results pane [Magnus 
Hagander]

Modified: trunk/pgadmin3/CHANGELOG.txt
===
--- trunk/pgadmin3/CHANGELOG.txt2006-01-09 09:22:29 UTC (rev 4882)
+++ trunk/pgadmin3/CHANGELOG.txt2006-01-09 09:31:15 UTC (rev 4883)
@@ -18,6 +18,7 @@
 /ul
 br
 ul
+li2006-01-09 DP  1.4.2  Honour the copy quoting setting properly in the 
SQL results pane [Magnus Hagander]
 li2006-01-09 DP Use Ctrl-A to select all results in the query 
results pane. [Magnus Hagander]
 li2006-01-09 DP  1.4.2  Set the initial Unicode/Local charset options 
correctly in the Export dialogue [Magnus Hagander]
 li2005-12-26 AP  1.4.2  Fix PK detection in EditGrid per Andrus Moor

Modified: trunk/pgadmin3/src/ctl/ctlSQLResult.cpp
===
--- trunk/pgadmin3/src/ctl/ctlSQLResult.cpp 2006-01-09 09:22:29 UTC (rev 
4882)
+++ trunk/pgadmin3/src/ctl/ctlSQLResult.cpp 2006-01-09 09:31:15 UTC (rev 
4883)
@@ -78,19 +78,25 @@
 
 wxString text=GetItemText(row, col);
 
-bool needQuote=(settings-GetExportQuoting()  1);
+   bool needQuote  = false;
+   if (settings-GetExportQuoting() == 1)
+   {
+   /* Quote strings only */
+   switch (colTypClasses.Item(col))
+   {
+   case PGTYPCLASS_NUMERIC:
+   case PGTYPCLASS_BOOL:
+   break;
+   default:
+   needQuote=true;
+   break;
+   }
+   }
+   else if (settings-GetExportQuoting() == 2)
+   /* Quote everything */
+   needQuote = true;
 
-
-switch (colTypClasses.Item(col))
-{
-case PGTYPCLASS_NUMERIC:
-case PGTYPCLASS_BOOL:
-break;
-default:
-needQuote=true;
-break;
-}
-if (needQuote)
+   if (needQuote)
 str.Append(settings-GetExportQuoteChar());
 str.Append(text);
 if (needQuote)


---(end of broadcast)---
TIP 6: explain analyze is your friend


[pgadmin-hackers] Paste bug in Query Tool

2006-01-09 Thread Magnus Hagander
Hi!

When you paste a multiline query in the query tool, where any line
*except* the last one is very long, the scrollbar doesn't resize, thus
making it impossible to scroll the whole query into view. A workaround
is to click this row and press end, or to manually move out to the end
of it, in which case the scrollbar resizes. This is also what happens if
you paste a long single-line query - since the cursor is placed at the
end of the long line automatically.

Example query (no linebreaks except when specified as a different line)
first line
select * from foo where bar=1 and bar=1 and bar=1 and bar=1 and bar=1
and bar=1 and bar=1 and bar=1 and bar=1 and bar=1 and bar=1 and bar=1
and bar=1 and bar=1 and bar=1 and bar=1 and bar=1 and bar=1 and bar=1
and bar=1 and bar=1 and bar=1 and bar=1 and bar=1 and bar=1 and bar=1
and bar=1 and bar=1 and bar=1 and bar=1 and bar=1 and bar=1 and bar=1
and bar=1 and bar=1 and bar=1 and bar=1 and bar=1 and bar=1 and bar=1
and bar=1 and bar=1 and bar=1 and bar=1 and bar=1 and bar=1 and bar=1
and bar=1
second line
and foo=2 and foo=2
end of second line

The query has to be long enough so the scrollbar would require resizing.


I guess this might be an actual bug in the wx control, but perehaps
there's some kind of workaround we can apply automatically? (Or if the
bug is in pgAdmin, it can hopefully be fixed :P)

//Magnus

---(end of broadcast)---
TIP 6: explain analyze is your friend


[pgadmin-hackers] SVN Commit by dpage: r4884 - in trunk/pgadmin3: . docs/en_US src src/frm src/include

2006-01-09 Thread svn
Author: dpage
Date: 2006-01-09 10:38:49 + (Mon, 09 Jan 2006)
New Revision: 4884

Added:
   trunk/pgadmin3/docs/en_US/commandline.html
Modified:
   trunk/pgadmin3/CHANGELOG.txt
   trunk/pgadmin3/docs/en_US/pgadmin3.hhc
   trunk/pgadmin3/docs/en_US/pgadmin3.hhp.cached
   trunk/pgadmin3/docs/en_US/using.html
   trunk/pgadmin3/src/frm/frmMain.cpp
   trunk/pgadmin3/src/include/frmMain.h
   trunk/pgadmin3/src/pgAdmin3.cpp
Log:
Add -a and -q command line options to auto connect to a server and open a query 
window respectively [Magnus Hagander]

Modified: trunk/pgadmin3/CHANGELOG.txt
===
--- trunk/pgadmin3/CHANGELOG.txt2006-01-09 09:31:15 UTC (rev 4883)
+++ trunk/pgadmin3/CHANGELOG.txt2006-01-09 10:38:49 UTC (rev 4884)
@@ -18,6 +18,7 @@
 /ul
 br
 ul
+li2006-01-09 DP Add -a and -q command line options to auto 
connect to a server and open a query window respectively [Magnus Hagander]
 li2006-01-09 DP  1.4.2  Honour the copy quoting setting properly in the 
SQL results pane [Magnus Hagander]
 li2006-01-09 DP Use Ctrl-A to select all results in the query 
results pane. [Magnus Hagander]
 li2006-01-09 DP  1.4.2  Set the initial Unicode/Local charset options 
correctly in the Export dialogue [Magnus Hagander]

Added: trunk/pgadmin3/docs/en_US/commandline.html
===
--- trunk/pgadmin3/docs/en_US/commandline.html  2006-01-09 09:31:15 UTC (rev 
4883)
+++ trunk/pgadmin3/docs/en_US/commandline.html  2006-01-09 10:38:49 UTC (rev 
4884)
@@ -0,0 +1,40 @@
+html
+
+head
+meta http-equiv=Content-Type content=text/html; charset=windows-1252
+link rel=STYLESHEET type=text/css href=pgadmin3.css
+titleCommand Line Parameters/title
+/head
+
+body
+
+h3Command Line Parameters/h3
+p
+There are a number of command line options that may be passed to the pgAdmin 
executable
+when starting it.
+/p
+
+ul
+  lib-h/b Display command line option help.br /nbsp;/li
+
+  lib-s lt;server descriptiongt;/b Auto connect to the specified 
server. lt;server descriptiongt; is the description 
+  entered when you added the server to the treeview in pgAdmin, quoted if 
required. If multiple servers are registered with 
+  the same description, the first found will be auto-connected.br 
/nbsp;/li
+
+  lib-q/b Open a a href=query.htmlQuery Tool/a window upon 
connection. This option requires the 
+  b-s lt;server descriptiongt;/b option.br /nbsp;/li
+
+  lib-cm lt;config filegt;/b Edit the specified postgresql.conf config 
file.br /nbsp;/li
+
+  lib-ch lt;hba filegt;/b Edit the specified pg_hba.conf config 
file.br /nbsp;/li
+
+  lib-c lt;filegt;/b Edit the specified config file. pgAdmin will 
attempt to auto-detect what type of config file is 
+  being editted.br /nbsp;/li
+
+  lib-t/b Start in dialogue translation test mode. This mode allows each 
dialogue to be viewed without running the 
+   application to assist with string translation.br /nbsp;/li
+/ul
+
+/body
+
+/html

Modified: trunk/pgadmin3/docs/en_US/pgadmin3.hhc
===
--- trunk/pgadmin3/docs/en_US/pgadmin3.hhc  2006-01-09 09:31:15 UTC (rev 
4883)
+++ trunk/pgadmin3/docs/en_US/pgadmin3.hhc  2006-01-09 10:38:49 UTC (rev 
4884)
@@ -106,6 +106,10 @@
param name=Name value=Guru Hints
param name=Local value=guruhints.html
/OBJECT
+   LI OBJECT type=text/sitemap
+   param name=Name value=Command Line Options
+   param name=Local value=commandline.html
+   /OBJECT
/UL
LI OBJECT type=text/sitemap
param name=Name value=pgAgent

Modified: trunk/pgadmin3/docs/en_US/pgadmin3.hhp.cached
===
(Binary files differ)

Modified: trunk/pgadmin3/docs/en_US/using.html
===
--- trunk/pgadmin3/docs/en_US/using.html2006-01-09 09:31:15 UTC (rev 
4883)
+++ trunk/pgadmin3/docs/en_US/using.html2006-01-09 10:38:49 UTC (rev 
4884)
@@ -10,7 +10,7 @@
 
 H3Using pgAdmin/H3
 PThis section explains how you can use pgAdmin to maintain your
-PostgreSQL databases. PgAdmin supports database server versions
+PostgreSQL databases. pgAdmin supports database server versions
 7.3 and up. Versions older than 7.3 are not supported, please use
 pgAdmin II for these./P
 UL
@@ -44,6 +44,7 @@
LIPThe A HREF=options.htmlOptions/A dialogue will allow
you to configure pgAdmin./P
LIPA HREF=guruhints.htmlGuru Hints/A help you perfect your 
databases./P
+LIPA HREF=commandline.htmlCommand Line Options/A to start 
pgAdmin in the most convenient mode./P
 /UL
 PWhen 

Re: [pgadmin-hackers] Patch: commandline connect/launch

2006-01-09 Thread Dave Page
 

 -Original Message-
 From: [EMAIL PROTECTED] 
 [mailto:[EMAIL PROTECTED] On Behalf Of 
 Magnus Hagander
 Sent: 08 January 2006 16:56
 To: pgadmin-hackers@postgresql.org
 Subject: [pgadmin-hackers] Patch: commandline connect/launch
 
 Attached patch makes it possibe to specify a server description to
 auto-connect to on the commandline (-s mydbserver), and also to have
 pgAdmin automatically launch the query tool (-s mydbserver -q). It
 will still open the main window as well, as there seems to be
 interaction between the query window and the main one that 
 I'm not fully
 understanding yet :)
 
 It also rearranges the commandline parsing to use the wx class for
 commandline parsing. It just made things much easier to do it 
 that way.
 Hopefully I didn't break anything else :-) As a bonus, there is now a
 /h for help on commandline args.

Thanks - patch committed with minor changes:

- Added documentation for all command line options

- Modified the patch to restore the server environment, but only if -q
is not used.

Regards, Dave.

---(end of broadcast)---
TIP 3: Have you checked our extensive FAQ?

   http://www.postgresql.org/docs/faq


[pgadmin-hackers] pgAdminIII feature proposal - Logging the SQL commands history

2006-01-09 Thread Tomek Kochanek
It would very nice to have the option to log all
changes in database. It will help me to manage changes
on testing and production server.
Currently it's possible to log all queries but it's
not the good sollution, because you have to filter
what are system queries and what isn't.



__ 
Yahoo! DSL – Something to write home about. 
Just $16.99/mo. or less. 
dsl.yahoo.com 


---(end of broadcast)---
TIP 1: if posting/reading through Usenet, please send an appropriate
   subscribe-nomail command to [EMAIL PROTECTED] so that your
   message can get through to the mailing list cleanly


Re: [pgadmin-hackers] Query tool: Autocompletion

2006-01-09 Thread Dave Page
 

 -Original Message-
 From: [EMAIL PROTECTED] 
 [mailto:[EMAIL PROTECTED] On Behalf Of 
 Magnus Hagander
 Sent: 08 January 2006 15:05
 To: pgadmin-hackers@postgresql.org
 Subject: Re: [pgadmin-hackers] Query tool: Autocompletion 
 
  Attached is a first attempt at autocompletion for the SQL 
  Query tool. It probably needs some more work, but it's a start :-)
  
  It's based on the tab completion in psql. The idea is to pull 
  the latest and greatest tab-complete.c from psql, then run it 
  through a perlscript that picks out the tasty parts.
  
  
  Anyway. Attached is the patch. I've also included a 
  tab-complete.inc from the current Due to a bug in the Visual 
  C++ compiler, it *has* to be compiled as C not as C++. 
  Thus, a bit if ugly glue is required between those two worlds 
  :-)psql - to make it build directly (without adding a build 
  dependency on perl), this one is what should probably go in 
  svn, and then be manually sycned onw and then from psql.
  tabcomplete.c needs to be added to the build project (I'm 
  devving in Visual Studio 2003, so I can't modify the .dsw 
  from there easily). 
  
  I've only tested this on Windows so far. Wouldn't surprise me 
  if some minor work is needed to build on *nix.
  
  I'm also unsure if I can get away with the easy way I pass 
  strings in and out of wx (encoding issues?). It works in my 
  testcases, but I'm not familiar enough to be sure if it 
 always does. 
  
  Finally, I've added a screenshot for those who don't want to 
  rebuild :)
  
  So. Thoughts, and comments?

Nice, it works quite well. Some thoughts:

- My main concern is that I do use tab, which this prevents - as per
your comment in the source I think we need an option to turn the feature
off for those that don't want it.

- A space should be added after an item has been inserted form the
auto-complete list, per psql.

- Schema-prefixed table names can't have columns in the WHERE clause
auto-completed. Actually on further investigation this seems to apply to
psql as well.

- SELECT * FROM foo WHERE bar = 'FOO' AND tab doesn't work. Also as
per psql?

I'd like Andreas to look at this before applying - particularly the
encoding bits which are still largely a mystery to me as well.

Regards, Dave.

---(end of broadcast)---
TIP 3: Have you checked our extensive FAQ?

   http://www.postgresql.org/docs/faq


Re: [pgadmin-hackers] Paste bug in Query Tool

2006-01-09 Thread Dave Page
 

 -Original Message-
 From: [EMAIL PROTECTED] 
 [mailto:[EMAIL PROTECTED] On Behalf Of 
 Magnus Hagander
 Sent: 09 January 2006 10:01
 To: pgadmin-hackers@postgresql.org
 Subject: [pgadmin-hackers] Paste bug in Query Tool
 
 Hi!
 
 When you paste a multiline query in the query tool, where any line
 *except* the last one is very long, the scrollbar doesn't resize, thus
 making it impossible to scroll the whole query into view. A workaround
 is to click this row and press end, or to manually move out 
 to the end
 of it, in which case the scrollbar resizes. This is also what 
 happens if
 you paste a long single-line query - since the cursor is placed at the
 end of the long line automatically.
 
 Example query (no linebreaks except when specified as a 
 different line)
 first line
 select * from foo where bar=1 and bar=1 and bar=1 and bar=1 and bar=1
 and bar=1 and bar=1 and bar=1 and bar=1 and bar=1 and bar=1 and bar=1
 and bar=1 and bar=1 and bar=1 and bar=1 and bar=1 and bar=1 and bar=1
 and bar=1 and bar=1 and bar=1 and bar=1 and bar=1 and bar=1 and bar=1
 and bar=1 and bar=1 and bar=1 and bar=1 and bar=1 and bar=1 and bar=1
 and bar=1 and bar=1 and bar=1 and bar=1 and bar=1 and bar=1 and bar=1
 and bar=1 and bar=1 and bar=1 and bar=1 and bar=1 and bar=1 and bar=1
 and bar=1
 second line
 and foo=2 and foo=2
 end of second line
 
 The query has to be long enough so the scrollbar would 
 require resizing.
 
 
 I guess this might be an actual bug in the wx control, but perehaps
 there's some kind of workaround we can apply automatically? (Or if the
 bug is in pgAdmin, it can hopefully be fixed :P)

You can also use the scroll arrow at the end of the scrollbar to get to
the end of the line, just not the scrollbar itself.

This is definitely a bug in the Scintilla control itself though - I can
reproduce it in the Scite editor so somehow we need to get a fix into
that, then get it refreshed into wx, and finally up to pgAdmin!

I'll start with the wx guys

/D

---(end of broadcast)---
TIP 1: if posting/reading through Usenet, please send an appropriate
   subscribe-nomail command to [EMAIL PROTECTED] so that your
   message can get through to the mailing list cleanly


Re: [pgadmin-hackers] Patch: commandline connect/launch

2006-01-09 Thread Magnus Hagander
  Attached patch makes it possibe to specify a server description to 
  auto-connect to on the commandline (-s mydbserver), and 
 also to have 
  pgAdmin automatically launch the query tool (-s mydbserver 
 -q). It 
  will still open the main window as well, as there seems to be 
  interaction between the query window and the main one that I'm not 
  fully understanding yet :)
  
  It also rearranges the commandline parsing to use the wx class for 
  commandline parsing. It just made things much easier to do it that 
  way.
  Hopefully I didn't break anything else :-) As a bonus, 
 there is now a 
  /h for help on commandline args.
 
 Thanks - patch committed with minor changes:
 
 - Added documentation for all command line options
 
 - Modified the patch to restore the server environment, but 
 only if -q is not used.

Thanks!

//Magnus

---(end of broadcast)---
TIP 6: explain analyze is your friend


[pgadmin-hackers] SVN Commit by dpage: r4885 - trunk/pgadmin3

2006-01-09 Thread svn
Author: dpage
Date: 2006-01-09 14:27:07 + (Mon, 09 Jan 2006)
New Revision: 4885

Modified:
   trunk/pgadmin3/BUGS.txt
Log:
Remove fixed items from bugs list - they should be in the changelog.

Modified: trunk/pgadmin3/BUGS.txt
===
--- trunk/pgadmin3/BUGS.txt 2006-01-09 10:38:49 UTC (rev 4884)
+++ trunk/pgadmin3/BUGS.txt 2006-01-09 14:27:07 UTC (rev 4885)
@@ -4,7 +4,6 @@
li[Edit grid] Editing very large columns freezes (might be restricted 
to bytea)
li[Edit grid] bool editing doesn't know NULL; major redesign needed
li[Edit grid] sqlGridTextEditor is broken on Mac. We're currently 
using wxGridCellAutoWrapStringEditor which works but isn't overly user friendly
-   li[Unix build] --enable-debug tries to use wx-config which hasn't 
been found yet
 /ulbr
 bKnown wxWindows issues/b
 ul
@@ -23,39 +22,3 @@
li[non-unicode build] Reading unicode files won't convert (wx not 
capable, use unicode build instead)
li[Object Tree] M$ Context menu key doesn't work in Windows 
(wxWindows bug?).
 /ulbr
-bFixed issues/b
-ul
-   liDP 2005-10-17 [Unix build] --enable-debug tries to use wx-config 
which hasn't been found yet
-   liAP 2004-07-27 [all] suppressed public. prefix leads to modified 
objects in wrong schema if found in search_path
-   liDP 2004-09-18 [Object Tree] Dropped servers reappear when changing 
display system objects due to the disconnect/tree refresh.
-   liAP 2004-09-18 [Database property] db creation with owner fails
-   liAP 2004-09-18 [Server property] some changes not handled correctly
-   liAP 2004-09-17 [new Database] Name/Owner not editable for 7.3/7.4 
servers
-   liDP 2004-09-16 [Server property] password visible when connecting to 
server [Ivan Nejgebauer]
-   liAP 2004-09-10 [all] internal types like varchar are quoted when 
used as type
-   liAP 2004-08-15 [Windows] Alt+Tab Icon is system default.
-   liAP 2004-08-15 [Object Tree] Adding an unnamed constraint isn't 
reflected immediately in the tree.
-   liAP 2004-08-15 [Object Tree] missing schema for function return type 
if table type
-   li?? 2004-08-15 [ctlSQLBox] STC hangs when searching (ctrl-F) for 
(non-existing?) strings
-   liAP 2004-07-11 [gtk] Segfault when refreshing a schema in the 
treeview that has been dropped through SQL. seems fixed by wx
-   liAP 2004-07-11 [gtk] retrieving current focus in QueryWindow failes 
(needed for toolbar enabling)
-   liAP 2004-07-11 [gtk] cursor problem with wxSTC (disappears every 
second focus change)
-   liAP 2004-06-04 [all] Multi-value variables (db and user) handled 
incorrectly (e.g. search_path)
-   liAP 2004-06-04 [Object Tree/Columns]check for dependencies on column 
type change
-   liA= 2004-01-01 [all Controls with gtk] Paste from other apps will 
fail for non-unicode apps (fixed in pgadmin3-wx snapshot, submitted to wx as 
776217).
-   liAP 2003-11-30 [Help-gtk] When selecting text in the help window, 
pgadmin crashes (wxWin issue)
-   liDP 2003-10-02 [Connect Dlg] When connecting to a new server, if 
logon fails all info is remembered except Description.
-   liDP 2003-10-02 [Query Builder] frmAddTableView: you have to double 
click buttons!
-   liDP 2003-10-02 Query Builder active in debug builds only.
-   liAP 2003-08-28 [Edit Grid] wxGridCellFloatEditor appears to round 
floats - 1.5151515151515151515151515152 will become 1.515152
-   liAP 2003-08-28 [Data Viewer] In-place edit control doesn't have 
autoscroll if text initially fits into control. Also will not accept more input 
than can be isplayed at once, even if pasting data in.
-   liDP/AP 2003-07-23 [Help System]  Inconsistent error reporting, 
doesn't currently work on Win32 at all.
-   liAP 2003-04-29 [Schema Browser]  Segfault under unix if server 
connection fails for non password reasons.
-   liAP 2003-04-29 [Query Tool]  Barfs unde unix when explaining query 
plan - not reproduceable.
-   liAP 2003-04-29 [Schema Browser]  Aggregate types are not schema 
qualified. - looks ok to me (fixed by DP?).
-   liAP 2003-05-03 [Schema Browser]  Comments do not work.
-   liAP 2003-05-04 [Schema Browser]  Fix Icons.
-   liAP 2003-05-04 [Schema Browser]  OPERATOR CLASSES need work. 
Secondary (onclick) discovery SQL has an error.
-   liAP 2003-06-17 [Edit/Results Grids]Scrollbars often do not 
appear until the window is resized following data load.
-   liAP 2003-08-11 [Table Editor] Generates invalid SQL when table 
includes Foreign Key.
-/ulbr


---(end of broadcast)---
TIP 5: don't forget to increase your free space map settings


Re: [pgadmin-hackers] SVN Commit by dpage: r4884 - in trunk/pgadmin3:

2006-01-09 Thread Miha Radej

hi!

after checking out revision 4884 make fails with the following error:

[EMAIL PROTECTED]:/net/programs/pgadmin-svn/pgadmin3]$ make
make  all-recursive
make[1]: Entering directory `/usr/net/programs/pgadmin-svn/pgadmin3'
Making all in i18n
make[2]: Entering directory `/usr/net/programs/pgadmin-svn/pgadmin3/i18n'
make[2]: Nothing to be done for `all'.
make[2]: Leaving directory `/usr/net/programs/pgadmin-svn/pgadmin3/i18n'
Making all in src
make[2]: Entering directory `/usr/net/programs/pgadmin-svn/pgadmin3/src'
if g++ -DHAVE_CONFIG_H -I. -I. -I.. 
-DDATA_DIR=\/usr/local/pgadmin-svn/share/pgadmin3/\ -Wall 
-Wno-non-virtual-dtor -I../src/include -I../src/agent/include 
-I../src/slony/include -I/usr/include/pgsql -DSSL 
-I/usr/local/lib/wx/include/gtk2-unicode-debug-static-2.6 
-I/usr/local/include/wx-2.6 -D__WXDEBUG__ -D__WXGTK__ 
-D_FILE_OFFSET_BITS=64 -D_LARGE_FILES -D_LARGEFILE_SOURCE=1 -g -O0 
-DDATA_DIR=\/usr/local/pgadmin-svn/share/pgadmin3/\ -Wall 
-Wno-non-virtual-dtor -I../src/include -I../src/agent/include 
-I../src/slony/include  -MT pgAdmin3.o -MD -MP -MF .deps/pgAdmin3.Tpo 
-c -o pgAdmin3.o `test -f './pgAdmin3.cpp' || echo './'`./pgAdmin3.cpp; \
then mv -f .deps/pgAdmin3.Tpo .deps/pgAdmin3.Po; else rm -f 
.deps/pgAdmin3.Tpo; exit 1; fi

pgAdmin3.cpp: In member function `virtual bool pgAdmin3::OnInit()':
pgAdmin3.cpp:420: error: `frmQuery' undeclared (first use this function)
pgAdmin3.cpp:420: error: (Each undeclared identifier is reported only 
once for

   each function it appears in.)
pgAdmin3.cpp:420: error: `fq' undeclared (first use this function)
pgAdmin3.cpp:420: error: syntax error before `(' token
make[2]: *** [pgAdmin3.o] Error 1
make[2]: Leaving directory `/usr/net/programs/pgadmin-svn/pgadmin3/src'
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory `/usr/net/programs/pgadmin-svn/pgadmin3'
make: *** [all] Error 2


revision 4883 makes just fine.

system is suse 9.3, gcc 3.3.4, wx 2.6.0.

regards,
Miha

[EMAIL PROTECTED] wrote:

Author: dpage
Date: 2006-01-09 10:38:49 + (Mon, 09 Jan 2006)
New Revision: 4884
...


---(end of broadcast)---
TIP 4: Have you searched our list archives?

  http://archives.postgresql.org


Re: [pgadmin-hackers] SVN Commit by dpage: r4884 - in trunk/pgadmin3:

2006-01-09 Thread Dave Page
 

 -Original Message-
 From: [EMAIL PROTECTED] 
 [mailto:[EMAIL PROTECTED] On Behalf Of Miha Radej
 Sent: 09 January 2006 14:56
 To: pgadmin-hackers@postgresql.org
 Subject: Re: [pgadmin-hackers] SVN Commit by dpage: r4884 - 
 in trunk/pgadmin3:
 
 hi!
 
 after checking out revision 4884 make fails with the following error:
 
snip

 revision 4883 makes just fine.
 
 system is suse 9.3, gcc 3.3.4, wx 2.6.0.
 
 regards,
 Miha

Does it build if you add 'include frmQuery.h' at the top of
pgAdmin3.cpp (see how frmMain and some others are already included)?

Regards, Dave.

---(end of broadcast)---
TIP 9: In versions below 8.0, the planner will ignore your desire to
   choose an index scan if your joining column's datatypes do not
   match


Re: [pgadmin-hackers] SVN Commit by dpage: r4884 - in trunk/pgadmin3:

2006-01-09 Thread Miha Radej

hi!

Dave Page wrote:

after checking out revision 4884 make fails with the following error:


snip


revision 4883 makes just fine.

system is suse 9.3, gcc 3.3.4, wx 2.6.0.

regards,
Miha


Does it build if you add 'include frmQuery.h' at the top of
pgAdmin3.cpp (see how frmMain and some others are already included)?


i have just been playing around and tried doing that :) no luck, though:

[EMAIL PROTECTED]:/net/programs/pgadmin-svn/pgadmin3]$ make
make  all-recursive
make[1]: Entering directory `/usr/net/programs/pgadmin-svn/pgadmin3'
Making all in i18n
make[2]: Entering directory `/usr/net/programs/pgadmin-svn/pgadmin3/i18n'
make[2]: Nothing to be done for `all'.
make[2]: Leaving directory `/usr/net/programs/pgadmin-svn/pgadmin3/i18n'
Making all in src
make[2]: Entering directory `/usr/net/programs/pgadmin-svn/pgadmin3/src'
if g++ -DHAVE_CONFIG_H -I. -I. -I.. 
-DDATA_DIR=\/usr/local/pgadmin-svn/share/pgadmin3/\ -Wall 
-Wno-non-virtual-dtor -I../src/include -I../src/agent/include 
-I../src/slony/include -I/usr/include/pgsql -DSSL 
-I/usr/local/lib/wx/include/gtk2-unicode-debug-static-2.6 
-I/usr/local/include/wx-2.6 -D__WXDEBUG__ -D__WXGTK__ 
-D_FILE_OFFSET_BITS=64 -D_LARGE_FILES -D_LARGEFILE_SOURCE=1 -g -O0 
-DDATA_DIR=\/usr/local/pgadmin-svn/share/pgadmin3/\ -Wall 
-Wno-non-virtual-dtor -I../src/include -I../src/agent/include 
-I../src/slony/include  -MT pgAdmin3.o -MD -MP -MF .deps/pgAdmin3.Tpo 
-c -o pgAdmin3.o `test -f './pgAdmin3.cpp' || echo './'`./pgAdmin3.cpp; \
then mv -f .deps/pgAdmin3.Tpo .deps/pgAdmin3.Po; else rm -f 
.deps/pgAdmin3.Tpo; exit 1; fi

pgAdmin3.cpp: In member function `virtual bool pgAdmin3::OnInit()':
pgAdmin3.cpp:421: error: `CreateConn' undeclared (first use this function)
pgAdmin3.cpp:421: error: (Each undeclared identifier is reported only 
once for

   each function it appears in.)
make[2]: *** [pgAdmin3.o] Error 1
make[2]: Leaving directory `/usr/net/programs/pgadmin-svn/pgadmin3/src'
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory `/usr/net/programs/pgadmin-svn/pgadmin3'
make: *** [all] Error 2


regards,
Miha

---(end of broadcast)---
TIP 5: don't forget to increase your free space map settings


Re: [pgadmin-hackers] SVN Commit by dpage: r4884 - in trunk/pgadmin3:

2006-01-09 Thread Dave Page
 

 -Original Message-
 From: Miha Radej [mailto:[EMAIL PROTECTED] 
 Sent: 09 January 2006 15:16
 To: Dave Page
 Cc: pgadmin-hackers@postgresql.org
 Subject: Re: [pgadmin-hackers] SVN Commit by dpage: r4884 - 
 in trunk/pgadmin3:
 
 hi!
 
 Dave Page wrote:
 after checking out revision 4884 make fails with the 
 following error:
 
  snip
  
 revision 4883 makes just fine.
 
 system is suse 9.3, gcc 3.3.4, wx 2.6.0.
 
 regards,
 Miha
  
  Does it build if you add 'include frmQuery.h' at the top of
  pgAdmin3.cpp (see how frmMain and some others are already included)?
 
 i have just been playing around and tried doing that :) no 
 luck, though:
 

OK, give me a few minutes - I'm just rebuilding my Slackware box -
almost there now. It's most certainly a header issue - Magnus' patch was
built on Windows, which I also tested it on, however Windows has
precompiled headers which normally means we only need to include
pgadmin3.h in each file.

/D

---(end of broadcast)---
TIP 2: Don't 'kill -9' the postmaster


[pgadmin-hackers] SVN Commit by dpage: r4886 - trunk/pgadmin3/src

2006-01-09 Thread svn
Author: dpage
Date: 2006-01-09 15:43:07 + (Mon, 09 Jan 2006)
New Revision: 4886

Modified:
   trunk/pgadmin3/src/pgAdmin3.cpp
Log:
Add a couple of headers needed on *nix

Modified: trunk/pgadmin3/src/pgAdmin3.cpp
===
--- trunk/pgadmin3/src/pgAdmin3.cpp 2006-01-09 14:27:07 UTC (rev 4885)
+++ trunk/pgadmin3/src/pgAdmin3.cpp 2006-01-09 15:43:07 UTC (rev 4886)
@@ -46,8 +46,10 @@
 #include misc.h
 #include sysSettings.h
 #include update.h
+#include pgServer.h
 #include frmMain.h
 #include frmConfig.h
+#include frmQuery.h
 #include frmSplash.h
 #include wx/dir.h
 #include wx/fs_zip.h


---(end of broadcast)---
TIP 4: Have you searched our list archives?

   http://archives.postgresql.org


Re: [pgadmin-hackers] SVN Commit by dpage: r4884 - in trunk/pgadmin3:

2006-01-09 Thread Dave Page
 

 -Original Message-
 From: [EMAIL PROTECTED] 
 [mailto:[EMAIL PROTECTED] On Behalf Of Dave Page
 Sent: 09 January 2006 15:21
 To: Miha Radej
 Cc: pgadmin-hackers@postgresql.org
 Subject: Re: [pgadmin-hackers] SVN Commit by dpage: r4884 - 
 in trunk/pgadmin3:
 
 OK, give me a few minutes - I'm just rebuilding my Slackware box -
 almost there now. It's most certainly a header issue - 
 Magnus' patch was
 built on Windows, which I also tested it on, however Windows has
 precompiled headers which normally means we only need to include
 pgadmin3.h in each file.

Fix committed - thanks for the report.

Regards, Dave.

---(end of broadcast)---
TIP 1: if posting/reading through Usenet, please send an appropriate
   subscribe-nomail command to [EMAIL PROTECTED] so that your
   message can get through to the mailing list cleanly


Re: [pgadmin-hackers] SVN Commit by dpage: r4884 - in trunk/pgadmin3:

2006-01-09 Thread Miha Radej

hi!

i've tinkered around a bit and it seems to work with the attached patch 
applied. pgadmin -q displayed the usage screen so i guess it should work.


cheers,
Miha

Dave Page wrote:
after checking out revision 4884 make fails with the 

following error:

snip


revision 4883 makes just fine.

system is suse 9.3, gcc 3.3.4, wx 2.6.0.

regards,
Miha

Does it build if you add 'include frmQuery.h' at the top of
pgAdmin3.cpp (see how frmMain and some others are already included)?
i have just been playing around and tried doing that :) no 
luck, though:




OK, give me a few minutes - I'm just rebuilding my Slackware box -
almost there now. It's most certainly a header issue - Magnus' patch was
built on Windows, which I also tested it on, however Windows has
precompiled headers which normally means we only need to include
pgadmin3.h in each file.
Index: src/pgAdmin3.cpp
===
--- src/pgAdmin3.cpp(revision 4885)
+++ src/pgAdmin3.cpp(working copy)
@@ -49,6 +49,8 @@
 #include frmMain.h
 #include frmConfig.h
 #include frmSplash.h
+#include frmQuery.h
+#include pgServer.h
 #include wx/dir.h
 #include wx/fs_zip.h
 #include ctl/xh_calb.h

---(end of broadcast)---
TIP 3: Have you checked our extensive FAQ?

   http://www.postgresql.org/docs/faq


Re: [pgadmin-hackers] SVN Commit by dpage: r4884 - in trunk/pgadmin3:

2006-01-09 Thread Miha Radej
oops, sorry :) just sent an email with a success report and didn't see 
this email.


cheers,
Miha

Dave Page wrote:
 


-Original Message-
From: [EMAIL PROTECTED] 
[mailto:[EMAIL PROTECTED] On Behalf Of Dave Page

Sent: 09 January 2006 15:21
To: Miha Radej
Cc: pgadmin-hackers@postgresql.org
Subject: Re: [pgadmin-hackers] SVN Commit by dpage: r4884 - 
in trunk/pgadmin3:


OK, give me a few minutes - I'm just rebuilding my Slackware box -
almost there now. It's most certainly a header issue - 
Magnus' patch was

built on Windows, which I also tested it on, however Windows has
precompiled headers which normally means we only need to include
pgadmin3.h in each file.


Fix committed - thanks for the report.

Regards, Dave.



---(end of broadcast)---
TIP 3: Have you checked our extensive FAQ?

  http://www.postgresql.org/docs/faq


Re: [pgadmin-hackers] SVN Commit by dpage: r4884 - in trunk/pgadmin3:

2006-01-09 Thread Dave Page
 

 -Original Message-
 From: Miha Radej [mailto:[EMAIL PROTECTED] 
 Sent: 09 January 2006 15:50
 To: Dave Page
 Cc: pgadmin-hackers@postgresql.org
 Subject: Re: [pgadmin-hackers] SVN Commit by dpage: r4884 - 
 in trunk/pgadmin3:
 
 oops, sorry :) just sent an email with a success report and 
 didn't see 
 this email.


:-)

Thanks for the patch anyhoo!

Regards, Dave.

---(end of broadcast)---
TIP 4: Have you searched our list archives?

   http://archives.postgresql.org


[pgadmin-hackers] pgadmin crash issue

2006-01-09 Thread Daniel Whitter

Hello,

I've posted this mail to the postgresql general mailing list.
For those of you who don't read it:


I'm new to postgresql and during testing for a script I've found some
curious things.

If I do the following things a bad dump will be created that can't be
restored (using pgadmin3, pg_dump and pg_restore or psql).
There's also a issue that pgadmin crash.

In pgadmin3 do
1)  Create a new db ('test_dump')
2)  Create a new schema ('test_dump')

3)  From schema 'pg_catalog' copy the lines from
   CREATE OPERATOR (... for (abstime,abstime), =(abstime,abstime),
   =(abstime,abstime), (abstime,abstime), =(abstime,abstime)
   and paste it in the query window. Write the schema name 'test_dump.'

   before the operator sign and execute the query.
   I've done this once for each operator.

4)  Then copy the lines for operator class 'abstime_ops(btree)' from 
   schema 'pg_catalog' and paste it in the query window.

   Write the schema name 'test_dump.' before the class and remove the
   'default'. Then execute the query.

If you click on the created operator class in schema 'test_dump' 
you'll get a error message box or on windows pgAdmin will crash.


[...]


greetings,
Daniel Whitter



---(end of broadcast)---
TIP 2: Don't 'kill -9' the postmaster