Re: [pgadmin-hackers] pgadmin3-1.6.1 - core dumped - Work around
Zdenek Kotala wrote:
I'm still not sure how you're getting into that code when you close
the form though...
The root cause is destructor of frmQuery dialog. It removes all
connection from combo box exclude last item - new connection. Each
deletion invoke frmQuery::OnChangeConnection event and the
OnChangeConnection method invokes new connection dialog in the last
step. And because there are some empty combo boxes on this dialog, gtk
generates core.
Ah, of course - well spotted.
My suggestion is disable event generation for cbConnection in the
destructor.
Agreed. Can one or both of you test the attached patch please?
Thanks, Dave.
Index: frmQuery.cpp
===
--- frmQuery.cpp(revision 5791)
+++ frmQuery.cpp(working copy)
@@ -62,7 +62,6 @@
BEGIN_EVENT_TABLE(frmQuery, pgFrame)
EVT_ERASE_BACKGROUND( frmQuery::OnEraseBackground)
EVT_SIZE( frmQuery::OnSize)
-EVT_COMBOBOX(CTRLID_CONNECTION, frmQuery::OnChangeConnection)
EVT_CLOSE( frmQuery::OnClose)
EVT_SET_FOCUS( frmQuery::OnSetFocus)
EVT_MENU(MNU_NEW, frmQuery::OnNew)
@@ -280,6 +279,7 @@
outputPane-AddPage(msgResult, _(Messages));
outputPane-AddPage(msgHistory, _(History));
+this-Connect(CTRLID_CONNECTION, wxEVT_COMMAND_COMBOBOX_SELECTED,
wxCommandEventHandler(frmQuery::OnChangeConnection));
sqlQuery-Connect(wxID_ANY,
wxEVT_SET_FOCUS,wxFocusEventHandler(frmQuery::OnFocus));
sqlResult-Connect(wxID_ANY, wxEVT_SET_FOCUS,
wxFocusEventHandler(frmQuery::OnFocus));
msgResult-Connect(wxID_ANY, wxEVT_SET_FOCUS,
wxFocusEventHandler(frmQuery::OnFocus));
@@ -369,6 +369,7 @@
sqlResult-Disconnect(wxID_ANY, wxEVT_SET_FOCUS,
wxFocusEventHandler(frmQuery::OnFocus));
msgResult-Disconnect(wxID_ANY, wxEVT_SET_FOCUS,
wxFocusEventHandler(frmQuery::OnFocus));
msgHistory-Disconnect(wxID_ANY, wxEVT_SET_FOCUS,
wxFocusEventHandler(frmQuery::OnFocus));
+this-Disconnect(CTRLID_CONNECTION, wxEVT_COMMAND_COMBOBOX_SELECTED,
wxCommandEventHandler(frmQuery::OnChangeConnection));
if (mainForm)
mainForm-RemoveFrame(this);
@@ -632,10 +633,6 @@
void frmQuery::OnChangeConnection(wxCommandEvent ev)
{
-// On Solaris, this event seems to get fired when the form closes(!!)
-if(!IsVisible())
-return;
-
unsigned int sel=cbConnection-GetCurrentSelection();
if (sel == cbConnection-GetCount()-1)
{
---(end of broadcast)---
TIP 1: if posting/reading through Usenet, please send an appropriate
subscribe-nomail command to [EMAIL PROTECTED] so that your
message can get through to the mailing list cleanly
Re: [pgadmin-hackers] pgadmin3-1.6.1 - core dumped - Work around
Hi Zdenek,
I tested this and still both problems exist (Add server and query tool
-core dump)
Can you test it once?
Dave Page wrote:
Zdenek Kotala wrote:
I'm still not sure how you're getting into that code when you close
the form though...
The root cause is destructor of frmQuery dialog. It removes all
connection from combo box exclude last item - new connection. Each
deletion invoke frmQuery::OnChangeConnection event and the
OnChangeConnection method invokes new connection dialog in the last
step. And because there are some empty combo boxes on this dialog,
gtk generates core.
Ah, of course - well spotted.
My suggestion is disable event generation for cbConnection in the
destructor.
Agreed. Can one or both of you test the attached patch please?
Thanks, Dave.
Index: frmQuery.cpp
===
--- frmQuery.cpp(revision 5791)
+++ frmQuery.cpp(working copy)
@@ -62,7 +62,6 @@
BEGIN_EVENT_TABLE(frmQuery, pgFrame)
EVT_ERASE_BACKGROUND( frmQuery::OnEraseBackground)
EVT_SIZE( frmQuery::OnSize)
-EVT_COMBOBOX(CTRLID_CONNECTION, frmQuery::OnChangeConnection)
EVT_CLOSE( frmQuery::OnClose)
EVT_SET_FOCUS( frmQuery::OnSetFocus)
EVT_MENU(MNU_NEW, frmQuery::OnNew)
@@ -280,6 +279,7 @@
outputPane-AddPage(msgResult, _(Messages));
outputPane-AddPage(msgHistory, _(History));
+this-Connect(CTRLID_CONNECTION, wxEVT_COMMAND_COMBOBOX_SELECTED,
wxCommandEventHandler(frmQuery::OnChangeConnection));
sqlQuery-Connect(wxID_ANY,
wxEVT_SET_FOCUS,wxFocusEventHandler(frmQuery::OnFocus));
sqlResult-Connect(wxID_ANY, wxEVT_SET_FOCUS,
wxFocusEventHandler(frmQuery::OnFocus));
msgResult-Connect(wxID_ANY, wxEVT_SET_FOCUS,
wxFocusEventHandler(frmQuery::OnFocus));
@@ -369,6 +369,7 @@
sqlResult-Disconnect(wxID_ANY, wxEVT_SET_FOCUS,
wxFocusEventHandler(frmQuery::OnFocus));
msgResult-Disconnect(wxID_ANY, wxEVT_SET_FOCUS,
wxFocusEventHandler(frmQuery::OnFocus));
msgHistory-Disconnect(wxID_ANY, wxEVT_SET_FOCUS,
wxFocusEventHandler(frmQuery::OnFocus));
+this-Disconnect(CTRLID_CONNECTION, wxEVT_COMMAND_COMBOBOX_SELECTED,
wxCommandEventHandler(frmQuery::OnChangeConnection));
if (mainForm)
mainForm-RemoveFrame(this);
@@ -632,10 +633,6 @@
void frmQuery::OnChangeConnection(wxCommandEvent ev)
{
-// On Solaris, this event seems to get fired when the form closes(!!)
-if(!IsVisible())
-return;
-
unsigned int sel=cbConnection-GetCurrentSelection();
if (sel == cbConnection-GetCount()-1)
{
---(end of broadcast)---
TIP 1: if posting/reading through Usenet, please send an appropriate
subscribe-nomail command to [EMAIL PROTECTED] so that your
message can get through to the mailing list cleanly
---(end of broadcast)---
TIP 6: explain analyze is your friend
Re: [pgadmin-hackers] pgadmin3-1.6.1 - core dumped - Work around
Dhanaraj M wrote: Hi Zdenek, I tested this and still both problems exist (Add server and query tool -core dump) Can you test it once? This patch fixes only problem with invoking connection form when frmQuery is closing. It does not fix problems with empty comboboxies. This patch works for me. Do you have same backtrace? Zdenek Dave Page wrote: Zdenek Kotala wrote: I'm still not sure how you're getting into that code when you close the form though... The root cause is destructor of frmQuery dialog. It removes all connection from combo box exclude last item - new connection. Each deletion invoke frmQuery::OnChangeConnection event and the OnChangeConnection method invokes new connection dialog in the last step. And because there are some empty combo boxes on this dialog, gtk generates core. Ah, of course - well spotted. My suggestion is disable event generation for cbConnection in the destructor. Agreed. Can one or both of you test the attached patch please? Thanks, Dave. ---(end of broadcast)--- TIP 7: You can help support the PostgreSQL project by donating at http://www.postgresql.org/about/donate
Re: [pgadmin-hackers] pgadmin3-1.6.1 - core dumped - Work around
Zdenek Kotala wrote: Dhanaraj M wrote: Hi Zdenek, I tested this and still both problems exist (Add server and query tool -core dump) Can you test it once? This patch fixes only problem with invoking connection form when frmQuery is closing. That's all it's supposed to fix - but I get the impression from Dhanaraj's comment above that it doesn't work for him on frmQuery. It does not fix problems with empty comboboxies. No, I'm still working on that. The fix I was thinking of last night isn't working as I expected... investigating now. Regards, Dave. ---(end of broadcast)--- TIP 2: Don't 'kill -9' the postmaster
Re: [pgadmin-hackers] pgagent linker problem
Zdenek Kotala wrote: I tested it again and this problem occurred if I use sunstudio compiler. Compilation with gcc works fine. I looks that gcc recursively go thru libraries to find symbol. You can test it with Linux version of SunStudio. Ok - is there a relatively easy way to test for the SunStudio compiler in configure, or shall I just add the lib for all compilers? Regards Dave ---(end of broadcast)--- TIP 9: In versions below 8.0, the planner will ignore your desire to choose an index scan if your joining column's datatypes do not match
Re: [pgadmin-hackers] pgagent linker problem
Dave Page wrote: Zdenek Kotala wrote: I tested it again and this problem occurred if I use sunstudio compiler. Compilation with gcc works fine. I looks that gcc recursively go thru libraries to find symbol. You can test it with Linux version of SunStudio. Ok - is there a relatively easy way to test for the SunStudio compiler in configure, or shall I just add the lib for all compilers? There are more issues related to SunStudio (hardcoded gcc flags ...). I will discussed it with Dhanaraj and we will prepare patch to solve it. Zdenek ---(end of broadcast)--- TIP 1: if posting/reading through Usenet, please send an appropriate subscribe-nomail command to [EMAIL PROTECTED] so that your message can get through to the mailing list cleanly
Re: [pgadmin-hackers] pgagent linker problem
Zdenek Kotala wrote:
Dave Page wrote:
Zdenek Kotala wrote:
I tested it again and this problem occurred if I use sunstudio
compiler. Compilation with gcc works fine. I looks that gcc
recursively go thru libraries to find symbol. You can test it with
Linux version of SunStudio.
Ok - is there a relatively easy way to test for the SunStudio compiler
in configure, or shall I just add the lib for all compilers?
There are more issues related to SunStudio (hardcoded gcc flags ...). I
will discussed it with Dhanaraj and we will prepare patch to solve it.
OK, thanks - did you see my previous message about the correct fix to
include the core lib? Specifically, that you just add it to the
appropriate wx-config lines in acinclude.m4, eg:
pgagent_LDADD=`${WX_CONFIG} ${WX_STATIC} --libs base,core --unicode=yes
--debug=yes --version=${WX_VERSION} 2 /dev/null`
Regards, Dave.
---(end of broadcast)---
TIP 4: Have you searched our list archives?
http://archives.postgresql.org
[pgadmin-hackers] SVN Commit by dpage: r5793 - trunk/pgadmin3/pgadmin/frm
Author: dpage Date: 2006-12-15 13:37:04 + (Fri, 15 Dec 2006) New Revision: 5793 Revision summary: http://svn.pgadmin.org/cgi-bin/viewcvs.cgi/?rev=5793view=rev Log: Fix the shortcut key for the favourites menu, per David Gould. Modified: trunk/pgadmin3/pgadmin/frm/frmQuery.cpp ---(end of broadcast)--- TIP 4: Have you searched our list archives? http://archives.postgresql.org
[pgadmin-hackers] SVN Commit by dpage: r5794 - trunk/pgadmin3
Author: dpage Date: 2006-12-15 14:02:36 + (Fri, 15 Dec 2006) New Revision: 5794 Revision summary: http://svn.pgadmin.org/cgi-bin/viewcvs.cgi/?rev=5794view=rev Log: Add bug noted by Daniel Segall: If I have two Query windows open, and one has a modal dialog open, I cannot execute queries in the other one by pressing F5. Using the mouse to select Query - Execute, however, does work. To Reproduce: 1. Open 2 Query windows. 2. In one window, select File - Open. Leave the Open File Dialog alone. 3. Switch to the other Query window. Type in a query. 4. Try to execute by pressing F5. (Bug - doesn't work) 5. Try to execute by selecting Query - Execute with the mouse. (Works fine) Platform: WinXP SP2 pgAdmin III 1.6.1, English, Binary distribution Modified: trunk/pgadmin3/BUGS ---(end of broadcast)--- TIP 5: don't forget to increase your free space map settings
[pgadmin-hackers] SVN Commit by dpage: r5795 - branches/REL-1_6_0_PATCHES/pgadmin3
Author: dpage Date: 2006-12-15 14:21:39 + (Fri, 15 Dec 2006) New Revision: 5795 Revision summary: http://svn.pgadmin.org/cgi-bin/viewcvs.cgi/?rev=5795view=rev Log: Add bug noted by Daniel Segall: If I have two Query windows open, and one has a modal dialog open, I cannot execute queries in the other one by pressing F5. Using the mouse to select Query - Execute, however, does work. To Reproduce: 1. Open 2 Query windows. 2. In one window, select File - Open. Leave the Open File Dialog alone. 3. Switch to the other Query window. Type in a query. 4. Try to execute by pressing F5. (Bug - doesn't work) 5. Try to execute by selecting Query - Execute with the mouse. (Works fine) Platform: WinXP SP2 pgAdmin III 1.6.1, English, Binary distribution Modified: branches/REL-1_6_0_PATCHES/pgadmin3/BUGS ---(end of broadcast)--- TIP 3: Have you checked our extensive FAQ? http://www.postgresql.org/docs/faq
[pgadmin-hackers] SVN Commit by dpage: r5796 - in trunk/pgadmin3: . pgadmin/schema
Author: dpage Date: 2006-12-15 14:36:35 + (Fri, 15 Dec 2006) New Revision: 5796 Revision summary: http://svn.pgadmin.org/cgi-bin/viewcvs.cgi/?rev=5796view=rev Log: Properly drop foreign keys in schemas whose names require quoting, per M S. Modified: trunk/pgadmin3/CHANGELOG trunk/pgadmin3/pgadmin/schema/pgForeignKey.cpp ---(end of broadcast)--- TIP 5: don't forget to increase your free space map settings
[pgadmin-hackers] SVN Commit by dpage: r5797 - in branches/REL-1_6_0_PATCHES/pgadmin3: . src/schema
Author: dpage Date: 2006-12-15 14:38:43 + (Fri, 15 Dec 2006) New Revision: 5797 Revision summary: http://svn.pgadmin.org/cgi-bin/viewcvs.cgi/?rev=5797view=rev Log: Properly drop foreign keys in schemas whose names require quoting, per M S. Modified: branches/REL-1_6_0_PATCHES/pgadmin3/CHANGELOG branches/REL-1_6_0_PATCHES/pgadmin3/src/schema/pgForeignKey.cpp ---(end of broadcast)--- TIP 9: In versions below 8.0, the planner will ignore your desire to choose an index scan if your joining column's datatypes do not match
[pgadmin-hackers] SVN Commit by dpage: r5798 - in branches/REL-1_6_0_PATCHES/pgadmin3/src: dlg ui
Author: dpage Date: 2006-12-15 16:07:42 + (Fri, 15 Dec 2006) New Revision: 5798 Revision summary: http://svn.pgadmin.org/cgi-bin/viewcvs.cgi/?rev=5798view=rev Log: More Solaris crash prevention Modified: branches/REL-1_6_0_PATCHES/pgadmin3/src/dlg/dlgServer.cpp branches/REL-1_6_0_PATCHES/pgadmin3/src/ui/dlgDatabase.xrc branches/REL-1_6_0_PATCHES/pgadmin3/src/ui/xrcDialogs.cpp ---(end of broadcast)--- TIP 5: don't forget to increase your free space map settings
[pgadmin-hackers] SVN Commit by dpage: r5799 - in trunk/pgadmin3/pgadmin: dlg ui
Author: dpage Date: 2006-12-15 16:08:21 + (Fri, 15 Dec 2006) New Revision: 5799 Revision summary: http://svn.pgadmin.org/cgi-bin/viewcvs.cgi/?rev=5799view=rev Log: More Solaris crash prevention Modified: trunk/pgadmin3/pgadmin/dlg/dlgServer.cpp trunk/pgadmin3/pgadmin/ui/dlgDatabase.xrc trunk/pgadmin3/pgadmin/ui/xrcDialogs.cpp ---(end of broadcast)--- TIP 3: Have you checked our extensive FAQ? http://www.postgresql.org/docs/faq
