Re: [pgadmin-hackers] Query History enhancements

2010-03-15 Thread Guillaume Lelarge
Le 15/03/2010 06:28, Dickson S. Guedes a écrit :
 2010/3/13 Guillaume Lelarge guilla...@lelarge.info:
 Le 14/03/2010 00:22, Dickson S. Guedes a écrit :
 [...]
 I'm thinking that there are some things that could enhance the query
 history: allow the user defines the max size of the query that could
 be added in history, the total number of queries stored and avoid
 store itentical queries

 What do you think?


 That there are good ideas. Unfortunately, I don't think we'll have time
 to do that before next release. Unless you or someone else would like to
 work on that.
 
 I've started something this weekend and I'll send a patch in a few days.
 

Wow, great. That's really great news.

While you're working on the query tool, can you take care of ticket #145
(http://code.pgadmin.org/trac/ticket/145)? it needs a new configuration
in the frmOptions dialog, and the capacity to append the output to the
file, rather than overwriting it. Should be quite simple to do. If you
do, I would like a patch for this specific ticket, and another one for
your current work. BTW, I'll add a ticket for this.

Thanks.


-- 
Guillaume.
 http://www.postgresqlfr.org
 http://dalibo.com

-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers


[pgadmin-hackers] [pgAdmin III] #148: Miscellaneous requests for the query tool

2010-03-15 Thread pgAdmin Trac
#148: Miscellaneous requests for the query tool
---+
 Reporter:  Dickson S. Guedes  |   Owner:  Dickson S. Guedes
 Type:  bug|  Status:  new  
 Priority:  minor  |   Milestone:   
Component:  pgadmin| Version:  trunk
 Keywords:  querytool  |Platform:  all  
---+
 I'm thinking that there are some things that could enhance the query
 history: allow the user defines the max size of the query that could be
 added in history, the total number of queries stored and avoid store
 itentical queries.

-- 
Ticket URL: http://code.pgadmin.org/trac/ticket/148
pgAdmin III http://code.pgadmin.org/trac/
pgAdmin III

-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers


Re: [pgadmin-hackers] Re: PATCH: pgAdmin III hangs - it try to close debugger when some query is already in progress

2010-03-15 Thread Dave Page
On Thu, Mar 11, 2010 at 11:21 AM, Ashesh Vashi
ashesh.va...@enterprisedb.com wrote:
 Oops...
 Forget to attach the patches. :-(
 PFA.

Just tried this on Windows and get a reproducible crash :-(

1) Connect to the server. I was using PPAS 8.3R2.
2) Debug a function, eg. public.new_empno() from the PPAS sample database.
3) Run the function to the end, and then close the parameters dialogue
and the debug windows using the X button.

I also noticed there's a commented out line of code in the patch, as
well as some C style comments that should be changed to //.

   pgAdmin3.exe!wxMutex::Lock()  Line 42 + 0x3 bytes   C++
pgAdmin3.exe!dbgPgConn::Cancel()  Line 396  C++
pgAdmin3.exe!dbgPgConn::Close()  Line 375   C++
pgAdmin3.exe!dlgDirectDbg::CloseConnection()  Line 433  C++
pgAdmin3.exe!frmDebugger::OnClose(wxCloseEvent  event={...})  Line 383 
C++
pgAdmin3.exe!wxAppConsole::HandleEvent(wxEvtHandler *
handler=0x02afcb58, void (wxEvent )* func=0x008324d3, wxEvent 
event={...})  Line 323  C++
pgAdmin3.exe!wxEvtHandler::ProcessEventIfMatches(const
wxEventTableEntryBase  entry={...}, wxEvtHandler *
handler=0x02afcb58, wxEvent  event={...})  Line 1233   C++
pgAdmin3.exe!wxEventHashTable::HandleEvent(wxEvent  event={...},
wxEvtHandler * self=0x02afcb58)  Line 907 + 0x1c bytes  C++
pgAdmin3.exe!wxEvtHandler::ProcessEvent(wxEvent  event={...})  Line
1293 + 0x1c bytes   C++
pgAdmin3.exe!wxEvtHandler::ProcessEvent(wxEvent  event={...})  Line
1300 + 0x1c bytes   C++
pgAdmin3.exe!wxWindowBase::Close(bool force=false)  Line 428 + 0x1c 
bytes   C++
pgAdmin3.exe!wxFrame::MSWWindowProc(unsigned int message=16,
unsigned int wParam=0, long lParam=0)  Line 1042 + 0xa bytesC++
pgAdmin3.exe!wxWndProc(HWND__ * hWnd=0x0009067a, unsigned int
message=16, unsigned int wParam=0, long lParam=0)  Line 2613 + 0x1c
bytes   C++
user32.dll!7e418734()   
[Frames below may be incorrect and/or missing, no symbols loaded for
user32.dll]
user32.dll!7e418816()   
user32.dll!7e428ea0()   
user32.dll!7e428eec()   
ntdll.dll!7c90e473()
user32.dll!7e4194be()   
user32.dll!7e428e0d()   
user32.dll!7e428dd9()   
user32.dll!7e42934b()   
user32.dll!7e428dd9()   
uxtheme.dll!5ad73bc2()  
uxtheme.dll!5ad8c7f6()  
uxtheme.dll!5ad71ac7()  
uxtheme.dll!5ad71b3d()  
user32.dll!7e4294ed()   
pgAdmin3.exe!wxVLogTrace(unsigned long mask=591482, const wchar_t *
szFormat=0x0112, char * argptr=0xf060)  Line 220 + 0x11
bytes   C++
pgAdmin3.exe!wxWindow::MSWDefWindowProc(unsigned int nMsg=274,
unsigned int wParam=61536, long lParam=7537328)  Line 2238  C++
pgAdmin3.exe!wxWindow::MSWWindowProc(unsigned int message=274,
unsigned int wParam=61536, long lParam=7537328)  Line 3419 + 0x22
bytes   C++
pgAdmin3.exe!wxTopLevelWindowMSW::MSWWindowProc(unsigned int
message=274, unsigned int wParam=61536, long lParam=7537328)  Line 372
+ 0x14 bytesC++
pgAdmin3.exe!wxFrame::MSWWindowProc(unsigned int message=274,
unsigned int wParam=61536, long lParam=7537328)  Line 1101 + 0x14
bytes   C++
pgAdmin3.exe!wxWndProc(HWND__ * hWnd=0x0009067a, unsigned int
message=274, unsigned int wParam=61536, long lParam=7537328)  Line
2613 + 0x1c bytes   C++
user32.dll!7e418734()   
user32.dll!7e42bdf1()   
user32.dll!7e42927b()   
user32.dll!7e4292e3()   
uxtheme.dll!5ad98895()  
uxtheme.dll!5ad71ac7()  
uxtheme.dll!5ad71b3d()  
user32.dll!7e4294ed()   
pgAdmin3.exe!wxVLogTrace(unsigned long mask=591482, const wchar_t *
szFormat=0x00a1, char * argptr=0x0014)  Line 220 + 0x11
bytes   C++
pgAdmin3.exe!wxWindow::MSWDefWindowProc(unsigned int nMsg=161,
unsigned int wParam=20, long lParam=7537328)  Line 2238 C++
pgAdmin3.exe!wxWindow::MSWWindowProc(unsigned int message=161,
unsigned int wParam=20, long lParam=7537328)  Line 3419 + 0x22
bytes   C++
pgAdmin3.exe!wxTopLevelWindowMSW::MSWWindowProc(unsigned int
message=161, unsigned int wParam=20, long lParam=7537328)  Line 372 +
0x14 bytes  C++
pgAdmin3.exe!wxFrame::MSWWindowProc(unsigned int message=161,
unsigned int wParam=20, long lParam=7537328)  Line 1101 + 0x14
bytes   C++
pgAdmin3.exe!wxWndProc(HWND__ * hWnd=0x0009067a, unsigned int
message=161, unsigned int wParam=20, long lParam=7537328)  Line 2613 +
0x1c bytes  C++
user32.dll!7e418734()   
user32.dll!7e418816()   
user32.dll!7e4189cd()   
pgAdmin3.exe!wxFindWinFromHandle(void * hWnd=0x0012fccc)  Line 3434 
C++
user32.dll!7e418a10()   
pgAdmin3.exe!wxEventLoop::ProcessMessage(tagMSG * msg=0x0012fccc)  Line 
80  C++
pgAdmin3.exe!wxEventLoop::Dispatch()  Line 294  C++

[pgadmin-hackers] PATCH: Fail to restore table/function, if it has special characters.

2010-03-15 Thread Ashesh Vashi
Hi Dave,

The restore option of a table/function will fail, if the function name
contains special characters (i.e. testxyz)
Please find the patch to resolve the issue for both the trunk and
1_10_0_PATCHES branch.

--
Ashesh Vashi
EnterpriseDB INDIA: Enterprise Postgres Companyhttp://www.enterprisedb.com


FB12720_v1.patch
Description: Binary data


FB12720_REL_1_10_0_PATCHES_v1.patch
Description: Binary data

-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers


Re: [pgadmin-hackers] Query History enhancements

2010-03-15 Thread Dickson S. Guedes
2010/3/15 Guillaume Lelarge guilla...@lelarge.info:
 Le 15/03/2010 06:28, Dickson S. Guedes a écrit :
 2010/3/13 Guillaume Lelarge guilla...@lelarge.info:
 Le 14/03/2010 00:22, Dickson S. Guedes a écrit :
 [...]
 I'm thinking that there are some things that could enhance the query
 history: allow the user defines the max size of the query that could
 be added in history, the total number of queries stored and avoid
 store itentical queries

 What do you think?


 That there are good ideas. Unfortunately, I don't think we'll have time
 to do that before next release. Unless you or someone else would like to
 work on that.

 I've started something this weekend and I'll send a patch in a few days.


 Wow, great. That's really great news.

 While you're working on the query tool, can you take care of ticket #145
 (http://code.pgadmin.org/trac/ticket/145)? it needs a new configuration
 in the frmOptions dialog, and the capacity to append the output to the
 file, rather than overwriting it. Should be quite simple to do. If you
 do, I would like a patch for this specific ticket, and another one for
 your current work. BTW, I'll add a ticket for this.

Hum. Ok, I'll do it too and send two distinct patches.

Thanks.
--
Dickson S. Guedes
mail/xmpp: gue...@guedesoft.net - skype: guediz
http://guedesoft.net - http://www.postgresql.org.br

-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers


[pgadmin-hackers] Mismatching of a pgAdmin3.vcproj

2010-03-15 Thread Hiroshi Saito

Hi Guillaume.

I'm sorry very late reaction.
project of windows file is slightly strange.?_?

Regards,
Hiroshi Saito


vcproj_patch
Description: Binary data

-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers


[pgadmin-hackers] Re: PATCH: Fail to restore table/function, if it has special characters.

2010-03-15 Thread Dave Page
On Mon, Mar 15, 2010 at 2:10 PM, Ashesh Vashi
ashesh.va...@enterprisedb.com wrote:

 Hi Dave,
 The restore option of a table/function will fail, if the function name
 contains special characters (i.e. testxyz)
 Please find the patch to resolve the issue for both the trunk and
 1_10_0_PATCHES branch.

Hi,

Why the refactoring? That's certainly not desired on the 1.10 branch,
and should be justified (and applied consistently in other related
dialogues) if we want to include it for 1.12.

/D

-- 
Dave Page
EnterpriseDB UK: http://www.enterprisedb.com
PG East Conference: http://www.enterprisedb.com/community/nav-pg-east-2010.do

-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers


[pgadmin-hackers] Trying to build pgadmin from svn

2010-03-15 Thread Ilan Volow
I recently decided to look into the possibility of doing some hacking on 
pgadmin to add some features/fixes that I've wanted.  I'm trying to 
build pgadmin on OS X (10.6 Snow Leopard) using the EnterpriseDB 
Postgres Plus distribution and the latest svn checkout. I followed the 
instructions for OS X to the tee, I set the PG_HOME variable to 
/Library/PostgresPlus/8.3, but I still got configure errors complaining 
about the postgresql directory not being present. I even tried passing 
in the --with-pgsql=DIR parameter, but it didn't make any difference. 
I'm stumped, because far as I know, I have all of the necessary 
libraries to build pgadmin with the stock install of snow leopard and 
the enterprise db install. I suppose I could download all the complete 
source trees for WxMac, Postgresql, libxml, etc, but I'm trying to take 
the easiest route first.


Below is the output of the configure command. Any help would be greatly 
appreciated.


checking build system type... i386-apple-darwin10.2.0
checking host system type... i386-apple-darwin10.2.0
checking for a BSD-compatible install... /usr/bin/install -c
checking whether build environment is sane... yes
checking for a thread-safe mkdir -p... config/install-sh -c -d
checking for gawk... no
checking for mawk... no
checking for nawk... no
checking for awk... awk
checking whether make sets $(MAKE)... yes
checking how to create a ustar tar archive... gnutar
checking for gcc... gcc
checking whether the C compiler works... yes
checking for C compiler default output file name... a.out
checking for suffix of executables...
checking whether we are cross compiling... no
checking for suffix of object files... o
checking whether we are using the GNU C compiler... yes
checking whether gcc accepts -g... yes
checking for gcc option to accept ISO C89... none needed
checking for style of include used by make... GNU
checking dependency style of gcc... gcc3
checking for g++... g++
checking whether we are using the GNU C++ compiler... yes
checking whether g++ accepts -g... yes
checking dependency style of g++... gcc3
checking for ranlib... ranlib
checking whether to use precompiled headers... yes
checking how to run the C preprocessor... gcc -E
checking for grep that handles long lines and -e... /usr/bin/grep
checking for egrep... /usr/bin/grep -E
checking for ANSI C header files... yes
checking for sys/types.h... yes
checking for sys/stat.h... yes
checking for stdlib.h... yes
checking for string.h... yes
checking for memory.h... yes
checking for strings.h... yes
checking for inttypes.h... yes
checking for stdint.h... yes
checking for unistd.h... yes
checking arpa/inet.h usability... yes
checking arpa/inet.h presence... yes
checking for arpa/inet.h... yes
checking netdb.h usability... yes
checking netdb.h presence... yes
checking for netdb.h... yes
checking netinet/in.h usability... yes
checking netinet/in.h presence... yes
checking for netinet/in.h... yes
checking for stdlib.h... (cached) yes
checking for stdbool.h that conforms to C99... yes
checking for _Bool... yes
checking for an ANSI C-conforming const... yes
checking for size_t... yes
checking whether time.h and sys/time.h may both be included... yes
checking for working strtod... yes
checking for gethostbyname... yes
checking for inet_ntoa... yes
checking for memmove... yes
checking for memset... yes
checking for strchr... yes
checking for pg_config... /Library/PostgresPlus/8.3/bin/pg_config
checking for SSL_library_init in -lssl... yes
checking for krb5_sendauth in -lkrb5... yes
checking for PQexec in -lpq... no
checking for SSL_connect in -lpq... present
checking for krb5_free_principle in -lpq... not present
checking libpq-fe.h usability... yes
checking libpq-fe.h presence... yes
checking for libpq-fe.h... yes
checking PostgreSQL in /Library/PostgresPlus/8.3... failed
configure: error: you must specify a valid PostgreSQL installation with 
--with-pgsql=DIR


-- Ilan


--
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers


[pgadmin-hackers] [pgAdmin III] #149: Bug: recent files reset

2010-03-15 Thread pgAdmin Trac
#149: Bug: recent files reset
-+--
 Reporter:  Josh Berkus  |   Owner:  dpage
 Type:  bug  |  Status:  new  
 Priority:  minor|   Milestone:   
Component:  pgadmin  | Version:  trunk
 Keywords:  querytool|Platform:  all  
-+--
 Version: 1.10.1
 Platform: OSX 10.5
 Severity: Annoyance
 Reproduceable: sometimes
 Description:

 1) have a bunch of query windows for saved SQL files open (call them files
 1,2,3,4,5 and 6 in order in which they are opened).
 2) save file #1 and close it.
 3) In another, the query window for #5 pick file #1 from the recent
 files list in the menu.
 4) File #2 will actually open.

 What happened: until File #1 was closed and saved, it was at the bottom of
 the recent files list.  Closing it and saving it will have bumped it up to
 the top of the recent files list.  However, the query window for query #5
 will not show this change until *after* you attempt to access a file from
 that list, which is why it gives you the wrong file.

-- 
Ticket URL: http://code.pgadmin.org/trac/ticket/149
pgAdmin III http://code.pgadmin.org/trac/
pgAdmin III

-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers