Re: [pgadmin-hackers] ]GTK 3

2016-01-06 Thread Guillaume Lelarge
2016-01-05 23:54 GMT+01:00 Björn Harrtell : > Found the theme color issue. > > Server node color is customizable and new server nodes are created with > background from window and saved in .pgadmin3. > > I don't see the usefulness of this feature so I've attached patch

Re: [pgadmin-hackers] ]GTK 3

2016-01-06 Thread Dave Page
On Wed, Jan 6, 2016 at 8:54 AM, Guillaume Lelarge wrote: > 2016-01-05 23:54 GMT+01:00 Björn Harrtell : >> >> Found the theme color issue. >> >> Server node color is customizable and new server nodes are created with >> background from window and

Re: [pgadmin-hackers] pgAdmin III commit: As per commit:600daf650bd5e50e664c4ece2e53e95446390

2016-01-06 Thread Dave Page
Thanks. Ashesh - can you review/commit please? On Tue, Jan 5, 2016 at 12:24 PM, Neel Patel wrote: > Hi, > > Please find attached patch file with below fix. > - Return value of the function will be displayed as "SETOF record" instead > of "SETOF SETOF record" under

[pgadmin-hackers] backgrid select2 cell

2016-01-06 Thread Harshal Dhumal
Hi, Please find patch for backgrid select2 cell Usage: schema: [ {id: 'name', label:'Name', type:'text', cell: Backgrid.Extension.Select2Cell, editable: true, optionValues: [['Allow','allow'], ['Prefer','prefer'], ['Require','require'], ['Disable','disable']], select2:{placeholder:

Re: [pgadmin-hackers] PATCH: added "Collation" & "Catalog Objects" nodes in pgAdmin4

2016-01-06 Thread Dave Page
On Wed, Jan 6, 2016 at 12:18 PM, Murtuza Zabuawala wrote: > Hi, > > Please find patch to add "Collation" & "Catalog Objects" nodes in pgAdmin4. > > Please note that this patch is mainly for "Collation" & "Catalog Objects" > nodes, Schema/Catalog node is not yet

[pgadmin-hackers] pgAdmin 4 commit: Resolved an issue in the sesion tracking, and generat

2016-01-06 Thread Ashesh Vashi
Resolved an issue in the sesion tracking, and generating the data properly. Also, takes care of setting options to empty array, when it couldn't fetch the options for the NodeAjaxOptionsControl. And, generating proper url for 'msql' url in the SQL tab, when creating new node from the same type

[pgadmin-hackers] pgAdmin 4 commit: Allow to pass array as an input to the qtIdent.

2016-01-06 Thread Ashesh Vashi
Allow to pass array as an input to the qtIdent. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=a086820288d282d0bf8a7a7e6fbb9e940b7def7e Modified Files -- web/pgadmin/utils/driver/psycopg2/__init__.py | 3 +++ 1 file changed, 3

Re: [pgadmin-hackers] CleanHelpPath & index.html

2016-01-06 Thread Andreas 'ads' Scherbaum
On 06.01.2016 22:47, Andreas 'ads' Scherbaum wrote: looking into misc.cpp, around line 661, there is CleanHelpPath. When I try to add a documentation link ending with "index.html", this function incorrectly assumes that it must be a directory and adds a "/" (or whatever the current separator

[pgadmin-hackers] pgAdmin 4 commit: Resolving issue setting proper value for options in S

2016-01-06 Thread Ashesh Vashi
Resolving issue setting proper value for options in Select2Cell Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=df594d56e52c9b0cd420043f6bfbadf9dd23e4de Author: Harshal Dhumal Modified Files --

[pgadmin-hackers] backgrid select2 cell fixed issue for optionsValues

2016-01-06 Thread Harshal Dhumal
Hi, Please find minor patch to fix optionsValues for backgrid cell. *Issue:* Fixed issue when accessing OptionValues from view -- *Harshal Dhumal* *Software Engineer * EenterpriseDB diff --git a/web/pgadmin/static/js/backgrid/backgrid.pgadmin.js

[pgadmin-hackers] pgAdmin 4 commit: Adding Select2Cell, which uses select2.

2016-01-06 Thread Ashesh Vashi
Adding Select2Cell, which uses select2. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=67a80ce8dda3d6d99cfcf1a7946bd1441966da30 Author: Harshal Dhumal Modified Files --

[pgadmin-hackers] pgAdmin 4 commit: Stringify the data only during GET mode.

2016-01-06 Thread Ashesh Vashi
Stringify the data only during GET mode. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=ee3efc369ddd6c2e69c643c39c1b849a5cdb673d Modified Files -- web/pgadmin/browser/templates/browser/js/node.js | 35 +---

Re: [pgadmin-hackers] backform select2 control

2016-01-06 Thread Harshal Dhumal
Hi, Updated patch. As yesterdays patch for backform select2 and select2ajaxoptoins controls was throwing malformed patch error. -- *Harshal Dhumal* *Software Engineer * EenterpriseDB On Wed, Jan 6, 2016 at 12:01 PM, Harshal Dhumal <

[pgadmin-hackers] PATCH: Minor patch to fix issue in Integer Control [ pgAdmin4 ]

2016-01-06 Thread Murtuza Zabuawala
Hi, Please find minor patch to fix Backform Integer-Control. _Issue:__ _After validation of input value, value was not getting updated in model, hence it was taking default value from schema. Regards, Murtuza Zabuawala diff --git a/web/pgadmin/static/js/backform.pgadmin.js

[pgadmin-hackers] pgAdmin 4 commit: JSONinfy all data in new mode for the Backbone.Model.

2016-01-06 Thread Ashesh Vashi
JSONinfy all data in new mode for the Backbone.Model. Also, takes care about not quoting the identifier, when found any digit in the name (except it starts with a digit). Branch -- master Details ---

[pgadmin-hackers] CleanHelpPath & index.html

2016-01-06 Thread Andreas 'ads' Scherbaum
Hi, looking into misc.cpp, around line 661, there is CleanHelpPath. When I try to add a documentation link ending with "index.html", this function incorrectly assumes that it must be a directory and adds a "/" (or whatever the current separator is). This even happens when the correct link