[pgadmin-hackers] pgAdmin 4 commit: Copyright updates for 2016.

2016-01-18 Thread Dave Page
Copyright updates for 2016. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=694506453b830fc60b98ea2382ea0a5bcd0331a0 Modified Files -- LICENSE| 2 +- web/config.py

[pgadmin-hackers] pgAdmin 4 commit: Support tabs in the runtime browser.

2016-01-18 Thread Dave Page
Support tabs in the runtime browser. Added functionality to open different website link and load the website data to different tab. To achieve this, new customized QTabWidget and QWebView are added to render the data to WebView widget. All the widgets (New Tab, WebViewWinodw, and QToolButton) are

Re: [pgadmin-hackers] [pgadmin-support] [pgAdmin4] - Desktop runtime patch

2016-01-18 Thread Dave Page
Thanks Neel. I've committed this with various minor tweaks, mostly around the tab button text and sizing. Please test on Windows and Linux to ensure I didn't inadvertently break anything. Mac seems fine here. On Fri, Jan 15, 2016 at 2:06 PM, Neel Patel wrote: > Hi,

[pgadmin-hackers] pgAdmin 4 commit: Bump the version requirement for Flask-Gravatar to 0.

2016-01-18 Thread Dave Page
Bump the version requirement for Flask-Gravatar to 0.4.2. This version has been restructured and plays nicely with our runtime. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=94bed721bd2f4157fa6629c197dd9e0a783cced6 Modified Files

[pgadmin-hackers] patch for cast module

2016-01-18 Thread Sanket Mehta
Hi, PFA patch for cast module. Please do review it and let me know in case of any issue. Regards, Sanket Mehta Sr Software engineer Enterprisedb diff --git a/web/pgadmin/browser/server_groups/servers/databases/casts/__init__.py

[pgadmin-hackers] pgAdmin 4 commit: Chagned the variable control to use the new format of

2016-01-18 Thread Ashesh Vashi
Chagned the variable control to use the new format of generateSchemaView(...) output. Also, set the value in proper format before rendering them using DynamicVariableCell. Branch -- master Details ---

[pgadmin-hackers] Remove "unsupported version" warning for Greenplum

2016-01-18 Thread Andreas 'ads' Scherbaum
Hello, we tested pgAdminIII 1.22 internally and found that it works sufficient with Greenplum. A few minor problems are identified and we plan to work on them as well, but nothing serious. We however know that there are a number more serious problems with HAWQ (SQL on Hadoop), we plan to

Re: [pgadmin-hackers] [pgAdmin4] [Patch]: Extension Module

2016-01-18 Thread Neel Patel
Hi Surinder, We have applied/tested the patch and below are the review comments. 1. When we select the extension "plpython3u", "plperl", "plperu" etc. then it gives 'TypeError' in Javascript. TypeError: d.version is undefined 'version': (!_.isNull(d.version[0]) ? d.version[0]: '') We are

Re: [pgadmin-hackers] [pgAdmin4] [Patch]: Extension Module

2016-01-18 Thread Surinder Kumar
Thanks Neel for reviewing. I'll send the patch with the fixes suggested. On Mon, Jan 18, 2016 at 4:52 PM, Neel Patel wrote: > Hi Surinder, > > We have applied/tested the patch and below are the review comments. > > 1. When we select the extension "plpython3u",

[pgadmin-hackers] [pgAdmin3][Extension]: Wrong SQL generated

2016-01-18 Thread Surinder Kumar
Hi all, While implementing Extension module in pgAdmin4, I came to know that there is an bug in pgadmin3. Following are the steps to reproduce it: 1. Edit an existing extension. 2. In definition tab, set schema and version fields to empty. 3. In SQL tab, it generates an sql for the changes made

Re: [pgadmin-hackers] PATCH: added "Collation" & "Catalog Objects" nodes in pgAdmin4

2016-01-18 Thread Neel Patel
Hi Murtuza, Please find below review comments for the collation node. 1. "Owner" field should be changed from text control to Backform.NodeListByNameControl. 2. Remove "Use Slony" option, we will implement it as separate module. 3. Use 2 space indentation instead of 4 space in javascript file.

Re: [pgadmin-hackers] [pgadmin-support] [pgAdmin4] - Desktop runtime patch

2016-01-18 Thread Neel Patel
Thanks Dave. I will test on Windows and Linux and keep you updated. Thanks, Neel Patel On Mon, Jan 18, 2016 at 8:07 PM, Dave Page wrote: > Thanks Neel. I've committed this with various minor tweaks, mostly > around the tab button text and sizing. > > Please test on Windows

[pgadmin-hackers] New mechanism in backgrid to render different types of cells in same column [pgAdmin4]

2016-01-18 Thread Harshal Dhumal
Hi, This patch is replacement for our developed DynamicVariablecell. Now we can pass cellFunction in column schema to get appropriate cell class. User provided cellFunction must return valid cell class. cellFunction will be called with context (this) as column and model as argument. eg.:

[pgadmin-hackers] Re: New mechanism in backgrid to render different types of cells in same column [pgAdmin4]

2016-01-18 Thread Harshal Dhumal
+ Also fixed some minor issues related to Unique column functionality in Variable control in same patch. -- *Harshal Dhumal* *Software Engineer * EenterpriseDB On Tue, Jan 19, 2016 at 12:37 AM, Harshal Dhumal < harshal.dhu...@enterprisedb.com> wrote: > Hi, > >

[pgadmin-hackers] pgAdmin 4 commit: Moving the data model and collection to separate modu

2016-01-18 Thread Ashesh Vashi
Moving the data model and collection to separate module for better code handling. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=2acba32c86c374381f77f422a474559e4b849a48 Modified Files -- web/pgadmin/browser/__init__.py

Re: [pgadmin-hackers] PATCH: added "Collation" & "Catalog Objects" nodes in pgAdmin4

2016-01-18 Thread Murtuza Zabuawala
Thanks Neel. I'll work on below mentioned issues & send new patch. Regards, Murtuza On Monday 18 January 2016 10:12 PM, Neel Patel wrote: Hi Murtuza, Please find below review comments for the collation node. 1. "Owner" field should be changed from text control to