[pgadmin-hackers] PATCH: Fix for node.ui.js [pgAdmin4]

2016-01-21 Thread Murtuza Zabuawala
Hi, PFA patch to fix an issue in node.ui.js, Issue: There is a typo in node.ui.js for node-ajax-options cell causing TypeError at client side. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company fix_node-ajax-options_cell.patch

[pgadmin-hackers] pgAdmin 4 commit: Resolved a typo in the psycopg2 driver, qtTypeIdent c

2016-01-21 Thread Ashesh Vashi
Resolved a typo in the psycopg2 driver, qtTypeIdent checking the wrong list, because - in specific type match comma (,) was missing. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=0a21beca17b2227942f64b17fc7d82af3ce9485e Modified Files

[pgadmin-hackers] pgAdmin 4 commit: Fix comment

2016-01-21 Thread Dave Page
Fix comment Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=b39943e3ff3c900e5d3157cfac993245938a1d5f Modified Files -- runtime/BrowserWindow.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- Sent via pgadmin-hackers

[pgadmin-hackers] pgAdmin 4 commit: Fix minor status bar display issue.

2016-01-21 Thread Dave Page
Fix minor status bar display issue. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=c6cfad4f0170ff44baedfef449a8e092fa7a1771 Author: Harshal Dhumal Modified Files --

[pgadmin-hackers] pgAdmin 4 commit: Fix border display issue in unique column collection

2016-01-21 Thread Dave Page
Fix border display issue in unique column collection Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=8f18ff04aeb32ca445601efc4877bb20bbce6917 Author: Harshal Dhumal Modified Files --

Re: [pgadmin-hackers] Patch for minor UI issues [pgadmin4]

2016-01-21 Thread Dave Page
Thanks, applied. On Wed, Jan 20, 2016 at 11:23 AM, Harshal Dhumal < harshal.dhu...@enterprisedb.com> wrote: > Hi, > > PFA patches for minor issues in status bar and border issue in Unique coll > collection. > > > -- > *Harshal Dhumal* > *Software Engineer * > > > > EenterpriseDB

Re: [pgadmin-hackers] Remove "unsupported version" warning for Greenplum

2016-01-21 Thread Dave Page
On Tue, Jan 19, 2016 at 10:54 PM, Andreas 'ads' Scherbaum wrote: > On 19.01.2016 16:03, Dave Page wrote: >> >> >> Your patch won't apply again. I have no idea why - I'm trying to do it >> on my Mac, which is a *nix under the hood (they don't use Mac line >> endings any more

Re: [pgadmin-hackers] [pgAdmin4] [Patch]: Extension Module

2016-01-21 Thread Surinder Kumar
Hi, I've fixed the issues given in review comments. Please find the attached updated patch for extension module, review it and let me know for any comments. On Mon, Jan 18, 2016 at 5:44 PM, Surinder Kumar < surinder.ku...@enterprisedb.com> wrote: > Thanks Neel for reviewing. I'll send the

Re: [pgadmin-hackers] Remove "unsupported version" warning for Greenplum

2016-01-21 Thread Magnus Hagander
On Thu, Jan 21, 2016 at 11:35 PM, Andreas 'ads' Scherbaum < adsm...@wars-nicht.de> wrote: > On 21.01.2016 10:31, Dave Page wrote: > >> On Tue, Jan 19, 2016 at 10:54 PM, Andreas 'ads' Scherbaum >> wrote: >> >>> On 19.01.2016 16:03, Dave Page wrote: >>> Your

Re: [pgadmin-hackers] Remove "unsupported version" warning for Greenplum

2016-01-21 Thread Magnus Hagander
On Thu, Jan 21, 2016 at 10:31 AM, Dave Page wrote: > On Tue, Jan 19, 2016 at 10:54 PM, Andreas 'ads' Scherbaum > wrote: > > On 19.01.2016 16:03, Dave Page wrote: > >> > >> > >> Your patch won't apply again. I have no idea why - I'm trying to do it > >>

Re: [pgadmin-hackers] Remove "unsupported version" warning for Greenplum

2016-01-21 Thread Magnus Hagander
On Thu, Jan 21, 2016 at 11:13 PM, Magnus Hagander wrote: > On Thu, Jan 21, 2016 at 10:31 AM, Dave Page wrote: > >> On Tue, Jan 19, 2016 at 10:54 PM, Andreas 'ads' Scherbaum >> wrote: >> > On 19.01.2016 16:03, Dave Page wrote: >> >>

Re: [pgadmin-hackers] Remove "unsupported version" warning for Greenplum

2016-01-21 Thread Andreas 'ads' Scherbaum
On 21.01.2016 10:31, Dave Page wrote: On Tue, Jan 19, 2016 at 10:54 PM, Andreas 'ads' Scherbaum wrote: On 19.01.2016 16:03, Dave Page wrote: Your patch won't apply again. I have no idea why - I'm trying to do it on my Mac, which is a *nix under the hood (they don't

[pgadmin-hackers] PATCH: minor issue resolved related to retrieval of last system oid

2016-01-21 Thread Sanket Mehta
Hi, I found an issue in *connnection* function in utils/drivers/psycopg2/__init__.py file related to 'datlastsysoid'. It was not getting retrieved and put inside db_info dict. Due to this error occurred while expanding cast collection node. I have resolved the issue and attached a patch with

[pgadmin-hackers] Database patch and other minor patches and control documentation

2016-01-21 Thread Harshal Dhumal
Hi, Please find the attached patches: Database node patch (depends on privilege_macro, node_ui_typo, variable_js patches) *How to use controls:* *1] Privilege control:* *a]* Data expected from server in following format: eg: * {grantee: public, privileges: Tc* , grantor: postgres}

Re: [pgadmin-hackers] PATCH: minor issue resolved related to retrieval of last system oid

2016-01-21 Thread Ashesh Vashi
Thanks applied. -- Thanks & Regards, Ashesh Vashi EnterpriseDB INDIA: Enterprise PostgreSQL Company *http://www.linkedin.com/in/asheshvashi* On Fri, Jan 22, 2016 at 10:31 AM, Sanket Mehta < sanket.me...@enterprisedb.com>

[pgadmin-hackers] pgAdmin 4 commit: Fetch the last system oid for the database connection

2016-01-21 Thread Ashesh Vashi
Fetch the last system oid for the database connection too. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=0eadd92a7f56a4a10f4a88d4256fef4a8768e81c Author: Sanket Mehta Modified Files --

Re: [pgadmin-hackers] [pgAdmin4] [Patch]: Extension Module

2016-01-21 Thread Surinder Kumar
Hi Please find the updated patch with following fixes: 1. Missing `owner` column under properties for `extensions collection`. Add cell: 'string' property for owner fixed it 2. Schema object identifier should be wrapped with in function qtIdent . Using function `qtIdent` for schema in create.sql

[pgadmin-hackers] pgAdmin 4 commit: Resovled a typo in rendering the NodeAjaxOptionsCell

2016-01-21 Thread Ashesh Vashi
Resovled a typo in rendering the NodeAjaxOptionsCell about getting the options from the column schema for the cell. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=7f3c972d066b5378e6a368622b210399add4183d Author: Harshal Dhumal