Re: [pgadmin-hackers] pgAdmin III: Muliple SQL tabs

2016-02-02 12:08 GMT+01:00 Dave Page : > On Tue, Feb 2, 2016 at 3:17 AM, Sergey Busel wrote: > > Patch file for multiple SQL tabs is attached. > > Thanks - I see how this could be useful. I think it needs a little > work before it could be included: > > -

Re: [pgadmin-hackers] [pgAdmin4] Patch: Added new Control SqlFieldControl

Hi Surinder, On Tue, Feb 2, 2016 at 1:05 PM, Surinder Kumar < surinder.ku...@enterprisedb.com> wrote: > Hi, > > > Please find patch for SqlFieldControl. > Thanks for the patch. > > This control allows the user to write/edit SQL queries. > K > > To use SqlFieldControl, Set *control* property of

Re: [pgadmin-hackers] pgAdmin 4 commit: Update the runtime to properly support Windows.

Hi Dave, Below two minor changes. - We have added below statement two times in Qt project files so removed the duplicate entry. PY2_VERSION = $$find(PY_VERSION, "^2") - Added some instructions in README file for the Windows system. Can you please review attached patch file and let us

Re: [pgadmin-hackers] PATCH: Login/Group Role Node

Hi Ashesh, I also found that we are not handling group role in macro templates. Steps to re-produce the issue: 1) Create a sample Group Role. name : my_group Click 'Ok' to create. 2) Go to privilege tab (in my case Database node) - Click on Add button - Select my_group (Group) from options

Re: [pgadmin-hackers] PATCH: Login/Group Role Node

On Tue, Feb 2, 2016 at 9:22 AM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi Ashesh, > > I also found that we are not handling group role in macro templates. > > Steps to re-produce the issue: > 1) Create a sample Group Role. > name : my_group > > Click 'Ok' to create.

[pgadmin-hackers] pgAdmin website commit: Simplify JSON structure

Simplify JSON structure Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin-www.git;a=commitdiff;h=b09ddb418b2f0a23487a49edbbae3529825a062f Modified Files -- versions.json | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) -- Sent via

Re: [pgadmin-hackers] pgAdmin III: Muliple SQL tabs

On Tue, Feb 2, 2016 at 3:17 AM, Sergey Busel wrote: > Patch file for multiple SQL tabs is attached. Thanks - I see how this could be useful. I think it needs a little work before it could be included: - Unused code should be removed, not commented out. - I think the tab names

[pgadmin-hackers] Minor issue in variable js [pgadmin4]

Hi, PFA minor patch for variable js. Issue fixed: Initialize boolean cell with proper data (either true or false not undefined). -- *Harshal Dhumal* *Software Engineer * EenterpriseDB diff --git a/web/pgadmin/browser/server_groups/servers/static/js/variable.js

[pgadmin-hackers] Added variable macro for generic db objects

Hi, PFA patch to add another generic macro for variable control, previously written macro was specific to database node and not usable with other db objects. *How to use:* VARIABLE.SET(conn, object_type, object_name, variable_name, value) VARIABLE.UNSET(conn, object_type, object_name,

Re: [pgadmin-hackers] Updated patches

Adding more comments. - "Delete Database" functionality is not working, we are getting below error. * The requested URL was not found on the server. If you entered the URL manually please check your spelling and try again.* - "Drop/Delete functionality is not working, we are getting below

[pgadmin-hackers] pgAdmin website commit: Fix JSON syntax

Fix JSON syntax Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin-www.git;a=commitdiff;h=fb1c835ed37b72a51b259afea04d7ee7b9bfbab9 Modified Files -- versions.json | 15 +++ 1 file changed, 11 insertions(+), 4 deletions(-) -- Sent via

[pgadmin-hackers] PATCH: NodeAjaxOptionsControl in Subnode

Hi, When we are using NodeAjaxOptionsControl in main model, it is working fine, but while using it in subnode, giving an error of node is undefined. So, I have fixed that issue and the patch for the same is attached. Please review it and let me know in case of problem. Thanks, Khushboo diff

[pgadmin-hackers] PATCH: Tablespace Node [pgAdmin4]

Hi, Please find attach patch for tablespace node for pgAdmin4. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company tablespace_node_v1.patch Description: Binary data -- Sent via pgadmin-hackers mailing list

Re: [pgadmin-hackers] PATCH: Tablespace Node [pgAdmin4]

Hi, PFA updated patch, Copyright year updated. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Wed, Feb 3, 2016 at 12:22 PM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi, > > Please find attach patch for

Re: [pgadmin-hackers] pgAdmin III: Muliple SQL tabs

No, that's not the way it works in this patch. All SQL tabs are sharing the same output pane. At this point, the tabs only help organize code into files. For me, it's easier to switch tabs and hit F5 then keep highlighting the text to execute in the same query box. I know that this is not a true

Re: [pgadmin-hackers] pgAdmin III: Muliple SQL tabs

- Removed unused/commented code. - Tab names now reflect the file name, if such is associated with a tab. - Removed the "Close Tab" menu item. Added X button to the active tab. - To tell the user which tab results are related to and to avoid messing with perspective, the name of the related tab is

Re: [pgadmin-hackers] Added variable macro for generic db objects

Hi, PFA updated patch, I missed adding parentheses in previous patch for UNSET macro . Thanks. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Tue, Feb 2, 2016 at 5:49 PM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com>

[pgadmin-hackers] pgAdmin 4 commit: Update the runtime to properly support Windows.

Update the runtime to properly support Windows. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=efc8815ecb78b20318d18ba50588e63e554f053a Author: Neel Patel Modified Files -- runtime/Server.cpp | 13

[pgadmin-hackers] pgAdmin 4 commit: Adding the macros to set variable options for objects

Adding the macros to set variable options for objects other than Role. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=e9497687d0b172fe452e0d3d682d14afc4b9749d Author: Murtuza Zabuawala Modified Files

[pgadmin-hackers] pgAdmin 4 commit: Do not trigger 'pgadmin-session:invalid' event, when

Do not trigger 'pgadmin-session:invalid' event, when a child object do not have any validation error, or the validation error message is null. Thanks Murtuza for find out the root cause. Branch -- master Details ---

Re: [pgadmin-hackers] Added variable macro for generic db objects

Thanks - checked in! -- Thanks & Regards, Ashesh Vashi EnterpriseDB INDIA: Enterprise PostgreSQL Company *http://www.linkedin.com/in/asheshvashi* On Tue, Feb 2, 2016 at 6:31 PM, Murtuza Zabuawala <