[pgadmin-hackers] [pgAdmin4] [Patch]: Resource Group Module

2016-02-04 Thread Akshay Joshi
Hi All Attached is the patch for the Resource Group Module. Please review it and if it looks good then please commit it. -- *Akshay Joshi* *Principal Software Engineer * *Phone: +91 20-3058-9517Mobile: +91 976-788-8246* Resource_Group.patch Description: Binary data -- Sent via

Re: [pgadmin-hackers] Remove "unsupported version" warning for Greenplum

2016-02-04 Thread Andreas 'ads' Scherbaum
On 18.01.2016 02:44, Andreas 'ads' Scherbaum wrote: we tested pgAdminIII 1.22 internally and found that it works sufficient with Greenplum. A few minor problems are identified and we plan to work on them as well, but nothing serious. We however know that there are a number more serious problems

[pgadmin-hackers] Common utility functions to parse privileges [pgadmin4]

2016-02-04 Thread Harshal Dhumal
Hi, PFA patch for server utility functions to parse privileges. -- *Harshal Dhumal* *Software Engineer * EenterpriseDB diff --git a/web/pgadmin/browser/server_groups/servers/utils.py b/web/pgadmin/browser/server_groups/servers/utils.py new file mode 100644

[pgadmin-hackers] pgAdmin 4 commit: Adding the Login/Group Role Node.

2016-02-04 Thread Ashesh Vashi
Adding the Login/Group Role Node. Also - includes: * Added 'parent_id' in the 'generate_browser_node' function of the Nodes to allow them to move around the parents objects (specially through update/save functionality). * Handles the issue related to adding the older object back to the

[pgadmin-hackers] pgAdmin 4 commit: Adding the Tablespace node

2016-02-04 Thread Ashesh Vashi
Adding the Tablespace node Author: Murtuza Zabuawala Reviewed by: Neel Patel, Ashesh Vashi Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=71a69f1dd4323bf01f78b5360d3637fb7c5cc8e1 Modified Files --

[pgadmin-hackers] pgAdmin 4 commit: Resolved an issue related to quoting the wrong keywor

2016-02-04 Thread Ashesh Vashi
Resolved an issue related to quoting the wrong keywords for the types. It was due to wrong index used for the COL_NAME_KEYWORD, used by the 'needsQuoting' function. Also, replaced a tab with a space in the generate_keyword.py file. Reported by: Sanket Mehta, Khushboo Vashi Branch -- master

Re: [pgadmin-hackers] patch for cast module

2016-02-04 Thread Akshay Joshi
Hi Sanket Below are the review comments - As "Show System Object" is not implemented yet, we should show all the objects by default. - As in pgAdmin3 when click on Casts (Collection) node it should show only Name, Owner and Comments. With current code it is showing all the

[pgadmin-hackers] pgAdmin 4 commit: Adding the Database node.

2016-02-04 Thread Ashesh Vashi
Adding the Database node. We know that current implemenation have some limitations: i.e. * We should not show the template0 in the browser tree. * Should not connect to the database which does not have permission to connect the server by the current user. * Show default previlige for PUBLIC in

[pgadmin-hackers] pgAdmin III commit: Include wxWidgets patch in the distro.

2016-02-04 Thread Dave Page
Include wxWidgets patch in the distro. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin3.git;a=commitdiff;h=1215e04b9d00d5fb1f23928fa2e1db2afb78bd50 Modified Files -- xtra/wx-build/Makefile.am | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) --

Re: [pgadmin-hackers] PATCH: Tablespace Node [pgAdmin4]

2016-02-04 Thread Murtuza Zabuawala
Hi, PFA updated patch, Corrected a typo in sql panel. Regards, Murtuza -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Thu, Feb 4, 2016 at 7:20 PM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > > Hi, > > PFA

[pgadmin-hackers] pgAdmin III commit: Add a wxWidgets patch that fixes the font selection

2016-02-04 Thread Dave Page
Add a wxWidgets patch that fixes the font selection dialogue. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin3.git;a=commitdiff;h=d97511421f8a7a172dbe4080fa112d2acb21ea9c Modified Files -- .../patches/wxmac-2_8_12-font-dialogue.diff| 26

Re: [pgadmin-hackers] Updated patches

2016-02-04 Thread Neel Patel
Hi, New database patch is working fine. Ashesh - Can you please review it ? If it looks good then can you please commit ? Thanks, Neel Patel On Thu, Feb 4, 2016 at 6:35 PM, Harshal Dhumal < harshal.dhu...@enterprisedb.com> wrote: > Hi, > > PFA updated patch for database node. > > Issue fixed:

Re: [pgadmin-hackers] patch for cast module

2016-02-04 Thread Sanket Mehta
Hi Akshay, PFA the latest patch for Cast module. Please do review it and let me know if anything is missing. Regards, Sanket Mehta Sr Software engineer Enterprisedb On Wed, Jan 20, 2016 at 5:03 PM, Sanket Mehta wrote: > Hi Neel. > > PFA the revised patch which

Re: [pgadmin-hackers] PATCH: Tablespace Node [pgAdmin4]

2016-02-04 Thread Neel Patel
Hi Team, New Tablespace patch is working fine. If it looks good then we can commit the code. Thanks, Neel Patel On Thu, Feb 4, 2016 at 7:44 PM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi, > > PFA updated patch, Corrected a typo in sql panel. > > Regards, > Murtuza > >

[pgadmin-hackers] pgAdmin III commit: Include wxWidgets patch in the distro.

2016-02-04 Thread Dave Page
Include wxWidgets patch in the distro. Branch -- REL-1_22_0_PATCHES Details --- http://git.postgresql.org/gitweb?p=pgadmin3.git;a=commitdiff;h=5960a6cd4a850e0c8dc627a7e21241106578bd50 Modified Files -- xtra/wx-build/Makefile.am | 3 ++- 1 file changed, 2 insertions(+), 1

[pgadmin-hackers] pgAdmin III commit: Add a wxWidgets patch that fixes the font selection

2016-02-04 Thread Dave Page
Add a wxWidgets patch that fixes the font selection dialogue. Branch -- REL-1_22_0_PATCHES Details --- http://git.postgresql.org/gitweb?p=pgadmin3.git;a=commitdiff;h=5118cf330dd66ea2b8621081a21d04ee62c5b89d Modified Files -- .../patches/wxmac-2_8_12-font-dialogue.diff

Re: [pgadmin-hackers] PATCH: Tablespace Node [pgAdmin4]

2016-02-04 Thread Murtuza Zabuawala
Hi, PFA updated patch, I have updated error handling at client side. Regards, Murtuza -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Thu, Feb 4, 2016 at 6:52 PM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi,

[pgadmin-hackers] pgAdmin 4 commit: Common functions to convert the privileges format to/

2016-02-04 Thread Ashesh Vashi
Common functions to convert the privileges format to/from the database server. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=3ff77e9866852ab6b2b8d01e9251af47c2096201 Author: Harshal Dhumal Modified Files

Re: [pgadmin-hackers] PATCH: Tablespace Node [pgAdmin4]

2016-02-04 Thread Murtuza Zabuawala
Hi, PFA updated patch, I have updated privilege parsing logic. Regards, Murtuza -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Thu, Feb 4, 2016 at 1:11 PM, Neel Patel wrote: > Thank you Murtuza. > New