[pgadmin-hackers] PATCH: Fixed Textarea control template [pgAdmin4]

Hi, PFA updated patch to fix an issue in textarea template, if we do not provide default rows then control then it fails to render it (issue with yesterday's Arun changes), Causing Sql-Feild Control to break which uses textarea to render code mirror control. -- Regards, Murtuza Zabuawala

Re: [pgadmin-hackers] PATCH: Added Node Type & Catalog objects [pgAdmin4]

Committed the catalog_objects with few changes: - Renamed to catalog_objects - columns under it were renamed to catalog_object_column - Some of the query were specific to PPAS moved them to specific SQL templates. -- Thanks & Regards, Ashesh Vashi EnterpriseDB INDIA: Enterprise PostgreSQL

[pgadmin-hackers] pgAdmin 4 commit: Resolved few typos, comments, and also some query cor

Resolved few typos, comments, and also some query correction in the SQL templates for different nodes. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=87623cb9979f40a68995fc4a50b5e67672d309cb Modified Files --

[pgadmin-hackers] pgAdmin 4 commit: Added support for the catalog objects under special c

Added support for the catalog objects under special catalogs. (also, added support for columns under it). Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=5347bdb886ca321bfb36d6b7662e70af5af3ef52 Author: Murtuza Zabuawala

[pgadmin-hackers] pgAdmin 4 commit: Fixup some SQL formatting, per Khushboo

Fixup some SQL formatting, per Khushboo Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=b7f6df34abf0fdf189f68ef60ace31c027587866 Modified Files -- .../templates/languages/sql/9.1_plus/acl.sql | 36 +++---

[pgadmin-hackers] pgAdmin 4 commit: Fix gettext calls per Khushboo

Fix gettext calls per Khushboo Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=ce5d7b7d60f0e04c9298d0f841ec9406e2dfc891 Modified Files -- .../servers/tablespaces/templates/tablespaces/js/tablespaces.js | 4 ++-- 1 file

[pgadmin-hackers] pgAdmin 4 commit: Variables should have their own tab on dialogues.

Variables should have their own tab on dialogues. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=649b719845a0d3468352953a5173d67d36feee95 Modified Files -- .../server_groups/servers/databases/templates/databases/js/databases.js |

[pgadmin-hackers] pgAdmin 4 commit: Fix all manner of inconsistencies in object propertie

Fix all manner of inconsistencies in object properties display: - Don't display the OID on Edit dialogues - Use the ACL summary display in the properties panel, not the subnode editor. - s/Oid/OID/g - Ensure all security properties are displayed in the Security group - Ensure all object

[pgadmin-hackers] pgAdmin 4 commit: Show the ACL summary on the properties panel for data

Show the ACL summary on the properties panel for databases. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=62537429d1ed530a5fe2f10e1ff7720ea9052cb7 Modified Files -- .../servers/databases/templates/databases/js/databases.js

[pgadmin-hackers] pgAdmin 4 commit: Fix various inconsistencies with databases and tables

Fix various inconsistencies with databases and tablespaces: - Display the ACL string in properties, not the subnode panel. - Offer default values for the owner of new objects. - Add missing context menu option to create a tablespace from a server node. Branch -- master Details ---

[pgadmin-hackers] pgAdmin 4 commit: Add some default connection parameters.

Add some default connection parameters. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=f95b9f06ca9d30f52ee7513705cf20e2fe779576 Modified Files -- web/pgadmin/browser/server_groups/servers/__init__.py| 9 +++--

[pgadmin-hackers] pgAdmin 4 commit: Make the dialogue control sizing slightly more compac

Make the dialogue control sizing slightly more compact and properly control textarea resizing. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=17ed27fbcde339566387948f1999d86f51e17d8e Author: Arun Kollan

Re: [pgadmin-hackers] Patch sequence node [pgadmin4]

Thanks - committed with the following changes: - SQL template formatting improvements - Don't display the ACL subnode panel on the Properties list, instead display the text ACL. - Preset defaults for the owner and schema when creating a new sequence. On Thu, Mar 10, 2016 at 2:05 PM, Harshal

[pgadmin-hackers] pgAdmin 4 commit: Add support for Sequences.

Add support for Sequences. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=def1a30251cb9ec95ed5cb4c5951f20f626a825d Author: Harshal Dhumal Modified Files --

Re: [pgadmin-hackers] Patch sequence node [pgadmin4]

Hi, PFA update patch for sequence node. Changes: Fixed leaf node issue. -- *Harshal Dhumal* *Software Engineer * EenterpriseDB On Thu, Mar 10, 2016 at 12:45 PM, Harshal Dhumal < harshal.dhu...@enterprisedb.com> wrote: > Hi, > > PFA updated patch for

Re: [pgadmin-hackers] Event trigges node patch [pgadmin4]

Thanks - applied with the following changes: - Added owner and enabled status to properties list - Display a list of trigger name, owner and comment when the collection node is selected. - Treat Event Triggers as a leaf node. Please be mindful of these issues with any future patches. Thanks

[pgadmin-hackers] pgAdmin 4 commit: Add support for Event Triggers.

Add support for Event Triggers. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=986375d60e45f2e73c625342cc1a0fd024dece3e Author: Harshal Dhumal Modified Files --

Re: [pgadmin-hackers] [pgAdmin4][Patch]: Foreign Data Wrapper

Hi On Thu, Mar 10, 2016 at 7:33 AM, Neel Patel wrote: > Hi Dave, > > Thank you for the reviewing the patch. > Please find inline comments and attached updated patch file after fixing all > the comments. > > Do let us know in case of any comments. > > Thanks, > Neel

Re: [pgadmin-hackers] [pgAdmin4][Patch]: Disable/Enable Edit Button: Sub-node Collection

Thanks, applied. On Thu, Mar 10, 2016 at 5:51 AM, Khushboo Vashi wrote: > Hi, > > Please find attached patch to disable/enable the Edit button of a sub-node > collection grid. > > Thanks, > Khushboo > > > -- > Sent via pgadmin-hackers mailing list

[pgadmin-hackers] pgAdmin 4 commit: Allow enabling/disabling of the Edit button of a sub-

Allow enabling/disabling of the Edit button of a sub-node collection grid. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=3b03c17f2bd4eed070cf29c641e7315b5a8a5954 Author: Khushboo Vashi Modified Files

[pgadmin-hackers] pgAdmin 4 commit: Updated Privileges macros under Schema node.

Updated Privileges macros under Schema node. The changes are required due to previous commit (8a7ec6b45221f042bc39c9bce2c577e12b43cc3a) regarding "parse_priv_to_db" function. Branch -- master Details ---

Re: [pgadmin-hackers] [pgAdmin4][Patch]: Updated Privileges macros under Schema

Thanks, applied. On Thu, Mar 10, 2016 at 6:27 AM, Khushboo Vashi wrote: > Hi, > > Please find attached patch for the updated Privileges macros under Schema > node. > > The changes are required due to previous commit > (8a7ec6b45221f042bc39c9bce2c577e12b43cc3a)

Re: [pgadmin-hackers] [pgAdmin4] [Patch]: Grant Wizard

On Thu, Mar 10, 2016 at 9:50 AM, Surinder Kumar wrote: > Please apply Khusboo's patch for "Privileges macros under Schema" before > using grant wizard patch. Thanks, that works. Some (hopefully final) feedback: - Can we add a side-image? Not sure what yet - just

Re: [pgadmin-hackers] [pgAdmin4] [Patch]: Grant Wizard

Please apply Khusboo's patch for "Privileges macros under Schema" before using grant wizard patch. On Thu, Mar 10, 2016 at 2:52 PM, Surinder Kumar < surinder.ku...@enterprisedb.com> wrote: > Hi, > > PFA patch after rebasing. > > On Wed, Mar 9, 2016 at 11:04 PM, Dave Page

[pgadmin-hackers] pgAdmin 4 commit: Resolved typos in SQL templates for PPAS

Resolved typos in SQL templates for PPAS Thanks Khushboo Vashi for reporting. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=77ae220f1e85ca7809793db2d342bc3165d82b13 Modified Files --

Re: [pgadmin-hackers] [pgAdmin4] [Patch]: Grant Wizard

Hi, PFA patch after rebasing. On Wed, Mar 9, 2016 at 11:04 PM, Dave Page wrote: > Sorry Surinder - can you rebase this please? I think it was broken by > 8a7ec6b45221f042bc39c9bce2c577e12b43cc3a :-( > How much work would it be to enable it to work at database level as