[pgadmin-hackers] pgAdmin 4 commit: Default owner for new event triggers.

Default owner for new event triggers. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=fd05dec29c2e169ba9cb369902511fda8023b402 Modified Files -- .../templates/event_triggers/js/event_trigger.js| 13 + 1 file

Re: [pgadmin-hackers] PATCH: Added Node Type & Catalog objects [pgAdmin4]

On Tue, Mar 8, 2016 at 1:38 PM, Murtuza Zabuawala wrote: > Hi, > > PFA patch to add new nodes in pgAdmin4. > 1) Type node > 2) Catalog objects > > Note: Both above nodes depended on schema/catalog node, Please apply them > after latest patch of schema/catalog

Re: [pgadmin-hackers] [pgAdmin4][Patch]: Foreign Data Wrapper

OK, I'll add --binary next time. Not sure why I didn't think of that... Thanks. On Fri, Mar 11, 2016 at 2:10 PM, Ashesh Vashi wrote: > git diff --cached --binary > > -- > > Thanks & Regards, > > Ashesh Vashi > EnterpriseDB INDIA: Enterprise PostgreSQL Company >

Re: [pgadmin-hackers] [pgAdmin4][Patch]: Foreign Data Wrapper

git diff --cached --binary -- Thanks & Regards, Ashesh Vashi EnterpriseDB INDIA: Enterprise PostgreSQL Company *http://www.linkedin.com/in/asheshvashi* On Fri, Mar 11, 2016 at 7:39 PM, Dave Page wrote:

Re: [pgadmin-hackers] [pgAdmin4][Patch]: Foreign Data Wrapper

Hmm... So how are you creating patches? The first one I did was by adding everything I needed with "git add", then doing "git diff --cached". The second one I did "git add -N" for the new files, then did a regular "git diff". On Fri, Mar 11, 2016 at 1:33 PM, Neel Patel

Re: [pgadmin-hackers] PATCH: Collation node [pgAdmin4]

Thanks - patch applied. On Tue, Mar 8, 2016 at 1:40 PM, Murtuza Zabuawala wrote: > Hi Dave, > > PFA updated patch for collation node. > > Regards, > Murtuza > > -- > Regards, > Murtuza Zabuawala > EnterpriseDB: http://www.enterprisedb.com > The Enterprise

[pgadmin-hackers] pgAdmin 4 commit: Add support for collations.

Add support for collations. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=b6f72024482b0ece6fd42534f51a477fdd26a8d9 Author: Murtuza Zabuawala Modified Files --

Re: [pgadmin-hackers] [pgAdmin4][Patch]: Foreign Data Wrapper

Hi Dave, New patch file gives another kind of error. Attached is the error log file for the reference. Anyway, I will use first patch file by giving command "patch -p1 " which is working and manually copy the image files. Thanks, Neel Patel On Fri, Mar 11, 2016 at 6:51 PM, Dave Page

Re: [pgadmin-hackers] [pgAdmin4][Patch]: Foreign Data Wrapper

Huh, weird. The quick fix is this: patch -p1 < ~/foreign_data_wrapper_v5-dave.patch >From the top of the source tree. On Fri, Mar 11, 2016 at 12:52 PM, Neel Patel wrote: > Hi Dave, > > I am not able to apply the attached patch file. I am getting the below > error.

Re: [pgadmin-hackers] PIP Package Building for pgAdmin4

EBROKENPATCH (pgadmin4)piranha:pgAdmin4 dpage$ git apply ~/Downloads/pgadmin4_pip_framework_v5.patch /Users/dpage/Downloads/pgadmin4_pip_framework_v5.patch:41: trailing whitespace. python pkg/pip/setup_pip.py bdist_wheel /Users/dpage/Downloads/pgadmin4_pip_framework_v5.patch:45: trailing

Re: [pgadmin-hackers] [pgAdmin4][Patch]: Foreign Data Wrapper

Hi Dave, I am not able to apply the attached patch file. I am getting the below error. If possible, Can you please send correct the patch file so that i can fix the comments on top of your patch. ## (pgAdmin4_3_4)neel@ubuntu:~/Projects/pgAdmin4/pgadmin4$ git apply

Re: [pgadmin-hackers] PIP Package Building for pgAdmin4

PFA the updated patch. On Wed, Mar 9, 2016 at 10:25 PM, Dave Page wrote: > Hi > > On Wed, Mar 9, 2016 at 2:24 PM, Muhammad Aqeel > wrote: > > Hi, > > > > PFA the patch to build PIP package for pgAdmin4 web component. It builds > PIP > > wheel

[pgadmin-hackers] pgAdmin 4 commit: Fix a number of minor issues with catalog objects:

Fix a number of minor issues with catalog objects: - Remove unnecessary columns from collection property lists. - Standardise property names and groupings. - pg_attribute doesn't have an OID column, so use attnum instead (of atttypid!?!) Branch -- master Details ---

[pgadmin-hackers] pgAdmin 4 commit: Fix cast SQL formatting.

Fix cast SQL formatting. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=470881ac461a0f6d986bf40a629faece8127a6ff Modified Files -- .../servers/databases/casts/templates/cast/sql/9.1_plus/sql.sql | 2 +- 1 file changed, 1

[pgadmin-hackers] pgAdmin 4 commit: Fix a couple of issues with the unique-collection co

Fix a couple of issues with the unique-collection control: - Pass the data to evaluation functions like canEdit, canAdd - Properly honour the canAdd option. Branch -- master Details ---

Re: [pgadmin-hackers] [pgAdmin4][Patch]: Unique Collection Control and Variable Control Fixes

Thanks, applied. On Fri, Mar 11, 2016 at 9:16 AM, Khushboo Vashi wrote: > Hi, > > The current implementation of the unique-collection control does not pass > the control data to the evaluation function like canAdd, canEdit etc., so > that has been fixed. > >

Re: [pgadmin-hackers] PATCH: Fixed Textarea control template [pgAdmin4]

Thanks, committed. On Fri, Mar 11, 2016 at 8:29 AM, Murtuza Zabuawala wrote: > Hi, > > PFA updated patch for mentioned issue. > > > > -- > Regards, > Murtuza Zabuawala > EnterpriseDB: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > > On Fri,

[pgadmin-hackers] pgAdmin 4 commit: Fix default height for text areas.

Fix default height for text areas. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=d21e60cc60aae80cb984ee94de5855747fe27fc9 Modified Files -- web/pgadmin/static/js/backform.pgadmin.js | 5 +++-- 1 file changed, 3 insertions(+), 2

[pgadmin-hackers] [pgAdmin4][Patch]: Unique Collection Control and Variable Control Fixes

Hi, The current implementation of the unique-collection control does not pass the control data to the evaluation function like canAdd, canEdit etc., so that has been fixed. Also, the current implementation of the variable control does not honour the canAdd option settings, which has been fixed.

Re: [pgadmin-hackers] PATCH: Updated acl parsing on tablespace node [pgAdmin4]

Thanks, applied. On Tue, Mar 8, 2016 at 2:02 PM, Murtuza Zabuawala wrote: > Hi, > > PFA updated patch to update acl parsing with new changes. > Removed hardcoded string and passed acl list instead. > > > -- > Regards, > Murtuza Zabuawala > EnterpriseDB:

[pgadmin-hackers] pgAdmin 4 commit: Update ACL parsing for tablespaces to use newer infra

Update ACL parsing for tablespaces to use newer infrastructure. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=b747a5b5ebb40a52b84bdd2094286828f383d404 Author: Murtuza Zabuawala Modified Files

Re: [pgadmin-hackers] PATCH: Fixed Textarea control template [pgAdmin4]

Hi, I have sent updated patch to include default rows arguments into sql field control. Regards, Murtuza -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Fri, Mar 11, 2016 at 2:03 PM, Ashesh Vashi

Re: [pgadmin-hackers] PATCH: Fixed Textarea control template [pgAdmin4]

On Fri, Mar 11, 2016 at 1:59 PM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi, > > PFA updated patch for mentioned issue. > Can please you describe, why did you sent the updated path, what was missing in the previous patch? -- Thanks & Regards, Ashesh Vashi EnterpriseDB

Re: [pgadmin-hackers] PATCH: Fixed Textarea control template [pgAdmin4]

Hi, PFA updated patch for mentioned issue. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Fri, Mar 11, 2016 at 1:08 PM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi, > > PFA updated patch to fix an issue in