Re: [pgadmin-hackers] Control for selecting multiple columns [pgadmin4]

2016-03-15 Thread Dave Page
It seems to be missing the test dialogue? On Tue, Mar 15, 2016 at 8:47 AM, Harshal Dhumal < harshal.dhu...@enterprisedb.com> wrote: > Hi, > > PFA generalized updated patch for backform multiSelectControl. > > -- > *Harshal Dhumal* > *Software Engineer * > > > > EenterpriseDB

Re: [pgadmin-hackers] depends.js and sql.js

2016-03-15 Thread Dave Page
On Tue, Mar 15, 2016 at 4:01 PM, Ashesh Vashi wrote: > On Tue, Mar 15, 2016 at 9:22 PM, Dave Page wrote: > >> Hi Ashesh, >> >> Any reason the above files are in static directories? Both have >> strings in them that should be translated. >> >

Re: [pgadmin-hackers] depends.js and sql.js

2016-03-15 Thread Ashesh Vashi
On Tue, Mar 15, 2016 at 9:22 PM, Dave Page wrote: > Hi Ashesh, > > Any reason the above files are in static directories? Both have > strings in them that should be translated. > When it was implemented initially, I was not in mood to keep the translation message in individual

Re: [pgadmin-hackers] pgAdmin 4 commit: Resolved an issue related to no proper valid/invalid

2016-03-15 Thread Ashesh Vashi
On Tue, Mar 15, 2016 at 8:32 PM, Dave Page wrote: > It looks like this has broken the schema properties dialog. On opening > it, I now get: > > Uncaught TypeError: Cannot read property 'server' of > >

[pgadmin-hackers] depends.js and sql.js

2016-03-15 Thread Dave Page
Hi Ashesh, Any reason the above files are in static directories? Both have strings in them that should be translated. FYI, I'm not overly sure what needs to be done to move them these days - I haven't looked into the require code at all. Thanks. -- Dave Page Blog: http://pgsnake.blogspot.com

[pgadmin-hackers] pgAdmin 4 commit: Do not rely on the individual model (instead use the

2016-03-15 Thread Ashesh Vashi
Do not rely on the individual model (instead use the first level 'top' model) to fetch the node_info, because - when loading the data in the collection, it may not initialize all the parameters. Branch -- master Details ---

[pgadmin-hackers] pgAdmin 4 commit: Improve message display.

2016-03-15 Thread Dave Page
Improve message display. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=62bd1a21cc926049fa7c8c2e4ad464e487ff3c27 Modified Files -- web/pgadmin/browser/templates/browser/js/browser.js | 6 +++---

[pgadmin-hackers] pgAdmin 4 commit: Fix security label sizing.

2016-03-15 Thread Dave Page
Fix security label sizing. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=c81469832871a8837225e12cecc8bcb349350637 Author: Arun Kollan Modified Files --

Re: [pgadmin-hackers] pgAdmin 4 commit: Resolved an issue related to no proper valid/invalid

2016-03-15 Thread Dave Page
It looks like this has broken the schema properties dialog. On opening it, I now get: Uncaught TypeError: Cannot read property 'server' of undefinedpgNode.PrivilegeRoleModel.pgNode.Model.extend.schema.cell.Backgrid.Extension.NodeListByNameCell.extend.omit_selected_roles @

Re: [pgadmin-hackers] Fixed issue related to 'show_system_objects' in dependencies/dependents

2016-03-15 Thread Dave Page
Thanks, committed. On Mon, Mar 14, 2016 at 10:56 AM, Akshay Joshi < akshay.jo...@enterprisedb.com> wrote: > Hi All > > As 'show_system_objects' has been implemented, I have fixed an issue for > dependencies/dependents. With previous implementation each node will have > to send the values of

[pgadmin-hackers] pgAdmin 4 commit: As 'show_system_objects' has been implemented, I have

2016-03-15 Thread Dave Page
As 'show_system_objects' has been implemented, I have fixed an issue for dependencies/dependents. With previous implementation each node will have to send the values of 'show_system_objects' while calling get_dependencies/get_dependents function. Now I have changed the logic to use the value

[pgadmin-hackers] pgAdmin 4 commit: Reduce column header letter spacing a touch.

2016-03-15 Thread Dave Page
Reduce column header letter spacing a touch. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=2711d3492d955bfccc8f1c8b9392a91c67aae429 Modified Files -- web/pgadmin/static/css/overrides.css | 5 - 1 file changed, 4 insertions(+),

[pgadmin-hackers] pgAdmin 4 commit: Resolved an issue related to no proper valid/invalid

2016-03-15 Thread Ashesh Vashi
Resolved an issue related to no proper valid/invalid event was generated for the privilege control. Also, made changes in the PrivilegeRoleModel, to allow to select a grantee only once for the current user (as grantor), and omit them from other cell objects. Valid/Invalid event was not properly

[pgadmin-hackers] pgAdmin 4 commit: Improvements in the form/properties dialog control ge

2016-03-15 Thread Ashesh Vashi
Improvements in the form/properties dialog control generation, and data change events. - In input & textarea control, call the change event on key up (but - not on every key up events, wait for sometime before trigger that event, so that - we do not overdo that). - In unique/subnode control,

Re: [pgadmin-hackers] [pgAdmin4][psycopg2] - poll function local variable reference error

2016-03-15 Thread Dave Page
Thanks, applied. On Tue, Mar 15, 2016 at 11:44 AM, Neel Patel wrote: > Hi, > > During the debugger implementation, we came to know that "poll()" function > is getting failed when the status is not equal to "ASYNC_OK". We are getting > the below error at python side.

[pgadmin-hackers] pgAdmin 4 commit: Fix a bug in the database drive poll() function where

2016-03-15 Thread Dave Page
Fix a bug in the database drive poll() function where we could try to reference a non-existant variable. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=ff424850f803850a99f1b9eae3300a94e5fc685b Author: Neel Patel

[pgadmin-hackers] pgAdmin 4 commit: Subnode collection layout improvements, with addition

2016-03-15 Thread Dave Page
Subnode collection layout improvements, with additional tweaks from me. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=cdd7a1f6371f3837ed5447bfaf240e90eeba80a8 Author: Arun Kollan Modified Files --

Re: [pgadmin-hackers] PIP Package Building for pgAdmin4

2016-03-15 Thread Dave Page
Hi On Tue, Mar 15, 2016 at 6:23 AM, Muhammad Aqeel wrote: > Hi Dave, > > On Mon, Mar 14, 2016 at 7:06 PM, Dave Page wrote: >> >> Hi >> >> On Mon, Mar 14, 2016 at 1:46 PM, Muhammad Aqeel >> wrote: >> > Hi Dave,

[pgadmin-hackers] pgAdmin 4 commit: Fix PIP packaging code so it works nicely on Linux an

2016-03-15 Thread Dave Page
Fix PIP packaging code so it works nicely on Linux and Mac. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=b1d26db8d9f478d1a52327287c8f02739ba200a1 Author: Muhammad Aqeel Modified Files --

[pgadmin-hackers] [pgAdmin4][psycopg2] - poll function local variable reference error

2016-03-15 Thread Neel Patel
Hi, During the debugger implementation, we came to know that "poll()" function is getting failed when the status is not equal to "ASYNC_OK". We are getting the below error at python side. "UnboundLocalError: local variable 'colinfo' referenced before assignment" Attached is the patch that

Re: [pgadmin-hackers] Adding to Documentation

2016-03-15 Thread Dave Page
Hi On Tue, Mar 15, 2016 at 7:36 AM, Lev Lazinskiy wrote: > Hi Team! > > My name is Lev. I am a long time PostgreSQL user but just switched to > pgadminIII when I switched to Ubuntu full time from OS X. My background > is in testing, general GNU/Linux sys admin, databases, and

[pgadmin-hackers] Primary key constraint [pgadmin4]

2016-03-15 Thread Harshal Dhumal
Hi PFA patch for primary key constraint. Note: This patch has dependency on Table, Column node and backform multiselect control. -- *Harshal Dhumal* *Software Engineer * EenterpriseDB diff --git

Re: [pgadmin-hackers] Control for selecting multiple columns [pgadmin4]

2016-03-15 Thread Harshal Dhumal
Hi, PFA generalized updated patch for backform multiSelectControl. -- *Harshal Dhumal* *Software Engineer * EenterpriseDB On Tue, Mar 8, 2016 at 1:04 PM, Harshal Dhumal < harshal.dhu...@enterprisedb.com> wrote: > Hi, > > PFA backform control for selecting

[pgadmin-hackers] Adding to Documentation

2016-03-15 Thread Lev Lazinskiy
Hi Team! My name is Lev. I am a long time PostgreSQL user but just switched to pgadminIII when I switched to Ubuntu full time from OS X. My background is in testing, general GNU/Linux sys admin, databases, and python. I know some C and C++ and would love to contribute more to this project. I