Re: [pgadmin-hackers] Control for displaying "auto vacuum" fields into grid

2016-03-23 Thread Surinder Kumar
Hi, On Fri, Mar 18, 2016 at 8:58 PM, Dave Page wrote: > On Fri, Mar 18, 2016 at 10:37 AM, Surinder Kumar > wrote: > > Hi, > > > > PFA control for displaying auto vacuum fields into grid. This control is > > common for > > Materialized View

[pgadmin-hackers] pgAdmin 4 commit: String improvements.

2016-03-23 Thread Dave Page
String improvements. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=2a2374329efb07a9a4532f4c719c0704e8c3037c Modified Files -- web/pgadmin/browser/templates/browser/js/node.js | 8 1 file changed, 4 insertions(+), 4

[pgadmin-hackers] pgAdmin 4 commit: String improvements.

2016-03-23 Thread Dave Page
String improvements. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=72f635356175ac94cdcc0e4c122a16629df06f5f Modified Files -- web/pgadmin/browser/templates/browser/js/browser.js | 10 +- 1 file changed, 5 insertions(+), 5

[pgadmin-hackers] [pgAdmin4] PATCH: Added Utility functions for triggers node and rules node

2016-03-23 Thread Surinder Kumar
Hi, Trigger and Rules nodes have functions which are also used by view node. View node use them while generating reverse engineering SQL for respective nodes. so they are moved into schema/utils.py Please review the patch. Thanks, Surinder Kumar

Re: [pgadmin-hackers] [pgAdmin4][Patch]: Functions/Procedures Module

2016-03-23 Thread Khushboo Vashi
Hi Dave, I think you forgot to attach the updated patch. Thanks, Khushboo On Wed, Mar 23, 2016 at 5:33 PM, Dave Page wrote: > On Tue, Mar 22, 2016 at 10:51 AM, Khushboo Vashi > wrote: > > Hi, > > > > Please find updated Patch for the

Re: [pgadmin-hackers] pgAdmin4 PATCH: Domain Module

2016-03-23 Thread Dave Page
Hi Almost there :-s - The hint for default should be a placeholder in the textbox itself (like combos have "Select from the list" - I should be able to check the "Validate?" option on one or more constraints from within the Domain dialogue - Please ensure the capitalisation of all property

Re: [pgadmin-hackers] [pgAdmin4][Patch]: Functions/Procedures Module

2016-03-23 Thread Dave Page
On Tue, Mar 22, 2016 at 10:51 AM, Khushboo Vashi wrote: > Hi, > > Please find updated Patch for the Functions/Procedures Module. Hi Unfortunately I found more issues as I tested in-depth. I've attached an updated patch in which I've done some cleanup -

[pgadmin-hackers] pgAdmin 4 commit: We have defaults for switch display now, so no need t

2016-03-23 Thread Dave Page
We have defaults for switch display now, so no need to set the options explicitly. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=1ac16cbc0ff66d2387b139779a71189d98959eea Modified Files --

[pgadmin-hackers] pgAdmin 4 commit: Don't display packages as schemas.

2016-03-23 Thread Dave Page
Don't display packages as schemas. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=258c7f3589f3a62a81552ab492af9a9dae40d6f4 Modified Files -- .../databases/schemas/templates/schema/ppas/9.1_plus/sql/nodes.sql | 1 +

Re: [pgadmin-hackers] PATCH: To fix an issue in server node refresh [pgAdmin4]

2016-03-23 Thread Ashesh Vashi
On Wed, Mar 23, 2016 at 4:46 PM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi, > > PFA minor patch to fix an issue which was causing not to collapse & > refresh server node status when we disconnect from server. > > Steps to reproduce the issue (with latest pull): > > Step

[pgadmin-hackers] pgAdmin 4 commit: Fixed the refresh issue when a server gets disconnect

2016-03-23 Thread Ashesh Vashi
Fixed the refresh issue when a server gets disconnected. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=0e044e121685aa9362f3a508522fda255a3ff5a5 Author: Murtuza Zabuawala Modified Files --

[pgadmin-hackers] PATCH: To fix an issue in server node refresh [pgAdmin4]

2016-03-23 Thread Murtuza Zabuawala
Hi, PFA minor patch to fix an issue which was causing not to collapse & refresh server node status when we disconnect from server. Steps to reproduce the issue (with latest pull): Step -1) Connect to server-1 Step -2) Expand the server till schema/collation node Step -3) Now directly go to

[pgadmin-hackers] pgAdmin 4 commit: Set appropriate default values for the boolean switch

2016-03-23 Thread Dave Page
Set appropriate default values for the boolean switch control. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=a6e96c55767a870f4114d4eee92113dbca9648d6 Modified Files -- web/pgadmin/static/js/backform.pgadmin.js | 6 +++--- 1 file

Re: [pgadmin-hackers] pgAdmin4 PATCH: Domain Module

2016-03-23 Thread Ashesh Vashi
On Wed, Mar 23, 2016 at 3:09 PM, Dave Page wrote: > Did you forget to attach the latest patch? > She did it in the previous patch only. She forgot to mention about the help string, which she did in later mail. -- Thanks & Regards, Ashesh Vashi EnterpriseDB INDIA: Enterprise

Re: [pgadmin-hackers] pgAdmin4 PATCH: Domain Module

2016-03-23 Thread Dave Page
Did you forget to attach the latest patch? On Wed, Mar 23, 2016 at 7:27 AM, Khushboo Vashi wrote: > Updated one comment. > > On Wed, Mar 23, 2016 at 12:48 PM, Khushboo Vashi > wrote: >> >> Hi, >> >> Please find attached updated

Re: [pgadmin-hackers] Server side session management using the SQLite (per session) database

2016-03-23 Thread Magnus Hagander
On Wed, Mar 23, 2016 at 10:15 AM, Dave Page wrote: > On Wed, Mar 23, 2016 at 9:04 AM, Magnus Hagander > wrote: > > > > > > On Tue, Mar 22, 2016 at 4:11 PM, Dave Page wrote: > >> > >> Hi > >> > >> On Thu, Mar 17, 2016 at 5:46 PM, Ashesh

Re: [pgadmin-hackers] Server side session management using the SQLite (per session) database

2016-03-23 Thread Dave Page
On Wed, Mar 23, 2016 at 9:04 AM, Magnus Hagander wrote: > > > On Tue, Mar 22, 2016 at 4:11 PM, Dave Page wrote: >> >> Hi >> >> On Thu, Mar 17, 2016 at 5:46 PM, Ashesh Vashi >> wrote: >>> >>> Hi Dave/team, >>> >>> As

Re: [pgadmin-hackers] Server side session management using the SQLite (per session) database

2016-03-23 Thread Ashesh Vashi
On Wed, Mar 23, 2016 at 2:34 PM, Magnus Hagander wrote: > > > On Tue, Mar 22, 2016 at 4:11 PM, Dave Page wrote: > >> Hi >> >> On Thu, Mar 17, 2016 at 5:46 PM, Ashesh Vashi < >> ashesh.va...@enterprisedb.com> wrote: >> >>> Hi Dave/team, >>> >>> As

Re: [pgadmin-hackers] Server side session management using the SQLite (per session) database

2016-03-23 Thread Magnus Hagander
On Tue, Mar 22, 2016 at 4:11 PM, Dave Page wrote: > Hi > > On Thu, Mar 17, 2016 at 5:46 PM, Ashesh Vashi < > ashesh.va...@enterprisedb.com> wrote: > >> Hi Dave/team, >> >> As discussed, I have implemented the server side session management using >> the SQLite database. >> >>

Re: [pgadmin-hackers] Server side session management using the SQLite (per session) database

2016-03-23 Thread Dave Page
On Wed, Mar 23, 2016 at 7:32 AM, Ashesh Vashi wrote: > On Tue, Mar 22, 2016 at 8:41 PM, Dave Page wrote: > >> Hi >> >> On Thu, Mar 17, 2016 at 5:46 PM, Ashesh Vashi < >> ashesh.va...@enterprisedb.com> wrote: >> >>> Hi Dave/team, >>> >>> As

Re: [pgadmin-hackers] Server side session management using the SQLite (per session) database

2016-03-23 Thread Ashesh Vashi
On Wed, Mar 23, 2016 at 2:04 PM, Neel Patel wrote: > Hi, > > I just tested the latest code under windows environment with python 2.7 > which is working fine without any errors. > Thanks. -- Thanks & Regards, Ashesh Vashi EnterpriseDB INDIA: Enterprise PostgreSQL

Re: [pgadmin-hackers] Server side session management using the SQLite (per session) database

2016-03-23 Thread Neel Patel
Hi, I just tested the latest code under windows environment with python 2.7 which is working fine without any errors. Thanks, Neel Patel On Wed, Mar 23, 2016 at 1:02 PM, Ashesh Vashi wrote: > On Tue, Mar 22, 2016 at 8:41 PM, Dave Page wrote:

Re: [pgadmin-hackers] Server side session management using the SQLite (per session) database

2016-03-23 Thread Ashesh Vashi
On Tue, Mar 22, 2016 at 8:41 PM, Dave Page wrote: > Hi > > On Thu, Mar 17, 2016 at 5:46 PM, Ashesh Vashi < > ashesh.va...@enterprisedb.com> wrote: > >> Hi Dave/team, >> >> As discussed, I have implemented the server side session management using >> the SQLite database. >> >>

Re: [pgadmin-hackers] pgAdmin4 PATCH: Domain Module

2016-03-23 Thread Khushboo Vashi
Updated one comment. On Wed, Mar 23, 2016 at 12:48 PM, Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > Hi, > > Please find attached updated patch for the Domains module. > > On Wed, Mar 16, 2016 at 9:40 PM, Dave Page wrote: > >> Hi >> >> On Wed, Mar 16, 2016 at

Re: [pgadmin-hackers] Disabled option to bootstrap switch control [pgadmin4]

2016-03-23 Thread Ashesh Vashi
On Wed, Mar 23, 2016 at 12:26 PM, Harshal Dhumal < harshal.dhu...@enterprisedb.com> wrote: > Hi, > > PFA minor patch for switch control. > > > Change: Added disabled option to bootstrap switch control. > Committed with small change. Also - modified the SubnodeControl to use the similar evaluation

[pgadmin-hackers] pgAdmin 4 commit: Evaluate the disabled option in SwitchControl.

2016-03-23 Thread Ashesh Vashi
Evaluate the disabled option in SwitchControl. Also - for consistency reason use the same evaluation logic in each of the control. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=219f208317650b5322eb0fa66951c596c4ab7f74 Author: Harshal Dhumal

[pgadmin-hackers] pgAdmin 4 commit: [Python 3] Fixed the issue loading the value for the

2016-03-23 Thread Ashesh Vashi
[Python 3] Fixed the issue loading the value for the session key from the sqlite. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=12a0cb1ba1720ecd6c42d519bd9bc7215147504e Author: Murtuza Zabuawala Modified

[pgadmin-hackers] Disabled option to bootstrap switch control [pgadmin4]

2016-03-23 Thread Harshal Dhumal
Hi, PFA minor patch for switch control. Change: Added disabled option to bootstrap switch control. -- *Harshal Dhumal* *Software Engineer * EenterpriseDB diff --git a/web/pgadmin/static/js/backform.pgadmin.js b/web/pgadmin/static/js/backform.pgadmin.js index

[pgadmin-hackers] PATCH: To fix session decoding issue with Python3 [pgAdmin4]

2016-03-23 Thread Murtuza Zabuawala
Hi, PFA patch to fix session key decoding issue with Python3 version. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company fixed_session_decoding_issue_py3.patch Description: Binary data -- Sent via pgadmin-hackers mailing list