Re: [pgadmin-hackers] [PATCH] Tables node (pgAdmin4)

2016-04-28 Thread Harshal Dhumal
-- *Harshal Dhumal* *Software Engineer * EenterpriseDB On Thu, Apr 28, 2016 at 2:22 PM, Dave Page wrote: > > > > On 27 Apr 2016, at 13:43, Thom Brown wrote: > > > > On 27 April 2016 at 10:22, Harshal Dhumal > >

[pgadmin-hackers][pgAdmin4][Patch]: Remove default extraclass from the SqlFieldControl

2016-04-28 Thread Surinder Kumar
Hi, The *SqlFieldControl* is setting default height for textarea, which is not needed. It should expand as needed as similar in *SqlTabControl*. Please find the attached patch, review it. Thanks Surinder Kumar remove_default_height_in_SqlFieldControl.patch Description: Binary data -- Sent

Re: [pgadmin-hackers][pgAdmin4][Patch]: File Manager & Backform FileControl

2016-04-28 Thread Neel Patel
Hi Surinder, Please find additional comments as below. 1. In Windows OS, when we try to open the dialog with default preference value then it gives error as below. 2016-04-28 13:07:44,716: ERROR pgadmin:Exception on /file_manager/filemanager/2530270/ [POST] Traceback (most recent call

Re: [pgadmin-hackers] [PATCH] Tables node (pgAdmin4)

2016-04-28 Thread Dave Page
> On 27 Apr 2016, at 13:43, Thom Brown wrote: > > On 27 April 2016 at 10:22, Harshal Dhumal > wrote: >> >> Hi, >> >> PFA attached patches for table node and all table child nodes. >> >> This patch includes below nodes, >> >> 1) Table node

Re: [pgadmin-hackers] [PATCH] Tables node (pgAdmin4)

2016-04-28 Thread Thom Brown
On 27 April 2016 at 14:34, Thom Brown wrote: > On 27 April 2016 at 13:43, Thom Brown wrote: >> On 27 April 2016 at 10:22, Harshal Dhumal >> wrote: >>> >>> Hi, >>> >>> PFA attached patches for table node and all table child nodes.

Re: [pgadmin-hackers] PATCH: Added Note Backform control (pgAdmin4).

2016-04-28 Thread Ashesh Vashi
Checked-in with some more twicks (resolved a typo in my modified patch). -- Thanks & Regards, Ashesh Vashi EnterpriseDB INDIA: Enterprise PostgreSQL Company *http://www.linkedin.com/in/asheshvashi* On Thu, Apr 28, 2016 at

[pgadmin-hackers] pgAdmin 4 commit: Added a new control for rendering the notes to be use

2016-04-28 Thread Ashesh Vashi
Added a new control for rendering the notes to be used by different tools/utitilities dialog. Modified a little bit by Ashesh Vashi. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=dac514a4ae340e4042fa5a1f57540afad8bb8d97 Author: Murtuza

Re: [pgadmin-hackers] PATCH: Added Note Backform control (pgAdmin4).

2016-04-28 Thread Ashesh Vashi
I've update the patch a little bit. Please test it at your end. -- Thanks & Regards, Ashesh Vashi EnterpriseDB INDIA: Enterprise PostgreSQL Company *http://www.linkedin.com/in/asheshvashi* On Wed, Apr 27, 2016 at 6:19 PM,