[pgadmin-hackers] [pgAdmin4][Patch]: RM#1184 - Re-docking on the main tabset is broken

Hi, Please find attached patch for mentioned issue: *Issue*: Re-docking on the main tabset is broken *Explanation*: We were missing 'moveable' property. It should be set to false while creating new Browser panel. By default it is true for all registered panels. I think both browser and dashboard

Re: [pgadmin-hackers] User management functionality patch [pgadmin4]

Hi, PFA attached patch (V5) for user management functionality. Note: If you've applied any of the previous patch of this functionality then set ConfigDB value to 10 in version table of and also delete role 'Standard' from role table before applying this patch. On Fri, Jun 3, 2016 at 4:39 PM,

Re: [pgadmin-hackers] PATCH: pgAdmin4 windows installer

Hello Dave. There was problem with the Make.bat file ^M characters which is been removed. Issues are fixed along with some code and README tidied On Fri, Jun 3, 2016 at 9:59 PM, Dave Page wrote: > Hi > > On Fri, Jun 3, 2016 at 2:45 PM, Paresh More

[pgadmin-hackers] [pgAdmin4][Patch]: RM#1256 - Add support for Query tool in the context menu

Hi, Please find attached patch for RM#1256 Explanation: 1) Add support for query tool in context menu for nodes and collections. 2) Added '*unsupported_node'* object of *datagrid* as *pgAdmin* object because it is used in node js and collection js as well. I set the menu priority as 3, please

Re: [pgadmin-hackers] PATCH: pgAdmin4 windows installer

Hi On Fri, Jun 3, 2016 at 2:45 PM, Paresh More wrote: > Hello Dave > > Attached is the updated patch for pgAdmin 4 windows > > - Windows x86 and amd64 check is added, so now on 32 machine if amd64 is > selected it would not allow to generate installer. > - check is

Re: [pgadmin-hackers] Patch for pgAdmin4 RPM package

My point is that the runtime uses the platform supplied Python interpreter, which presumably knows where to search for packages. Mind you, I suppose the issue there is that it wouldn't be able to distinguish between v1 and v2 then... I don't have a major issue with your suggested code - I just

Re: [pgadmin-hackers] Patch for pgAdmin4 RPM package

Do you mean to say when a python app is launched, it imports some modules automatically and in that sense it knows about where it's site-packages are? May be, but how the pgAdmin4 runtime will know where the Web App is installed? The changes that I have done to the runtime is to let it know the

[pgadmin-hackers] PATCH: TO fix issue in Role node (pgAdmin4)

Hi, PFA patch to fix an issue while creating role if user has set expire date. Current implements works only if datestyle is set to ISO,MDY in database for others it fails. (RM#1134) Additionally I've fixed unwanted space indentation issue in Database node. Please review. -- Regards, Murtuza

Re: [pgadmin-hackers] Patch for pgAdmin4 RPM package

Hi, Well, I have to wonder why we need the changes to the runtime? We're linking the runtime with the same build of Python that's already on the system - doesn't it know where it's site-packages are already? I could see us needing this is we were using a distro-independent build of Python and

[pgadmin-hackers] pgAdmin 4 commit: Fix mouse cursor on dashboard quick links. Fixes #116

Fix mouse cursor on dashboard quick links. Fixes #1163 Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=4398d1d8694024b3f357e74fba4683d5f3cd5745 Modified Files -- web/pgadmin/dashboard/static/css/dashboard.css | 4 1 file

Re: [pgadmin-hackers] User management functionality patch [pgadmin4]

On Fri, Jun 3, 2016 at 11:37 AM, Ashesh Vashi wrote: > Hi Harshal, > > Dave asked to put the User Management menu under the 'Change Password' > (right top side). > Correct - that way it won't be displayed in desktop mode. Other comments: - If I type an email

Re: [pgadmin-hackers] Backgrid passwordCell [pgadmin4]

Thanks - committed! -- Thanks & Regards, Ashesh Vashi EnterpriseDB INDIA: Enterprise PostgreSQL Company *http://www.linkedin.com/in/asheshvashi* On Wed, Jun 1, 2016 at 3:15 PM, Harshal Dhumal <

[pgadmin-hackers] pgAdmin 4 commit: Removing wrongly overridden CSS on the Select2 arrow,

Removing wrongly overridden CSS on the Select2 arrow, and selection__rendered. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=129ca8793793f8a8556a5a3c3940444b0ec0dd2e Modified Files -- web/pgadmin/static/css/pgadmin.css | 6 --

[pgadmin-hackers] pgAdmin 4 commit: Added support for the password cell.

Added support for the password cell. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=5eef63c0683ea6e5b248d53a6d5c8de16d9fa5f6 Author: Harshal Dhumal Modified Files --

Re: [pgadmin-hackers] User management functionality patch [pgadmin4]

Hi Harshal, Dave asked to put the User Management menu under the 'Change Password' (right top side). -- Thanks & Regards, Ashesh Vashi EnterpriseDB INDIA: Enterprise PostgreSQL Company *http://www.linkedin.com/in/asheshvashi*

[pgadmin-hackers] Destroy header controls properly [pgadmin4]

Hi, PFA patch for tokes control in fts configuration and variable control. Issue fixed : Destroy header controls properly. -- *Harshal Dhumal* *Software Engineer* EnterpriseDB India: http://www.enterprisedb.com The Enterprise PostgreSQL Company diff --git

Re: [pgadmin-hackers] PATCH: To fix the issue in type node (pgAdmin4)

Thanks - committed! -- Thanks & Regards, Ashesh Vashi EnterpriseDB INDIA: Enterprise PostgreSQL Company *http://www.linkedin.com/in/asheshvashi* On Thu, Jun 2, 2016 at 4:03 PM, Murtuza Zabuawala <

[pgadmin-hackers] pgAdmin 4 commit: Fixes #1273 - Resolved an issue setting privileges on

Fixes #1273 - Resolved an issue setting privileges on the SHELL type. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=6dbfb7db7e10bbab4c83e88d8f5e31cc2b2b40ef Author: Murtuza Zabuawala Modified Files

[pgadmin-hackers] pgAdmin 4 commit: Fixes #1280 - Resolved issue in json encoding while d

Fixes #1280 - Resolved issue in json encoding while dealing with the date format. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=6501f4cf362a26cc28ba0bf4f1160aaeb6889111 Author: Murtuza Zabuawala Modified

Re: [pgadmin-hackers] PATCH: Fix the issue in JSON decoding (pgAdmin4)

At the moment - I have committed the code, but - I think, we should rely on some external utility to make it work better with date, timestamp, etc. Please take a look at this mail-chain. https://www.postgresql.org/message-id/87mvnauugi.fsf%40metapensiero.it -- Thanks & Regards, Ashesh Vashi

[pgadmin-hackers] pgAdmin 4 commit: Let's make it Beta 1

Let's make it Beta 1 Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=fc654a09341dba5bb4ee649a5a7a4a7c9fc34ff4 Modified Files -- web/config.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- Sent via pgadmin-hackers

Re: [pgadmin-hackers] PATCH: To fix issue in table node (pgAdmin4)

I've committed both the patches. Please check the commit-id: 9c8637cf0fe0686580447662302e6e6d831c2c2a. -- Thanks & Regards, Ashesh Vashi EnterpriseDB INDIA: Enterprise PostgreSQL Company *http://www.linkedin.com/in/asheshvashi*

[pgadmin-hackers] pgAdmin 4 commit: Change package status

Change package status Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=b15383e93d1a54c78f6602f4c6242ccff1182162 Modified Files -- pkg/pip/setup_pip.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- Sent via

Re: [pgadmin-hackers] PATCH: To fix minor patches (pgAdmin4)

On Fri, Jun 3, 2016 at 3:42 PM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi Ashesh, > > It is difficult to handle in each template with various options user can > choose from, > > We try to handle as much as possible space indentation in templates itself > but still we got

[pgadmin-hackers] pgAdmin 4 commit: Corrected the z-index of backgrid-filter so that - it

Corrected the z-index of backgrid-filter so that - it does not take precedence over top panel. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=9c8637cf0fe0686580447662302e6e6d831c2c2a Author: Murtuza Zabuawala

Re: [pgadmin-hackers] PATCH: To fix issue in table node (pgAdmin4)

Thanks - committed! -- Thanks & Regards, Ashesh Vashi EnterpriseDB INDIA: Enterprise PostgreSQL Company *http://www.linkedin.com/in/asheshvashi* On Fri, Jun 3, 2016 at 3:34 PM, Murtuza Zabuawala <

[pgadmin-hackers] pgAdmin 4 commit: Fixes #1300 - Honour show system object in the table

Fixes #1300 - Honour show system object in the table dialog, and do not show catalog schema tables. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=c14ff8e15e1959ae8ad315d3c37429db502515dd Author: Murtuza Zabuawala

Re: [pgadmin-hackers] PATCH: Fixed issue in Index node (pgAdmin4)

Thanks - committed! -- Thanks & Regards, Ashesh Vashi EnterpriseDB INDIA: Enterprise PostgreSQL Company *http://www.linkedin.com/in/asheshvashi* On Thu, Jun 2, 2016 at 5:35 PM, Murtuza Zabuawala <

[pgadmin-hackers] pgAdmin 4 commit: Fixes #1283, #1287 - Do not show null description in

Fixes #1283, #1287 - Do not show null description in the create mode, corrected the index expression on table node. Reported by Thom Brown. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=6036c431b0ab714e2aabaa649c389fbfcbd69173 Author:

[pgadmin-hackers] pgAdmin 4 commit: Fixes #1303 Query with Order by clause is not working

Fixes #1303 Query with Order by clause is not working in Query Tool Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=967159664e617a04d86d62ed7652600d42822536 Modified Files --

[pgadmin-hackers] pgAdmin 4 commit: Fixes #1285 - Update the comments (description) over

Fixes #1285 - Update the comments (description) over the tablespace properly. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=8b54b59f2becae0a307b6953e74a92a5bc2741b5 Author: Murtuza Zabuawala Modified

[pgadmin-hackers] PATCH: To fix issue in table node (pgAdmin4)

Hi, PFA patch to fix an issue in table node where, in relation combobox it was displaying pg_catalog/system tables by default so we added show system object condition in sql. (RM#1300) Additionally, I have included patch to fix an issue where due to high Backgrid's search icon z-index [on

Re: [pgadmin-hackers] PATCH: To fix minor patches (pgAdmin4)

On Thu, Jun 2, 2016 at 6:11 PM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi, > > PFA updated patch for RM#1234. > Please do not tweak the '\n' off the output, but - fix the issue from the template itself. -- Thanks & Regards, Ashesh Vashi EnterpriseDB INDIA: Enterprise

[pgadmin-hackers] pgAdmin 4 commit: Fixes #1223 - Do not allow to drop user from non-supe

Fixes #1223 - Do not allow to drop user from non-super user. Also - fixed some javascript variable scope issue in the 'delete_obj' function of nodes. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=94365420740500743f2f43bda4efe928b7d8c831

Re: [pgadmin-hackers] PATCH: To fix the issue in Role node (pgAdmin4)

Thanks - committed! -- Thanks & Regards, Ashesh Vashi EnterpriseDB INDIA: Enterprise PostgreSQL Company *http://www.linkedin.com/in/asheshvashi* On Thu, Jun 2, 2016 at 7:17 PM, Murtuza Zabuawala <

Re: [pgadmin-hackers] PATCH: Fix issue in Query tool not showing correct output (pgAdmin4)

Thanks - Committed On Thu, Jun 2, 2016 at 3:46 PM, Ashesh Vashi wrote: > Akshay, > > Can you please review it? > > -- > > Thanks & Regards, > > Ashesh Vashi > EnterpriseDB INDIA: Enterprise PostgreSQL Company > > > >

[pgadmin-hackers] pgAdmin 4 commit: Fixes #1275 Issue with Query tool for PPAS - not show

Fixes #1275 Issue with Query tool for PPAS - not showing the correct output Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=1bd37d1f76f23982ffb9f009863f7600f2a9 Author: Murtuza Zabuawala Modified Files

[pgadmin-hackers] Re: [pgAdmin4][Patch]: RM#1293 - SQL pane is not displaying GRANT queries in Function, Procedure and Trigger node

Hi, Please find attached patch for: 1. RM#1293 - SQL pane is not displaying GRANT queries in functions node 2. RM#1294 - Comments are not visible in sql pane for trigger functions and functions Explanation: Previously we we using 'get_defintion.sql' template to generate SQL for SQL pane for

[pgadmin-hackers] pgAdmin 4 commit: Tarball build target and script

Tarball build target and script Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=a989840460880e319aaffd17d86ec6fff985cd16 Modified Files -- .gitignore | 1 + Makefile | 17 ++--- pkg/src/build.sh | 74

Re: [pgadmin-hackers] fix for RM1210 [pgadmin4]

On Fri, Jun 3, 2016 at 1:13 PM, Harshal Dhumal < harshal.dhu...@enterprisedb.com> wrote: > Hi Ashesh, > > I have used 'ajax_response' utility function (alias to make_response > pdadmin utility function) which has mime-type set to "text/json" which is > correct I guess in this case. > > Also I

[pgadmin-hackers] pgAdmin 4 commit: Fixes# 1210 - Send the columns SQL with proper mime t

Fixes# 1210 - Send the columns SQL with proper mime type. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=ab9f63d96038cfd7f30c45ddfc9ee412f3988f36 Author: Harshal Dhumal Modified Files --

Re: [pgadmin-hackers] PATCH: To fix the issue in Sequence node (pgAdmin4)

Thanks - committed! -- Thanks & Regards, Ashesh Vashi EnterpriseDB INDIA: Enterprise PostgreSQL Company *http://www.linkedin.com/in/asheshvashi* On Fri, Jun 3, 2016 at 1:20 PM, Murtuza Zabuawala <

[pgadmin-hackers] pgAdmin 4 commit: Fixes #1298 - ACL for the SEQUENCE node were not pars

Fixes #1298 - ACL for the SEQUENCE node were not parsed properly. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=40ab0b7c883484ccd8200abe07d0a168ffd516ea Author: Murtuza Zabuawala Modified Files

Re: [pgadmin-hackers] Evaluate Sellect2 cell options properly [pgadmin4]

Thanks - committed! -- Thanks & Regards, Ashesh Vashi EnterpriseDB INDIA: Enterprise PostgreSQL Company *http://www.linkedin.com/in/asheshvashi* On Fri, Jun 3, 2016 at 3:17 PM, Harshal Dhumal <

[pgadmin-hackers] pgAdmin 4 commit: Proper evaluation of the optionsValues in the Backgri

Proper evaluation of the optionsValues in the Backgrid Select2Cell. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=dea4b8ca31ecc92215065899329dac118cad5b39 Author: Harshal Dhumal Modified Files --

[pgadmin-hackers] Evaluate Sellect2 cell options properly [pgadmin4]

Hi, There are two ways we can provide options for select2 cell either by extending select2 cell with "optionValues" array or by passing "options" (function or array) in column definition. Generally, if we are passing "optionValues" to select2 cell then we should not look for "options" in column

Re: [pgadmin-hackers] Patch for pgAdmin4 RPM package

Hi Dave, how about changes in the pgadmin4 source code for conf.py and Server.cpp? Looks okay? On Fri, Jun 3, 2016 at 2:41 PM, Sandeep Thakkar < sandeep.thak...@enterprisedb.com> wrote: > Thanks Dave. > > On Fri, Jun 3, 2016 at 2:08 PM, Dave Page wrote: > >> Hi >> >> On Thu,

Re: [pgadmin-hackers] Patch for pgAdmin4 RPM package

Thanks Dave. On Fri, Jun 3, 2016 at 2:08 PM, Dave Page wrote: > Hi > > On Thu, Jun 2, 2016 at 4:23 PM, Sandeep Thakkar > wrote: > > Hi Devrim, Hi Dave, > > > > I have updated the patch. The earlier patch may fail because of app > bundle > >

Re: [pgadmin-hackers] Patch for pgAdmin4 RPM package

Hi On Thu, Jun 2, 2016 at 4:23 PM, Sandeep Thakkar wrote: > Hi Devrim, Hi Dave, > > I have updated the patch. The earlier patch may fail because of app bundle > commit in git. > > For testing, you may define the source tarball location as : > Source0: >

Re: [pgadmin-hackers] PATCH: To fix expanding server if server inaccessible (pgAdmin4)

Thanks - pushed. On Thu, Jun 2, 2016 at 3:35 PM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi Dave/Ashesh, > > Please find patch for the dashboard issue, Please review it. > > I tried with both config options "threaded=True" & "threaded=False", In > both cases this fix

[pgadmin-hackers] pgAdmin 4 commit: Resolve threading issue in the dashboards.

Resolve threading issue in the dashboards. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=c3e2f5f2127fa7c0745c38fd3031a8e652005ca7 Author: Murtuza Zabuawala Modified Files --

[pgadmin-hackers] PATCH: To fix the issue in Sequence node (pgAdmin4)

Hi, PFA patch to fix the issue in Sequence node where it was not displaying ACL properly in SQL panel. RM#1298 -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company RM_1298.patch Description: Binary data -- Sent via pgadmin-hackers mailing

Re: [pgadmin-hackers] fix for RM1210 [pgadmin4]

Hi Ashesh, I have used 'ajax_response' utility function (alias to make_response pdadmin utility function) which has mime-type set to "text/json" which is correct I guess in this case. Also I have check all other node to check if all of them are using correct function while returning sql. --

Re: [pgadmin-hackers] fix for RM1210 [pgadmin4]

On Fri, Jun 3, 2016 at 12:59 PM, Harshal Dhumal < harshal.dhu...@enterprisedb.com> wrote: > Hi, > > Issue: For column node it was showing wrong sql in sql tab > > -- Column: public.test_qmg.a -- ALTER TABLE > public.test_qmg DROP COLUMN a; ALTER TABLE public.test_qmg ADD COLUMN a > integer; > >

Re: [pgadmin-hackers] fix for RM1210 [pgadmin4]

Hi, Issue: For column node it was showing wrong sql in sql tab -- Column: public.test_qmg.a -- ALTER TABLE public.test_qmg DROP COLUMN a; ALTER TABLE public.test_qmg ADD COLUMN a integer; Fix: I have changed response to ajax response while returning SQL for column node. -- *Harshal

Re: [pgadmin-hackers] fix for RM1210 [pgadmin4]

Hi Harshal, Can you please describe the issue, and root cause, and how did you fix it? -- Thanks & Regards, Ashesh Vashi EnterpriseDB INDIA: Enterprise PostgreSQL Company *http://www.linkedin.com/in/asheshvashi* On Fri,

[pgadmin-hackers] fix for RM1210 [pgadmin4]

Hi, PFA patch for RM1210 -- *Harshal Dhumal* *Software Engineer* EnterpriseDB India: http://www.enterprisedb.com The Enterprise PostgreSQL Company diff --git a/web/pgadmin/browser/server_groups/servers/databases/schemas/tables/column/__init__.py