Re: [pgadmin-hackers] Patch for pgAdmin4 RPM package

Hi On Tue, Jun 7, 2016 at 8:02 AM, Sandeep Thakkar < sandeep.thak...@enterprisedb.com> wrote: > Hi Dave > > I used few APIs from Importing Modules and Modules Objects to import the > pgAdmin4 module and then get it's location but the application crashed on > running. I didn't debug it and

Re: [pgadmin-hackers] pgadmin4: Server does not launch

On Wed, Jun 8, 2016 at 5:44 PM, Colin Beckingham wrote: > > > On 08/06/16 12:22, Dave Page wrote: >> >> On Wed, Jun 8, 2016 at 5:03 PM, Colin Beckingham >> wrote: >>> >>> Right, forced an upgrade via pip2 and it overwrote the existing psycopg2. >>> In

[pgadmin-hackers] [pgAdmin4][Patch]: RM#1324 - Grant wizard does not show privileges option again if Click on Back button on Privileges page

Hi, Please find attached patch. This issue was regression of *commit id: 47d7e24bb91f22da3b55c941f515ce76248f2cc6* shouldn't have return statement in view object because it is called by render of wizard object class to render the page in wizard. Please review. Thanks, Surinder Kumar

[pgadmin-hackers] [pgAdmin4[Patch]: RM#1319 - Unable to select sql file through query tool on windows operating system

Hi, Please find attached patch with fixes: 1) Unable to select sql file through query tool on windows OS. In file_manager.js, we are stripping initial slash '/' from the path obtained. but we should not strip if it is full path like 'c:/path/to/dir/filename.ext' 2) Handle directory path if

Re: [pgadmin-hackers] PATCH: Reset view/layout (pgAdmin4)

Hi, PFA updated patch, I have shifted it to File menu. Please review. Regards, Murtuza -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Wed, Jun 8, 2016 at 5:19 PM, Dave Page wrote: > Hi > > On Wed, Jun 8, 2016 at

[pgadmin-hackers] Email validation in setup.py [pgadmin4]

Hi, PFA patch for email validation in setup.py -- *Harshal Dhumal* *Software Engineer* EnterpriseDB India: http://www.enterprisedb.com The Enterprise PostgreSQL Company diff --git a/web/setup.py b/web/setup.py index 4ea28e1..5f13e83 100644 --- a/web/setup.py +++ b/web/setup.py @@ -15,6 +15,7

Re: [pgadmin-hackers] PATCH: TO fix issue in Role node (pgAdmin4)

Hi, Apologies, It was partial patch, missed JS side changes in last patch. Please review updated patch. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Wed, Jun 8, 2016 at 5:35 PM, Dave Page wrote: > On Fri, Jun

[pgadmin-hackers] Removed unwanted empty_value form Select2 template [pgadmin4]

Hi, PFA patch for select2 control in exclusion constraint. Fixed template render issue. -- *Harshal Dhumal* *Software Engineer* EnterpriseDB India: http://www.enterprisedb.com The Enterprise PostgreSQL Company diff --git

[pgadmin-hackers] PAtch for RM 1107 [pgadmin4]

Hi, PAF patch for RM1107 Issue fixed: *1]* Removed alter.sql and merged sql statement from alter.sql with create sql wherever possible so that objects can be create in single statement to ensure that whole operation is atomic. *Code merged for below nodes:* Schema, Table, all constraints.