Re: [pgadmin-hackers] Qt runtime issue on python 3 + patch

2016-06-14 Thread Surinder Kumar
On Wed, Jun 15, 2016 at 10:46 AM, Ashesh Vashi < ashesh.va...@enterprisedb.com> wrote: > Hi Surinder, > > On Sat, Jun 11, 2016 at 11:08 PM, Dave Page wrote: > >> Hi >> >> On Sat, Jun 11, 2016 at 2:17 PM, Asser Schrøder Femø >> wrote: >> > Hello pgadmin

Re: [pgadmin-hackers] Qt runtime issue on python 3 + patch

2016-06-14 Thread Ashesh Vashi
Hi Surinder, On Sat, Jun 11, 2016 at 11:08 PM, Dave Page wrote: > Hi > > On Sat, Jun 11, 2016 at 2:17 PM, Asser Schrøder Femø > wrote: > > Hello pgadmin hackers, > > > > I checked out the newly released beta and wanted to see how easy it > would be > >

Re: [pgadmin-hackers] pgAdmin 4 commit: Fix query tool horizontal scrolling of results. Fixes

2016-06-14 Thread Surinder Kumar
OK, I will fix it. On Wed, Jun 15, 2016 at 10:41 AM, Ashesh Vashi < ashesh.va...@enterprisedb.com> wrote: > On Tue, Jun 14, 2016 at 8:21 PM, Dave Page wrote: > >> Fix query tool horizontal scrolling of results. Fixes #1362 >> >> The backgrid-sizeable's css property 'overflow:

Re: [pgadmin-hackers] pgAdmin 4 commit: Fix query tool horizontal scrolling of results. Fixes

2016-06-14 Thread Ashesh Vashi
On Tue, Jun 14, 2016 at 8:21 PM, Dave Page wrote: > Fix query tool horizontal scrolling of results. Fixes #1362 > > The backgrid-sizeable's css property 'overflow: hidden' was overriding > backgrid table css property and It was reproducible only in runtime. > Removed

Re: [pgadmin-hackers] Fix for issue RM1313 [pgadmin4]

2016-06-14 Thread Dave Page
On Tue, Jun 14, 2016 at 5:28 PM, Dave Page wrote: > Thanks - committed with some minor changes: > > - Move the password field under the user name. > > - Remove the password requirement. The user might be using "trust" auth. > > - Adjust the vertical positioning of the checkbox.

Re: [pgadmin-hackers] Fix for issue RM1313 [pgadmin4]

2016-06-14 Thread Dave Page
Thanks - committed with some minor changes: - Move the password field under the user name. - Remove the password requirement. The user might be using "trust" auth. - Adjust the vertical positioning of the checkbox. On Tue, Jun 14, 2016 at 2:18 PM, Harshal Dhumal

[pgadmin-hackers] pgAdmin 4 commit: Added connect now option in server create dialog. Fix

2016-06-14 Thread Dave Page
Added connect now option in server create dialog. Fixes #1313 Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=6b95d6ac75449a1c2f9877a48bc4003ad1ac5dfc Author: Harshal Dhumal Modified Files --

Re: [pgadmin-hackers] [pgAdmin4][Patch]: RM#1352 - Problem displaying intervals and timestamps with pgAdmin 4

2016-06-14 Thread Dave Page
Thanks, patch applied. On Tue, Jun 14, 2016 at 8:55 AM, Surinder Kumar wrote: > Hi, > > Please find the patch with issues fixed: > > 1) No handling for INTERVAL type datetime. > For example: executing query > SELECT INTERVAL '15 minutes'; > throws json

[pgadmin-hackers] pgAdmin 4 commit: Resolve problem displaying intervals and timestamps.

2016-06-14 Thread Dave Page
Resolve problem displaying intervals and timestamps. Fixes #1352 1) No handling for INTERVAL type datetime. For example: executing query SELECT INTERVAL '15 minutes'; throws json serialization error, because it returns time in timedelta format which is not handled. Added support to handle

Re: [pgadmin-hackers] PATCH: To have validation messages on status panel only (pgAdmin4)

2016-06-14 Thread Dave Page
This seems to have been committed inadvertently as part of another patch. Thanks though :-) On Tue, Jun 14, 2016 at 8:53 AM, Murtuza Zabuawala wrote: > Hi, > > PFA patch to fix the issue mentioned in RM#1281, We have removed error > messages from standard

Re: [pgadmin-hackers] [pgAdmin4][Patch]: RM#1362 - Query Tool: Can't View All Columns

2016-06-14 Thread Dave Page
Thanks, applied. On Tue, Jun 14, 2016 at 11:50 AM, Surinder Kumar wrote: > Hi, > > Please find attached patch for RM#1362: > The backgrid-sizeable's css property 'overflow: hidden' was overriding > backgrid table css property and It was reproducible only in

[pgadmin-hackers] pgAdmin 4 commit: Fix query tool horizontal scrolling of results. Fixes

2016-06-14 Thread Dave Page
Fix query tool horizontal scrolling of results. Fixes #1362 The backgrid-sizeable's css property 'overflow: hidden' was overriding backgrid table css property and It was reproducible only in runtime. Removed 'overflow: hidden' property from backgrid-sizeabled-columns.css Branch -- master

Re: [pgadmin-hackers] Fix for issue RM1348 [pgadmin4]

2016-06-14 Thread Dave Page
Thanks, applied. On Mon, Jun 13, 2016 at 7:37 PM, Harshal Dhumal wrote: > Hi, > > PFA patch for issue RM1348. > > Issue fixed: Not to show multiple 'Reset Layout' options under file menu. > Also restructured code related to reset layout functionality. > > -- >

[pgadmin-hackers] pgAdmin 4 commit: Avoid showing multiple 'Reset Layout' options under f

2016-06-14 Thread Dave Page
Avoid showing multiple 'Reset Layout' options under file menu. Fixes #1348 Also restructured code related to reset layout functionality. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=b0b21fd46c08ce01cf3859aaa8908b5f7f73d3ad Author: Harshal

[pgadmin-hackers] Re: [pgadmin-hackers] PATCH: To add "Move objects..” functionality in tablespace (pgAdmin4)

2016-06-14 Thread Dave Page
Hi On Mon, Jun 13, 2016 at 9:38 AM, Murtuza Zabuawala wrote: > Hi, > > PFA patch to add "Move objects..” functionality in tablespace node. > (RM#1286) > > Additionally I have removed pre_9.1 sql's & align SQL line indentation as > well. Committed with some

[pgadmin-hackers] pgAdmin 4 commit: Add "Move objects..” functionality to tablespace no

2016-06-14 Thread Dave Page
Add "Move objects..” functionality to tablespace node. Fixes #1286 Additionally I have removed pre_9.1 sql's & align SQL line indentation as well. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=62c136993870e987df21ee14b7cffc9db0f07751 Author:

[pgadmin-hackers] integration of minimap in graphical explain feature

2016-06-14 Thread Sanket Mehta
Hi, PFA the patch for integration of minimap in graphical explain. It will show minimap on left top corner of graphical explain. Regards, Sanket Mehta Sr Software engineer Enterprisedb diff --git a/web/pgadmin/misc/__init__.py b/web/pgadmin/misc/__init__.py index 2081822..6b307e3 100644 ---

[pgadmin-hackers] Fix for issue RM1313 [pgadmin4]

2016-06-14 Thread Harshal Dhumal
Hi, PFA patch for issue RM 1313. Changes: Added connect now option in server create dialog. -- *Harshal Dhumal* *Software Engineer* EnterpriseDB India: http://www.enterprisedb.com The Enterprise PostgreSQL Company diff --git a/web/pgadmin/browser/server_groups/servers/__init__.py

Re: [pgadmin-hackers] Fix for RM1318 [pgadmin4]

2016-06-14 Thread Dave Page
Thanks, applied. On Mon, Jun 13, 2016 at 7:20 PM, Harshal Dhumal wrote: > Hi, > > PFA patch for issue RM1318 with remaining bug fixes. > > > On Mon, Jun 13, 2016 at 8:49 PM, Dave Page wrote: >> >> On Mon, Jun 13, 2016 at 7:25 AM, Harshal

[pgadmin-hackers] pgAdmin 4 commit: Preferences and user management help button fixes. Fi

2016-06-14 Thread Dave Page
Preferences and user management help button fixes. Fixes #1318 Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=93706ee40b6fe260c1dca36033faffd93a3c176d Author: Harshal Dhumal Modified Files --

Re: [pgadmin-hackers] PATCH: To fixed the issue in server node (pgAdmin4)

2016-06-14 Thread Dave Page
Thanks, applied. On Mon, Jun 13, 2016 at 11:29 AM, Murtuza Zabuawala wrote: > Hi, > > PFA minor patch to fix the issue for RM#1144. > > > -- > Regards, > Murtuza Zabuawala > EnterpriseDB: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > > > --

[pgadmin-hackers] pgAdmin 4 commit: Fix SSL mode selection. Fixes #1144

2016-06-14 Thread Dave Page
Fix SSL mode selection. Fixes #1144 Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=fe1c86cbbe74ff9d4742568b816365e89373e78c Author: Murtuza Zabuawala Modified Files --

[pgadmin-hackers] pgAdmin 4 commit: Tell the user where the app server is running.

2016-06-14 Thread Dave Page
Tell the user where the app server is running. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=0f12defd2043684128ffa28f982031e2f449da30 Modified Files -- web/pgAdmin4.py | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-)

[pgadmin-hackers] [pgAdmin4][Patch]: RM#1362 - Query Tool: Can't View All Columns

2016-06-14 Thread Surinder Kumar
Hi, Please find attached patch for *RM#1362*: The *backgrid-sizeable's* css property '*overflow: hidden*' was overriding backgrid table css property and It was reproducible only in runtime. Removed 'overflow: hidden' property from backgrid-sizeabled-columns.css Thanks Neel & Akshay for sorting

Re: [pgadmin-hackers] Patch for pgAdmin 4 docs

2016-06-14 Thread Dave Page
Hi On Tue, Jun 14, 2016 at 10:16 AM, Susan Douglas wrote: > Hi All, > > I think this patch should complete the first pass through the project - > please let me know if you find dialogs that are missing documentation, and > share any feedback on the docs.

[pgadmin-hackers] pgAdmin 4 commit: More doc updates.

2016-06-14 Thread Dave Page
More doc updates. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=d87a6a15ac93a713c716017477d82a047a84cc0f Author: Susan Douglas Modified Files -- docs/en_US/debugger.rst| 102

Re: [pgadmin-hackers] pgadmin4 slow with large tables compared to pgadmin3

2016-06-14 Thread Dave Page
Hi 2016-06-14 8:17 GMT+01:00 Akshay Joshi : > Hi Dave > > 2016-06-13 21:47 GMT+05:30 Dave Page : >> >> On Mon, Jun 13, 2016 at 5:01 PM, Colin Beckingham >> wrote: >> > I have the latest fully patched pgadmin4. Runs fine on

Re: [pgadmin-hackers] PATCH: Added Statistics functionality for many nodes (pgAdmin4)

2016-06-14 Thread Murtuza Zabuawala
Hi Dave, I copied pgAdmin3 behaviour, I’ll implement it in pgAdmin4 :) Thanks, Murtuza > On 13-Jun-2016, at 5:51 pm, Dave Page wrote: > > On Mon, Jun 13, 2016 at 12:29 PM, Murtuza Zabuawala > wrote: >> The strange effects that leads to.

[pgadmin-hackers] [pgAdmin4][Patch]: RM#1352 - Problem displaying intervals and timestamps with pgAdmin 4

2016-06-14 Thread Surinder Kumar
Hi, Please find the patch with issues fixed: 1) No handling for INTERVAL type datetime. For example: executing query *SELECT INTERVAL '15 minutes';* throws json serialization error, because it returns time in timedelta format which is not handled. Added support to handle *timedelta* datetime

[pgadmin-hackers] PATCH: To have validation messages on status panel only (pgAdmin4)

2016-06-14 Thread Murtuza Zabuawala
Hi, PFA patch to fix the issue mentioned in RM#1281, We have removed error messages from standard Backform control rather display validation error messages only on status panel. Please review. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL