Re: [pgadmin-hackers] Patch for pgAdmin 4 docs

Thanks - applied with a couple of minor changes: - Added a line to index.html to explain that the user options only apply in server mode. - Added a line to the user management page to explain the difference between user and administrator roles. On Wed, Jun 15, 2016 at 7:38 PM, Susan Douglas

[pgadmin-hackers] pgAdmin 4 commit: Doc updates for user management and tablespace move o

Doc updates for user management and tablespace move objects. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=7c45d54d948f5aad1325ad7866e4c795834bcaf5 Author: Susan Douglas Modified Files --

[pgadmin-hackers] pgAdmin 4 commit: Support distro-specific configs, and include docs in

Support distro-specific configs, and include docs in the PIP wheel. A distro can now install a config_distro.py file alongside config.py in which distro-specific configuration settings can be set, overriding those in config.py. User settings in config_local.py will override all other settings.

[pgadmin-hackers] pgAdmin 4 commit: Overhaul the PIP build system so it's less messy on d

Overhaul the PIP build system so it's less messy on disk during builds, and avoids packaging unnecessary files. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=29fbbb581f3551c43eeabeb9d57835f90e7650a0 Modified Files -- .gitignore

Re: [pgadmin-hackers] Fixed RM #1356

Hi Please ignore the last patch. Attached is the latest patch. Please review it. On Wed, Jun 15, 2016 at 9:10 PM, Akshay Joshi wrote: > Hi > > On Wed, Jun 15, 2016 at 5:54 PM, Dave Page wrote: > >> >> >> On Wed, Jun 15, 2016 at 1:16 PM,

Re: [pgadmin-hackers] Fixed RM #1356

Hi On Wed, Jun 15, 2016 at 5:54 PM, Dave Page wrote: > > > On Wed, Jun 15, 2016 at 1:16 PM, Ashesh Vashi < > ashesh.va...@enterprisedb.com> wrote: > >> On Wed, Jun 15, 2016 at 5:44 PM, Akshay Joshi < >> akshay.jo...@enterprisedb.com> wrote: >> >>> >>> >>> On Wed, Jun 15, 2016

Re: [pgadmin-hackers] Regarding issue 1241

On Wed, Jun 15, 2016 at 7:24 PM, Dave Page wrote: > > > On Wed, Jun 15, 2016 at 2:08 PM, Ashesh Vashi < > ashesh.va...@enterprisedb.com> wrote: > >> On Wed, Jun 15, 2016 at 6:25 PM, Dave Page wrote: >> >>> On Wed, Jun 15, 2016 at 1:49 PM, Ashesh Vashi >>>

Re: [pgadmin-hackers] Regarding issue 1241

On Wed, Jun 15, 2016 at 2:08 PM, Ashesh Vashi wrote: > On Wed, Jun 15, 2016 at 6:25 PM, Dave Page wrote: > >> On Wed, Jun 15, 2016 at 1:49 PM, Ashesh Vashi >> wrote: >> > On Thu, Jun 2, 2016 at 1:59 PM, Dave Page

Re: [pgadmin-hackers] Regarding issue 1241

On Wed, Jun 15, 2016 at 6:25 PM, Dave Page wrote: > On Wed, Jun 15, 2016 at 1:49 PM, Ashesh Vashi > wrote: > > On Thu, Jun 2, 2016 at 1:59 PM, Dave Page wrote: > >> > >> > >> > >> On Tue, May 31, 2016 at 8:53 PM, Harshal

Re: [pgadmin-hackers] Regarding issue 1241

On Wed, Jun 15, 2016 at 1:49 PM, Ashesh Vashi wrote: > On Thu, Jun 2, 2016 at 1:59 PM, Dave Page wrote: >> >> >> >> On Tue, May 31, 2016 at 8:53 PM, Harshal Dhumal >> wrote: >>> >>> Hi Dave, >>> >>> Regarding

Re: [pgadmin-hackers] Regarding issue 1241

On Thu, Jun 2, 2016 at 1:59 PM, Dave Page wrote: > > > On Tue, May 31, 2016 at 8:53 PM, Harshal Dhumal < > harshal.dhu...@enterprisedb.com> wrote: > >> Hi Dave, >> >> Regarding Issue 1241 : >> >> We have added header section for

Re: [pgadmin-hackers] Fixed RM #1356

On Wed, Jun 15, 2016 at 1:16 PM, Ashesh Vashi wrote: > On Wed, Jun 15, 2016 at 5:44 PM, Akshay Joshi < > akshay.jo...@enterprisedb.com> wrote: > >> >> >> On Wed, Jun 15, 2016 at 5:25 PM, Dave Page wrote: >> >>> Hi >>> >>> On Wed, Jun 15, 2016

[pgadmin-hackers] Re: [pgadmin-hackers] PATCH: To add "Move objects..” functionality in tablespace (pgAdmin4)

Thanks, applies as-is, but please look at the CSS for the SQL tab. There seems to be a small white border around CodeMirror, plus it scrolls vertically a long way without there actually being text overflowing. The above is low priority - please concentrate on higher priority bugs first! On Wed,

[pgadmin-hackers] pgAdmin 4 commit: Add "Move objects..” functionality in tablespace no

Add "Move objects..” functionality in tablespace node. Fixes #1286 Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=d4e5d9c4f479eec8a0f551c505a7a3b361af9e3b Author: Murtuza Zabuawala Modified Files

Re: [pgadmin-hackers] Fixed RM #1356

On Wed, Jun 15, 2016 at 5:44 PM, Akshay Joshi wrote: > > > On Wed, Jun 15, 2016 at 5:25 PM, Dave Page wrote: > >> Hi >> >> On Wed, Jun 15, 2016 at 11:27 AM, Akshay Joshi < >> akshay.jo...@enterprisedb.com> wrote: >> >>> Hi >>> >>> I have fixed

Re: [pgadmin-hackers] Fixed RM #1356

On Wed, Jun 15, 2016 at 5:25 PM, Dave Page wrote: > Hi > > On Wed, Jun 15, 2016 at 11:27 AM, Akshay Joshi < > akshay.jo...@enterprisedb.com> wrote: > >> Hi >> >> I have fixed RM #1356 "Query tool enhancement". I have added the logic to >> preferences which checks the min/max

Re: [pgadmin-hackers] Fixed RM #1356

Hi On Wed, Jun 15, 2016 at 11:27 AM, Akshay Joshi < akshay.jo...@enterprisedb.com> wrote: > Hi > > I have fixed RM #1356 "Query tool enhancement". I have added the logic to > preferences which checks the min/max value before setting it. If value > given by user is less than min value then set it

[pgadmin-hackers] pgAdmin 4 commit: Wording improvements.

Wording improvements. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=0717b40543addd8f6b1b0a6b5415d8bc79233652 Modified Files -- web/pgadmin/browser/templates/browser/js/node.js| 2 +-

[pgadmin-hackers] pgAdmin 4 commit: Fix handling of errors when using "Connect Now?" for

Fix handling of errors when using "Connect Now?" for new servers. Fixes #1313. Also fixes #1363 - display the server group properly in server properties. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=fc40197d3946e570c4064d0477bde84c07068ade

Re: [pgadmin-hackers] Fix for issue RM1313 [pgadmin4]

Thanks, applied with some improvements to the error handling. On Wed, Jun 15, 2016 at 11:15 AM, Harshal Dhumal wrote: > Hi, > > > PFA attached patch for RM1313 updates and RM1363 > > -- > Harshal Dhumal > Software Engineer > > EnterpriseDB India:

[pgadmin-hackers] Re: [pgadmin-hackers] PATCH: To add "Move objects..” functionality in tablespace (pgAdmin4)

Hi, PFA updated patch for comments given over last patch. Regards, Murtuza -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Tue, Jun 14, 2016 at 7:25 PM, Dave Page wrote: > Hi > > On Mon, Jun 13, 2016 at 9:38 AM,

Re: [pgadmin-hackers] pgAdmin 4 commit: Fix query tool horizontal scrolling of results. Fixes

Thanks, applied. On Wed, Jun 15, 2016 at 8:21 AM, Surinder Kumar < surinder.ku...@enterprisedb.com> wrote: > Hi Ashesh, > > I have revert back the changes made in backgrid-sizeable.css and override > the table.backgrid css of resizable in overrides.css. > Please find the patch and review. > > On

[pgadmin-hackers] pgAdmin 4 commit: A more appropriate fix for RM1362 - horizontal scroll

A more appropriate fix for RM1362 - horizontal scrolling of query results. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=0e11f4d082c92ec71e6641639967c1ce22de4f56 Author: Surinder Kumar Modified Files

Re: [pgadmin-hackers] PATCH: Added Statistics functionality for many nodes (pgAdmin4)

Thanks, applied. On Wed, Jun 15, 2016 at 8:06 AM, Murtuza Zabuawala wrote: > Hi, > > PFA patch to add stats on Sequences/Function/Trigger functions collection > nodes. > Please review. > > > Regards, > Murtuza > > -- > Regards, > Murtuza Zabuawala >

[pgadmin-hackers] pgAdmin 4 commit: Add stats on Sequences/Functions/Trigger functions co

Add stats on Sequences/Functions/Trigger functions collection nodes. Fixes #1299 Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=71ec9ef914fce3bd47c25f06b0f59ecf6ab8418a Author: Murtuza Zabuawala Modified

[pgadmin-hackers] Fixed RM #1356

Hi I have fixed RM #1356 "Query tool enhancement". I have added the logic to preferences which checks the min/max value before setting it. If value given by user is less than min value then set it to min value and if value is greater then max value then set it to max value. For "items_per_page"

Re: [pgadmin-hackers] Fix for issue RM1313 [pgadmin4]

Hi, PFA attached patch for RM1313 updates and RM1363 -- *Harshal Dhumal* *Software Engineer* EnterpriseDB India: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Tue, Jun 14, 2016 at 10:40 PM, Dave Page wrote: > On Tue, Jun 14, 2016 at 5:28 PM, Dave Page

Re: [pgadmin-hackers] pgAdmin IV API test cases patch

Thanks a lot Dave. On 15 June 2016 at 14:09, Dave Page wrote: > Hi > > On Thu, Jun 9, 2016 at 1:37 PM, Priyanka Shendge > wrote: > > Hi Dave, > > > > PFA updated patch. I have made changes suggested by you. > > > > Kindly, review and let me

Re: [pgadmin-hackers] pgAdmin IV API test cases patch

Ashesh - can you also look at the patch please (feel free to wait for the update). I want more eyes on this. Thanks. On Wed, Jun 15, 2016 at 9:39 AM, Dave Page wrote: > Hi > > On Thu, Jun 9, 2016 at 1:37 PM, Priyanka Shendge > wrote: >> Hi

Re: [pgadmin-hackers] pgAdmin 4 commit: Fix query tool horizontal scrolling of results. Fixes

Hi Ashesh, I have revert back the changes made in backgrid-sizeable.css and override the table.backgrid css of resizable in overrides.css. Please find the patch and review. On Wed, Jun 15, 2016 at 10:42 AM, Surinder Kumar < surinder.ku...@enterprisedb.com> wrote: > OK, I will fix it. > > On

Re: [pgadmin-hackers] PATCH: Added Statistics functionality for many nodes (pgAdmin4)

Hi, PFA patch to add stats on Sequences/Function/Trigger functions collection nodes. Please review. Regards, Murtuza -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Tue, Jun 14, 2016 at 1:49 PM, Murtuza Zabuawala <