[pgadmin-hackers] pgAdmin 4 commit: Code tidy.

2016-06-21 Thread Dave Page
Code tidy. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=0ee096dbf680862296d9334c87c1b22b4d82a911 Modified Files -- web/pgadmin/tools/datagrid/templates/datagrid/index.html | 14 +++---

[pgadmin-hackers] pgAdmin 4 commit: Code tidy.

2016-06-21 Thread Dave Page
Code tidy. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=8908c5b2d3b02fb371e1b7360c2130aaf899ea12 Modified Files -- web/pgadmin/tools/datagrid/__init__.py | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) -- Sent via

Re: [pgadmin-hackers] [pgAdmin4][runtime]: RM 1186 - Query tool and debugger rendering issue in Linux

2016-06-21 Thread Dave Page
Thanks, applied. On Tue, Jun 21, 2016 at 3:14 PM, Neel Patel wrote: > Hi, > > Issue : - > > Whenever we open any alertify dialog inside the query tool and debugger > panel then panel contents are not visible. Query tool panel display as > blank. > This issue is only

[pgadmin-hackers] pgAdmin 4 commit: Query tool and debugger rendering issue in Linux

2016-06-21 Thread Dave Page
Query tool and debugger rendering issue in Linux Issue : - Whenever we open any alertify dialog inside the query tool and debugger panel then panel contents are not visible. Query tool panel display as blank. This issue is only reproducible in Linux. Solution:- Animations and transitions are

[pgadmin-hackers] [pgAdmin4][runtime]: RM 1186 - Query tool and debugger rendering issue in Linux

2016-06-21 Thread Neel Patel
Hi, *Issue : -* Whenever we open any alertify dialog inside the query tool and debugger panel then panel contents are not visible. Query tool panel display as blank. This issue is only reproducible in Linux. *Solution:-* Animations and transitions are not automatically GPU accelerated and by

[pgadmin-hackers] pgAdmin 4 commit: Remove 'v' from windows installer filename version.

2016-06-21 Thread Dave Page
Remove 'v' from windows installer filename version. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=d45c5c087455ea217cff0522ed7f4117665111fe Modified Files -- Make.bat | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- Sent

[pgadmin-hackers] pgAdmin 4 commit: Code tidy.

2016-06-21 Thread Dave Page
Code tidy. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=7d0fe669cac976a23fcc7b3a4594e36d01ef7548 Modified Files -- web/config.py | 15 +- web/pgadmin/__init__.py|

[pgadmin-hackers] pgAdmin 4 commit: Optimise Python imports.

2016-06-21 Thread Dave Page
Optimise Python imports. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=3026b470e9c8745dd9ff2ef623c8c04456f09e46 Modified Files -- web/config.py | 2 +- web/pgadmin/__init__.py

[pgadmin-hackers] pgAdmin 4 commit: More doc restructuring.

2016-06-21 Thread Dave Page
More doc restructuring. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=4f5eeffd1fe95c4b805f5c59c583c56498469c55 Author: Susan Douglas Modified Files -- docs/en_US/client_features.rst| 22

[pgadmin-hackers] pgAdmin 4 commit: Set the sys path from the runtime as we were doing it

2016-06-21 Thread Ashesh Vashi
Set the sys path from the runtime as we were doing it earlier along with the PYTHONPATH environment variable settings. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=fc34f85aa35bec327828d111aeb71e8559738ebc Modified Files --

[pgadmin-hackers] pgAdmin 4 commit: Fix SELECT Script option for functions. Fixes #1191

2016-06-21 Thread Dave Page
Fix SELECT Script option for functions. Fixes #1191 Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=03d348f7c217f099f190f6b2e2b8855d5cd76f9c Author: Sanket Mehta Modified Files --

[pgadmin-hackers] pgAdmin 4 commit: Revert "Adding proper virtual environment path on win

2016-06-21 Thread Ashesh Vashi
Revert "Adding proper virtual environment path on windows." As per Dave, we are not using 'pgAdmin 4' from the community installer, hence - we should not bother about it. This reverts commit 3484998775eff16c6777654649d91105be6c78cf. Branch -- master Details ---

[pgadmin-hackers] Fwd: [pgAdmin 4 - Bug #1191] proper code "select new_empno();" should displayed in query tool window for function new_empno()

2016-06-21 Thread Sanket Mehta
Hi, I have resolved the issue and patch is attached with this mail. Please do review it and let me know if any changes required. Regards, Sanket Mehta Sr Software engineer Enterprisedb -- Forwarded message -- From: Date: Mon, Jun 13, 2016 at 3:10 PM

[pgadmin-hackers] pgAdmin 4 commit: Fix installer filename.

2016-06-21 Thread Dave Page
Fix installer filename. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=9224ce77b3b7f4bf020a1a01c2735694beb1aa5e Modified Files -- Make.bat | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) -- Sent via pgadmin-hackers

Re: [pgadmin-hackers] pgAdmin 4 commit: Adding proper virtual environment path on windows.

2016-06-21 Thread Dave Page
Umm, this is most definitely not correct. There is no "pgAdmin 4" directory in a Windows installation of pgAdmin. On Tue, Jun 21, 2016 at 12:24 PM, Ashesh Vashi wrote: > Adding proper virtual environment path on windows. > > Branch > -- > master > > Details >

[pgadmin-hackers] pgAdmin 4 commit: Adding proper virtual environment path on windows.

2016-06-21 Thread Ashesh Vashi
Adding proper virtual environment path on windows. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=3484998775eff16c6777654649d91105be6c78cf Modified Files -- runtime/Server.cpp | 12 +++- 1 file changed, 7 insertions(+), 5

[pgadmin-hackers] pgAdmin 4 commit: Bump version for beta 2.

2016-06-21 Thread Dave Page
Bump version for beta 2. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=648eebd230c393477cae0b6349ffae6a9093d2b3 Modified Files -- web/config.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- Sent via pgadmin-hackers

[pgadmin-hackers] pgAdmin 4 commit: Update message catalog.

2016-06-21 Thread Dave Page
Update message catalog. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=e43ff84627b9967cc1ac5877b6c1594de60e5a5e Modified Files -- web/pgadmin/messages.pot | 5827 +- 1 file changed, 4206

[pgadmin-hackers] pgAdmin 4 commit: Restore should include database name in dialog title

2016-06-21 Thread Dave Page
Restore should include database name in dialog title like in backup. Add icons to restore and cancel button in restore dialog. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=85a7104e2c8c66ca09d5918b65d85a8c0c35b529 Author: Surinder Kumar

Re: [pgadmin-hackers] [pgAdmin4][Patch]: Miscellaneous UI changes & fixes

2016-06-21 Thread Dave Page
Thanks, applied. On Tue, Jun 21, 2016 at 12:07 PM, Surinder Kumar wrote: > Hi, > > Please find patch with following changes: > > 1) Remove unnecessary console log statement from pgadmin.defaults.js file. > 2) subnode-header label not taking full width (in

[pgadmin-hackers] pgAdmin 4 commit: Fix subnode-header label not taking full width (in pr

2016-06-21 Thread Dave Page
Fix subnode-header label not taking full width (in privileges/variable controls), label goes to next line on viewing properties of node(ex: database node properties). Branch -- master Details ---

[pgadmin-hackers] pgAdmin 4 commit: Remove debug code

2016-06-21 Thread Dave Page
Remove debug code Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=2a778f3c16867f427722ec4c490a0872d91686c1 Author: Surinder Kumar Modified Files --

Re: [pgadmin-hackers] Fix for issue RM1220 and RM 1221 [pgadmin4]

2016-06-21 Thread Dave Page
Hi On Tue, Jun 21, 2016 at 11:38 AM, Harshal Dhumal wrote: > Hi, > > PFA patch for issues RM1220 and RM1221 > > Issue fixed: Backup, Restore and Maintenance were causing error with > database name with special characters. This patch causes the following error

[pgadmin-hackers] [pgAdmin4][Patch]: Miscellaneous UI changes & fixes

2016-06-21 Thread Surinder Kumar
Hi, Please find patch with following changes: 1) Remove unnecessary console log statement from pgadmin.defaults.js file. 2) subnode-header label not taking full width (in privileges/variable controls), label goes to next line on viewing properties of node(ex: database node properties). 3)

[pgadmin-hackers] pgAdmin 4 commit: Fix creation of exclusion constraints. Fixes #1301

2016-06-21 Thread Dave Page
Fix creation of exclusion constraints. Fixes #1301 Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=3210975568c74dcef1650a3e0540d4489a9ba551 Author: Murtuza Zabuawala Modified Files --

Re: [pgadmin-hackers] PATCH: To fix the issue in exclude constraint (pgAdmin4)

2016-06-21 Thread Dave Page
Thanks, applied. On Tue, Jun 21, 2016 at 11:45 AM, Murtuza Zabuawala wrote: > Hi, > > PFA patch to fix the issue in exclude constraint where we were missing > validation of operator field for column, causing incomplete create sql. > (RM#1301) > > -- > Regards,

Re: [pgadmin-hackers] PATCH: To fix the issue in Exclusion constraint (pgAdmin4)

2016-06-21 Thread Murtuza Zabuawala
++ Typo corrected. > On 21-Jun-2016, at 4:15 pm, Murtuza Zabuawala > wrote: > > Hi, > > PFA patch to fix the issue in Exclusion constraint where we were missing > validation of operator field for column, causing incomplete create sql. > (RM#1301) > > -- >

[pgadmin-hackers] PATCH: To fix the issue in exclude constraint (pgAdmin4)

2016-06-21 Thread Murtuza Zabuawala
Hi, PFA patch to fix the issue in exclude constraint where we were missing validation of operator field for column, causing incomplete create sql. (RM#1301) -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company RM_1301.patch Description:

Re: [pgadmin-hackers] Fix for issue RM1220 and RM 1221 [pgadmin4]

2016-06-21 Thread Harshal Dhumal
Hi, This patch consist fix for only RM1220 I'll send another patch for RM1221 -- *Harshal Dhumal* *Software Engineer* EnterpriseDB India: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Tue, Jun 21, 2016 at 4:08 PM, Harshal Dhumal < harshal.dhu...@enterprisedb.com> wrote: >

[pgadmin-hackers] Fix for issue RM1220 and RM 1221 [pgadmin4]

2016-06-21 Thread Harshal Dhumal
Hi, PFA patch for issues RM1220 and RM1221 Issue fixed: Backup, Restore and Maintenance were causing error with database name with special characters. -- *Harshal Dhumal* *Software Engineer* EnterpriseDB India: http://www.enterprisedb.com The Enterprise PostgreSQL Company diff --git

[pgadmin-hackers] pgAdmin 4 commit: Using the preprocessor macor Q_OS_WIN differently, it

2016-06-21 Thread Ashesh Vashi
Using the preprocessor macor Q_OS_WIN differently, it was failing to compile the runtime on windows with C1017 error. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=061a9d9322208a11ee25c25d10f98138384e6647 Modified Files --

[pgadmin-hackers] pgAdmin 4 commit: Save the runtime status information in the applicatio

2016-06-21 Thread Ashesh Vashi
Save the runtime status information in the application object for using it other places. globals() does not return consistent value across the application context. Thanks Neel Patel for reporting the issue. Branch -- master Details ---

[pgadmin-hackers] pgAdmin 4 commit: Include python.exe and pythonw.exe in the Windows ins

2016-06-21 Thread Dave Page
Include python.exe and pythonw.exe in the Windows installer s the interpreter is used to run background processes. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=d133e33c4bc8434f9863f85737a44f7708fa8a92 Modified Files -- Make.bat

[pgadmin-hackers] pgAdmin 4 commit: Setting the PYTHONPATH variable before initializing t

2016-06-21 Thread Ashesh Vashi
Setting the PYTHONPATH variable before initializing the python environment using Py_Initialize() function. Also, add virtual environment binary path to the PATH environment variable. Branch -- master Details ---

Re: [pgadmin-hackers] PATCH: Unable to open Query tool (pgAdmin4)

2016-06-21 Thread Dave Page
Thanks, applied. On Tue, Jun 21, 2016 at 9:18 AM, Murtuza Zabuawala wrote: > Hi, > > PFA patch to fix the issue in query tool where it was not able to handle > special characters in editor title. > (RM#1381) > > -- > Regards, > Murtuza Zabuawala >

[pgadmin-hackers] pgAdmin 4 commit: Fix an issue in query tool where it was not able to h

2016-06-21 Thread Dave Page
Fix an issue in query tool where it was not able to handle special characters in editor title. Fixes #1381 Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=a1f65e981fa86cad91e2895cbf49a1a9726d2f25 Author: Murtuza Zabuawala

Re: [pgadmin-hackers] [pgAdmin4][Patch]: Improvements in Backup and Restore dialogs

2016-06-21 Thread Dave Page
Thanks, applied. On Tue, Jun 21, 2016 at 8:57 AM, Surinder Kumar wrote: > Hi, > > Please find patch with following improvements: > > Make dialogs non-modal > Prevent closing dialog when clicked outside the dialog. > > Please review. > > Thanks, > Surinder Kumar >

[pgadmin-hackers] pgAdmin 4 commit: Make the backup and restore dialogues non-modal.

2016-06-21 Thread Dave Page
Make the backup and restore dialogues non-modal. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=a563e17f9becb3ff84437ccc2d643b4c0fa38ea1 Author: Surinder Kumar Modified Files --

[pgadmin-hackers] pgAdmin 4 commit: Fix help URLs

2016-06-21 Thread Dave Page
Fix help URLs Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=991cbcabcb38d35edb7cb4794a73f022360a5998 Modified Files -- web/pgadmin/preferences/templates/preferences/preferences.js| 2 +-

Re: [pgadmin-hackers] Fix for RM1386 [pgamin4]

2016-06-21 Thread Dave Page
Thanks, applied. On Tue, Jun 21, 2016 at 8:54 AM, Harshal Dhumal wrote: > Hi, > > PFA patch for issue RM1386 > > > Issue Fixed: Now User cannot be created with single (or less than 6 ) > character password. > > -- > Harshal Dhumal > Software Engineer > >

[pgadmin-hackers] pgAdmin 4 commit: Issue Fixed: Now User cannot be created with single (

2016-06-21 Thread Dave Page
Issue Fixed: Now User cannot be created with single (or less than 6 ) character password. Fixes #1386 Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=19b4f9e01f65f784d9de886cd1410ae257e04abf Author: Harshal Dhumal

[pgadmin-hackers] PATCH: Unable to open Query tool (pgAdmin4)

2016-06-21 Thread Murtuza Zabuawala
Hi, PFA patch to fix the issue in query tool where it was not able to handle special characters in editor title. (RM#1381) -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company RM_1381.patch Description: Binary data -- Sent via

Re: [pgadmin-hackers] [pgAdmin4][Patch]: Backup job fails

2016-06-21 Thread Dave Page
Thanks, applied. On Tue, Jun 21, 2016 at 7:43 AM, Surinder Kumar wrote: > Hi, > > Issue: Unable to create backup of database. > Regression of commit id: bc4703c5 > > Please find patch and review. > > > Thanks, > Surinder Kumar > > > -- > Sent via pgadmin-hackers

[pgadmin-hackers] pgAdmin 4 commit: Issue: Unable to create backup of database.

2016-06-21 Thread Dave Page
Issue: Unable to create backup of database. Regression of commit id: bc4703c5 Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=eb5a97bc3c4d6fa824cb028429aa6d17c6d3474c Author: Surinder Kumar Modified Files

[pgadmin-hackers] pgAdmin 4 commit: Doc restructuring

2016-06-21 Thread Dave Page
Doc restructuring Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=5051470bc7ddf1380c4240d2c32716e979378000 Author: Susan Douglas Modified Files -- docs/en_US/add_restore_point_dialog.rst| 5 +-

[pgadmin-hackers] [pgAdmin4][Patch]: Improvements in Backup and Restore dialogs

2016-06-21 Thread Surinder Kumar
Hi, Please find patch with following improvements: 1. Make dialogs non-modal 2. Prevent closing dialog when clicked outside the dialog. Please review. Thanks, Surinder Kumar dialog_improvements.patch Description: Binary data -- Sent via pgadmin-hackers mailing list

[pgadmin-hackers] Fix for RM1386 [pgamin4]

2016-06-21 Thread Harshal Dhumal
Hi, PFA patch for issue RM1386 Issue Fixed: Now User cannot be created with single (or less than 6 ) character password. -- *Harshal Dhumal* *Software Engineer* EnterpriseDB India: http://www.enterprisedb.com The Enterprise PostgreSQL Company diff --git

[pgadmin-hackers] [pgAdmin4][Patch]: Backup job fails

2016-06-21 Thread Surinder Kumar
Hi, Issue: Unable to create backup of database. Regression of commit id: bc4703c5 Please find patch and review. Thanks, Surinder Kumar backup_job_fails.patch Description: Binary data -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your