Fwd: [pgadmin-hackers] [pgAdmin4][Patch]: RM#1184 - Re-docking on the main tabset is broken

2016-06-23 Thread Surinder Kumar
Hi Please find attached patch with following changes: 1) Given a title to browser panel. 2) Add an icon and did styling to match with other panels.(please change icon it it doesn't look good). 3) Added new class to title div to override css style. Please review. Thanks, Surinder Kumar

[pgadmin-hackers] pgAdmin 4 commit: Auto-discover locally installed servers at login. Fix

2016-06-23 Thread Dave Page
Auto-discover locally installed servers at login. Fixes #1389 Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=1acc1a767846a0862abe84d919a94943ec30e97f Modified Files -- web/config.py | 2 +- web/pgadmin/__init__.py

[pgadmin-hackers] pgAdmin 4 commit: Tag REL-1_0-BETA2 has been created.

2016-06-23 Thread Dave Page
Tag REL-1_0-BETA2 has been created. View: http://git.postgresql.org/gitweb?p=pgadmin4.git;a=tag;h=refs/tags/REL-1_0-BETA2 Log Message --- Tag beta 2 -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription:

Re: [pgadmin-hackers] pgAdmin IV API test cases patch

2016-06-23 Thread Priyanka Shendge
On 15 June 2016 at 15:05, Priyanka Shendge < priyanka.shen...@enterprisedb.com> wrote: > Thanks a lot Dave. > > On 15 June 2016 at 14:09, Dave Page wrote: > >> Hi >> >> On Thu, Jun 9, 2016 at 1:37 PM, Priyanka Shendge >> wrote: >> > Hi Dave,

Re: [pgadmin-hackers] Fix for issue RM1220 and RM 1221 [pgadmin4]

2016-06-23 Thread Ashesh Vashi
On Thu, Jun 23, 2016 at 6:26 PM, Harshal Dhumal < harshal.dhu...@enterprisedb.com> wrote: > Hi Dave, > > It seems that pg_dump utility does not handle database name properly with > equal to (=) sign in it. > > Observe above stack trace, we are generating command line command > properly. However

Re: [pgadmin-hackers] Fix for issue RM1220 and RM 1221 [pgadmin4]

2016-06-23 Thread Harshal Dhumal
One more thing that this also fails in pgadmin3 as well. -- *Harshal Dhumal* *Software Engineer* EnterpriseDB India: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Thu, Jun 23, 2016 at 6:26 PM, Harshal Dhumal < harshal.dhu...@enterprisedb.com> wrote: > Hi Dave, > > It seems

Re: [pgadmin-hackers] Fix for issue RM1220 and RM 1221 [pgadmin4]

2016-06-23 Thread Harshal Dhumal
Hi Dave, It seems that pg_dump utility does not handle database name properly with equal to (=) sign in it. Observe above stack trace, we are generating command line command properly. However pg_dump only takes database name upto equal to sign reset is ignored. e.g. Database name in command is

[pgadmin-hackers] [pgAdmin4][Patch]: RM#1242 - Cleanup busy indication for tree view and tab panes

2016-06-23 Thread Surinder Kumar
Hi *Following are the changes in patch:* 1) Assign a common class '*pg_spinner*' for loading spinner in wcDocker for all panels. 2) Removed the default wcDocker spinner icon which was specific to page load. 3) In case of collection node, we were re-creating the grid every time new data comes.

Re: [pgadmin-hackers] PATCH: Statistics for Tablespace (pgAdmin4)

2016-06-23 Thread Dave Page
Thanks, applied! On Thu, Jun 23, 2016 at 11:05 AM, Murtuza Zabuawala wrote: > Hi, > > PFA patch to fix the issue in tablespace stats, earlier it was not > displaying any stats. > RM#1196 > > -- > Regards, > Murtuza Zabuawala > EnterpriseDB:

[pgadmin-hackers] pgAdmin 4 commit: Fix tablespace statistics. Fixes #1196

2016-06-23 Thread Dave Page
Fix tablespace statistics. Fixes #1196 Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=e4ef927da31eae612a28b914207b92e1bbdbc359 Author: Murtuza Zabuawala Modified Files --

Re: [pgadmin-hackers] PATCH: Allow default ACLs to be specified when creating a schema (pgAdmin4)

2016-06-23 Thread Dave Page
Thanks, applied. On Thu, Jun 23, 2016 at 10:14 AM, Murtuza Zabuawala wrote: > Hi, > > PFA patch, This will allow us to set default ACLs to be specified while > creating a schema. > (RM#1108) > > Additionally misc changes in templates for SQL indentation. > >

[pgadmin-hackers] pgAdmin 4 commit: Allow default ACLs to be specified when creating sche

2016-06-23 Thread Dave Page
Allow default ACLs to be specified when creating schemas. Fixes #1108. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=8b0e65dc57c179b28dac7c7d4e88c2f624360839 Author: Murtuza Zabuawala Modified Files

[pgadmin-hackers] pgAdmin 4 commit: Fix default ACL queries which were using invalid valu

2016-06-23 Thread Dave Page
Fix default ACL queries which were using invalid values for defaclobjtype. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=5928f70a1d31cb817375df03d9097a6a8090316e Modified Files --

[pgadmin-hackers] pgAdmin 4 commit: Fix "number.toFixed is not function" JS error.

2016-06-23 Thread Dave Page
Fix "number.toFixed is not function" JS error. Issue: We got the following error in console log "number.toFixed is not function" Steps to reproduce: 1) Click on statistics tab. 1) Select any database node. 2) then select Databases collection node. 3) The above error will appear into console.

Re: [pgadmin-hackers] [pgAdmin4][Patch]: number.toFixed is not function

2016-06-23 Thread Dave Page
Thanks, applied. On Thu, Jun 23, 2016 at 7:53 AM, Surinder Kumar wrote: > Hi > > Please find the patch > Issue: > We got the following error in console log > "number.toFixed is not function" > > Steps to reproduce: > 1) Click on statistics tab. > 1) Select any

Re: [pgadmin-hackers] PACTH: To fix the issue while selecting primary key in table (pgAdmin4)

2016-06-23 Thread Dave Page
Hi On Wed, Jun 22, 2016 at 12:56 PM, Murtuza Zabuawala wrote: > Hi, > > PFA minor patches to fix two issues mentioned in RM#1235 & RM#1234. I've pushed the fix for 1234, however the fix for 1235 changes the control used in the grid to a checkbox which is

[pgadmin-hackers] pgAdmin 4 commit: Fix SQL formatting. Fixes #1234

2016-06-23 Thread Dave Page
Fix SQL formatting. Fixes #1234 Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=4983eb2f1cd0b87e9309477bab0be0ec6e2c7893 Modified Files -- .../server_groups/servers/databases/schemas/tables/__init__.py| 4 ++-- 1 file

Re: [pgadmin-hackers] Fix for issue RM1220 and RM 1221 [pgadmin4]

2016-06-23 Thread Dave Page
On Wed, Jun 22, 2016 at 11:09 AM, Harshal Dhumal wrote: > Hi, > > PFA updated patch for issues 1220 and 1221 Hi Still not working I'm afraid: Backing up an object on the server 'PostgreSQL 9.4 (127.0.0.1:5432)' from database '!#$%^&*()_+{}|:"<>?=-\][';/.,'...

Re: [pgadmin-hackers] PATCH: To fix the issue of IntegrityError in server port defination (pgAdmin4)

2016-06-23 Thread Dave Page
Ahh, yes - in pgadmin/__init__.py. Thanks, patch applied. On Wed, Jun 22, 2016 at 10:18 AM, Murtuza Zabuawala wrote: > Hi Dave, > > I checked the code it's already implemented, pgAdmin4.py will upgrade schema > automatically on subsequent run. > > Thanks, >

[pgadmin-hackers] pgAdmin 4 commit: Fix constraint on server table to allow port 65535 to

2016-06-23 Thread Dave Page
Fix constraint on server table to allow port 65535 to be used. Fixes #1388 Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=97d49af43adc7b50a1d711fad445fab15bd48462 Author: Murtuza Zabuawala Modified Files

Re: [pgadmin-hackers] PATCH: Do not allow to drop current maintenance DB

2016-06-23 Thread Dave Page
Thanks, applied. On Wed, Jun 22, 2016 at 9:32 AM, Murtuza Zabuawala wrote: > Hi > > PFA patch to fix the issue mentioned in RM#1382. > To fix the issue we will not display drop option on maintenance db. > > -- > Regards, > Murtuza Zabuawala > EnterpriseDB:

[pgadmin-hackers] pgAdmin 4 commit: Don't offer an option to drop the current maintenance

2016-06-23 Thread Dave Page
Don't offer an option to drop the current maintenance database. Fixes #1382 Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=e5ee592470984265c0999610e3d2b419882592e3 Author: Murtuza Zabuawala Modified Files

Re: [pgadmin-hackers] PATCH:Treeview item sorting (pgAdmin4)

2016-06-23 Thread Dave Page
OK, thanks. I'll leave it with him then. On Thu, Jun 23, 2016 at 11:09 AM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi Dave, > > Ashesh picked up on this task. > > > -- > Regards, > Murtuza Zabuawala > EnterpriseDB: http://www.enterprisedb.com > The Enterprise PostgreSQL

Re: [pgadmin-hackers] PATCH:Treeview item sorting (pgAdmin4)

2016-06-23 Thread Murtuza Zabuawala
Hi Dave, Ashesh picked up on this task. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Thu, Jun 23, 2016 at 3:18 PM, Dave Page wrote: > Hi > > Can you please check this is still relevant, and if so, rebase it?

[pgadmin-hackers] PATCH: Statistics for Tablespace (pgAdmin4)

2016-06-23 Thread Murtuza Zabuawala
Hi, PFA patch to fix the issue in tablespace stats, earlier it was not displaying any stats. RM#1196 -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company RM_1196.patch Description: Binary data -- Sent via pgadmin-hackers mailing list

Re: [pgadmin-hackers] PATCH:Treeview item sorting (pgAdmin4)

2016-06-23 Thread Dave Page
Hi Can you please check this is still relevant, and if so, rebase it? Somehow I missed it when you first posted it :-( On Tue, May 31, 2016 at 11:06 AM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi, > > PFA patch to add server & client side sorting of nodes when node is >

[pgadmin-hackers] PATCH: Allow default ACLs to be specified when creating a schema (pgAdmin4)

2016-06-23 Thread Murtuza Zabuawala
Hi, PFA patch, This will allow us to set default ACLs to be specified while creating a schema. (RM#1108) Additionally misc changes in templates for SQL indentation. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company RM_1108.patch

[pgadmin-hackers] [pgAdmin4][Patch]: number.toFixed is not function

2016-06-23 Thread Surinder Kumar
Hi Please find the patch *Issue:* We got the following error in console log *"number.toFixed is not function"* *Steps to reproduce:* 1) Click on statistics tab. 1) Select any database node. 2) then select Databases collection node. 3) The above error will appear into console. *Reason:* I