Re: [pgadmin-hackers] [Patch] Fix Unicode in errmsg

I've changed only the data coming as the user input for deferent nodes. :-) Great! It's good to have feedback like above. That will give us the idea, where we need improvements, as all the current developers, working on pgAdmin 4, are from English background. I'm really interested in

Re: [pgadmin-hackers] [pgAdmin4][Patch]: RM#1432 - File Browser - File does not exist error

Please find updated patch. This patch also includes the fix for issue "File Browser - File does not exist error". On Wed, Jul 13, 2016 at 7:23 PM, Surinder Kumar < surinder.ku...@enterprisedb.com> wrote: > I forgot to merge the fix for issue "File Browser - File does not exist > error" in the

[pgadmin-hackers] pgAdmin 4 commit: Fix an issue in procedure node where users were not a

Fix an issue in procedure node where users were not able to create a new procedure when they provide arguments. Fixes #1416 Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=fdcb9d2a576730bf9d864b89dbe69bf22008bf09 Author: Murtuza Zabuawala

Re: [pgadmin-hackers] PATCH: Unable to create procedure (pgAdmin4)

Thanks, applied. On Tue, Jul 12, 2016 at 9:04 AM, Murtuza Zabuawala wrote: > Hi, > > PFA patch to fixed the issue in procedure node where user were not able to > create new procedure when they provide arguments. > (RM#1449) > > To fix the issue we used

Re: [pgadmin-hackers] [pgAdmin4][Patch]: RM#1432 - File Browser - File does not exist error

I forgot to merge the fix for issue "File Browser - File does not exist error" in the patch. Please ignore this patch. On Wed, Jul 13, 2016 at 7:20 PM, Surinder Kumar < surinder.ku...@enterprisedb.com> wrote: > Please find updated patch with following changes/enhancements: > >1. Double click

Re: [pgadmin-hackers] PATCH: To fix issue using PUBLIC as role (pgAdmin4)

Thanks, applied. On Wed, Jul 13, 2016 at 11:40 AM, Murtuza Zabuawala wrote: > Hi, > > PFA patch to fix the issue where user was not able to select 'PUBLIC' as > role in privileges. > (RM#1416) > > This issue was due to previous commit: b78b3904cd7e5a8edf > > >

Re: [pgadmin-hackers] [pgAdmin4][Patch]: RM#1432 - File Browser - File does not exist error

Please find updated patch with following changes/enhancements: 1. Double click on file/folder icon or name will navigate to the folder/file. 2. Selected file/folder can be renamed by Rename button only. Double click rename is removed. 3. Filename text box will not hide on smaller

[pgadmin-hackers] pgAdmin 4 commit: Display comments on languages. Fixes #1412

Display comments on languages. Fixes #1412 Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=ae692d2416e0b4bc1569350a9b76c79e7e255594 Author: Murtuza Zabuawala Modified Files --

Re: [pgadmin-hackers] PATCH: Comments are not visible in Language node (pgAdmin4)

Thanks, applied. On Tue, Jul 12, 2016 at 12:15 PM, Murtuza Zabuawala wrote: > Hi, > > PFA patch to fix RM#1412, where comments are not visible in sql pane for > Languages node. > > -- > Regards, > Murtuza Zabuawala > EnterpriseDB: http://www.enterprisedb.com >

Re: [pgadmin-hackers] PATCH: Fix the issue for saving query output as CSV

Hi, PFA rebased patch for RM1405 -- *Harshal Dhumal* *Software Engineer* EnterpriseDB India: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Wed, Jul 13, 2016 at 5:15 PM, Harshal Dhumal < harshal.dhu...@enterprisedb.com> wrote: > Yes sure > > -- > *Harshal Dhumal* >

Re: [pgadmin-hackers] PATCH: Fix the issue for saving query output as CSV

Yes sure -- *Harshal Dhumal* *Software Engineer* EnterpriseDB India: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Wed, Jul 13, 2016 at 5:10 PM, Dave Page wrote: > Hi > > Can you rebase this please? > > Thanks. > > On Mon, Jul 11, 2016 at 9:16 AM,

Re: [pgadmin-hackers] [pgAdmin4][Patch]: RM#1432 - File Browser - File does not exist error

On Tue, Jul 12, 2016 at 7:10 AM, Surinder Kumar wrote: > On Mon, Jul 11, 2016 at 6:41 PM, Dave Page wrote: >> >> On Thu, Jul 7, 2016 at 1:50 PM, Surinder Kumar >> wrote: >> > On Wed, Jul 6, 2016 at 7:02 PM,

[pgadmin-hackers] pgAdmin 4 commit: Fix incomplete reverse engineered SQL for databases.

Fix incomplete reverse engineered SQL for databases. Fixes #1420 Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=f58c4df85de9ccd13be7613ddcd8aebf14ef2931 Author: Surinder Kumar Modified Files --

Re: [pgadmin-hackers] [pgAdmin4][Patch]: RM#1420 - Reverse engineered SQL incomplete for Databases

Thanks, applied. On Mon, Jul 11, 2016 at 10:58 AM, Surinder Kumar wrote: > Hi > > Please find attached patch with fix and review. > Included missing Create and Drop comments in generated sql query. > > Thanks, > Surinder Kumar > > > -- > Sent via pgadmin-hackers

Re: [pgadmin-hackers] PATCH: Fix the issue for saving query output as CSV

Hi Can you rebase this please? Thanks. On Mon, Jul 11, 2016 at 9:16 AM, Harshal Dhumal < harshal.dhu...@enterprisedb.com> wrote: > Hi, > > PFA patch for RM1405. Also to allow download in runtime we will still need > patch >

Re: [pgadmin-hackers] [pgAdmin4][Patch]: Clear query window button click opens query tool in new window in Mac Runtime

Thanks, applied. On Mon, Jul 11, 2016 at 9:13 AM, Surinder Kumar wrote: > Hi > > Issue: > When we click on "Clear query window" button in Query tool, a new instance > of query tool opens in new window. The event "StopEventPropogation" was not > working. > >

[pgadmin-hackers] pgAdmin 4 commit: Fix clear query option which was opening a query tool

Fix clear query option which was opening a query tool in new window in Mac Runtime Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=9ad0bd10265fbcef3efe33704c52ffa3e7f841e4 Author: Surinder Kumar Modified

Re: [pgadmin-hackers] [pgAdmin4][Patch]: Busy icon not visible in Debugger and Query tool in Runtime environment

Thanks, applied. On Fri, Jul 8, 2016 at 8:30 AM, Surinder Kumar wrote: > Hi > > The spinner icon is not visible while executing query or running debugger in > Runtime environment specific to Ubuntu. This issue is related to RM#1186 > > To make it work, we need to

[pgadmin-hackers] pgAdmin 4 commit: The spinner icon is not visible while executing query

The spinner icon is not visible while executing query or running debugger in Runtime environment specific to Ubuntu. This issue is related to RM#1186 To make it work, we need to explicitly set -webkit-animation property to 'none' for classes "sql-editor-busy-icon.fa-pulse" and

Re: [pgadmin-hackers] [pgAdmin4][runtime]: Download feature in runtime

Thanks - applied. On Fri, Jul 8, 2016 at 7:17 AM, Neel Patel wrote: > Hi Dave, > > Please find attached patch file for the fix of crash and comment text. > Downloading cancel request was not handled properly and due to that > application was getting crashed. > > Do

[pgadmin-hackers] pgAdmin 4 commit: Properly support file downloads in the desktop runtim

Properly support file downloads in the desktop runtime. Fixes #1405. Fixes #1342 Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=d22ea8bf61b1d644c9add7880b4dbea6d1e3c1d6 Author: Neel Patel Modified Files

Re: [pgadmin-hackers] [Patch] Fix Unicode in errmsg

What error are you getting? Can you please share the exact error message to understand the issue properly? Sorry, my bad. Here is the traceback: 2016-07-12 16:12:22,366: ERRORpgadmin:Exception on /browser/server-group/obj/ [POST] Traceback (most recent call last): File

[pgadmin-hackers] PATCH: To fix issue using PUBLIC as role (pgAdmin4)

Hi, PFA patch to fix the issue where user was not able to select 'PUBLIC' as role in privileges. (RM#1416) This issue was due to previous commit: b78b3904cd7e5a8edf -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company RM_1416.patch

Re: [pgadmin-hackers] [pgAdmin4][Patch]: Render data grid only if Dashboard Panel is active

On Wed, Jul 13, 2016 at 12:32 PM, Dave Page wrote: > Won't this result in incorrect graphs? I.e. chunks of data being missing > (but not obviously so)? > Oh I see.. It might result in incorrect graphs.. Please ignore the patch. > > -- > Dave Page > Blog:

Re: [pgadmin-hackers] [pgAdmin4][Patch]: Render data grid only if Dashboard Panel is active

Won't this result in incorrect graphs? I.e. chunks of data being missing (but not obviously so)? -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK:http://www.enterprisedb.com The Enterprise PostgreSQL Company > On 13 Jul 2016, at 07:47, Surinder Kumar

[pgadmin-hackers] [pgAdmin4][Patch]: Render data grid only if Dashboard Panel is active

Hi In Dashboard, the ajax calls to *render data grid* should only made, if dashboard panel is active. Currently it make ajax calls even if other panels like properties, sql are active. Please find attached patch and review. Thanks, Surinder Kumar dashboard_render_if_panel_is_opened.patch

[pgadmin-hackers] Regarding issue in psycopg2 driver handling duplicate field names in query (pgAdmin4)

Hi, I was looking into RM#1409 and found that it is issue with psycopg2 driver handling DictCursor result which is not handling duplicate field names. I have also raised issue for the same https://github.com/psycopg/psycopg2/issues/454 -- Regards, Murtuza Zabuawala EnterpriseDB: