Re: [pgadmin-hackers] Runtime broken on Mac

2016-09-01 Thread Ashesh Vashi
Sorry. Unfortunately - we did not have access to the community build at that time. We can test the one click installer without setting PYTHON_HOME, if that works - we can unset it only for Mac. -- Thanks & Regards, Ashesh Vashi EnterpriseDB INDIA: Enterprise PostgreSQL Company

Re: [pgadmin-hackers] Runtime broken on Mac

2016-09-01 Thread Dave Page
It should have fixed 1392, but it broke the community mac package (just after beta 4) -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK:http://www.enterprisedb.com The Enterprise PostgreSQL Company > On 1 Sep 2016, at 17:42, Ashesh Vashi

Re: [pgadmin-hackers] Runtime broken on Mac

2016-09-01 Thread Ashesh Vashi
Also - during beta 4 release the runtime issue was fixed only by setting PYTHON_HOME. On Sep 1, 2016 22:10, "Ashesh Vashi" wrote: > This might explain. > https://redmine.postgresql.org/issues/1392 > > On Sep 1, 2016 21:52, "Dave Page" wrote: >

Re: [pgadmin-hackers] Runtime broken on Mac

2016-09-01 Thread Ashesh Vashi
This might explain. https://redmine.postgresql.org/issues/1392 On Sep 1, 2016 21:52, "Dave Page" wrote: > Neel, Ashesh, > > re: https://git.postgresql.org/gitweb/?p=pgadmin4.git;a=commitdiff;h= > a3e8ba93ae6968f13b331d9218d51b8e2d39f344 > > it seems that setting PYTHON_HOME

[pgadmin-hackers] Runtime broken on Mac

2016-09-01 Thread Dave Page
Neel, Ashesh, re: https://git.postgresql.org/gitweb/?p=pgadmin4.git;a=commitdiff;h=a3e8ba93ae6968f13b331d9218d51b8e2d39f344 it seems that setting PYTHON_HOME breaks the runtime on Mac OSX. Doing so means that the system installed Python libraries cannot be found, a (large) number of which do

Re: [pgadmin-hackers] pgAdmin IV : Unittest modular patch (Domains and Tables nodes)

2016-09-01 Thread Navnath Gadakh
Sure. On Thu, Sep 1, 2016 at 4:44 PM, Dave Page wrote: > Hi > > Please separate the cleanup from the new tests. Each patch should have > just one feature/focus/fix. > > Thanks. > > On Thu, Sep 1, 2016 at 12:12 PM, Navnath Gadakh < > navnath.gad...@enterprisedb.com>

Re: [pgadmin-hackers] pgAdmin IV : Unittest modular patch (Domains and Tables nodes)

2016-09-01 Thread Dave Page
Hi Please separate the cleanup from the new tests. Each patch should have just one feature/focus/fix. Thanks. On Thu, Sep 1, 2016 at 12:12 PM, Navnath Gadakh < navnath.gad...@enterprisedb.com> wrote: > Hello Dave, > Object cleanup work is completed in above patch. I am working on enhanced

Re: [pgadmin-hackers] pgAdmin IV : Unittest modular patch (Domains and Tables nodes)

2016-09-01 Thread Navnath Gadakh
Hello Dave, Object cleanup work is completed in above patch. I am working on enhanced summary work, once that's complete I will send the revised patch. Thanks! On Thu, Sep 1, 2016 at 3:57 PM, Dave Page wrote: > Per my earlier email to Priyanka, I'm not going to

[pgadmin-hackers] pgAdmin 4 commit: Fix the boolean editor, and warn the user if there ar

2016-09-01 Thread Dave Page
Fix the boolean editor, and warn the user if there are unsaved changed in the edit grid before refreshing. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=087332f32e93434546ef174787522d0060568522 Author: Murtuza Zabuawala

[pgadmin-hackers] Re: Schema child node: FTS nodes (Configuration, Dictionaries, Parser, Templates)

2016-09-01 Thread Priyanka Shendge
Sure, i'll re-submit a patch once clean up work and summary output in place. Thank you. On 1 September 2016 at 15:55, Dave Page wrote: > Hi > > I'm currently seeing numerous failures in the test suite, including ERROR > tags being output from tests in this patch

[pgadmin-hackers] pgAdmin 4 commit: Tag REL-1_0-RC1 has been created.

2016-09-01 Thread Dave Page
Tag REL-1_0-RC1 has been created. View: http://git.postgresql.org/gitweb?p=pgadmin4.git;a=tag;h=refs/tags/REL-1_0-RC1 Log Message --- Tag 1.0 RC1 -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription:

Re: [pgadmin-hackers] RC1 did not hit website

2016-09-01 Thread Dave Page
On Thu, Sep 1, 2016 at 11:35 AM, Devrim Gündüz wrote: > > Hi Dave, > > On Thu, 2016-09-01 at 11:33 +0100, Dave Page wrote: > > > pgadmin.org still mentions about beta 4, it needs an update for RC1. > > > > > > > Yes. We always 'officially' release after PostgreSQL. > > For a

Re: [pgadmin-hackers] RC1 did not hit website

2016-09-01 Thread Devrim Gündüz
Hi Dave, On Thu, 2016-09-01 at 11:33 +0100, Dave Page wrote: > > pgadmin.org still mentions about beta 4, it needs an update for RC1. > > > > Yes. We always 'officially' release after PostgreSQL. For a moment I thought it was Friday. Sorry :) Regards, -- Devrim GÜNDÜZ EnterpriseDB:

Re: [pgadmin-hackers] Package node test cases [pgadmin4]

2016-09-01 Thread Harshal Dhumal
Ok, I'll do that once that work is completed. -- *Harshal Dhumal* *Software Engineer* EnterpriseDB India: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Thu, Sep 1, 2016 at 3:57 PM, Dave Page wrote: > Per my earlier email to Priyanka, I'm not going to

Re: [pgadmin-hackers] RC1 did not hit website

2016-09-01 Thread Dave Page
2016-09-01 11:31 GMT+01:00 Devrim Gündüz : > > Hi, > > pgadmin.org still mentions about beta 4, it needs an update for RC1. > Yes. We always 'officially' release after PostgreSQL. -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK:

[pgadmin-hackers] RC1 did not hit website

2016-09-01 Thread Devrim Gündüz
Hi, pgadmin.org still mentions about beta 4, it needs an update for RC1. Regards, -- Devrim GÜNDÜZ EnterpriseDB: http://www.enterprisedb.com PostgreSQL Danışmanı/Consultant, Red Hat Certified Engineer Twitter: @DevrimGunduz , @DevrimGunduzTR signature.asc Description: This is a digitally

Re: [pgadmin-hackers] pgAdmin IV : Unittest modular patch (Domains and Tables nodes)

2016-09-01 Thread Dave Page
Per my earlier email to Priyanka, I'm not going to commit any more test cases until the existing issues are resolved and the enhanced summary and object cleanup work is complete, otherwise it's just taking too much time unnecessarily. Please re-test and resubmit this patch once that work is

Re: [pgadmin-hackers] Package node test cases [pgadmin4]

2016-09-01 Thread Dave Page
Per my earlier email to Priyanka, I'm not going to commit any more test cases until the existing issues are resolved and the enhanced summary and object cleanup work is complete, otherwise it's just taking too much time unnecessarily. Please re-test and resubmit this patch once that work is

[pgadmin-hackers] Re: Schema child node: FTS nodes (Configuration, Dictionaries, Parser, Templates)

2016-09-01 Thread Dave Page
Hi I'm currently seeing numerous failures in the test suite, including ERROR tags being output from tests in this patch without any other output (does that mean they're negative tests and the error is expected)? In any case, I'm not going to commit any more test cases until the existing issues