Re: [pgadmin-hackers][Patch] Refactor sql template version picking

[Murtuza Zabuawala]

Hi Dave,

I found one typo as given below and apart from that, code is working as
expected with new template loader,


   - 
web/pgadmin/browser/server_groups/servers/databases/schemas/__init__.py:241:
 return 'ppas/*#{0#}*'.format(ver)


--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

On Mon, Jan 30, 2017 at 10:56 AM, Murtuza Zabuawala <
murtuza.zabuaw...@enterprisedb.com> wrote:

> Sure Dave, I will take a look.
>
> --
> Regards,
> Murtuza Zabuawala
> EnterpriseDB: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
> On Fri, Jan 27, 2017 at 9:57 PM, Dave Page  wrote:
>
>> Scrub that Khushboo - Murtuza, can you review on Monday please? I'm
>> being told Khushboo is on the critical path for something else at the
>> moment.
>>
>> On Fri, Jan 27, 2017 at 4:22 PM, Dave Page  wrote:
>> > Very nice indeed! I didn't realise we'd ended up with quite so many
>> > duplicated templates.
>> >
>> > Both patches look good to me - really the only thing that caught my
>> > eye was the name versioned_template_loader which is somewhat longer
>> > than I'd prefer.
>> >
>> > As it's a major change, and we're going to be wrapping 1.2 in a little
>> > over a week, I'd like some further review before committing. Khushboo,
>> > can you take a look first thing on Monday please? If you're happy,
>> > I'll commit and ask Fahar to do some testing.
>> >
>> > Thanks!
>> >
>> > On Thu, Jan 26, 2017 at 8:48 PM, George Gelashvili
>> >  wrote:
>> >> As a followup, we created this additional patch removing now-redundant
>> sql
>> >> templates. If you're interested in how we decided what files to
>> delete, the
>> >> script we used is here. We only removed files that were exactly
>> identical
>> >> between multiple postgres versions for the same feature.
>> >>
>> >> This patch should be applied on a master patched with
>> >> version-aware-sql-template-loader-refactor.diff
>> >>
>> >>
>> >> On Thu, Jan 26, 2017 at 12:22 PM, George Gelashvili <
>> ggelashv...@pivotal.io>
>> >> wrote:
>> >>>
>> >>> Hi Hackers!
>> >>>
>> >>> Since we are preparing to add greenplum support, we made a new
>> template
>> >>> loader to automatically pick the available sql template file that
>> >>> corresponds to the postgres version number.
>> >>>
>> >>> Our next patch will be to remove duplicated sql template files since
>> many
>> >>> of the files are identical between versions.
>> >>>
>> >>> Cheers,
>> >>> George & Tira
>> >>
>> >>
>> >>
>> >>
>> >> --
>> >> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
>> >> To make changes to your subscription:
>> >> http://www.postgresql.org/mailpref/pgadmin-hackers
>> >>
>> >
>> >
>> >
>> > --
>> > Dave Page
>> > Blog: http://pgsnake.blogspot.com
>> > Twitter: @pgsnake
>> >
>> > EnterpriseDB UK: http://www.enterprisedb.com
>> > The Enterprise PostgreSQL Company
>>
>>
>>
>> --
>> Dave Page
>> Blog: http://pgsnake.blogspot.com
>> Twitter: @pgsnake
>>
>> EnterpriseDB UK: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>
>

[pgadmin-hackers] [pgAdmin4][PATCH] To fix the issue in handling of timestamp type

[Murtuza Zabuawala]

Hi,

Please find a patch to fix the issue in timestamp & time type when user
tries to provide scale/lengt to them.
I did some refactoring in code to handle it at one place, affected nodes
would be Type, Table & Column.
*RM#2076*


--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


fix_timestamp_type_issue.patch
Description: Binary data

-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers] PATCH: To fix the issue in Database node (pgAdmin4)

[Murtuza Zabuawala]

Hi Dave,

Please find updated patch, Tested against maintenance database as well.

--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

On Wed, Jan 25, 2017 at 6:39 PM, Dave Page  wrote:

> Hi
>
> On Wed, Jan 25, 2017 at 12:21 PM, Murtuza Zabuawala
>  wrote:
> > Hi Dave,
> >
> > Last patch had Python-3 fix for test suite, but now it is already
> committed.
> > PFA updated patch.
>
> It still doesn't work completely for me. I tried changing the value of
> bytea_output in a database that *does* allow connections, and I get a
> 503 response from the server, with a message of:
>
> {"info":"CONNECTION_LOST","errormsg":"Connection to the server has
> been lost!","data":{"database":null,"conn_id":null,"sid":1},"
> result":null,"success":0}
>
> The payload sent via PUT to
> http://127.0.0.1:5050/browser/database/obj/1/1/12403 was:
>
> {"id":12403,"variables":{"changed":[{"role":"pgweb","
> name":"bytea_output","value":"hex","database":"postgres"}]}}
>
> It works fine without the patch applied.
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>


RM_2024_v4.patch
Description: Binary data

-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] [pgAdmin4][Patch]: RM2047 - Allow user to move panel over the menu bar

[Surinder Kumar]

Hi Dave,

*Solution:*
Setting z-index: 10 of .pg-navbar menu class to allow panel float over the
menu bar.

Please find attached patch.

Thanks,
Surinder Kumar


RM2047.patch
Description: Binary data

-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers