Re: [pgadmin-hackers][patch] Test dependencies and screenshots

2017-03-02 Thread Joao Pedro De Almeida Pereira
Hi, We adjusted the patches to correct the issues that you mentioned Improves screenshots and reduces test flakiness - rename screenshot files to add python version - put screenshots into separate pg version folders Thanks Joao & Tira & Sarah On Thu, Mar 2, 2017 at 5:15 AM, Dave Page

[pgadmin-hackers][discussion] Javascript package management (Yarn?)

2017-03-02 Thread Atira Odhner
Hi Hackers, We've had some discussion on another thread in the past couple weeks about pulling in npm to

[pgadmin-hackers] [Design Update][Dashboard]

2017-03-02 Thread Shirley Wang
Hello Hackers, Below is an update on our findings for the Dashboard in pgAdmin. You can also find all updates here: https://docs.google.com/document/d/1J_GhsL0nR4dbTI6F-XlxspvXutghzj-3UGjDWf8MtVA/edit?usp=sharing . . . *Summary* We wanted to learn if the graphs within the ‘Dashboard’ option

[pgadmin-hackers] [Design Update][Autoformat]

2017-03-02 Thread Shirley Wang
Hello Hackers, Below is an update on our findings for autoformatting in pgAdmin. You can also find all updates here: https://docs.google.com/document/d/1J_GhsL0nR4dbTI6F-XlxspvXutghzj-3UGjDWf8MtVA/edit?usp=sharing . . . *Summary* We learned that where the ‘autoformat’ pop up appears works well

Re: [pgadmin-hackers] Feature test issues

2017-03-02 Thread Atira Odhner
Just to clarify the change we made in this regard --- we use the 'reset layout' link in the header between tests, but it essentially still does a page load and doesn't save us time. If we were to do an actual page load we would run into issues because of the navigation confirmation popup. If we

[pgadmin-hackers] pgAdmin 4 commit: Exclude a bunch of unnecessary files from the Windows

2017-03-02 Thread Dave Page
Exclude a bunch of unnecessary files from the Windows package. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=523cd6f34a21034c9f7ee2678da797cb5e1e2c38 Modified Files -- Make.bat | 4 1 file changed, 4 insertions(+) -- Sent

[pgadmin-hackers] pgAdmin 4 commit: Revert "Rename the top level feature tests directory

2017-03-02 Thread Dave Page
Revert "Rename the top level feature tests directory for consistency with other test directories" The exclude command line option relies on the directory name. This needs fixing... This reverts commit 9288d69b62413423544acef60f42e4b73a8114e7. Branch -- master Details ---

[pgadmin-hackers] pgAdmin 4 commit: Rename the top level feature tests directory for cons

2017-03-02 Thread Dave Page
Rename the top level feature tests directory for consistency with other test directories Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=9288d69b62413423544acef60f42e4b73a8114e7 Modified Files --

Re: [pgadmin-hackers][patch] Test dependencies and screenshots

2017-03-02 Thread Dave Page
Hi On Wed, Mar 1, 2017 at 9:34 PM, Joao Pedro De Almeida Pereira wrote: > Hi Hackers > > We noticed that the feature test dependencies were removed in a recent > patch, so we added them back. They were intentionally moved - see:

[pgadmin-hackers] pgAdmin 4 commit: Better handling the non-ascii characters for differen

2017-03-02 Thread Ashesh Vashi
Better handling the non-ascii characters for different database objects. Using 'psycopg2.extensions.UNICODE' (for Python < 3) in the psycopg2 driver for proper conversation of unicode characters. Also - adjusted the string typecaster to take care of different character types (char, character,

[pgadmin-hackers] pgAdmin 4 commit: Move another test-only dependency to web/regression/r

2017-03-02 Thread Dave Page
Move another test-only dependency to web/regression/requirements.txt Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=af29eac6ba167d3f0355f951797e543c5b2ad58f Modified Files -- requirements.txt| 1 -