Re: [pgadmin-hackers] [pgAdmin4][PATCH] Improvements to Query Results Grid User Experience

2017-06-08 Thread Dave Page
t;> 1) Clicking on a new added row(after save) results in console error - >>>>> screenshot attached. >>>> >>>> >>> >>> We tried to follow the steps you provided to replicate the bug but >>> couldn't replicate the error. Can

[pgadmin-hackers] pgAdmin 4 commit: Improvements to the Query Results grid:

2017-06-08 Thread Dave Page
Improvements to the Query Results grid: - Improve the UI - Allow copy/paste from sets of rows, columns or arbitrary blocks of cells Patch by Matt, Shruti, Joao and Sarah @ Pivotal Fixes #2476 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=0

Re: [pgadmin-hackers] [pgAdmin4][Patch]: Load module's JS files only when required

2017-06-08 Thread Dave Page
Can you forward the patch so we can take a look at it. > > We believe that every effort done to eliminate templated Javascript and CSS > files is well worth it, and should be followed. Odd - the patch was sent to you as well. Oh well, here it is. > On Tue, Jun 6, 2017 at 9:39 AM,

Re: [pgadmin-hackers] Re: [pgAdmin4][Patch][Feature #1971]: Remember column sizes between executions of the same query in the query tool

2017-06-08 Thread Dave Page
Nice! Thanks, patch applied. On Wed, Jun 7, 2017 at 4:03 PM, Surinder Kumar wrote: > PFA patch after rebase > > On Wed, Jun 7, 2017 at 6:26 PM, Surinder Kumar > wrote: >> >> Hi >> >> Please find rebased patch. >> >> On Wed, Jun 7, 2017 at 6:15 PM,

[pgadmin-hackers] pgAdmin 4 commit: Retain column sizing in the query tool results grid w

2017-06-08 Thread Dave Page
Retain column sizing in the query tool results grid when the same query is re-run multiple times in a row. Fixes #1971 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=2fddf750e6a664a2d82756bf896bdacad1e10b2a Author: Surinder Kumar Modified F

[pgadmin-hackers] pgAdmin 4 commit: Fix an intermittent error seen during result polling.

2017-06-08 Thread Dave Page
Fix an intermittent error seen during result polling. Fixes #2470 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=678b891ff76fea6f2c287d1eb3bc84ff242c61b4 Author: Murtuza Zabuawala Modified Files -- web/pgadmin/utils/driver/psycop

Re: [pgadmin-hackers] [pgAdmin4] To fix the error "ValueError: too many values to unpack" while polling

2017-06-08 Thread Dave Page
Zabuawala > EnterpriseDB: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > > > -- > Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) > To make changes to your subscription: > http://www.postgresql.org/mailpref/pgadmin-hackers > -- Dave Page Blog: ht

Re: [pgadmin-hackers] [pgAdmin4] To fix issues in pgAgent's modules

2017-06-08 Thread Dave Page
.com > The Enterprise PostgreSQL Company > > > -- > Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) > To make changes to your subscription: > http://www.postgresql.org/mailpref/pgadmin-hackers > -- Dave Page Blog: http://pgsnake.blogspot.com Twitt

[pgadmin-hackers] pgAdmin 4 commit: Fix various issues with pgAgent job steps and schedul

2017-06-08 Thread Dave Page
Fix various issues with pgAgent job steps and schedules: 1) Error on clicking SQL panel when Schedule OR Step node is selected in browser. Fixes #1888 2) Error while dropping Schedule OR Step node. Fixes #1889 3) Newly created Schedule/Step node was not displaying in browser. Fixes #1890 Branc

[pgadmin-hackers] pgAdmin 4 commit: Fix a couple of missing greys.

2017-06-07 Thread Dave Page
Fix a couple of missing greys. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=88737248ab9d2615ea6a16bef3913634020989f0 Author: Surinder Kumar Modified Files -- web/pgadmin/browser/templates/browser/js/node.js | 4 ++-- 1 file chan

Re: [pgadmin-hackers] [pgAdmin4][PATCH] Consolidating gray colors in the application

2017-06-07 Thread Dave Page
n Wed, Jun 7, 2017 at 6:59 PM, Robert Eckhardt > wrote: >> >> Thank you. >> >> -- Rob >> >> On Wed, Jun 7, 2017 at 9:28 AM, Surinder Kumar >> wrote: >>> >>> Sure I will send. >>> >>> On Wed, Jun 7, 2017 at 6:54 PM, Da

Re: [pgadmin-hackers] [pgAdmin4] [PATCH] History Tab rewrite in React

2017-06-07 Thread Dave Page
nt or Gulp to >>>> execute tasks. >>>> >>>> Is it possible to run the task listed above by configuring them in >>>> "scripts" in package.json file and running concurrently ? >>>> >>>> scripts: { >>>> "task-n

Re: [pgadmin-hackers] [pgAdmin4][Patch][RM_2461]: Unable to drop defaut value from the column in table

2017-06-07 Thread Dave Page
; Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) > To make changes to your subscription: > http://www.postgresql.org/mailpref/pgadmin-hackers > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Ente

[pgadmin-hackers] pgAdmin 4 commit: Allow users to remove default values from columns pro

2017-06-07 Thread Dave Page
Allow users to remove default values from columns properly. Fixes #2461 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=63c093248dfeaae41057ace0bf32c3ef1024d954 Author: Surinder Kumar Modified Files -- .../schemas/tables/templates

Re: [pgadmin-hackers] Fix for RM2421 [pgAdmin4][patch]

2017-06-07 Thread Dave Page
Can you rebase this please? I think Ashesh broke it :-p On Tue, Jun 6, 2017 at 7:42 AM, Harshal Dhumal wrote: > Hi, > > On Mon, Jun 5, 2017 at 9:25 PM, Dave Page wrote: >> >> Hi >> >> With this patch applied, it uses the field names instead of the

[pgadmin-hackers] pgAdmin 4 commit: Resolve the PG datatype feature test flakiness and ma

2017-06-07 Thread Dave Page
Resolve the PG datatype feature test flakiness and make for a nice buttery crust. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=f89aec867a3bcac337362889dfb6769188524839 Author: George Gelashvili Modified Files -- .../feature_te

Re: [pgadmin-hackers] [pgAdmin4][PATCH] Consolidating gray colors in the application

2017-06-07 Thread Dave Page
the new classes? -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgres

Re: [pgadmin-hackers] [PATCH] extract function from sqleditor

2017-06-07 Thread Dave Page
n-hackers@postgresql.org) > To make changes to your subscription: > http://www.postgresql.org/mailpref/pgadmin-hackers > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgad

[pgadmin-hackers] pgAdmin 4 commit: Extract row staging into it's own module with tests.

2017-06-07 Thread Dave Page
Extract row staging into it's own module with tests. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=8d8e7dab3c7f3f44690670614d7165474ff2265f Author: George Gelashvili Modified Files -- web/pgadmin/static/js/selection/set_staged_r

Re: [pgadmin-hackers] [pgAdmin4][PATCH] Consolidating gray colors in the application

2017-06-07 Thread Dave Page
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) > To make changes to your subscription: > http://www.postgresql.org/mailpref/pgadmin-hackers > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Ente

[pgadmin-hackers] pgAdmin 4 commit: Update the styling to use the set of grays defined in

2017-06-07 Thread Dave Page
Update the styling to use the set of grays defined in the WIP style guide. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=0d05385585d559b13f3eb8bcec83d5c41afeab30 Author: Shruti B Iyer Modified Files -- web/karma.conf.js

Re: [pgadmin-hackers] Re: [pgAdmin4][Patch][Feature #1971]: Remember column sizes between executions of the same query in the query tool

2017-06-07 Thread Dave Page
gt;> i use a hash generator function which returns unique hash for a query >>>> written in query editor and adjusted column(s) width are stored against >>>> that >>>> hash in object. >>>> >>>> Is there any way to get temporary table

Re: [pgadmin-hackers] [pgAdmin4][PATCH] To fix the issue in Synonym node EPAS9.2

2017-06-07 Thread Dave Page
p://www.enterprisedb.com > The Enterprise PostgreSQL Company > > > -- > Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) > To make changes to your subscription: > http://www.postgresql.org/mailpref/pgadmin-hackers > -- Dave Page Blog: http://pgsnake

[pgadmin-hackers] pgAdmin 4 commit: List packages in PPAS 9.2-9.4 when creating synonyms.

2017-06-07 Thread Dave Page
List packages in PPAS 9.2-9.4 when creating synonyms. Fixes #1813 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=495a3cedb05d9097d169d81814af73f3d01a7434 Author: Murtuza Zabuawala Modified Files -- .../templates/synonym/sql/9.2_p

Re: [pgadmin-hackers] [pgAdmin4][Patch]: Fixed RM 2381 - "Create Script" for view assigns incorrect schema to trigger functions in "public" schema.

2017-06-07 Thread Dave Page
nction schema name in the view SQL tab. > > > Thanks, > Khushboo > > > > -- > Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) > To make changes to your subscription: > http://www.postgresql.org/mailpref/pgadmin-hackers > -- Dave Page

[pgadmin-hackers] pgAdmin 4 commit: Fix the RE-SQL for for views to properly qualify trig

2017-06-07 Thread Dave Page
Fix the RE-SQL for for views to properly qualify trigger function names. Fixes #2381 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=b134ae2cb4d0a57833eb93e5fecece669214b16d Author: Khushboo Vashi Modified Files -- .../servers/da

Re: [pgadmin-hackers] [pgAdmin4][Patch]: Load module's JS files only when required

2017-06-06 Thread Dave Page
ack.config.js) and provide additionally global template tags to > use in Jinja templates. > > But it might not work with latest version of Webpack as this repo is not > updated since last 2 years. I need to check with latest version and I will > update on this. Given how straigh

Re: [pgadmin-hackers] [pgAdmin4][Patch]: Fixed RM 2324 - PostGIS datatypes not showing up properly on SQL tab.

2017-06-06 Thread Dave Page
On Tue, Jun 6, 2017 at 2:15 PM, Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > > > On 6 Jun 2017 18:36, "Dave Page" wrote: > > > > On Tue, Jun 6, 2017 at 1:23 PM, Khushboo Vashi < > khushboo.va...@enterprisedb.com> wrote: > >>

Re: [pgadmin-hackers] [pgAdmin4][Patch]: Fixed RM 2324 - PostGIS datatypes not showing up properly on SQL tab.

2017-06-06 Thread Dave Page
On Tue, Jun 6, 2017 at 1:23 PM, Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > > > On 6 Jun 2017 17:42, "Dave Page" wrote: > > Hi > > The table and column dialogues seem to have related problems. For example, > the table dialogue shows the

Re: [pgadmin-hackers] [pgAdmin4][Patch]: Fixed RM 2324 - PostGIS datatypes not showing up properly on SQL tab.

2017-06-06 Thread Dave Page
at 3:23 PM, Khushboo Vashi < >>>> khushboo.va...@enterprisedb.com> wrote: >>>> >>>>> Hi, >>>>> >>>>> Please find the attached patch to fix RM #2324 : PostGIS datatypes not >>>>> showing up properly on SQL tab. >&g

Re: [pgadmin-hackers] [pgAdmin4][PATCH] To fix the issue in procedure debugging in EPAS

2017-06-06 Thread Dave Page
ick review of this patch? > > -- > Regards, > Murtuza Zabuawala > EnterpriseDB: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > > > -- > Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) > To make changes to your subscription: > http

[pgadmin-hackers] pgAdmin 4 commit: Prevent attempts to debug procedures with variadic ar

2017-06-06 Thread Dave Page
Prevent attempts to debug procedures with variadic arguments. Fixes #1466 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=7e9f82bc1787ff300dbe319f18c8f9eb9dd928d3 Author: Murtuza Zabuawala Modified Files -- web/pgadmin/tools/debug

[pgadmin-hackers] pgAdmin 4 commit: Add feature tests for the View Data tool.

2017-06-06 Thread Dave Page
Add feature tests for the View Data tool. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=beda7ebbf2fde76344882625dce25f672e4240d3 Author: Surinder Kumar Modified Files -- web/pgadmin/feature_tests/test_data.json | 18 +

Re: [pgadmin-hackers] [pgAdmin4][Patch][RM_2400]: Columns with defaults set to NULL when removing contents after pasting in the edit grid

2017-06-06 Thread Dave Page
tead of finding each cell value by xpath and compare with actual > value, now a row is located using xpath and all of cell values are extracted > into an array and then compared with actual values. It eliminates the use of > wait_timeout. > > Also, I added a print statement for debuggin

Re: [pgadmin-hackers] [pgAdmin4][PATCH] Display Security Labels in SQL (PPAS9.2+)

2017-06-06 Thread Dave Page
uawala > EnterpriseDB: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > > > -- > Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) > To make changes to your subscription: > http://www.postgresql.org/mailpref/pgadmin-hackers > -- Dave Page Blog: http:

[pgadmin-hackers] pgAdmin 4 commit: Properly display security labels on EPAS 9.2+. Fixes

2017-06-06 Thread Dave Page
Properly display security labels on EPAS 9.2+. Fixes #1575 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=9803468a771f979cd2d1e44782f9fa89eefc4e6b Author: Murtuza Zabuawala Modified Files -- .../schemas/templates/schema/ppas/9.2_

Re: [pgadmin-hackers] [pgAdmin4][PATCH] To make $ quoting consistent

2017-06-06 Thread Dave Page
greSQL Company > > > -- > Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) > To make changes to your subscription: > http://www.postgresql.org/mailpref/pgadmin-hackers > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: ht

[pgadmin-hackers] pgAdmin 4 commit: Make $ quoting consistent. Fixes #1525

2017-06-06 Thread Dave Page
Make $ quoting consistent. Fixes #1525 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=cd3484d936ec76f654918c4fe7c812257b631dcd Author: Murtuza Zabuawala Modified Files -- .../schemas/functions/templates/function/pg/sql/9.2_plus/c

Re: [pgadmin-hackers] [pgAdmin4][Patch][RM_2448]: Multiple button presses to switch boolean fields

2017-06-06 Thread Dave Page
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) > To make changes to your subscription: > http://www.postgresql.org/mailpref/pgadmin-hackers > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterpris

[pgadmin-hackers] pgAdmin 4 commit: Ensure that boolean checkboxes cycle values in the co

2017-06-06 Thread Dave Page
Ensure that boolean checkboxes cycle values in the correct order. Fixes #2448 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=b82e00147879c2c3a670342263954bff72e211c9 Author: Surinder Kumar Modified Files -- .../static/js/slickgri

Re: [pgadmin-hackers] [pgAdmin4][PATCH] To fix the validation in Types node

2017-06-06 Thread Dave Page
gt; The Enterprise PostgreSQL Company > > > -- > Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) > To make changes to your subscription: > http://www.postgresql.org/mailpref/pgadmin-hackers > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter:

[pgadmin-hackers] pgAdmin 4 commit: Fix validation for external and range types. Fixes #1

2017-06-06 Thread Dave Page
Fix validation for external and range types. Fixes #1795 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=bf06d828707f965eaa76aa5c8660efc43d05d6fd Author: Murtuza Zabuawala Modified Files -- .../servers/databases/schemas/types/__in

[pgadmin-hackers] pgAdmin 4 commit: Fix default values and SQL formatting for event trigg

2017-06-06 Thread Dave Page
Fix default values and SQL formatting for event triggers. Fixes #1229 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=e6aa3e14947a0e415465fc0a96b67843e90d00ba Author: Murtuza Zabuawala Modified Files -- .../server_groups/servers/d

Re: [pgadmin-hackers] [pgAdmin4][PATCH] To fix the spacing issue in SQL for Event trigger

2017-06-06 Thread Dave Page
om > The Enterprise PostgreSQL Company > > > -- > Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) > To make changes to your subscription: > http://www.postgresql.org/mailpref/pgadmin-hackers > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgs

Re: [pgadmin-hackers] [pgAdmin4][PATCH] To fix the issue in index or exclusion contrarians node

2017-06-06 Thread Dave Page
de. > RM#2113 > > -- > Regards, > Murtuza Zabuawala > EnterpriseDB: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > > > -- > Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) > To make changes to your subscription: > http://www.

[pgadmin-hackers] pgAdmin 4 commit: Correct the validation logic when modifying indexes/e

2017-06-06 Thread Dave Page
Correct the validation logic when modifying indexes/exclusion constraints. Fixes #2113 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=4c2004d479a9401523374299791a41cb163702fa Modified Files -- .../js/exclusion_constraint.js

Re: [pgadmin-hackers] [pgAdmin4][Patch]: Fixed RM #2425 : Can't delete rows when using composite primary key

2017-06-06 Thread Dave Page
; key which has been fixed. > > Thanks, > Khushboo > > > -- > Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) > To make changes to your subscription: > http://www.postgresql.org/mailpref/pgadmin-hackers > -- Dave Page Blog: http://pgsna

[pgadmin-hackers] pgAdmin 4 commit: Handle composite primary keys correctly when deleting

2017-06-06 Thread Dave Page
Handle composite primary keys correctly when deleting rows in the Edit Grid. Fixes #2425 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=d21cbb8b1ffbd011cd5238f637580963504e3bb0 Author: Khushboo Vashi Modified Files -- .../sqledi

Re: [pgadmin-hackers] [pgAdmin4][PATCH] To enable dialog help option for Language and Foreign table node

2017-06-06 Thread Dave Page
The Enterprise PostgreSQL Company > > > -- > Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) > To make changes to your subscription: > http://www.postgresql.org/mailpref/pgadmin-hackers > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgs

[pgadmin-hackers] pgAdmin 4 commit: Enable dialogue help buttons on Language and Foreign

2017-06-06 Thread Dave Page
Enable dialogue help buttons on Language and Foreign Table dialogues. Fixes #2116 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=4b74a5ff3585b862c75a7ce4e9c37d6675be724f Author: Murtuza Zabuawala Modified Files -- .../servers/da

[pgadmin-hackers] pgAdmin 4 commit: Properly refresh the parent node when renaming childr

2017-06-06 Thread Dave Page
Properly refresh the parent node when renaming children. Fixes #2355 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=0bc9997a95114fd8d023d3369b186d9ba843a1ad Author: Murtuza Zabuawala Modified Files -- .../server_groups/servers/da

Re: [pgadmin-hackers] Declarative partitioning in pgAdmin4

2017-06-06 Thread Dave Page
On Mon, Jun 5, 2017 at 5:17 PM, Robert Eckhardt wrote: > On Mon, Jun 5, 2017 at 11:45 AM, Dave Page wrote: > >> >> >> The former is what I was bleating about when I said we needed to expose >> partitions to the user. The latter isn't relevant - declarative

[pgadmin-hackers] pgAdmin 4 commit: Display and allow toggling of trigger enable/disable

2017-06-05 Thread Dave Page
Display and allow toggling of trigger enable/disable status from the trigger dialogue. Fixes #2386 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=9e98ded06c2c80968522db1c731e941a5b8d5f32 Modified Files -- .../templates/trigger/sq

Re: [pgadmin-hackers] [pgAdmin4][Patch] Add property in trigger node to display if trigger is enabled or not

2017-06-05 Thread Dave Page
Thanks, applied. On Tue, May 30, 2017 at 5:20 PM, Murtuza Zabuawala wrote: > Hi, > > PFA updated patch for the same. > > -- > Regards, > Murtuza Zabuawala > EnterpriseDB: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > > On Tue, May 30,

Re: [pgadmin-hackers] [pgAdmin4][Patch] To display proper SQL for Procedure node

2017-06-05 Thread Dave Page
uawala > EnterpriseDB: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > > > -- > Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) > To make changes to your subscription: > http://www.postgresql.org/mailpref/pgadmin-hackers > -

[pgadmin-hackers] pgAdmin 4 commit: Handle procedure flags (IMMUTABLE STRICT SECURITY DEF

2017-06-05 Thread Dave Page
Handle procedure flags (IMMUTABLE STRICT SECURITY DEFINER PARALLEL RESTRICTED) properly in RE-SQL on EPAS. Fixes #2280 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=3f150f3f4ec395e62db3f51accb601539863b5f1 Author: Murtuza Zabuawala Modifie

Re: [pgadmin-hackers] [pgAdmin4][Patch] Make Statistics view consistent

2017-06-05 Thread Dave Page
p://www.enterprisedb.com > The Enterprise PostgreSQL Company > > > -- > Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) > To make changes to your subscription: > http://www.postgresql.org/mailpref/pgadmin-hackers > -- Dave Page Blog: http://pgsnake

[pgadmin-hackers] pgAdmin 4 commit: Cache statistics more reliably. Fixes #2357

2017-06-05 Thread Dave Page
Cache statistics more reliably. Fixes #2357 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=a4d86d24e6e664075d85461d816504c9d322f648 Author: Murtuza Zabuawala Modified Files -- web/pgadmin/misc/statistics/static/js/statistics.js |

Re: [pgadmin-hackers] Fix for RM2421 [pgAdmin4][patch]

2017-06-05 Thread Dave Page
;> + 'pgadmin-session:valid', this.model.sessChanged(), >>>>> this.model >>>>> + ); >>>>> + } >>>>> >>>>> 4) We also noticed that the following change sets look very similiar. >>

Re: [pgadmin-hackers] Declarative partitioning in pgAdmin4

2017-06-05 Thread Dave Page
t; more child partitions at the same time. For the latter, that is a workflow > that might be addressed outside of the create table with partition workflow > we're working on currently. > > > > > > On Mon, Jun 5, 2017 at 5:21 AM Dave Page wrote: > >> On Fr

Re: [pgadmin-hackers] Style guide live website - looking for feedback

2017-06-05 Thread Dave Page
ve much more subtle borders. Seems like something to fix. - I think we need some notes on when the different font sizes should be used. - You've obviously created classes for these styles (e.g. text-14). Let's make sure they are all actually defined in the stylesheets for the app

Re: [pgadmin-hackers] [pgAdmin4] To Extract or Not To Extract - That is the Question

2017-06-05 Thread Dave Page
On Fri, Jun 2, 2017 at 3:40 PM, Matthew Kleiman wrote: > We are working on this now. Should I open a bug or a feature in redmine to > track this work publicly or just keep it in our backlog only? I don't think it needs an RM - users aren't likely to care about it. -- Dave

Re: [pgadmin-hackers] Declarative partitioning in pgAdmin4

2017-06-05 Thread Dave Page
tely correct and we were >> confused. >> >> Given our new found understanding do you mind if we iterate a bit on the >> UI/UX? What we were suggesting with the daily/monthly/yearly drop down was >> a specific example of an expression. Given that fact that doesn't seem to >> be required in an MVP, however, I do think a more interactive experience >> between the definition of the child partitions and the creation of the >> partitions would be optimal. >> >> I'm not sure where you are with respect to implementing the UI but I'd >> love to float some ideas and mock ups past you. >> >> -- Rob >> > > > > -- > *Akshay Joshi* > *Principal Software Engineer * > > > > *Phone: +91 20-3058-9517 <+91%2020%203058%209517>Mobile: +91 976-788-8246 > <+91%2097678%2088246>* > > > -- > Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) > To make changes to your subscription: > http://www.postgresql.org/mailpref/pgadmin-hackers > > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company

Re: [pgadmin-hackers] Process for Creating Translations

2017-06-02 Thread Dave Page
Right, you don't need to do anything except wrap strings in the appropriate macros/functions. -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK:http://www.enterprisedb.com The Enterprise PostgreSQL Company On 2 Jun 2017, at 15:47, Matthew Kleiman wrote:

Re: [pgadmin-hackers] Process for Creating Translations

2017-06-01 Thread Dave Page
here a process for getting these text translated to other languages? I periodically update the translation templates, and then put a shout out to the translators. I try to minimise that though - I don't want to be pinging them every other commit for obvious reasons. -- Dave Page Blog: http

Re: [pgadmin-hackers] [pgAdmin4] To Extract or Not To Extract - That is the Question

2017-06-01 Thread Dave Page
ack for onSelectedRangesChanged. In > the latest commit on master (12fa02), it's from line 696 to 773. > > [image: Inline image 1] > > Sounds sensible. Do you have a proposed patch? -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company

[pgadmin-hackers] pgAdmin 4 commit: Fix a couple of issue descriptions.

2017-06-01 Thread Dave Page
Fix a couple of issue descriptions. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=12fa023c6d63c9e065708d8af2a27cedb9257456 Modified Files -- docs/en_US/release_notes_1_2.rst | 2 +- docs/en_US/release_notes_1_3.rst | 2 +- 2 files

[pgadmin-hackers] pgAdmin 4 commit: Add documented release notes.

2017-06-01 Thread Dave Page
Add documented release notes. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=54760ef3bb42d027db103e6fee71859e3dbec377 Author: Karen Blatchley Modified Files -- docs/en_US/index.rst | 1 + docs/en_US/release_notes.rst

Re: [pgadmin-hackers] [Design update] Style guide for pgAdmin4

2017-05-31 Thread Dave Page
ly. > > If people don't typically type to search or there are usually only a few > options, it can just be a dropdown. > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company

[pgadmin-hackers] pgAdmin 4 commit: Fix permissions on some files.

2017-05-31 Thread Dave Page
Fix permissions on some files. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=1b23a7912ac5e363af9c142efea2f63ced398d3f Modified Files -- docs/en_US/images/query_execute_section.png | Bin docs/en_US/images/query_output_explain.png

Re: [pgadmin-hackers] [pgadmin-support] pgAdmin4 and boolean columns

2017-05-31 Thread Dave Page
g that cell displays ‘false’. >> >> If you return to the box and click once on it, it switches to a ticked >> box – which on leaving the cell shows ‘null’. >> >> If however you double click on the cell, it converts to a ticked box >> which on leaving the cell sh

Re: [pgadmin-hackers] [pgAdmin4][Patch] Add property in trigger node to display if trigger is enabled or not

2017-05-30 Thread Dave Page
ue. Can you fix that please? > Also used node-list-by-name control instead of muti-select control for > listing table columns to simplify the logic. OK. Thanks! -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterpri

Re: [pgadmin-hackers] [pgAdmin4][RM_2424]: Menu Items don't appear in tools menu for modules that are loaded using deps

2017-05-30 Thread Dave Page
t confused when they find an option they expected to be there, isn't. Is there any way you can think of to have the menu items added at startup, but the rest of the code loaded as needed? Of course, whatever we do with Grunt/webpack will make this moot anyway, so don't spend much time on

Re: [pgadmin-hackers] pgAdmin 4 commit: Cleanup handling of default/null values when data edi

2017-05-30 Thread Dave Page
ut of addNewRow(...) and put into a > function grid.addBlankRow() and called separately for copy/paste after batch > operation is completed. > > Now copy/paste with 10k records took 2 seconds. > > Please find attached patch. > > > On Mon, May 29, 2017 at 5:19 AM, Dave Page

[pgadmin-hackers] pgAdmin 4 commit: Avoid re-rendering the edit grid for every row that i

2017-05-30 Thread Dave Page
Avoid re-rendering the edit grid for every row that is pasted. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=456096092d7fac8cc592003d930e06ea86eaa23c Author: Surinder Kumar Modified Files -- .../sqleditor/templates/sqleditor/js/

Re: [pgadmin-hackers] [pgAdmin4][runtime][patch]: RM#2398 - Proxy not bypassed for embedded server in runtime on Windows

2017-05-30 Thread Dave Page
I've applied the patch from Neel for this in commit:6e24cb038a0498cf87219104368dfcea40630440 and put a test build at https://developer.pgadmin.org/~dpage/pgadmin4-1.5-x86.exe. Please test! Thanks Neel! On Wed, May 24, 2017 at 6:53 PM, Dave Page wrote: > Good catch - thanks Neel. I don&#

Re: [pgadmin-hackers] [pgAdmin4] [PATCH] History Tab rewrite in React

2017-05-30 Thread Dave Page
er is currently looking into flask-webpack. I spent some time playing with grunt and some other options last week. However; this patch is supposed to be about the history tab rewrite. Whatever solution we use for webpacking/transpiling/linting/minifying etc, it should be a standalone change as it

[pgadmin-hackers] pgAdmin 4 commit: Ensure the runtime works correctly if a Windows user

2017-05-30 Thread Dave Page
Ensure the runtime works correctly if a Windows user has a proxy server enabled. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=6e24cb038a0498cf87219104368dfcea40630440 Author: Neel Patel Modified Files -- runtime/pgAdmin4.cpp |

Re: [pgadmin-hackers] feature test timeouts

2017-05-30 Thread Dave Page
t; > 5 tests passed > 1 test failed: > PGDataypeFeatureTest (Test checks for PG data-types output) > 0 tests skipped > > == > > Please check output in file: > /Users/edb/Documents/projects/pgadmin4/web/regression/re

Re: [pgadmin-hackers] Issue about pgadmin4

2017-05-30 Thread Dave Page
s attached to this mail. > Please see https://www.pgadmin.org/faq/#6 -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company

Re: [pgadmin-hackers] [pgAdmin4] [PATCH] History Tab rewrite in React

2017-05-28 Thread Dave Page
that should resolve "waiting for app to start" > > Thanks! > George and Joao > > On Fri, May 26, 2017 at 4:39 PM, Dave Page wrote: >> >> Hi >> >> That fixed the JS tests, however, the feature tes

Re: [pgadmin-hackers] [pgAdmin4][Patch]: Load module's JS files only when required

2017-05-28 Thread Dave Page
On Fri, May 26, 2017 at 12:01 AM, Surinder Kumar wrote: > On Fri, May 26, 2017 at 3:02 AM, Dave Page wrote: >> >> On Tue, May 23, 2017 at 4:21 PM, Dave Page wrote: >> > >> > I'm actually thinking that maybe it would be easier to start with the >>

Re: [pgadmin-hackers] Autoformatting

2017-05-28 Thread Dave Page
On Sun, May 28, 2017 at 11:54 AM, Robert Eckhardt wrote: > > > On Tue, May 9, 2017 at 4:26 AM, Dave Page wrote: >> >> >> Anyhoo, The standard we try to use in pgAdmin at the moment is slightly >> different from the example you've given. To add it into the m

Re: [pgadmin-hackers] pgAdmin 4 commit: Cleanup handling of default/null values when data edi

2017-05-28 Thread Dave Page
; re-render the grid) Copying that number of rows is an extreme case of course, but still... Is there an alternative way to batch notify? -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent

Re: [pgadmin-hackers] [pgAdmin4][Patch][RM_2400]: Columns with defaults set to NULL when removing contents after pasting in the edit grid

2017-05-27 Thread Dave Page
Hi On Sat, May 27, 2017 at 4:03 PM, Surinder Kumar wrote: > Hi Dave > > Please find update Feature test cases patch. > > On Sun, May 28, 2017 at 12:40 AM, Dave Page wrote: >> >> Thanks - I committed the code changes, as they seem to work very well. >> The re

Re: [pgadmin-hackers] [pgAdmin4][Patch][RM_2400]: Columns with defaults set to NULL when removing contents after pasting in the edit grid

2017-05-27 Thread Dave Page
>>>>> "/Users/surinder/Documents/Projects/pgadmin4/web/pgadmin/feature_tests/view_data_dml_queries.py", >> >>>>> line 125, in runTest >> >>>>> self.page.close_query_to

[pgadmin-hackers] pgAdmin 4 commit: Cleanup handling of default/null values when data edi

2017-05-27 Thread Dave Page
Cleanup handling of default/null values when data editting. FIxes #2400 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=1f26953504a963d2c2223c51f9da29db4d48594b Author: Surinder Kumar Modified Files -- .../static/js/slickgrid/slic

Re: [pgadmin-hackers] [pgAdmin4][PATCH] Improvements to Query Results Grid User Experience

2017-05-27 Thread Dave Page
On Sat, May 27, 2017 at 9:02 AM, Surinder Kumar wrote: > Hi Dave, > On Sat, May 27, 2017 at 3:07 AM, Dave Page wrote: >> >> Hi >> >> OK, so we're getting somewhere now :-). Here's what I found: >> >> - The grid looks and feels great now. Selec

[pgadmin-hackers] pgAdmin 4 commit: Increase feature test timeouts.

2017-05-27 Thread Dave Page
Increase feature test timeouts. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=10caae4dc699511a03461814ee94b5fb310a7675 Author: George Gelashvili Modified Files -- web/regression/feature_utils/pgadmin_page.py | 11 +++ 1 f

Re: [pgadmin-hackers] feature test timeouts

2017-05-27 Thread Dave Page
t; > -- > Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) > To make changes to your subscription: > http://www.postgresql.org/mailpref/pgadmin-hackers > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprise

Re: [pgadmin-hackers] [pgAdmin4][PATCH] Improvements to Query Results Grid User Experience

2017-05-26 Thread Dave Page
in.org/docs/pgadmin4/dev/submitting_patches.html Thanks! -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make chan

Re: [pgadmin-hackers] [pgAdmin4][PATCH] Improvements to Query Results Grid User Experience

2017-05-26 Thread Dave Page
r in ~/workspace/pgadmin4 > ± jp+si |master → origin {9} U:41 ?:16 ✗| → git apply > 6-adapt-slickgrid-to-pgadmin.patch > > > Maybe we should update the website with this information to help future > committers. > > Thanks > Joao & Shruti > > > On Fri, May 26, 2017 at 1

[pgadmin-hackers] pgAdmin 4 commit: Improve docs on patch creation

2017-05-26 Thread Dave Page
Improve docs on patch creation Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=6abc4c239a8eabca04f4429aeb056f910623cd16 Modified Files -- docs/en_US/submitting_patches.rst | 11 +++ 1 file changed, 11 insertions(+) -- Sen

Re: [pgadmin-hackers] [pgAdmin4] [PATCH] History Tab rewrite in React

2017-05-26 Thread Dave Page
/dev/submitting_patches.html. Sorry for > any inconvenience from generating a patch in an alternate manner earlier. > > Thanks, > Joao & Matt > > On Wed, May 24, 2017 at 9:36 AM, Matthew Kleiman > wrote: >> >> Hi Dave, >> >> This one is our bad! We did

[pgadmin-hackers] pgAdmin 4 commit: Import the ordereddict module for Python 2.6

2017-05-26 Thread Dave Page
Import the ordereddict module for Python 2.6 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=8aabee352c70a54ea777bc21033233a72122cd30 Author: Murtuza Zabuawala Modified Files -- web/pgadmin/tools/sqleditor/command.py | 5 - 1 f

Re: [pgadmin-hackers] [pgAdmin4] [PATCH] Allow user to create ENUM type without any label

2017-05-26 Thread Dave Page
labels. > RM#2426 > > -- > Regards, > Murtuza Zabuawala > EnterpriseDB: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > > > -- > Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) > To make changes to your subscription: > http://www.p

[pgadmin-hackers] pgAdmin 4 commit: Allow creation of ENUM types with no members. Fixes #

2017-05-26 Thread Dave Page
Allow creation of ENUM types with no members. Fixes #2426 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=2c9af4784e1423779c3f4a91a867d6408105ddff Author: Murtuza Zabuawala Modified Files -- .../servers/databases/schemas/types/__i

Re: [pgadmin-hackers] [pgAdmin4] [PATCH] To fix issue in UPDATE Script and Primary key order when view data

2017-05-26 Thread Dave Page
script to work. > > -- > Regards, > Murtuza Zabuawala > EnterpriseDB: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > > > -- > Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) > To make changes to your subscripti

[pgadmin-hackers] pgAdmin 4 commit: Order columns in multi-column pkeys correctly. Fixes

2017-05-26 Thread Dave Page
Order columns in multi-column pkeys correctly. Fixes #2417 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=dba64e77f133c332c339421e3a4844639ea6767e Author: Murtuza Zabuawala Modified Files -- web/pgadmin/tools/sqleditor/command.py

[pgadmin-hackers] pgAdmin 4 commit: Pass the database ID to the query tool when using the

2017-05-26 Thread Dave Page
Pass the database ID to the query tool when using the Script options. Fixes #2435 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=a45bb905f5442c5bbcff620608f83b73286deda6 Author: Murtuza Zabuawala Modified Files -- .../browser/se

<    1   2   3   4   5   6   7   8   9   10   >