Re: [pgadmin-hackers] New committer: Akshay Joshi

2016-05-06 Thread Guillaume Lelarge
Le 6 mai 2016 10:25 AM, "Dave Page" a écrit : > > All, > > I'm pleased to announce that Akshay Joshi has been added to the > pgAdmin 4 project as our newest committer. Akshay has been working on > pgAdmin 3 for a number of years now, and has done some excellent work > on pgAdmin 4, being primarily

[pgadmin-hackers] pgAdmin III commit: Disabling handler in fdw with pgsql < 9.1

2011-05-27 Thread Guillaume Lelarge
Disabling handler in fdw with pgsql < 9.1 Fix error message because of missing pg_foreign_data_wrapper.fdwhandler column with PostgresSQL < 9.1. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin3.git;a=commitdiff;h=05521bb8a89aee5dccf3f3165d87e744e41bff02 Author: Ja

Re: [pgadmin-hackers] FWD Handler with 9.0

2011-05-27 Thread Guillaume Lelarge
Le 05/27/2011 10:00 PM, Jasmin Dizdarevic a écrit : > With 1.14 Beta 1 when connecting to 9.0 and enabling FWD in browser a error > message appears: Column fwdhandler not found or similar. > My fault. I applied your patch, works great. Thanks a lot. -- Guillaume http://www.postgresql.fr http

Re: [pgadmin-hackers] PATCH: Using wxDatePickerCtrl instead of wxCalendarBox

2011-05-27 Thread Guillaume Lelarge
Le 05/27/2011 11:17 PM, Ashesh Vashi a écrit : > Hi Dave, > > For some reason, the wxCalendarBox control was not working on linux (i.e. > Ubuntu). > I found that - wxWidgets has already provided a class for that. > (wxDatePickerCtrl). > > http://docs.wxwidgets.org/stable/wx_wxdatepickerctrl.html

Re: [pgadmin-hackers] PATCH: Using wxDatePickerCtrl instead of wxCalendarBox

2011-05-28 Thread Guillaume Lelarge
On 05/28/2011 06:57 AM, Ashesh Vashi wrote: > On ubuntu 10.04 and some of the linux flavors, the wxCalendarBox is not at > all usable. > Sometimes, it even does not render the calendar properly on clicking the pop > up button, and sometimes, it does not allow to click on the calendar. > > As per m

[pgadmin-hackers] Seems you forgot to add a file to your repository

2011-05-28 Thread Guillaume Lelarge
Or maybe more than one. dd/dditems/figures/ddTextColumnFigure.cpp is missing, and I guess its header file too. Can you add them, and check nothing else is missing? so that I can compile, and check what you've done till now. Thanks. -- Guillaume http://www.postgresql.fr http://dalibo.com --

[pgadmin-hackers] pgAdmin III commit: Fix segfault when connecting to a database

2011-05-28 Thread Guillaume Lelarge
Fix segfault when connecting to a database The issue appears when you first connect to a database, and then disconnect from it. If you try to connect once again to it, you get a segmentation fault because pgAdmin will try to get the database statistics informations from a non-existent connection.

Re: [pgadmin-hackers] 1.14, Cmd +a on output grid doesn't select all lines

2011-05-28 Thread Guillaume Lelarge
On 05/07/2011 06:43 PM, Christophe Chauvet wrote: > I test PgAdmin 1.14 Beta1 on MacOS X snow-leopard and found an issue > when i want to select all lines in the datas output grid, if i press > "Cmd + a" no lines select, if i use "Ctrl + a" i can select all the > content ("Cmd + c" and "Cmd + v" wo

[pgadmin-hackers] pgAdmin III commit: Some fixes on the query tool

2011-05-28 Thread Guillaume Lelarge
Some fixes on the query tool "Database bar" has been renamed to "Connection bar". The connection bar is larger. The connection name doesn't contain the rolename. Per discussion with Erwin. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin3.git;a=commitdiff;h=c49f3b

Re: [pgadmin-hackers] Database bar

2011-05-28 Thread Guillaume Lelarge
On 05/09/2011 07:17 PM, Erwin Brandstetter wrote: > On 06.05.2011 23:40, Guillaume Lelarge wrote: >> On 05/06/2011 04:27 PM, Erwin Brandstetter wrote: >>> Hi Guillaume! >>> >>> On 05.05.2011 22:50, Guillaume Lelarge wrote: >>>>

[pgadmin-hackers] pgAdmin III commit: Fix setting a comment to a foreign table

2011-05-31 Thread Guillaume Lelarge
Fix setting a comment to a foreign table Per report from Shigeru Hanada. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin3.git;a=commitdiff;h=ab005b1f0f04ba9129c8aac65027e04225c82344 Modified Files -- pgadmin/dlg/dlgForeignTable.cpp |2 +- 1 files c

Re: [pgadmin-hackers] Discussion - Search Objects

2011-05-31 Thread Guillaume Lelarge
On Wed, 2011-06-01 at 01:05 +0200, Jasmin Dizdarevic wrote: > To better get into the code I've decided to implement a feature from > the todo list: "Ability to search a database for objects with a > specific name" > Now I have a first result, which I like to discuss with you. > > > 1. The search

Re: [pgadmin-hackers] Discussion - Search Objects

2011-06-01 Thread Guillaume Lelarge
On Wed, 2011-06-01 at 07:50 +, Dave Page wrote: > On Wed, Jun 1, 2011 at 6:06 AM, Guillaume Lelarge > wrote: > > On Wed, 2011-06-01 at 01:05 +0200, Jasmin Dizdarevic wrote: > >> To better get into the code I've decided to implement a feature from > >>

Re: [pgadmin-hackers] Discussion - Search Objects

2011-06-01 Thread Guillaume Lelarge
On Wed, 2011-06-01 at 10:05 +0200, Jasmin Dizdarevic wrote: > Can we use the pg_catalog? > pgAdmin works only by querying the PostgreSQL catalog. -- Guillaume http://blog.guillaume.lelarge.info http://www.dalibo.com -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.or

Re: [pgadmin-hackers] Object translation mechanism is, umm, broken.

2011-06-03 Thread Guillaume Lelarge
Hi, On Thu, 2011-06-02 at 08:54 +, Dave Page wrote: > [...] > This commit: > http://git.postgresql.org/gitweb?p=pgadmin3.git;a=commitdiff;h=4b8ae9d82c3b879eb02dda60908ed9590a674ec4 > (particularly the code in pgObject.cpp) is causing problems. I keep > running into objects for which we now ge

Re: [pgadmin-hackers] Hi, I'm looking the best way of doing edition of relationship figure metadata at database designer

2011-06-06 Thread Guillaume Lelarge
On Mon, 2011-06-06 at 16:27 -0430, Luis Ochoa wrote: > I'm finishing the first goal of my database designer improvement > project http://goo.gl/21rXu and now I'm adding a new metadata > information to relationship objects, with info about: match, on > delete, on update and table constraint name (fo

[pgadmin-hackers] pgAdmin III commit: Fix adding a comment to a new column

2011-06-07 Thread Guillaume Lelarge
Fix adding a comment to a new column This patch fixes a bug that occurs when a user opens table properties, selects Columns tab, and then clicks on "Add" to set column's properties (at least, name, type, and comment). The comment was ignored. Report from Aleksey Chirkin. Branch -- master De

Re: [pgadmin-hackers] Discussion - Search Objects

2011-06-07 Thread Guillaume Lelarge
On Tue, 2011-06-07 at 19:30 +0200, Jasmin Dizdarevic wrote: > In the search result list I've to build a node path. the problem is, > that node paths are language dependent. > how can i manually translate "Server > Groups/Servers/local.db/Databases/..." to > "Servergruppen/Server/local.db/Datenbank

Re: [pgadmin-hackers] Discussion - Search Objects

2011-06-07 Thread Guillaume Lelarge
On Tue, 2011-06-07 at 21:58 +0200, Jasmin Dizdarevic wrote: > I know...these are the strings that has to be translated. As I know in > pgAdmin there are language files, which are defined something like > this: > English - Foreign Language > Server Groups - Servergruppen > Help - Hilfe > > >

Re: [pgadmin-hackers] Discussion - Search Objects

2011-06-07 Thread Guillaume Lelarge
On Tue, 2011-06-07 at 21:25 +0100, Dave Page wrote: > On Tue, Jun 7, 2011 at 9:11 PM, Guillaume Lelarge > wrote: > > On Tue, 2011-06-07 at 21:58 +0200, Jasmin Dizdarevic wrote: > >> I know...these are the strings that has to be translated. As I know in > >> pgAdmin t

Re: [pgadmin-hackers] pgAdmin docs screenshots under Windows 7

2011-06-08 Thread Guillaume Lelarge
On Wed, 2011-06-08 at 10:36 +0100, Dave Page wrote: > On Wed, Jun 8, 2011 at 9:07 AM, Akshay Joshi > wrote: > > Hi > > > > I have taken all the screenshots( except one "slony-upgrade.png") of the > > pgAdmin docs from the 1.14 source tree, under Windows 7. I have uploaded the > > zip file on http:

[pgadmin-hackers] Beta2?

2011-06-10 Thread Guillaume Lelarge
Hi, I suppose beta 2 is on its way. I have one question: do I still have time to work today on the object translation mechanism, so that it can be part of it? I still have an issue on it with the Slony objects, but the rest is done. Thanks. -- Guillaume http://blog.guillaume.lelarge.info h

Re: [pgadmin-hackers] Beta2?

2011-06-10 Thread Guillaume Lelarge
On Fri, 2011-06-10 at 09:05 +0100, Dave Page wrote: > On Fri, Jun 10, 2011 at 8:01 AM, Guillaume Lelarge > wrote: > > Hi, > > > > I suppose beta 2 is on its way. I have one question: do I still have > > time to work today on the object translation mechanism, so th

[pgadmin-hackers] First test of the Database Designer

2011-06-11 Thread Guillaume Lelarge
Hi, I tried Luis's repo this morning, and here are the things I've found that still need some work before reaching the first goal: * I have an assertion each time I launch pgAdmin2 from your repo: Debug: ./src/common/cmdline.cpp(446): assert "i != (-1)" failed in Found(): unknown switch * I

Re: [pgadmin-hackers] Object translation mechanism is, umm, broken.

2011-06-11 Thread Guillaume Lelarge
On Sat, 2011-06-11 at 11:22 +0200, Guillaume Lelarge wrote: > On Fri, 2011-06-03 at 14:24 +0100, Dave Page wrote: > > On Fri, Jun 3, 2011 at 1:45 PM, Guillaume Lelarge > > wrote: > > > > > > Hi, > > > > > > On Thu, 2011-06-02 at 08:54 +,

[pgadmin-hackers] pgAdmin III commit: Update the english documentation.

2011-06-11 Thread Guillaume Lelarge
Update the english documentation. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin3.git;a=commitdiff;h=1da38be8aa13e26add020348da7ab9a41b6ed910 Modified Files -- docs/en_US/connect.html | 49 ++ docs/en_US/e

[pgadmin-hackers] pgAdmin III commit: French translation of the documentation.

2011-06-11 Thread Guillaume Lelarge
French translation of the documentation. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin3.git;a=commitdiff;h=ba8f90d8a3fdd7d14484d110487575944e0f4315 Modified Files -- docs/en_US/options.html |6 +- docs/fr_FR/connect.html

Re: [pgadmin-hackers] Database bar

2011-06-11 Thread Guillaume Lelarge
On Sat, 2011-06-11 at 16:02 +0200, Erwin Brandstetter wrote: > On 28.05.2011 15:56, Guillaume Lelarge wrote: > > On 05/09/2011 07:17 PM, Erwin Brandstetter wrote: > >> On 06.05.2011 23:40, Guillaume Lelarge wrote: > >>> On 05/06/2011 04:27 PM, Erwin Brandstet

Re: [pgadmin-hackers] Translated docs

2011-06-11 Thread Guillaume Lelarge
On Wed, 2011-06-08 at 10:54 +0100, Dave Page wrote: [...] > > Have you thought about what we should do with the translated docs for > this release? We have both French and Czech versions of the docs which > are currently out of date (not to mention the updates needed for the > English docs I menti

Re: [pgadmin-hackers] Database bar

2011-06-12 Thread Guillaume Lelarge
On Sat, 2011-06-11 at 22:24 +0200, Erwin Brandstetter wrote: > On 11.06.2011 18:16, Guillaume Lelarge wrote: > > On Sat, 2011-06-11 at 18:13 +0200, Erwin Brandstetter wrote: > >> On 11.06.2011 17:17, Guillaume Lelarge wrote: > >>> On Sat, 2011-06-11 at 16:02 +

Re: [pgadmin-hackers] First test of the Database Designer

2011-06-12 Thread Guillaume Lelarge
On Sat, 2011-06-11 at 12:58 -0430, Luis Ochoa wrote: > On Sat, Jun 11, 2011 at 3:06 AM, Guillaume Lelarge > wrote: > Hi, > > I tried Luis's repo this morning, and here are the things I've > found > that still need some work

Re: [pgadmin-hackers] Discussion - Search Objects

2011-06-12 Thread Guillaume Lelarge
On Sat, 2011-06-11 at 19:12 +0200, Jasmin Dizdarevic wrote: > Attached a patch for searching objects in a database. I've added most > of the objects, except operator-objects. I don't think that we need > them. I think we do. They are objects just like any others. > non-pgsql object types (edb, sl

Re: [pgadmin-hackers] Object translation mechanism is, umm, broken.

2011-06-13 Thread Guillaume Lelarge
On Mon, 2011-06-13 at 10:18 +0100, Dave Page wrote: > On Sat, Jun 11, 2011 at 1:37 PM, Guillaume Lelarge > wrote: > > On Sat, 2011-06-11 at 11:22 +0200, Guillaume Lelarge wrote: > >> On Fri, 2011-06-03 at 14:24 +0100, Dave Page wrote: > >> > On Fri, Jun 3, 2

[pgadmin-hackers] pgAdmin III commit: Fix our i18n support.

2011-06-13 Thread Guillaume Lelarge
Fix our i18n support. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin3.git;a=commitdiff;h=6f88f423f024d9ed5d6081c66f2351249a5bd190 Modified Files -- pgadmin/agent/pgaJob.cpp | 55 +++-- pgadmin/agent/pgaSchedule.cpp

[pgadmin-hackers] pgAdmin III commit: Forgot to increment the perspective number

2011-06-13 Thread Guillaume Lelarge
Forgot to increment the perspective number I should have done this with commit c49f3bdbf097577bc8955f47eb19ceb991351ddf. Per a report from Erwin Brandstetter. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin3.git;a=commitdiff;h=8647abd390612c590dc1f2f6f51c7c68f076

Re: [pgadmin-hackers] Database bar

2011-06-13 Thread Guillaume Lelarge
On Mon, 2011-06-13 at 00:36 +0200, Erwin Brandstetter wrote: > On 12.06.2011 08:59, Guillaume Lelarge wrote: > > On Sat, 2011-06-11 at 22:24 +0200, Erwin Brandstetter wrote: > >> On 11.06.2011 18:16, Guillaume Lelarge wrote: > >>> On Sat, 2011-06-11 at 18:13 +

[pgadmin-hackers] pgAdmin III commit: Automatic merge using stringmerge script.

2011-06-13 Thread Guillaume Lelarge
Automatic merge using stringmerge script. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin3.git;a=commitdiff;h=7ebf4c02d962436c00c872b714a4f50bdfc01c7c Modified Files -- i18n/af_ZA/pgadmin3.po | 4229 ++--- i18n/ar_SA/pgadmin3.po | 4334 ++--- i18

[pgadmin-hackers] pgAdmin III commit: Update .pot file.

2011-06-13 Thread Guillaume Lelarge
Update .pot file. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin3.git;a=commitdiff;h=6f5150b3b909c39e1c712f5e1f5602f17ba69b75 Modified Files -- pgadmin3.pot | 3582 -- 1 files changed, 2224 insert

Re: [pgadmin-hackers] Database bar

2011-06-13 Thread Guillaume Lelarge
On Mon, 2011-06-13 at 15:13 +0200, Erwin Brandstetter wrote: > On 13.06.2011 14:56, Guillaume Lelarge wrote: > > On Mon, 2011-06-13 at 00:36 +0200, Erwin Brandstetter wrote: > >> On 12.06.2011 08:59, Guillaume Lelarge wrote: > >>> On Sat, 2011-06-11 at 22:24 +

Re: [pgadmin-hackers] Cut / Paste issue

2011-06-13 Thread Guillaume Lelarge
On Mon, 2011-06-13 at 15:39 -0500, Blake McBride wrote: > Greetings, > > Interesting inconsistency in the cut / paste operation in pgAdmin. I > am using 1.14.0 beta 2. > > If you View the top 100 rows you get a spreadsheet like display > showing the rows. If you then select a row (not its data)

Re: [pgadmin-hackers] Cut / paste part 2

2011-06-13 Thread Guillaume Lelarge
On Mon, 2011-06-13 at 15:49 -0500, Blake McBride wrote: > Greetings, > > I also found that if you cut / paste multiple columns, the columns get > separated with semi-colons. For SQL it would be much better to use > commas. > Same reason. You can change it in the options dialog (tab "Query tool"

Re: [pgadmin-hackers] Cut / Paste issue

2011-06-13 Thread Guillaume Lelarge
On Tue, 2011-06-14 at 00:29 +0200, Guillaume Lelarge wrote: > On Mon, 2011-06-13 at 15:39 -0500, Blake McBride wrote: > > Greetings, > > > > Interesting inconsistency in the cut / paste operation in pgAdmin. I > > am using 1.14.0 beta 2. > > > >

[pgadmin-hackers] Branch 1.14?

2011-06-14 Thread Guillaume Lelarge
Hi, PostgreSQL already created a 9.1 branch, so that new features could be commited on head. Actually, there'll be a commitfest starting tomorrow. Should we also create a new branch, so that new features could be applied on head? I have no features right now to commit and push, but it could be in

Re: [pgadmin-hackers] Branch 1.14?

2011-06-14 Thread Guillaume Lelarge
On Tue, 2011-06-14 at 11:25 +0100, Dave Page wrote: > On Tue, Jun 14, 2011 at 11:21 AM, Guillaume Lelarge > wrote: > > Hi, > > > > PostgreSQL already created a 9.1 branch, so that new features could be > > commited on head. Actually, there'll be a commitfest st

Re: [pgadmin-hackers] Branch 1.14?

2011-06-14 Thread Guillaume Lelarge
On Tue, 2011-06-14 at 15:25 +0100, Dave Page wrote: > On Tue, Jun 14, 2011 at 2:59 PM, Guillaume Lelarge > wrote: > > On Tue, 2011-06-14 at 11:25 +0100, Dave Page wrote: > >> On Tue, Jun 14, 2011 at 11:21 AM, Guillaume Lelarge > >> wrote: > >> > Hi, >

Re: [pgadmin-hackers] Branch 1.14?

2011-06-14 Thread Guillaume Lelarge
On Tue, 2011-06-14 at 20:57 +0200, Jasmin Dizdarevic wrote: > Excuse me? *g* > Yeah, I don't think I'll have the time to work on new features now. Too much other things to do. -- Guillaume http://blog.guillaume.lelarge.info http://www.dalibo.com -- Sent via pgadmin-hackers mailing list

Re: [pgadmin-hackers] Looking for suggestions about how should I implement an action at database designer UI

2011-06-14 Thread Guillaume Lelarge
On Tue, 2011-06-14 at 00:01 -0430, Luis Ochoa wrote: > In a relationship between tables, I need to allow use of existing > columns as destination target of my foreign key columns. > Right now, when a user create a relationship between two tables, he > should select kind: from fk or from uk ( and w

Re: [pgadmin-hackers] Branch 1.14?

2011-06-14 Thread Guillaume Lelarge
On Tue, 2011-06-14 at 22:00 +0100, Dave Page wrote: > On Tuesday, June 14, 2011, Guillaume Lelarge wrote: > > On Tue, 2011-06-14 at 20:57 +0200, Jasmin Dizdarevic wrote: > >> Excuse me? *g* > >> > > > > Yeah, I don't think I'll have the time to wo

Re: [pgadmin-hackers] Branch 1.14?

2011-06-14 Thread Guillaume Lelarge
On Tue, 2011-06-14 at 23:41 +0100, Dave Page wrote: > We don't tend to remove the old code as that can lead to painful > amounts of refactoring to make things look right afterwards. If you > feel so inclined though, go ahead and do some cleanup. > I don't see why we should remove old code that st

[pgadmin-hackers] pgAdmin III commit: Update french translation

2011-06-14 Thread Guillaume Lelarge
Update french translation Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin3.git;a=commitdiff;h=9ca58d3f6ef87219a626f4a5912fd61cf348ba70 Modified Files -- i18n/fr_FR/pgadmin3.mo | Bin 299166 -> 317675 bytes i18n/fr_FR/pgadmin3.po |23494

Re: [pgadmin-hackers] Discussion - Search Objects

2011-06-14 Thread Guillaume Lelarge
On Wed, 2011-06-15 at 01:03 +0200, Jasmin Dizdarevic wrote: > Hi, > > > please take another look on it. The UI should work correctly now. > > > Linux make files should also be correct now. > It works much better now. You still have one issue with primary key (and I guess, unique constraint a

Re: [pgadmin-hackers] Branch 1.14?

2011-06-14 Thread Guillaume Lelarge
On Wed, 2011-06-15 at 08:34 +0200, Jasmin Dizdarevic wrote: > currently there are 10 versions of pgadmin for download > (http://pgadmin.org/download/windows.php) available, which works with > older versions. if someone likes to manage an older version he can > download an older client. > there are

Re: [pgadmin-hackers] Branch 1.14?

2011-06-15 Thread Guillaume Lelarge
On Wed, 2011-06-15 at 08:14 +0100, Dave Page wrote: > On Wed, Jun 15, 2011 at 6:57 AM, Guillaume Lelarge > wrote: > > On Tue, 2011-06-14 at 23:41 +0100, Dave Page wrote: > >> We don't tend to remove the old code as that can lead to painful > >> amounts of re

Re: [pgadmin-hackers] Branch 1.14?

2011-06-15 Thread Guillaume Lelarge
On Wed, 2011-06-15 at 10:00 +0200, Jasmin Dizdarevic wrote: > You're right. Patching very old releases will become more difficult. > But those patches are rare and most of the time not very large, so the > merge should not be a big problem. I'm not sure I understand. Do you mean that users will h

Re: [pgadmin-hackers] Branch 1.14?

2011-06-15 Thread Guillaume Lelarge
On Wed, 2011-06-15 at 11:11 +0100, Dave Page wrote: > On Wed, Jun 15, 2011 at 11:03 AM, Magnus Hagander wrote: > > On Wed, Jun 15, 2011 at 11:57, Dave Page wrote: > >> On Wed, Jun 15, 2011 at 10:09 AM, Guillaume Lelarge > >> wrote: > >>> We don't

[pgadmin-hackers] pgAdmin III commit: Fix the owner combobox

2011-06-15 Thread Guillaume Lelarge
Fix the owner combobox We couldn't set the owner of these objects at creation time, because pgAdmin didn't detect we changed the owner if we selected the first one. Per report and pre-patch from Miha Radej. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin3.git;a=c

Re: [pgadmin-hackers] Ownership of a new view

2011-06-15 Thread Guillaume Lelarge
Hi, On Wed, 2011-06-15 at 09:53 +0200, McAjvar wrote: > [...] > When creating a new view I've ran across some puzzling behaviour. I > made a view as a superuser and assigned view ownership to another user > who would be using it. Afterwards I was puzzled when I tried to select > data from it and i

Re: [pgadmin-hackers] Discussion - Search Objects

2011-06-15 Thread Guillaume Lelarge
On Wed, 2011-06-15 at 08:08 +0200, Guillaume Lelarge wrote: > On Wed, 2011-06-15 at 01:03 +0200, Jasmin Dizdarevic wrote: > > Hi, > > > > > > please take another look on it. The UI should work correctly now. > > > > > > Linux make files should

[pgadmin-hackers] pgAdmin III commit: Fix infinite loop when decoding options

2011-06-16 Thread Guillaume Lelarge
Fix infinite loop when decoding options ... in a foreign table with no options. Per request from Jasmin Dizdarevic. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin3.git;a=commitdiff;h=27c10443d191c97485a1acd56360ff725a548772 Modified Files -- pgadmin

Re: [pgadmin-hackers] Foreign Table without options

2011-06-16 Thread Guillaume Lelarge
On Thu, 2011-06-16 at 01:52 +0200, Jasmin Dizdarevic wrote: > There is a Problem in "void pgForeignTable::iSetOptions(const wxString > &tmpoptions)" when tmpoptions is empty (no options specified during > creation of FT) we're running into an infinite loop. > I would like to provide a patch, but cu

[pgadmin-hackers] pgAdmin III commit: Fix validate constraint with PostgreSQL < 9.1

2011-06-16 Thread Guillaume Lelarge
Fix validate constraint with PostgreSQL < 9.1 ... when creating covering index. Reported by Timon. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin3.git;a=commitdiff;h=45ff0e025e27c4cdb9d1ae224895f7ca30643034 Author: Jasmin Dizdarevic Modified Files

Re: [pgadmin-hackers] wrong sql code for fk covering index

2011-06-16 Thread Guillaume Lelarge
On Thu, 2011-06-16 at 18:45 +0200, Jasmin Dizdarevic wrote: > [...] > this patch should fix that. > Thanks, patch applied. -- Guillaume http://blog.guillaume.lelarge.info http://www.dalibo.com -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to y

Re: [pgadmin-hackers] Discussion - Search Objects

2011-06-16 Thread Guillaume Lelarge
On Wed, 2011-06-15 at 23:48 +0200, Jasmin Dizdarevic wrote: > Yeah, I know. All of the dialogs have a "binding" to some pgObject, > because all of them modifies something. No, see dlgFindAndReplace. > When I started working I had no clear picture about the class > hierarchy and I thought this wo

[pgadmin-hackers] pgAdmin III commit: Add new files to htmlhelp index

2011-06-16 Thread Guillaume Lelarge
Add new files to htmlhelp index Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin3.git;a=commitdiff;h=00e1e06351c3aca96d00d5c368388be6f5f50dda Modified Files -- docs/en_US/pgadmin3.hhc | 14 +++--- docs/en_US/pgadmin3.hhp |2 ++ docs/fr_FR/pg

Re: [pgadmin-hackers] Translated docs

2011-06-16 Thread Guillaume Lelarge
On Sun, 2011-06-12 at 11:15 +0100, Dave Page wrote: > On Sat, Jun 11, 2011 at 4:25 PM, Guillaume Lelarge > wrote: > > On Wed, 2011-06-08 at 10:54 +0100, Dave Page wrote: > > [...] > >> > >> Have you thought about what we should do with the translated docs

Re: [pgadmin-hackers] Discussion - Search Objects

2011-06-16 Thread Guillaume Lelarge
On Thu, 2011-06-16 at 20:54 +0100, Dave Page wrote: > On Thu, Jun 16, 2011 at 8:48 PM, Guillaume Lelarge > wrote: > > On Wed, 2011-06-15 at 23:48 +0200, Jasmin Dizdarevic wrote: > >> Yeah, I know. All of the dialogs have a "binding" to some pgObject, > >>

Re: [pgadmin-hackers] Discussion - Search Objects

2011-06-16 Thread Guillaume Lelarge
On Thu, 2011-06-16 at 22:31 +0200, Jasmin Dizdarevic wrote: > > > 2011/6/16 Guillaume Lelarge > On Wed, 2011-06-15 at 23:48 +0200, Jasmin Dizdarevic wrote: > > Yeah, I know. All of the dialogs have a "binding" to some > pgObject, >

Re: [pgadmin-hackers] First test of the Database Designer

2011-06-16 Thread Guillaume Lelarge
On Sat, 2011-06-11 at 09:36 +0200, Guillaume Lelarge wrote: > Hi, > > I tried Luis's repo this morning, and here are the things I've found > that still need some work before reaching the first goal: > > * I have an assertion each time I launch pgAdmin2 from your r

Re: [pgadmin-hackers] Discussion - Search Objects

2011-06-16 Thread Guillaume Lelarge
On Thu, 2011-06-16 at 23:51 +0200, Jasmin Dizdarevic wrote: > > > I suppose you're talking about "git rebase". Do a "git > rebase -i" to get > the interactive mode. Let the first commit the way it > is. Use squash for

Re: [pgadmin-hackers] Discussion - Search Objects

2011-06-16 Thread Guillaume Lelarge
On Fri, 2011-06-17 at 00:23 +0200, Jasmin Dizdarevic wrote: > > > 2011/6/17 Guillaume Lelarge > On Thu, 2011-06-16 at 23:51 +0200, Jasmin Dizdarevic wrote: > > > > > > I suppose you're talking abou

Re: [pgadmin-hackers] Replication references

2011-06-22 Thread Guillaume Lelarge
On Wed, 2011-06-22 at 18:10 +0200, Magnus Hagander wrote: > On Wed, Jun 22, 2011 at 18:03, Dave Page wrote: > > On Wed, Jun 22, 2011 at 4:53 PM, Magnus Hagander > > wrote: > >> On Mon, Jun 20, 2011 at 23:45, Peter Geoghegan > >> wrote: > >>> On 20 June 2011 21:40, Magnus Hagander wrote: > >>>

Re: [pgadmin-hackers] Replication references

2011-06-24 Thread Guillaume Lelarge
On Thu, 2011-06-23 at 11:41 +0200, Magnus Hagander wrote: > On Thu, Jun 23, 2011 at 00:07, Guillaume Lelarge > wrote: > > On Wed, 2011-06-22 at 18:10 +0200, Magnus Hagander wrote: > >> On Wed, Jun 22, 2011 at 18:03, Dave Page wrote: > >> > On Wed, Jun 22,

Re: [pgadmin-hackers] First test of the Database Designer

2011-06-25 Thread Guillaume Lelarge
Sorry for not being able to answer you before, I was without internet connection most of this week. On Thu, 2011-06-16 at 17:57 -0430, Luis Ochoa wrote: > Can you tell me how much progress you did since you started > working on > this list? I tried to compile your branch to

Re: [pgadmin-hackers] First test of the Database Designer

2011-06-25 Thread Guillaume Lelarge
On Sat, 2011-06-25 at 15:51 +0200, Guillaume Lelarge wrote: > On Sat, 2011-06-25 at 12:18 +0200, Guillaume Lelarge wrote: > > [...] > > Dave, any objection on applying the current work of Luis? I'll work this > > afternoon on the xpm files, I should be able

[pgadmin-hackers] configure "stuff"

2011-06-25 Thread Guillaume Lelarge
Hi, I received an email a few days ago (humm, weeks) about issues with compiling pgAdmin. == extract == The file pgadmin/db/keywords.c has this statement in it: #include Now it comes that pg_config does spit out either /usr/include/postgresql for the --includedir switch (for client thi

[pgadmin-hackers] pgAdmin III commit: Automatic merge using stringmerge script.

2011-06-26 Thread Guillaume Lelarge
Automatic merge using stringmerge script. Branch -- REL-1_14_0_PATCHES Details --- http://git.postgresql.org/gitweb?p=pgadmin3.git;a=commitdiff;h=93f5220d6547cb779af8e9bf2d0f17f51069e665 Modified Files -- i18n/af_ZA/pgadmin3.po | 131 +- i18n/ar_SA/pgadmin3.po | 131 +- i18n/

[pgadmin-hackers] pgAdmin III commit: Update .pot file.

2011-06-26 Thread Guillaume Lelarge
Update .pot file. Branch -- REL-1_14_0_PATCHES Details --- http://git.postgresql.org/gitweb?p=pgadmin3.git;a=commitdiff;h=e83548785f8c75dbebb5fcf5a3fd70b3c7abc932 Modified Files -- pgadmin3.pot | 129 - 1 files changed,

[pgadmin-hackers] pgAdmin III commit: Update french translation.

2011-06-26 Thread Guillaume Lelarge
Update french translation. Branch -- REL-1_14_0_PATCHES Details --- http://git.postgresql.org/gitweb?p=pgadmin3.git;a=commitdiff;h=b832710a34d77fec62115a0723e52f17e65f4e3e Modified Files -- i18n/fr_FR/pgadmin3.mo | Bin 317675 -> 317918 bytes i18n/fr_FR/pgadmin3.po |22943 +++

Re: [pgadmin-hackers] pgAdmin III commit: Rename "Replication" to "Slony Replication"

2011-06-26 Thread Guillaume Lelarge
On Mon, 2011-06-27 at 11:03 +0600, Timon wrote: > and now you should update pgadmin3.pot file :) cause translator are > preparing translation for new release :) > This is done. -- Guillaume http://blog.guillaume.lelarge.info http://www.dalibo.com -- Sent via pgadmin-hackers mailing list

[pgadmin-hackers] pgAdmin III commit: Database Designer (milestone 1 of GSoC 2011)

2011-06-27 Thread Guillaume Lelarge
Database Designer (milestone 1 of GSoC 2011) This patch adds the database designer. This new tool helps users to create their databases' schema. Lots of things still need to be implemented, but the raw features are in. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadm

Re: [pgadmin-hackers] First test of the Database Designer

2011-06-27 Thread Guillaume Lelarge
On Sun, 2011-06-26 at 20:29 +0100, Dave Page wrote: > On Sat, Jun 25, 2011 at 3:50 PM, Guillaume Lelarge > wrote: > > On Sat, 2011-06-25 at 15:51 +0200, Guillaume Lelarge wrote: > >> On Sat, 2011-06-25 at 12:18 +0200, Guillaume Lelarge wrote: > >> > [...] >

Re: [pgadmin-hackers] pgAdmin III commit: Database Designer (milestone 1 of GSoC 2011)

2011-06-27 Thread Guillaume Lelarge
On Mon, 2011-06-27 at 09:21 +0200, Magnus Hagander wrote: > Did this patch randomly update a couple of copyright years to 2011, or > were those files that were somehow forgotten in a previous run? EIther > way it looked unrelated so I figured I'd ask :-) (e.g > .pgForeignServer.cpp and pgUserMappin

Re: [pgadmin-hackers] configure "stuff"

2011-06-27 Thread Guillaume Lelarge
On Sun, 2011-06-26 at 20:35 +0100, Dave Page wrote: > On Sat, Jun 25, 2011 at 7:26 PM, Guillaume Lelarge > wrote: > > Hi, > > > > I received an email a few days ago (humm, weeks) about issues with > > compiling pgAdmin. > > > > == extract == &

Re: [pgadmin-hackers] pgAdmin III commit: Database Designer (milestone 1 of GSoC 2011)

2011-06-27 Thread Guillaume Lelarge
On Mon, 2011-06-27 at 09:31 +0200, Magnus Hagander wrote: > On Mon, Jun 27, 2011 at 09:29, Guillaume Lelarge > wrote: > > On Mon, 2011-06-27 at 09:21 +0200, Magnus Hagander wrote: > >> Did this patch randomly update a couple of copyright years to 2011, or > >> were

[pgadmin-hackers] pgAdmin III commit: Automatic merge using stringmerge script.

2011-06-27 Thread Guillaume Lelarge
Automatic merge using stringmerge script. Branch -- REL-1_14_0_PATCHES Details --- http://git.postgresql.org/gitweb?p=pgadmin3.git;a=commitdiff;h=dbfd99a3732eebe9c397df63edd68e3aa4ea7bed Modified Files -- i18n/af_ZA/pgadmin3.po | 33 +- i18n/ar_SA/pgadmin3.po | 33 +- i18n/

[pgadmin-hackers] pgAdmin III commit: Update .pot file.

2011-06-27 Thread Guillaume Lelarge
Update .pot file. Branch -- REL-1_14_0_PATCHES Details --- http://git.postgresql.org/gitweb?p=pgadmin3.git;a=commitdiff;h=0f143802e80286186985d1adf54dbc67d34f7714 Modified Files -- pgadmin3.pot | 33 +++-- 1 files changed, 15 insertions(+), 18 del

Re: [pgadmin-hackers] configure "stuff"

2011-06-27 Thread Guillaume Lelarge
On Mon, 2011-06-27 at 13:04 +0530, Ashesh Vashi wrote: > Does this take of windows-build too? (Just question out of mind...) > Yes, I didn't think of that, but the changes on pgadmin/db/keywords.c may need some changes on the Visual Studio project. -- Guillaume http://blog.guillaume.lelarge.

Re: [pgadmin-hackers] pgAdmin III commit: Database Designer (milestone 1 of GSoC 2011)

2011-06-27 Thread Guillaume Lelarge
On Mon, 2011-06-27 at 08:52 +0100, Dave Page wrote: > On Mon, Jun 27, 2011 at 8:07 AM, Guillaume Lelarge > wrote: > > Database Designer (milestone 1 of GSoC 2011) > > > > This patch adds the database designer. This new tool helps users to create > > their databases

[pgadmin-hackers] pgAdmin III commit: Update russian translation.

2011-06-27 Thread Guillaume Lelarge
Update russian translation. Branch -- REL-1_14_0_PATCHES Details --- http://git.postgresql.org/gitweb?p=pgadmin3.git;a=commitdiff;h=b001a4d546a95cb303123b1718895e2f8c7d9357 Author: Timon Modified Files -- i18n/ru_RU/pgadmin3.mo | Bin 329741 -> 383268 bytes i18n/ru_RU/pgadmi

Re: [pgadmin-hackers] Russian translation for 1.14

2011-06-27 Thread Guillaume Lelarge
On Mon, 2011-06-27 at 20:06 +0600, Timon wrote: > Hello. There is PO file for pgadmin 1.14. Tested with latest > REL-1_14_0_PATCHES branch, but suits master branch well too. Big thank > to Alexander LAW for his work. Yeah. I only commit it to the 1.14 branch. I'll commit it to the master branch wh

Re: [pgadmin-hackers] pgAdmin III commit: Database Designer (milestone 1 of GSoC 2011)

2011-06-27 Thread Guillaume Lelarge
On Mon, 2011-06-27 at 09:12 +0100, Dave Page wrote: > On Mon, Jun 27, 2011 at 9:09 AM, Guillaume Lelarge > wrote: > > On Mon, 2011-06-27 at 08:52 +0100, Dave Page wrote: > >> On Mon, Jun 27, 2011 at 8:07 AM, Guillaume Lelarge > >> wrote: > >> > D

Re: [pgadmin-hackers] Copy/Paste table(s) functions

2011-06-27 Thread Guillaume Lelarge
On Mon, 2011-06-27 at 17:25 +0200, Vladimir Kokovic wrote: > Hi, > > I don't know who and why keeps source code for copy/paste of > schema/table that I have sent. Probably because I didn't have time when you sent your patch, and that you sent another mail in the same thread about a bug you found.

Re: [pgadmin-hackers] Copy/Paste table(s) functions - git context patch

2011-06-27 Thread Guillaume Lelarge
On Mon, 2011-06-27 at 20:11 +0200, Vladimir Kokovic wrote: > Hi, > > Again, patch for Copy/Paste table(s) functions. > I tried it, there are some improvements, but, still, here are my comments. I already asked this, but had no answer. I'll ask again :) Why should the schema be different? you sh

[pgadmin-hackers] pgAdmin III commit: Handle the server include directory

2011-06-28 Thread Guillaume Lelarge
Handle the server include directory Report from Gerfried Fuchs. Branch -- REL-1_14_0_PATCHES Details --- http://git.postgresql.org/gitweb?p=pgadmin3.git;a=commitdiff;h=f9534bc154c0429d551ea72d947ab9be77bc254f Modified Files -- acinclude.m4|3 ++- pgadmin/db/ke

[pgadmin-hackers] pgAdmin III commit: Handle the server include directory

2011-06-28 Thread Guillaume Lelarge
Handle the server include directory Report from Gerfried Fuchs. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin3.git;a=commitdiff;h=4f63f7c9508ff25c37bc30a9ea3023186c1490da Modified Files -- acinclude.m4|3 ++- pgadmin/db/keywords.c |

[pgadmin-hackers] pgAdmin III commit: Fix a bug with adding tables in the DD

2011-06-28 Thread Guillaume Lelarge
Fix a bug with adding tables in the DD Only happens on Windows. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin3.git;a=commitdiff;h=bba755ed2ff29fdd383c42a79d92a1d5ba2242ae Author: Luis Ochoa Modified Files -- pgadmin/dd/dditems/utilities/ddTableName

Re: [pgadmin-hackers] pgAdmin III commit: Database Designer (milestone 1 of GSoC 2011)

2011-06-28 Thread Guillaume Lelarge
On Tue, 2011-06-28 at 19:24 +0100, Dave Page wrote: > On Tue, Jun 28, 2011 at 7:01 PM, Luis Ochoa wrote: > > Well, I really don't have any objections about change library name, but in > > fact I wrote to my mentor informing about this change a few weeks ago. > > > > I choose wxhotdraw because is a

Re: [pgadmin-hackers] pgAdmin III commit: Database Designer (milestone 1 of GSoC 2011)

2011-06-28 Thread Guillaume Lelarge
On Tue, 2011-06-28 at 14:56 +0100, Dave Page wrote: > On Mon, Jun 27, 2011 at 9:12 AM, Dave Page wrote: > > On Mon, Jun 27, 2011 at 9:09 AM, Guillaume Lelarge > > wrote: > >> On Mon, 2011-06-27 at 08:52 +0100, Dave Page wrote: > >>> On Mon, Jun 27, 2011 at 8:0

Re: [pgadmin-hackers] configure "stuff"

2011-06-29 Thread Guillaume Lelarge
On Mon, 2011-06-27 at 08:50 +0100, Dave Page wrote: > On Mon, Jun 27, 2011 at 8:32 AM, Guillaume Lelarge > wrote: > > > > diff --git a/pgadmin/db/keywords.c b/pgadmin/db/keywords.c > > index 9370a9e..0362a71 100644 > > --- a/pgadmin/db/keywords.c > > +++ b/pgad

Re: [pgadmin-hackers] pgAdmin III commit: Database Designer (milestone 1 of GSoC 2011)

2011-06-30 Thread Guillaume Lelarge
On Wed, 2011-06-29 at 20:08 +0100, Dave Page wrote: > On Wednesday, June 29, 2011, Luis Ochoa wrote: > > On Wed, Jun 29, 2011 at 3:51 AM, Dave Page wrote: > > > > > > > > On Wed, Jun 29, 2011 at 3:16 AM, Luis Ochoa wrote: > >> > >> Well, I can change that class name, but when should I do that,

  1   2   3   4   5   6   7   8   9   10   >