Re: [pgadmin-hackers] App Icons
Dave Page píše v Po 15. 12. 2014 v 16:39 +: Hi On Sun, Dec 14, 2014 at 3:56 PM, Marek Černocký ma...@manet.cz wrote: pgAdmin's icons have low quality and are not fully ready for hi-dpi monitors. Icon for Linux app is only low res and has pure quality (see attachment screenshot.png). Icon for Windows app is probably generated from a jpeg and so it has some artefacts (see attachment zoomed.png). I generated new app icons set (see attachment icons.zip): Windows icon - it's clean and has 256px variant OS X icon - it has added 1024px variant Linux icons - new set with various sizes inc. scalable variant Cool, thanks. I've updated all the existing icons, and added the new sized PNGs to the include/images directory alongside the rest. It should be updated packages specifications and pgamdin3.desktop file in /pkg to reflect this new icons. -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers
[pgadmin-hackers] Keywords in .desktop
I created the patch adding the key Keywords to pgadmin3.desktop (see http://standards.freedesktop.org/desktop-entry-spec/latest/ar01s05.html#key-keywords ) Regards Marek Černocký diff --git a/pgadmin/ui/dlgView.xrc b/pgadmin/ui/dlgView.xrc index 0b0f083..2acb469 100644 --- a/pgadmin/ui/dlgView.xrc +++ b/pgadmin/ui/dlgView.xrc @@ -1,4 +1,4 @@ -?xml version=1.0 encoding=ISO-8859-1? +?xml version=1.0 encoding=UTF-8 standalone=yes ? resource object class=wxDialog name=dlgView title/title diff --git a/pkg/pgadmin3.desktop b/pkg/pgadmin3.desktop index 1b9729c..30db0dd 100644 --- a/pkg/pgadmin3.desktop +++ b/pkg/pgadmin3.desktop @@ -8,3 +8,4 @@ Categories=Application;Development; MimeType=text/html DocPath=/usr/share/pgadmin3/docs/en_US/index.html Comment=PostgreSQL Tools +Keywords=database;db;sql;query;administration;development; -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers
Re: [pgadmin-hackers] App Icons
http://standards.freedesktop.org/icon-theme-spec/icon-theme-spec-latest.html http://standards.freedesktop.org/desktop-entry-spec/latest/ar01s05.html Essentials: - Install icons to /BUILD_ROOT/DATA_DIR/icons/hicolor/SIZE_SPEC/apps/pgadmin3.PNG|SVG (same parts of path may be distribution specific) - Use Icon=pgamdmin3 in pgadmin3.desktop - desktop shell, e.g. GNOME, KDE..., select itself suitable icon version from paths mentioned above. Currently only one icon version is installed and used (mostly old icon pgadmin3.xpm). See pkg/debian/pgadmin3.install, pkg/suse/pgadmin3.spec.in... Some distributions added other own icons outside official source code. It would nice prepare unified resources for all Linux and *nix distributions. It includes some other changes, I will post them separately. Dave Page píše v Út 16. 12. 2014 v 09:42 +: On Tue, Dec 16, 2014 at 9:35 AM, Marek Černocký ma...@manet.cz wrote: Dave Page píše v Po 15. 12. 2014 v 16:39 +: Hi On Sun, Dec 14, 2014 at 3:56 PM, Marek Černocký ma...@manet.cz wrote: pgAdmin's icons have low quality and are not fully ready for hi-dpi monitors. Icon for Linux app is only low res and has pure quality (see attachment screenshot.png). Icon for Windows app is probably generated from a jpeg and so it has some artefacts (see attachment zoomed.png). I generated new app icons set (see attachment icons.zip): Windows icon - it's clean and has 256px variant OS X icon - it has added 1024px variant Linux icons - new set with various sizes inc. scalable variant Cool, thanks. I've updated all the existing icons, and added the new sized PNGs to the include/images directory alongside the rest. It should be updated packages specifications What do you mean? and pgamdin3.desktop file in /pkg to reflect this new icons. The new icons were given the same names as the old ones. Do we need to add entries to the desktop file for multiple image sizes? If so, do you know what they should look like? -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers
Re: [pgadmin-hackers] Fwd: Wrong desktop file
I agree with your suggestions. Except for writing localized keys directly to pgadmin3.desktop It is outside translation workflow. Better way is: - Rename pgadmin3.desktop to pgadmin3.desktop.in - Add line xgettext -k -kName -kGenericName -kComment -kKeywords -o pgadmin3.pot pkg/pgadmin3.desktop.in to stringextract script - it extracts proper text from desktop file to translation template (translators translate this texts standardy way) - Generate pgadmin3.desktop from pgadmin3.desktop.in with msgfmt. Unfortunately pgadmin don't use gettext standard files and dir tree, so it may be a little tricky. Probably it needs chained generation language by language. Gettext supports this from 0.19 - it should be checked by configure script. Marek Černocký Alexey Loginov píše v Čt 27. 11. 2014 v 12:07 +0400: Hello, desktop-file-validate pgadmin3.desktop pgadmin3.desktop: warning: key Encoding in group Desktop Entry is deprecated pgadmin3.desktop: warning: value Application;Development; for key Categories in group Desktop Entry contains a deprecated value Application pgadmin3.desktop: error: value text/html for string list key MimeType in group Desktop Entry does not have a semicolon (';') as trailing character Next issues: missing GenericName for KDE, missing translations, missing /usr/share/pgadmin3/pgAdmin3.png There is a fix in attachment. Regards, Alex -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers
[pgadmin-hackers] Bad string from the translation point of view
The construction: if (wxMessageBox(_(Are you sure you wish to move objects from ) + GetQuotedFullIdentifier() + _( to ) + rdo.GetTablespace() + _(?), _(Move tablespace?), wxYES_NO) != wxYES) return; in pgadmin/schema/pgTablespace.cpp is bad from the point of view of translation. It should be: if (wxMessageBox(wxString::Format(_(Are you sure you wish to move objects from %s to %s?), GetQuotedFullIdentifier(), rdo.GetTablespace()), _(Move tablespace?), wxYES_NO) != wxYES) return; Regards Marek Černocký -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers
Re: [pgadmin-hackers] Heads-up - Beta 1
What my translation and patch http://www.postgresql.org/message-id/1366823347.15060.23.camel@sirius Can Guillaume see it. Dave Page píše v Út 18. 06. 2013 v 15:48 +0100: I plan to cut the beta 1 release on Monday. -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers
Re: [pgadmin-hackers] Hints
Dave Page píše v Čt 25. 04. 2013 v 14:54 +0100: On Wed, Apr 24, 2013 at 6:09 PM, Marek Černocký ma...@manet.cz wrote: Hi, I updated Czech version of hint files. (attachment hints-cs_CZ.zip) While testing, I found two problems with hints. 1. Displays garbage non-ASCII chars for UTF-8 encoded files. I changed code to suppose all hint files are UTF-8 encoded and load it right way. I fixed files, which didn't have UTF-8 header. Are they all UTF-8? I wouldn't be surprised if some languages were using other encodings. It concerns three languages: en_US: uses only ASCII and header change don't affect content fr_FR: 3 files have header Windows-1215 although they are saved in UTF-8 - it's anyway an bug sl_SI: uses non-ASCII chars converted to entities so header change don't affect content 2. If config file .pgadmin3 has not set item LanguageId, wxLANGUAGE_UNKNOWN is used and user see en_US hints instead by your locale. I changed it to wxLANGUAGE_DEFAULT. If memory serves, that's intentionally done to ensure it falls back to the one, guaranteed supported language. However, these are translation issues which is not an area I'm overly confident in, so I'll leave it to Guillaume to comment further. Maybe some reason for this behavior. But for user it's unfriendly. He install pgadmin3, run it first time and UI uses his language (by locale). OK. He starts work and hint popups in English. What user will think? It's untranslated. It will not explore hidden options to display it in correct language. You (or Guillaume) can suggest other code changes, but behavior should be to display hints in right language after installation straight away. Thanks. -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers
[pgadmin-hackers] Plural forms
Function frmQuery::OnPositionStc should use wxPLURAL for %d char message. Patch is attached. Regards Marek Černocký diff --git a/pgadmin/frm/frmQuery.cpp b/pgadmin/frm/frmQuery.cpp index 07f126a..d3d0097 100644 --- a/pgadmin/frm/frmQuery.cpp +++ b/pgadmin/frm/frmQuery.cpp @@ -1634,18 +1634,17 @@ void frmQuery::OnChangeStc(wxStyledTextEvent event) void frmQuery::OnPositionStc(wxStyledTextEvent event) { - int selFrom, selTo; + int selFrom, selTo, selCount; sqlQuery-GetSelection(selFrom, selTo); + selCount = selTo - selFrom; wxString pos; pos.Printf(_(Ln %d, Col %d, Ch %d), sqlQuery-LineFromPosition(sqlQuery-GetCurrentPos()) + 1, sqlQuery-GetColumn(sqlQuery-GetCurrentPos()) + 1, s SetStatusText(pos, STATUSPOS_POS); - if (selTo - selFrom == 1) - pos.Printf(_(%d char), selTo - selFrom); - else if (selTo - selFrom 1) - pos.Printf(_(%d chars), selTo - selFrom); - else + if (selCount 1) pos = wxEmptyString; + else + pos.Printf(wxPLURAL(%d char, %d chars, selCount), selCount); SetStatusText(pos, STATUSPOS_SEL); } -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers
[pgadmin-hackers] Updated cs translation - UI
Hi, I send updated Czech translation for UI. Regards Marek Černocký -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers
Re: [pgadmin-hackers] Documentation
I comprehend your concern for quality. But now I have no clear info about documentation changes. I would have to study git changelogs or do other frustration work. It has impact on documentation translation completeness and quality too. I translate Gnome (which uses own tools for work with documentation po/pot) and I don't see any problem with quality. Documentation translator is usually the same as UI translator so he has knowledge about application. I thing the limit to translation quality is translator at first, using .po is the matter in question. Guillaume Lelarge píše v Pá 24. 09. 2010 v 12:22 +0200: Le 24/09/2010 12:06, Marek Černocký a écrit : It would be nice to choice format the gettext (or similar tool) know about. It's very difficult to track changes in the current documentation for translators. Gettext really doesn't work for documentation. It's much harder to know the context of each sentence. I'm translating the PostgreSQL manuel since 7.4.7 IIRC, and I'm completely against using a .po toolchain for the french translation. It could help to make it quicker and simpler to update, but it would quickly degrade the quality of the translation. Of course, this is only my opinion, and I know some that don't agree with me on this. -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers
Re: [pgadmin-hackers] Documentation
Guillaume Lelarge píše v Pá 24. 09. 2010 v 16:20 +0200: Le 24/09/2010 15:16, Marek Černocký a écrit : I comprehend your concern for quality. But now I have no clear info about documentation changes. I would have to study git changelogs or do other frustration work. It has impact on documentation translation completeness and quality too. You just need this command: git diff REL-1_10_0_PATCHES -- docs/en_US Which gives you 439 lines of changes (many are from binary files). With this, you easily know changes on the documentation. I translate Gnome (which uses own tools for work with documentation po/pot) and I don't see any problem with quality. Documentation translator is usually the same as UI translator so he has knowledge about application. Problem is not knowledge on the software. Translating a UI is a complete different business than translating a documentation. There's not really a context when you translate a UI, but there is one when you translate a manual. Messages in .po file are sorted sequentially much like original document. And messages are full sentences or even paragraphs. Context you see directly. Documentation translation is exacting only for its length. Translating UI si difficult because you see isolated words or snippets and you must search context in application. I thing the limit to translation quality is translator at first, using .po is the matter in question. Anyway, there are tools that helps you to build .po files from various text formats. po4a for example. -- Guillaume http://www.postgresql.fr http://dalibo.com -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers
[pgadmin-hackers] Webinfo update for GIT
I see you updated web informations for GIT. But text with SVN stay on some places: Developement / GIT access Title SVN access Developement / TODO list The list below is automatically extracted from the pgAdmin SVN repository and is only available in English. Developement / Change log The change log is a record of the notable changes made to pgAdmin by the various developers. It is a manually maintained list, and as such may not include details of every minor change that has ever been made. If you need that level of detail, please check the commit messages in the SVN repository. The log below is automatically extracted from the SVN repository and is only available in English. Documentation / Introduction The documentation is automatically imported from the pgAdmin SVN source code repository, and is only available in English. Downloads / Snapshots Source tarballs and binary snapshots for a variety of platforms are built from SVN trunk daily. Other snapshots are built on a less regular basis, following programming milestones. Support / Mailinglist The version of pgAdmin you are running. If it is a development snapshot, please include the build date from the Help - About screen, and SVN repository version if known. Support / Known issues The list below is automatically extracted from the SVN repository and is only available in English. The issues listed affect to the current development code and all previous versions of pgAdmin where applicable. Regards Marek Černocký -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers
Re: [pgadmin-hackers] First SVN module moved to GIT
It would be well respectively to update the informations on the web. Regards Marek Černocký Dave Page píše v Čt 15. 07. 2010 v 21:11 +0100: As part of our move to GIT, I finally got the scripts to split the SVN repo up properly, and have now moved the pgagent repository over to git.postgresql.org. It can be accessed here: http://git.postgresql.org/gitweb?p=pgagent.git;a=summary If you are a pgAdmin committer, in order to commit to this repository you will need to ensure you have an SSH key configured in your community account profile. You can add this here: http://wwwmaster.postgresql.org/login?p=community/profile. Once you have a key, please let me know what your community login user ID is. Oh - and please ensure all commits to pgAgent go to the GIT repo from now on! Thanks! -- Dave Page EnterpriseDB UK: http://www.enterprisedb.com The Enterprise Postgres Company -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers
Re: [pgadmin-hackers] SVN Commit by guillaume: r7998 - trunk/pgadmin3/pgadmin/frm
This patch affect translateable strings. Please update POT tamplate and PO files. Marek Černocký s...@pgadmin.org píše v Po 03. 08. 2009 v 12:18 +0100: Author: guillaume Date: 2009-08-03 12:18:04 +0100 (Mon, 03 Aug 2009) New Revision: 7998 Revision summary: http://svn.pgadmin.org/cgi-bin/viewcvs.cgi/?rev=7998view=rev Log: Better l10n support on the generated reports, per a patch from Marek Cernocky. Modified: trunk/pgadmin3/pgadmin/frm/frmReport.cpp -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers
[pgadmin-hackers] Patch - translation seq stats
Hi, I send patch to do sequence statistics description translateable. Regards Marek diff --recursive -c pgadmin3.svn/pgadmin/schema/pgSequence.cpp pgadmin3.new/pgadmin/schema/pgSequence.cpp *** pgadmin3.svn/pgadmin/schema/pgSequence.cpp 2009-08-04 20:15:59.0 +0200 --- pgadmin3.new/pgadmin/schema/pgSequence.cpp 2009-08-04 20:49:42.0 +0200 *** *** 131,139 if (stats) { ! statistics-InsertItem(0, wxT(Blocks Read), PGICON_STATISTICS); statistics-SetItem(0l, 1, stats-GetVal(wxT(blks_read))); ! statistics-InsertItem(1, wxT(Blocks Hit), PGICON_STATISTICS); statistics-SetItem(1, 1, stats-GetVal(wxT(blks_hit))); delete stats; --- 131,139 if (stats) { ! statistics-InsertItem(0, _(Blocks Read), PGICON_STATISTICS); statistics-SetItem(0l, 1, stats-GetVal(wxT(blks_read))); ! statistics-InsertItem(1, _(Blocks Hit), PGICON_STATISTICS); statistics-SetItem(1, 1, stats-GetVal(wxT(blks_hit))); delete stats; -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers
Re: [pgadmin-hackers] Change: l10n patch
Dave Page píše v Po 03. 08. 2009 v 10:21 +0100: 2009/8/1 Marek Černocký ma...@manet.cz: Oops! I now see there is prepared function for translanted object types names. I send new patch instead previous. Marek Černocký píše v So 01. 08. 2009 v 17:58 +0200: Hi, I send patch. It solves translation for object type names in dialog Grand Wizard. Hi, Should there be some formatting in there to allow for languages where the ordering of the type name and the object name may differ from English? You are right. For some languages may be better use some like: wxString::Printf( _(%s %s), (wxString)wxGetTranslation(obj-GetTypeName()), obj-GetFullIdentifier() ) But it solves only little part of more bigger problem which reported here: http://code.pgadmin.org/trac/ticket/4 It has two solutions (Let's have real example Cannot drop system %s % s): --- 1. To leave it in translators Right czech translation is Nelze odstranit systémovou tabulku XXX (accusative case tabulkU). But it is substituted Nelze odstranit systemovou tabulka XXX (Nominative case tabulkA). I circumvent problem by other formulation in translation: Nelze odstranit systémový objekt: tabulka XXX (= Cannot drop system object: %s %s). Negative: It isn't universal solution. It's differnt laguage by language. --- 2. To split it to individual objekts Cannot drop system table %s Cannot drop system function %s Cannot drop system sequence %s ... Negative: There is much combinations which would increase quantities of code. Marek -- Dave Page EnterpriseDB UK: http://www.enterprisedb.com -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers
Re: [pgadmin-hackers] Change: l10n patch
Dave Page píše v Po 03. 08. 2009 v 12:26 +0100: On Mon, Aug 3, 2009 at 12:10 PM, Guillaume Lelargeguilla...@lelarge.info wrote: I tried this too, and it works AFAICT. Not sure why, in some place we use the _ and in other places, we use wxGetTranslation. wxGetTranslation isn't passed by argument -k to xgettext in stringextract script. Macro _(s) do automatic cast with macro _T(s) before call wxGetTranslation. So _(s) is useful for constant strings, which should be extracted to POT. And wxGetTranslation is useful for wxString variables (expressions are extracted elsewher, e.g by N_(s) in structure). iirc, there is a reason, but I'm darned if I can remember what it it. Of course, wxGetTranslation won't work well with the stringextract scripts. Apart from that, the code Marek wrote is looking good. I'll work on the ordering in some time. Or perhaps Marek can work on this, if he agrees. I don't know enough right know to have a good answer for you. Anyways, there are other codes in pgadmin that looks like what Marek wrote, so I think we would better apply his patch, and work on the ordering in a separate patch. OK - I'll leave this stuff in your capable hands then :-) Thanks! -- Dave Page EnterpriseDB UK: http://www.enterprisedb.com -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers
[pgadmin-hackers] l10n patch
Hi, I send patch. It solves translation for object type names in dialog Grand Wizard. Regards Marek diff --recursive -c pgadmin3.svn/pgadmin/frm/frmGrantWizard.cpp pgadmin3.new/pgadmin/frm/frmGrantWizard.cpp *** pgadmin3.svn/pgadmin/frm/frmGrantWizard.cpp 2009-08-01 16:52:58.0 +0200 --- pgadmin3.new/pgadmin/frm/frmGrantWizard.cpp 2009-08-01 17:09:30.0 +0200 *** *** 155,161 if (obj-CanEdit()) { objectArray.Add(obj); ! chkList-Append(obj-GetTypeName() + wxT( ) + obj-GetFullIdentifier()); // no translation! } } } --- 155,161 if (obj-CanEdit()) { objectArray.Add(obj); ! chkList-Append((wxString)wxGetTranslation(obj-GetTypeName()) + wxT( ) + obj-GetFullIdentifier()); } } } -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers
[pgadmin-hackers] Change: l10n patch
Oops! I now see there is prepared function for translanted object types names. I send new patch instead previous. Marek Černocký píše v So 01. 08. 2009 v 17:58 +0200: Hi, I send patch. It solves translation for object type names in dialog Grand Wizard. Regards Marek diff --recursive -c pgadmin3.svn/pgadmin/frm/frmGrantWizard.cpp pgadmin3.new/pgadmin/frm/frmGrantWizard.cpp *** pgadmin3.svn/pgadmin/frm/frmGrantWizard.cpp 2009-08-01 16:52:58.0 +0200 --- pgadmin3.new/pgadmin/frm/frmGrantWizard.cpp 2009-08-01 18:17:03.0 +0200 *** *** 155,161 if (obj-CanEdit()) { objectArray.Add(obj); ! chkList-Append(obj-GetTypeName() + wxT( ) + obj-GetFullIdentifier()); // no translation! } } } --- 155,161 if (obj-CanEdit()) { objectArray.Add(obj); ! chkList-Append(obj-GetTranslatedTypeName() + wxT( ) + obj-GetFullIdentifier()); } } } -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers
[pgadmin-hackers] Second l10n patch
Hi, I send patch. It solves translation for object type names in reports. Regards Marek diff --recursive -c pgadmin3.svn/pgadmin/frm/frmReport.cpp pgadmin3.new/pgadmin/frm/frmReport.cpp *** pgadmin3.svn/pgadmin/frm/frmReport.cpp 2009-08-01 16:52:58.0 +0200 --- pgadmin3.new/pgadmin/frm/frmReport.cpp 2009-08-01 18:51:54.0 +0200 *** *** 1199,1208 void reportObjectPropertiesFactory::GenerateReport(frmReport *report, pgObject *object) { wxString title; ! title.Printf(_(%s properties report - %s), object-GetTypeName().c_str(), object-GetIdentifier().c_str()); report-SetReportTitle(title); ! int section = report-XmlCreateSection(object-GetTypeName() + _( properties)); ctlListView *list = GetFrmMain()-GetProperties(); object-ShowProperties(); --- 1199,1208 void reportObjectPropertiesFactory::GenerateReport(frmReport *report, pgObject *object) { wxString title; ! title.Printf(_(%s properties report - %s), object-GetTranslatedTypeName().c_str(), object-GetIdentifier().c_str()); report-SetReportTitle(title); ! int section = report-XmlCreateSection(wxString::Format(_(%s properties), object-GetTranslatedTypeName().c_str())); ctlListView *list = GetFrmMain()-GetProperties(); object-ShowProperties(); *** *** 1236,1245 void reportObjectDdlFactory::GenerateReport(frmReport *report, pgObject *object) { wxString title; ! title.Printf(_(%s DDL report - %s), object-GetTypeName().c_str(), object-GetIdentifier().c_str()); report-SetReportTitle(title); ! int section = report-XmlCreateSection(object-GetTypeName() + _( DDL)); report-XmlSetSectionSql(section, object-GetSql(NULL)); } --- 1236,1245 void reportObjectDdlFactory::GenerateReport(frmReport *report, pgObject *object) { wxString title; ! title.Printf(_(%s DDL report - %s), object-GetTranslatedTypeName().c_str(), object-GetIdentifier().c_str()); report-SetReportTitle(title); ! int section = report-XmlCreateSection(wxString::Format(_(%s DDL), object-GetTranslatedTypeName().c_str())); report-XmlSetSectionSql(section, object-GetSql(NULL)); } *** *** 1271,1277 pgTable *table = (pgTable *)object; wxString title; ! title.Printf(_(%s Data dictionary report - %s), object-GetTypeName().c_str(), object-GetIdentifier().c_str()); report-SetReportTitle(title); // Columns --- 1271,1277 pgTable *table = (pgTable *)object; wxString title; ! title.Printf(_(%s Data dictionary report - %s), object-GetTranslatedTypeName().c_str(), object-GetIdentifier().c_str()); report-SetReportTitle(title); // Columns *** *** 1416,1425 void reportObjectStatisticsFactory::GenerateReport(frmReport *report, pgObject *object) { wxString title; ! title.Printf(_(%s statistics report - %s), object-GetTypeName().c_str(), object-GetIdentifier().c_str()); report-SetReportTitle(title); ! int section = report-XmlCreateSection(object-GetTypeName() + _( statistics)); ctlListView *list = GetFrmMain()-GetStatisticsCtl(); object-ShowStatistics(GetFrmMain(), list); --- 1416,1425 void reportObjectStatisticsFactory::GenerateReport(frmReport *report, pgObject *object) { wxString title; ! title.Printf(_(%s statistics report - %s), object-GetTranslatedTypeName().c_str(), object-GetIdentifier().c_str()); report-SetReportTitle(title); ! int section = report-XmlCreateSection(wxString::Format(_(%s statistics), object-GetTranslatedTypeName().c_str())); ctlListView *list = GetFrmMain()-GetStatisticsCtl(); object-ShowStatistics(GetFrmMain(), list); *** *** 1451,1460 void reportObjectDependenciesFactory::GenerateReport(frmReport *report, pgObject *object) { wxString title; ! title.Printf(_(%s dependencies report - %s), object-GetTypeName().c_str(), object-GetIdentifier().c_str()); report-SetReportTitle(title); ! int section = report-XmlCreateSection(object-GetTypeName() + _( dependencies)); ctlListView *list = GetFrmMain()-GetDependenciesCtl(); object-ShowDependencies(parent, list); --- 1451,1461 void reportObjectDependenciesFactory::GenerateReport(frmReport *report, pgObject *object) { wxString title; ! title.Printf(_(%s dependencies report - %s), object-GetTranslatedTypeName().c_str(), object-GetIdentifier().c_str()); report-SetReportTitle(title); ! int section = report-XmlCreateSection(wxString::Format(_(%s dependencies), object-GetTranslatedTypeName().c_str())); ! ctlListView *list = GetFrmMain()-GetDependenciesCtl(); object-ShowDependencies(parent, list); *** *** 1485,1494 void reportObjectDependentsFactory::GenerateReport(frmReport *report, pgObject *object) { wxString title; !
Re: [pgadmin-hackers] SVN Commit by dpage: r7952 - in trunk/www: . docs download include
It would be well to change following too: - Home / Tour ... pgAdmin III is finally available in beta ... [It isn't beta now.] - Download / Windows pgAdmin III is available for Windows ™ 2000, XP and 2003. [It don't work under Vista and Windows 7?] - Download / Mac OSX ... To install the 1.8 series ... To install the 1.6 series, ... For earlier versions ... [Missing install info for 1.10] Regards Marek s...@pgadmin.org píše v Út 30. 06. 2009 v 09:15 +0100: Author: dpage Date: 2009-06-30 09:15:37 +0100 (Tue, 30 Jun 2009) New Revision: 7952 Revision summary: http://svn.pgadmin.org/cgi-bin/viewcvs.cgi/?rev=7952view=rev Log: Update the website for 1.10 Modified: trunk/www/.htaccess trunk/www/docs/menu.php trunk/www/download/macosx.php trunk/www/download/source.php trunk/www/download/windows.php trunk/www/include/doc.php trunk/www/index.php -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers
[pgadmin-hackers] Patch for plural forms
I write patch for plural forms of translated texts. It solves second problem from report by Heikki: http://archives.postgresql.org/pgadmin-hackers/2009-05/msg00017.php It use wxPLURAL instead _. I also change stringextract script to know this. Following steps required when patche is aplied: - regenerate POT template - merge it with PO files PO files must have set Plural-Forms correctly, e.g. for czech it si: Plural-Forms: nplurals=3; plural=(n==1) ? 0 : (n=2 n=4) ? 1 : 2; \n You can find it in gettext documentation (section 10.2.5) or create new PO file from POT by msginit with appropriate param -l. Marek diff -r -c pgadmin3.svn/pgadmin/ctl/ctlSQLBox.cpp pgadmin3.new/pgadmin/ctl/ctlSQLBox.cpp *** pgadmin3.svn/pgadmin/ctl/ctlSQLBox.cpp 2009-06-10 11:04:52.0 +0200 --- pgadmin3.new/pgadmin/ctl/ctlSQLBox.cpp 2009-06-10 11:32:17.0 +0200 *** *** 192,198 GotoPos(initialPos); wxString msg; ! msg.Printf(_(%d replacements made.), count); wxMessageBox(msg, _(Replace all)); if (count) --- 192,198 GotoPos(initialPos); wxString msg; ! msg.Printf(wxPLURAL(%d replacement made., %d replacements made., count), count); wxMessageBox(msg, _(Replace all)); if (count) diff -r -c pgadmin3.svn/pgadmin/db/pgQueryThread.cpp pgadmin3.new/pgadmin/db/pgQueryThread.cpp *** pgadmin3.svn/pgadmin/db/pgQueryThread.cpp 2009-06-10 11:05:04.0 +0200 --- pgadmin3.new/pgadmin/db/pgQueryThread.cpp 2009-06-10 12:24:14.0 +0200 *** *** 145,158 insertedOid=PQoidValue(res); if (insertedOid insertedOid != (OID)-1) appendMessage(wxString::Format(_(Query inserted one row with OID %d.\n), insertedOid)); ! else ! appendMessage(wxString::Format(_(Query result with %d rows will be returned.\n), PQntuples(result))); continue; } if (lastResult) { if (PQntuples(lastResult)) ! appendMessage(wxString::Format(_(Query result with %d rows discarded.\n), PQntuples(lastResult))); PQclear(lastResult); } lastResult=res; --- 145,160 insertedOid=PQoidValue(res); if (insertedOid insertedOid != (OID)-1) appendMessage(wxString::Format(_(Query inserted one row with OID %d.\n), insertedOid)); ! else ! appendMessage(wxString::Format(wxPLURAL(Query result with %d row will be returned.\n, Query result with %d rows will be returned.\n, ! PQntuples(result)), PQntuples(result))); continue; } if (lastResult) { if (PQntuples(lastResult)) ! appendMessage(wxString::Format(wxPLURAL(Query result with %d row discarded.\n, Query result with %d rows discarded.\n, ! PQntuples(lastResult)), PQntuples(lastResult))); PQclear(lastResult); } lastResult=res; diff -r -c pgadmin3.svn/pgadmin/frm/frmEditGrid.cpp pgadmin3.new/pgadmin/frm/frmEditGrid.cpp *** pgadmin3.svn/pgadmin/frm/frmEditGrid.cpp 2009-06-10 11:05:04.0 +0200 --- pgadmin3.new/pgadmin/frm/frmEditGrid.cpp 2009-06-10 12:31:40.0 +0200 *** *** 387,393 if (limit = 0) cbLimit-SetValue(_(No limit)); else ! cbLimit-SetValue(wxString::Format(_(%i rows), limit)); } } --- 387,393 if (limit = 0) cbLimit-SetValue(_(No limit)); else ! cbLimit-SetValue(wxString::Format(wxPLURAL(%i row, %i rows, limit), limit)); } } *** *** 668,674 { int copied; copied = sqlGrid-Copy(); ! SetStatusText(wxString::Format(_(Data from %d rows copied to clipboard.), copied)); } } } --- 668,676 { int copied; copied = sqlGrid-Copy(); ! SetStatusText(wxString::Format( ! wxPLURAL(Data from %d row copied to clipboard., Data from %d rows copied to clipboard., copied), ! copied)); } } } *** *** 1062,1071 return; wxString prompt; ! if (i == 1) ! prompt.Printf(_(Are you sure you wish to delete the selected row?)); ! else ! prompt.Printf(_(Are you sure you wish to delete the %d selected rows?), i); wxMessageDialog msg(this, prompt, _(Delete rows?), wxYES_NO | wxICON_QUESTION); if (msg.ShowModal() != wxID_YES) --- 1064,1070 return; wxString prompt; ! prompt.Printf(wxPLURAL(Are you sure you wish to delete the selected row?, Are you sure you wish to delete the %d selected rows?, i)); wxMessageDialog msg(this, prompt, _(Delete rows?), wxYES_NO | wxICON_QUESTION); if (msg.ShowModal() != wxID_YES)
[pgadmin-hackers] Untranslated command line help
While pgadmin prints command line help, locale support is not initialized. So this help is always printed in english though translated strings exist. Marek -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers
[pgadmin-hackers] Translation to czech
Hi, I would like to translate pgAdmin to Czech / Čeština / cs Marek Černocký -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers