[pgadmin-hackers] pgAdmin 4 commit: Ensure the feature tests use the correct test setting

2017-06-16 Thread Dave Page
Ensure the feature tests use the correct test settings database. Fixes #2486 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=1ee555e4687dcd94cc054738076b4cb78999e81c Author: Khushboo Vashi Modified Files

Re: [pgadmin-hackers] [pgAdmin4][Patch]: Fixed #2486: Feature tests use SQLITE_PATH instead of TEST_SQLITE_PATH.

2017-06-16 Thread Dave Page
QLITE_PATH (i.e. Database path for testing). > > Thanks, > Khushboo > > > > -- > Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) > To make changes to your subscription: > http://www.postgresql.org/mailpref/pgadmin-hackers > -- Dave Page

Re: [pgadmin-hackers] Re: Server side cursor limitations for on demand loading of data in query tool [RM2137] [pgAdmin4]

2017-06-15 Thread Dave Page
Sounds good, thanks. On Thu, Jun 15, 2017 at 9:54 PM, Harshal Dhumal <harshal.dhu...@enterprisedb.com> wrote: > Hi > > On Fri, Jun 16, 2017 at 2:07 AM, Dave Page <dp...@pgadmin.org> wrote: >> >> Hi >> >> On Thu, Jun 15, 2017 at 9:30 PM, Harshal Dhum

Re: [pgadmin-hackers] Re: Server side cursor limitations for on demand loading of data in query tool [RM2137] [pgAdmin4]

2017-06-15 Thread Dave Page
Hi On Thu, Jun 15, 2017 at 9:30 PM, Harshal Dhumal <harshal.dhu...@enterprisedb.com> wrote: > Hi Dave, > > Please find attached updated patch. > > On Thu, Jun 15, 2017 at 3:58 PM, Dave Page <dp...@pgadmin.org> wrote: >> >> Hi >> >> On Wed, Jun 1

Re: [pgadmin-hackers][patch] History Detail Pane

2017-06-15 Thread Dave Page
Absolutely makes sense. >>> >>> Matt, Sarah, >>> >>> Do we understand the issues Dave is mentioning well enough to look into >>> it and tackle it? >>> >>> -- Rob >>> >>> On Wed, Jun 14, 2017 at 8:12 AM, Dave Page <dp

[pgadmin-hackers] pgAdmin 4 commit: Fix Yarn tasks for Windows

2017-06-15 Thread Dave Page
Fix Yarn tasks for Windows Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=5d45dee686056663795c0dbea5a310d8950df2e4 Modified Files -- Make-MinGW.bat | 4 ++-- Make.bat

Re: [pgadmin-hackers] Minor typo in web/config.py

2017-06-15 Thread Dave Page
in-hackers@postgresql.org) > To make changes to your subscription: > http://www.postgresql.org/mailpref/pgadmin-hackers > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via

[pgadmin-hackers] pgAdmin 4 commit: Fix a typo in the config file

2017-06-15 Thread Dave Page
Fix a typo in the config file Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=827aa72e99364cf78f57d7ac1a906f644c961e5e Author: Johan Van de Wauw Modified Files -- web/config.py | 2 +- 1 file changed, 1

Re: [pgadmin-hackers] pgAdmin 4 commit: Use a more sensible name for Query Tool tabs. Fixes #

2017-06-15 Thread Dave Page
< surinder.ku...@enterprisedb.com> wrote: > Hi Dave, > > Please find attached patch. It should work. > In previous patch I was unaware that i added untracked file to tracked. > > On Thu, Jun 15, 2017 at 4:10 PM, Dave Page <dp...@pgadmin.org> wrote: > >> Hi

[pgadmin-hackers] pgAdmin 4 commit: Fix script options which were inadvertently broken in

2017-06-15 Thread Dave Page
Fix script options which were inadvertently broken in the query tool tab naming patch. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=2a87585665049fb67ca9d51fd949b3bd7d25b077 Author: Surinder Kumar Modified

[pgadmin-hackers] pgAdmin 4 commit: Add double precision[] tests to the query tool.

2017-06-15 Thread Dave Page
Add double precision[] tests to the query tool. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=d70c3003d3fdadfbcfff4f677f25a9f3f35471cd Author: Murtuza Zabuawala Modified Files --

Re: [pgadmin-hackers] [pgAdmin4][PATCH] To fix the issue in Grant wizard

2017-06-15 Thread Dave Page
ion: > http://www.postgresql.org/mailpref/pgadmin-hackers > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes t

[pgadmin-hackers] pgAdmin 4 commit: Fix canceling of Grant Wizard on Windows. Fixes #2142

2017-06-15 Thread Dave Page
Fix canceling of Grant Wizard on Windows. Fixes #2142 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=8376d33d775ddb79ecedae93f9d969d8955693f5 Author: Murtuza Zabuawala Modified Files --

Re: [pgadmin-hackers] pgAdmin 4 commit: Use a more sensible name for Query Tool tabs. Fixes #

2017-06-15 Thread Dave Page
>> callback @ jquery-1.11.2.js:9713 >> >> >> >> >> -- >> *Harshal Dhumal* >> *Sr. Software Engineer* >> >> EnterpriseDB India: http://www.enterprisedb.com >> The Enterprise PostgreSQL Company >> >> On Tue, Jun 13, 2017 at 4:04

Re: [pgadmin-hackers] [pgAdmin4][PATCH] Improvements to Query Results Grid User Experience

2017-06-15 Thread Dave Page
On Fri, Jun 9, 2017 at 9:03 AM, Dave Page <dp...@pgadmin.org> wrote: > On Thu, Jun 8, 2017 at 7:31 PM, Sarah McAlear <smcal...@pivotal.io> wrote: >>> Thanks. When I run the tests my browser opens in some default size >>> that's always consistent, but doesn'

Re: [pgadmin-hackers][patch] History Detail Pane

2017-06-14 Thread Dave Page
mailing list (pgadmin-hackers@postgresql.org) > To make changes to your subscription: > http://www.postgresql.org/mailpref/pgadmin-hackers > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Comp

[pgadmin-hackers] pgAdmin 4 commit: Add some more Makefile targets for running different

2017-06-14 Thread Dave Page
Add some more Makefile targets for running different test suites. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=6938fbafb538997e8a37a19827b03ad402572829 Modified Files -- Makefile | 11 ++- 1 file changed, 10

Re: [pgadmin-hackers] Re: Server side cursor limitations for on demand loading of data in query tool [RM2137] [pgAdmin4]

2017-06-14 Thread Dave Page
n query with verbose >>> vi. explain query with costs >>> vii. explain analyze query >>> viii. explain analyze query with buffers >>> ix. explain analyze query with timing >>> x. auto commit disabled. >>> xi. auto commit en

Re: [pgadmin-hackers] Declarative partitioning in pgAdmin4

2017-06-14 Thread Dave Page
On Wed, Jun 14, 2017 at 1:06 PM, Ashesh Vashi <ashesh.va...@enterprisedb.com > wrote: > On Wed, Jun 14, 2017 at 1:59 PM, Dave Page <dp...@pgadmin.org> wrote: > >> >> >> On Tue, Jun 13, 2017 at 2:59 PM, Akshay Joshi < >> akshay.jo...@enterprisedb.

[pgadmin-hackers] pgAdmin 4 commit: Ensure text editors render in an appropriate place on

2017-06-14 Thread Dave Page
Ensure text editors render in an appropriate place on the results grid. Fixes #2477 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=fdc9eed51479e0057420f116f4b3b7425a12f377 Author: Surinder Kumar Modified

[pgadmin-hackers] pgAdmin 4 commit: Un-break the feature tests. Fixes from Surinder and m

2017-06-14 Thread Dave Page
Un-break the feature tests. Fixes from Surinder and myself. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=2b4a8ed89c9374fa9e0f9c0eb190662979d0bb6b Author: Surinder Kumar Modified Files --

Re: [pgadmin-hackers] [pgAdmin4][Patch][RM_2482]: Query tool/ Edit grid panel should have meaningful title

2017-06-14 Thread Dave Page
Thanks Surinder. That, along with another fix seems to have got the tests working fully again. On Tue, Jun 13, 2017 at 6:37 PM, Surinder Kumar <surinder.ku...@enterprisedb.com> wrote: > Hi > > PFA patch. > > On Tue, Jun 13, 2017 at 9:54 PM, Dave Page <dp...@pgadm

Re: [pgadmin-hackers][patch] Correct bundle test that polluted Python modules

2017-06-14 Thread Dave Page
ruti & Joao > > On Tue, Jun 13, 2017 at 10:35 AM, Dave Page <dp...@pgadmin.org> wrote: >> >> Hi >> >> On Tue, Jun 13, 2017 at 3:25 PM, Joao Pedro De Almeida Pereira >> <jdealmeidapere...@pivotal.io> wrote: >> > Hi Hackers, >> >

Re: [pgadmin-hackers] Declarative partitioning in pgAdmin4

2017-06-14 Thread Dave Page
ons will be listed in the partition list, not the Attach list. > Please review the design. Suggestions/Comments are welcome. > > > On Tue, Jun 6, 2017 at 4:30 PM, Robert Eckhardt <reckha...@pivotal.io> > wrote: > >> >> >> On Tue, Jun 6, 2017 at 4:

Re: [pgadmin-hackers] [pgAdmin4][Patch][RM_2482]: Query tool/ Edit grid panel should have meaningful title

2017-06-13 Thread Dave Page
Hmm, this seems to have broken the feature tests. Can you look at that ASAP please? I think it's because the tab text has changed. On Tue, Jun 13, 2017 at 11:34 AM, Dave Page <dp...@pgadmin.org> wrote: > Thanks, patch applied. > > On Tue, Jun 13, 2017 at 6:24 AM, Surinder Kumar

Re: [pgadmin-hackers][patch] Correct bundle test that polluted Python modules

2017-06-13 Thread Dave Page
'run', 'bundle:dev']) File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/mock/mock.py", line 947, in assert_called_once_with raise AssertionError(msg) AssertionError: Expected 'call' to be called once. Called 0 times. ------

Re: [pgadmin-hackers] pgAdmin 4 commit: Temporarily disable the Javascript bundler test until

2017-06-13 Thread Dave Page
imagine subsequent) servers. Can you take a look at this please? Thanks. On Tue, Jun 13, 2017 at 2:22 PM, Dave Page <dp...@pgadmin.org> wrote: > Temporarily disable the Javascript bundler test until it handle more than one > run. > > Branch > -- > master >

[pgadmin-hackers] pgAdmin 4 commit: Temporarily disable the Javascript bundler test until

2017-06-13 Thread Dave Page
Temporarily disable the Javascript bundler test until it handle more than one run. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=cb97722fc3826f94f375f5f48807a486383ee3a9 Modified Files --

Re: [pgadmin-hackers] [pgAdmin4] [PATCH] History Tab rewrite in React

2017-06-13 Thread Dave Page
On Tue, Jun 13, 2017 at 11:47 AM, Surinder Kumar <surinder.ku...@enterprisedb.com> wrote: > On Tue, Jun 13, 2017 at 4:05 PM, Dave Page <dp...@pgadmin.org> wrote: >> >> On Tue, Jun 13, 2017 at 11:31 AM, Surinder Kumar >> <surinder.ku...@enterprisedb.com> wro

Re: [pgadmin-hackers] [pgAdmin4] [PATCH] History Tab rewrite in React

2017-06-13 Thread Dave Page
On Tue, Jun 13, 2017 at 11:31 AM, Surinder Kumar <surinder.ku...@enterprisedb.com> wrote: > > On Tue, Jun 13, 2017 at 3:56 PM, Dave Page <dp...@pgadmin.org> wrote: >> >> On Tue, Jun 13, 2017 at 11:22 AM, Ashesh Vashi >> <ashesh.va...@enterprisedb.com> w

Re: [pgadmin-hackers] [pgAdmin4][Patch][RM_2482]: Query tool/ Edit grid panel should have meaningful title

2017-06-13 Thread Dave Page
se find attached patch > > Thanks > Surinder > > > -- > Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) > To make changes to your subscription: > http://www.postgresql.org/mailpref/pgadmin-hackers > -- Dave Page Blog: http://pgsnake.blogspot.c

[pgadmin-hackers] pgAdmin 4 commit: Use a more sensible name for Query Tool tabs. Fixes #

2017-06-13 Thread Dave Page
Use a more sensible name for Query Tool tabs. Fixes #2482 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=57d866f7b70996a82a881b20248c3285ab3a6900 Author: Surinder Kumar Modified Files --

Re: [pgadmin-hackers] [pgAdmin4] [PATCH] History Tab rewrite in React

2017-06-13 Thread Dave Page
On Tue, Jun 13, 2017 at 11:22 AM, Ashesh Vashi <ashesh.va...@enterprisedb.com> wrote: > On Tue, Jun 13, 2017 at 2:47 PM, Dave Page <dp...@pgadmin.org> wrote: >> >> And then I find a problem. Sigh. >> >> When running in the desktop runtime, under Q

Re: [pgadmin-hackers] pgAdmin 4 commit: Required mock package for python < 3.3.

2017-06-13 Thread Dave Page
t; >> >> >> *http://www.linkedin.com/in/asheshvashi* >> <http://www.linkedin.com/in/asheshvashi> >> >> On Tue, Jun 13, 2017 at 3:50 PM, Dave Page <dp...@pgadmin.org> wrote: >> >>> Is mock required at runtime, or just for tests? It's a

Re: [pgadmin-hackers] pgAdmin 4 commit: Required mock package for python < 3.3.

2017-06-13 Thread Dave Page
t (pgadmin-hackers@postgresql.org) > To make changes to your subscription: > http://www.postgresql.org/mailpref/pgadmin-hackers -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgadmin-hac

Re: [pgadmin-hackers] [pgAdmin4] [PATCH] Skip CheckForViewDataTest test based on the DB version

2017-06-13 Thread Dave Page
-hackers mailing list (pgadmin-hackers@postgresql.org) > To make changes to your subscription: > http://www.postgresql.org/mailpref/pgadmin-hackers > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterpris

[pgadmin-hackers] pgAdmin 4 commit: Skip a test that uses the COLLATE option on PG versio

2017-06-13 Thread Dave Page
Skip a test that uses the COLLATE option on PG versions below 9.1 (e.g. Greenplum). Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=a9ce9c97173e904792073597f90ff30c4bfdc1fc Author: Joao Pedro De Almeida Pereira

Re: [pgadmin-hackers] [pgAdmin4][Patch][RM_ 2477]: New Line text edit pop up renders off page when the size of the grid exceeds the size of the window

2017-06-13 Thread Dave Page
ship it with the app. >>> >>> I prefer 1 if possible, then 2, finally 3. >>> >>> Shirley, any thoughts? > > > Option 1 would require us choosing something new and free (there are a lot > of webfonts you can get from Google) but would take some time to pi

Re: [pgadmin-hackers] [pgAdmin4][Patch]: Added the shortcut (CTRL + 0) to reset the zoom level in runtime

2017-06-13 Thread Dave Page
Nice work! Committed (along with an update to the docs). Congratulations on your first C++ patch :-) On Tue, Jun 13, 2017 at 7:07 AM, Khushboo Vashi <khushboo.va...@enterprisedb.com> wrote: > Hi, > > On Mon, Jun 12, 2017 at 5:27 PM, Dave Page <dp...@pgadmin.org> wrote: >&

[pgadmin-hackers] pgAdmin 4 commit: Add a shortcut (Ctrl/Cmd + 0 (zero)) to the runtime t

2017-06-13 Thread Dave Page
Add a shortcut (Ctrl/Cmd + 0 (zero)) to the runtime to allow the zoom level to be reset. Fixes #2485 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=3a5fda44e400492bd76811906f5261334d819956 Author: Khushboo Vashi

Re: [pgadmin-hackers] [pgAdmin4] [PATCH] History Tab rewrite in React

2017-06-13 Thread Dave Page
o applied - thanks! Could you answer my earlier question about the need for the delay in app_starter.py please? Thanks. > On Mon, Jun 12, 2017 at 12:15 PM Dave Page <dp...@pgadmin.org> wrote: >> >> To add to that; running the JS tests gives: >> >> ERROR in ./regr

[pgadmin-hackers] pgAdmin 4 commit: Initial re-vamp of the History tab.

2017-06-13 Thread Dave Page
Initial re-vamp of the History tab. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=1208206bc0eca2d135469258e8a209b983e668be Author: Shruti B Iyer Modified Files -- web/.eslintrc.js

Re: [pgadmin-hackers] [pgAdmin4][Patch]: Fixed RM 2324 - PostGIS datatypes not showing up properly on SQL tab.

2017-06-13 Thread Dave Page
Thanks, applied. On Tue, Jun 13, 2017 at 4:45 AM, Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > Hi, > > On Mon, Jun 12, 2017 at 8:24 PM, Dave Page <dp...@pgadmin.org> wrote: > >> Hi Khushboo, >> >> Looks like this patch broke the regressi

[pgadmin-hackers] pgAdmin 4 commit: Fix the fix for RM2324.

2017-06-13 Thread Dave Page
Fix the fix for RM2324. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=16a15bf9344ed9938cade6eb7090cd7149c4b550 Author: Khushboo Vashi Modified Files --

Re: [pgadmin-hackers] PG Admin 4

2017-06-13 Thread Dave Page
ntended for the addressee only. It may contain > confidential and legally privileged information. If you are not the > intended recipient, please reply to advise the sender and do not disclose, > copy or redistribute this document or any information contained herein. > > Please consider the environment before printing this email. > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company

Re: [pgadmin-hackers] [pgAdmin4] [PATCH] Translatable Text in Query Results Header

2017-06-12 Thread Dave Page
; Matt and Shruti > > > -- > Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) > To make changes to your subscription: > http://www.postgresql.org/mailpref/pgadmin-hackers > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB

[pgadmin-hackers] pgAdmin 4 commit: Bring React into the tree, and add linting and bundli

2017-06-12 Thread Dave Page
Bring React into the tree, and add linting and bundling framework for the JS etc. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=659eb1c1e821e2ea414dc00d22022b8a2d7c91f7 Author: Shruti B Iyer Modified Files --

[pgadmin-hackers] pgAdmin 4 commit: Add a missing translation call.

2017-06-12 Thread Dave Page
Add a missing translation call. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=f1acad85db4b9bf8a201cd8b6d90c703322a0073 Author: Shruti B Iyer Modified Files -- web/pgadmin/static/js/selection/grid_selector.js |

[pgadmin-hackers] pgAdmin 4 commit: Add linting support, and, well, lint.

2017-06-12 Thread Dave Page
Add linting support, and, well, lint. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=3f4f8b9e77204a62ecdbf99caf296b6ac39b0f5e Author: Shruti B Iyer Modified Files -- web/.eslintrc.js

Re: [pgadmin-hackers] [pgAdmin4] [PATCH] History Tab rewrite in React

2017-06-12 Thread Dave Page
Also, while I think of it, why the addition of the delay to app_starter.py? On Mon, Jun 12, 2017 at 5:12 PM, Dave Page <dp...@pgadmin.org> wrote: > Hi, > > So 01 and 02 are now committed :-). > > 03 has a couple of problems though (likely the same): > > - Running the webpac

[pgadmin-hackers] PACKAGERS BEWARE: Build changes required

2017-06-12 Thread Dave Page
/packager will need to do this. 2) Web-packing of all the JS and CSS code. This will minimise all the JS/CSS to reduce file transfer sizes, and bundle it together into as few files as possible to minimise client/server round trips. 3) A move towards React to improve UI rendering/generation etc. -- Dave

Re: [pgadmin-hackers] [pgAdmin4][Patch][Feature_1535]: Pressing ESC from within a dialog box should act like "Cancel" button

2017-06-12 Thread Dave Page
Thanks, applied. On Mon, Jun 12, 2017 at 3:52 PM, Surinder Kumar <surinder.ku...@enterprisedb.com> wrote: > Hi Dave, > > Please find updated patch. > > On Mon, Jun 12, 2017 at 7:58 PM, Dave Page <dp...@pgadmin.org> wrote: >> >> Hi >> >&

[pgadmin-hackers] pgAdmin 4 commit: Teach dialogues about Escape to cancel, Enter to Save

2017-06-12 Thread Dave Page
Teach dialogues about Escape to cancel, Enter to Save/OK, and F1 for help. Fixes #1535 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=af43ccfc07bd1f919015b79ce9c9e7e06d92cf6a Author: Surinder Kumar Modified

Re: [pgadmin-hackers] [pgAdmin4][Patch]: Fixed RM 2324 - PostGIS datatypes not showing up properly on SQL tab.

2017-06-12 Thread Dave Page
_formatter(tid, data) File "/Users/pivotal/workspace/pgadmin4/web/pgadmin/browser/ server_groups/servers/databases/schemas/tables/__init__.py", line 663, in _columns_formatter column['attlen'] = matchObj.group(1) AttributeError: 'NoneType' object has no attribute 'group' On Mon,

Re: [pgadmin-hackers] [pgAdmin4] [PATCH] History Tab rewrite in React

2017-06-12 Thread Dave Page
rvers/databases/schemas/tables/__init__.py", > line 663, in _columns_formatter > column['attlen'] = matchObj.group(1) > AttributeError: 'NoneType' object has no attribute 'group' > > Was this introduced in a previous patch? Yes, it looks like it. For some reason it's not failing o

Re: [pgadmin-hackers] [pgAdmin4][Patch][RM_ 2477]: New Line text edit pop up renders off page when the size of the grid exceeds the size of the window

2017-06-12 Thread Dave Page
oose something completely new and free, and ship it with the app. I prefer 1 if possible, then 2, finally 3. Shirley, any thoughts? > On Mon, Jun 12, 2017 at 6:16 PM, Dave Page <dp...@pgadmin.org> wrote: >> >> Hi >> >> Can you update this so that the CSS all

Re: [pgadmin-hackers] [pgAdmin4][Patch][Feature_1535]: Pressing ESC from within a dialog box should act like "Cancel" button

2017-06-12 Thread Dave Page
inue to work. I tried moving the: if (panel && panel['_type'] !== 'node_props') return; into the branch for keyCode.ENTER, but that doesn't seem to help. -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL

Re: [pgadmin-hackers] [pgAdmin4][PATCH] To fix the issue in Role Membership control

2017-06-12 Thread Dave Page
2086 > > -- > Regards, > Murtuza Zabuawala > EnterpriseDB: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > > > -- > Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) > To make changes to your subscription: > http://www.postgr

[pgadmin-hackers] pgAdmin 4 commit: Allow editing of the WITH ADMIN option of role member

2017-06-12 Thread Dave Page
Allow editing of the WITH ADMIN option of role membership. Fixes #2086 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=ec5bc23dfdb41da1b5ccd4ab2ab2e6244d8b5ebd Author: Murtuza Zabuawala Modified Files

Re: [pgadmin-hackers] [pgAdmin4][Patch][Feature_1535]: Pressing ESC from within a dialog box should act like "Cancel" button

2017-06-12 Thread Dave Page
Hi Is that the correct patch? Hitting in a comment text area is still causing the dialogue to close. Thanks. On Mon, Jun 12, 2017 at 12:55 PM, Surinder Kumar <surinder.ku...@enterprisedb.com> wrote: > Hi > > Please find rebased patch > > Thanks > > On Mon, Jun 12,

[pgadmin-hackers] pgAdmin 4 commit: Refresh the SQL editor view on resize to ensure the c

2017-06-12 Thread Dave Page
Refresh the SQL editor view on resize to ensure the contents are re-rendered for the new viewport. Fixes #2078 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=3743c6e86ed74b8ae6f4776f27e1555c4ee64e89 Author: Murtuza Zabuawala

Re: [pgadmin-hackers] [pgAdmin4][PATCH] CREATE Script do not display properly on panel resize

2017-06-12 Thread Dave Page
> Regards, > Murtuza Zabuawala > EnterpriseDB: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > > > -- > Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) > To make changes to your subscription: > http://www.postgresql.org/mailpref/pgadmin-hackers >

Re: [pgadmin-hackers] [pgAdmin4][PATCH] To fix the issue in displaying Trigger SQL

2017-06-12 Thread Dave Page
changes to your subscription: > http://www.postgresql.org/mailpref/pgadmin-hackers > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgadmin-hackers mailing list (pgadmin-hac

[pgadmin-hackers] pgAdmin 4 commit: Properly handle trigger functions with parameters. Fi

2017-06-12 Thread Dave Page
Properly handle trigger functions with parameters. Fixes #2043 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=c435d488853b7b52f33b8d01fe98b5938e6fd835 Author: Murtuza Zabuawala Modified Files

Re: [pgadmin-hackers] [pgAdmin4][Patch]: Added the shortcut (CTRL + 0) to reset the zoom level in runtime

2017-06-12 Thread Dave Page
I don't think resetting to the startup value is really what we want. Shouldn't it reset it to 1.0? -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgadmin-hackers mailing list (pgadmi

[pgadmin-hackers] pgAdmin 4 commit: Fix the PostGIS Datatypes in SQL tab, Create / Update

2017-06-12 Thread Dave Page
Fix the PostGIS Datatypes in SQL tab, Create / Update dialogues for Table, Column, Foreign Table and Type node. Fixes #2324 Note that this doesn't add full support for PostGIS types to the table/column dialogues, which still can't handle the typmod usage. It does bring support to parity with

Re: [pgadmin-hackers] [pgAdmin4][Patch]: Fixed RM 2324 - PostGIS datatypes not showing up properly on SQL tab.

2017-06-12 Thread Dave Page
with Dave, I have logged RM #2473 > <https://redmine.postgresql.org/issues/2473> to add support for PostGIS > Datatypes. > > Thanks, > Khushboo > > On Tue, Jun 6, 2017 at 6:49 PM, Dave Page <dp...@pgadmin.org> wrote: > >> >> >> On Tue, Jun 6, 2017 at 2:15 PM, Khush

[pgadmin-hackers] pgAdmin 4 commit: Stop ignoring yarn.lock, per discussion with Pivotal

2017-06-12 Thread Dave Page
Stop ignoring yarn.lock, per discussion with Pivotal team. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=59da69087cd32ea9e4996f87bae62c8c31dc632b Author: George Gelashvili Modified Files -- .gitignore

[pgadmin-hackers] pgAdmin 4 commit: Another minor perf tweak for the runtime.

2017-06-11 Thread Dave Page
Another minor perf tweak for the runtime. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=ef4b8e8c1c563d51641c2eb2f2f81475a00a09d9 Modified Files -- runtime/Server.cpp | 1 + 1 file changed, 1 insertion(+) -- Sent via

[pgadmin-hackers] pgAdmin 4 commit: Couple of minor performance tweaks. Tests on my Windo

2017-06-11 Thread Dave Page
Couple of minor performance tweaks. Tests on my Windows VM show a consistent 30% startup time reduction. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=f0d287588ace15dee3e4e9447ec54d9b4fef8491 Modified Files --

Re: [pgadmin-hackers] Re: [pgAdmin4][Patch][Feature #1971]: Remember column sizes between executions of the same query in the query tool

2017-06-09 Thread Dave Page
umns. > > PFA patch. > > On Thu, Jun 8, 2017 at 5:12 PM, Dave Page <dp...@pgadmin.org> wrote: >> >> Nice! Thanks, patch applied. >> >> On Wed, Jun 7, 2017 at 4:03 PM, Surinder Kumar >> <surinder.ku...@enterprisedb.com> wrote: >> > PFA

[pgadmin-hackers] pgAdmin 4 commit: Fine tune result grid column sizing now we don't have

2017-06-09 Thread Dave Page
Fine tune result grid column sizing now we don't have checkboxes. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=49976b193476c7626c305853c23cbf9a98af68e8 Author: Surinder Kumar Modified Files --

Re: [pgadmin-hackers] [pgAdmin4][Patch][Feature_1535]: Pressing ESC from within a dialog box should act like "Cancel" button

2017-06-09 Thread Dave Page
.ku...@enterprisedb.com> wrote: > Hi > > Please find updated patch. > > Thanks, > Surinder > > On Thu, Jun 8, 2017 at 7:16 PM, Dave Page <dp...@pgadmin.org> wrote: >> >> Hi >> >> On Thu, Jun 8, 2017 at 5:38 AM, Surinder Kumar >> <surind

Re: [pgadmin-hackers][patch] Changing the ACI tree font to Helvetica

2017-06-09 Thread Dave Page
gt; > -- > Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) > To make changes to your subscription: > http://www.postgresql.org/mailpref/pgadmin-hackers > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterpr

[pgadmin-hackers] pgAdmin 4 commit: Use the correct font for the treeview.

2017-06-09 Thread Dave Page
Use the correct font for the treeview. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=ee4a84778457e3ca022be4e2c7f730c98a5e3422 Author: Sarah McAlear Modified Files --

Re: [pgadmin-hackers] [pgAdmin4][PATCH] Improvements to Query Results Grid User Experience

2017-06-09 Thread Dave Page
generate_series(1, 5)" > The issue was still present for us when we ran the app at each of 2fddf750 > and 495a3cedb > Could we move this discussion to a new thread as it doesn't seem related to > these changes? Something in these changes caused it to start manifesting, but I

Re: [pgadmin-hackers] [pgAdmin4][Patch]: UI improvements in data-grid/query tool

2017-06-08 Thread Dave Page
p; > right > border > color is changed to #888 to match with bottom > border > (#888) > , now the header can easily be distinguished from the grid rows border > styling. > > Please review and let me know if any changes. > > > On Thu, Jun 8, 2017 at 7:51 PM, Dave P

Re: [pgadmin-hackers] [pgAdmin4][Patch][RM_2450] : Internal Server Error displayed if click on statistic tab for PG 10 server

2017-06-08 Thread Dave Page
sion number system instead of 3, I think the directory name should be 10_plus shouldn't it? Will that work with the template search code? If not, can you please fix that as well? Thanks! -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com

Re: [pgadmin-hackers] [pgAdmin4][Patch]: UI improvements in data-grid/query tool

2017-06-08 Thread Dave Page
ese changes, the vertical scrollbar which appears at >> data-grid right side seems to fixed. >> >> PFA patch and review. >> >> >> Thanks, >> Surinder >> >> >> -- >> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postg

Re: [pgadmin-hackers] [pgAdmin4][PATCH] Improvements to Query Results Grid User Experience

2017-06-08 Thread Dave Page
Hi On Thu, Jun 8, 2017 at 2:18 PM, Sarah McAlear <smcal...@pivotal.io> wrote: > On Thu, Jun 8, 2017 at 8:34 AM, Dave Page <dp...@pgadmin.org> wrote: >> - There are changes to SlickGrid, the addition of a function to scroll >> a column into view. Is this submitted up

Re: [pgadmin-hackers] Fix for RM2421 [pgAdmin4][patch]

2017-06-08 Thread Dave Page
eSQL Company > > On Wed, Jun 7, 2017 at 6:59 PM, Dave Page <dp...@pgadmin.org> wrote: >> >> Can you rebase this please? I think Ashesh broke it :-p >> >> On Tue, Jun 6, 2017 at 7:42 AM, Harshal Dhumal >> <harshal.dhu...@enterprisedb.com> wrote: >>

[pgadmin-hackers] pgAdmin 4 commit: Fix integer/numeric validation on various dialogues.

2017-06-08 Thread Dave Page
Fix integer/numeric validation on various dialogues. Fixes #2421 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=aa400cbc12f34f219322a2b62f9f51e21d031f0e Author: Harshal Dhumal Modified Files --

Re: [pgadmin-hackers] [pgAdmin4][PATCH] Fix handling of double precision[] type

2017-06-08 Thread Dave Page
dmin-hackers mailing list (pgadmin-hackers@postgresql.org) > To make changes to your subscription: > http://www.postgresql.org/mailpref/pgadmin-hackers > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Co

[pgadmin-hackers] pgAdmin 4 commit: Fix the handling of double precision[] type. Fixes #

2017-06-08 Thread Dave Page
Fix the handling of double precision[] type. Fixes #1928 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=3bcbc505258e4583d94a40c6e0506046bdc21b98 Author: Murtuza Zabuawala Modified Files --

Re: [pgadmin-hackers] [pgAdmin4][Patch][Feature_1535]: Pressing ESC from within a dialog box should act like "Cancel" button

2017-06-08 Thread Dave Page
Hmm, I see similar behaviour in some other apps. Let's leave it as you've done it :-) Please add support for the properties dialogues, then I think we're good to go. Thanks! -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise

Re: [pgadmin-hackers] [pgAdmin4][Patch][Feature_1533]: Set focus on first field when new dialog window is presented

2017-06-08 Thread Dave Page
ke changes to your subscription: > http://www.postgresql.org/mailpref/pgadmin-hackers > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgadmin-hackers mailing list (pgadmin-ha

[pgadmin-hackers] pgAdmin 4 commit: Set focus on the first enabled field when a dialogue

2017-06-08 Thread Dave Page
Set focus on the first enabled field when a dialogue is opened. Fixes #1533 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=c9b717ed68797740a6ea8d3480627fe21777a8a8 Author: Surinder Kumar Modified Files

Re: [pgadmin-hackers] [pgAdmin4] [PATCH] History Tab rewrite in React

2017-06-08 Thread Dave Page
to be removed from there repo. Once I can apply a version of this, how should I be running the linter and the unit tests? -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgadmin-ha

Re: [pgadmin-hackers] [pgAdmin4][PATCH] Improvements to Query Results Grid User Experience

2017-06-08 Thread Dave Page
t;> >>> We tried to follow the steps you provided to replicate the bug but >>> couldn't replicate the error. Can you provide further instructions to help >>> us replicate the bug? Perhaps share a screen video if that makes sense. >>> Is this occurring on t

[pgadmin-hackers] pgAdmin 4 commit: Improvements to the Query Results grid:

2017-06-08 Thread Dave Page
Improvements to the Query Results grid: - Improve the UI - Allow copy/paste from sets of rows, columns or arbitrary blocks of cells Patch by Matt, Shruti, Joao and Sarah @ Pivotal Fixes #2476 Branch -- master Details ---

Re: [pgadmin-hackers] [pgAdmin4][Patch]: Load module's JS files only when required

2017-06-08 Thread Dave Page
t; On Tue, Jun 6, 2017 at 9:39 AM, Dave Page <dp...@pgadmin.org> wrote: >> >> Hi >> >> On Mon, Jun 5, 2017 at 10:22 AM, Surinder Kumar >> <surinder.ku...@enterprisedb.com> wrote: >> > Hi Dave, >> > >> > Please find attached patch fo

Re: [pgadmin-hackers] Re: [pgAdmin4][Patch][Feature #1971]: Remember column sizes between executions of the same query in the query tool

2017-06-08 Thread Dave Page
; Please find rebased patch. >> >> On Wed, Jun 7, 2017 at 6:15 PM, Dave Page <dp...@pgadmin.org> wrote: >>> >>> Hi, >>> >>> Could you rebase this please? >>> >>> Thanks. >>> >>> On Tue, Jun 6, 2017 at 9:22

[pgadmin-hackers] pgAdmin 4 commit: Retain column sizing in the query tool results grid w

2017-06-08 Thread Dave Page
Retain column sizing in the query tool results grid when the same query is re-run multiple times in a row. Fixes #1971 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=2fddf750e6a664a2d82756bf896bdacad1e10b2a Author: Surinder Kumar

[pgadmin-hackers] pgAdmin 4 commit: Fix an intermittent error seen during result polling.

2017-06-08 Thread Dave Page
Fix an intermittent error seen during result polling. Fixes #2470 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=678b891ff76fea6f2c287d1eb3bc84ff242c61b4 Author: Murtuza Zabuawala Modified Files

Re: [pgadmin-hackers] [pgAdmin4] To fix the error "ValueError: too many values to unpack" while polling

2017-06-08 Thread Dave Page
> Regards, > Murtuza Zabuawala > EnterpriseDB: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > > > -- > Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) > To make changes to your subscription: > http://www.postgresq

Re: [pgadmin-hackers] [pgAdmin4] To fix issues in pgAgent's modules

2017-06-08 Thread Dave Page
EnterpriseDB: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > > > -- > Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) > To make changes to your subscription: > http://www.postgresql.org/mailpref/pgadmin-hackers > -- Dave Page Blog

[pgadmin-hackers] pgAdmin 4 commit: Fix various issues with pgAgent job steps and schedul

2017-06-08 Thread Dave Page
Fix various issues with pgAgent job steps and schedules: 1) Error on clicking SQL panel when Schedule OR Step node is selected in browser. Fixes #1888 2) Error while dropping Schedule OR Step node. Fixes #1889 3) Newly created Schedule/Step node was not displaying in browser. Fixes #1890

[pgadmin-hackers] pgAdmin 4 commit: Fix a couple of missing greys.

2017-06-07 Thread Dave Page
Fix a couple of missing greys. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=88737248ab9d2615ea6a16bef3913634020989f0 Author: Surinder Kumar Modified Files --

Re: [pgadmin-hackers] [pgAdmin4][PATCH] Consolidating gray colors in the application

2017-06-07 Thread Dave Page
ched patch. > > > On Wed, Jun 7, 2017 at 6:59 PM, Robert Eckhardt <reckha...@pivotal.io> > wrote: >> >> Thank you. >> >> -- Rob >> >> On Wed, Jun 7, 2017 at 9:28 AM, Surinder Kumar >> <surinder.ku...@enterprisedb.com> wrote: >>>

Re: [pgadmin-hackers] [pgAdmin4] [PATCH] History Tab rewrite in React

2017-06-07 Thread Dave Page
t; files (using r.js which is not preferred). But Webpack can not do both. It >>>> can only bundle files, it has to be used with either Grunt or Gulp to >>>> execute tasks. >>>> >>>> Is it possible to run the task listed above by configuring them in >>>

  1   2   3   4   5   6   7   8   9   10   >