[pgadmin-hackers] pgAdmin 4 commit: Ensure the feature tests use the correct test setting

2017-06-16 Thread Dave Page
Ensure the feature tests use the correct test settings database. Fixes #2486

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=1ee555e4687dcd94cc054738076b4cb78999e81c
Author: Khushboo Vashi 

Modified Files
--
web/config.py  | 2 --
web/pgadmin/__init__.py| 5 +
web/regression/runtests.py | 5 -
web/setup.py   | 3 ++-
4 files changed, 11 insertions(+), 4 deletions(-)


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers


Re: [pgadmin-hackers] [pgAdmin4][Patch]: Fixed #2486: Feature tests use SQLITE_PATH instead of TEST_SQLITE_PATH.

2017-06-16 Thread Dave Page
Thanks - patch applied!

On Thu, Jun 15, 2017 at 1:24 PM, Khushboo Vashi
<khushboo.va...@enterprisedb.com> wrote:
> Hi,
>
> Please find the attached patch to fix #2486: Feature tests use SQLITE_PATH
> instead of TEST_SQLITE_PATH.
>
> While running the feature tests, the separate process of the app does not
> honour the config settings which are in runtests.py file.
>
> Fix:
> As per Dave, no need to set TESTING_MODE in config rather set environment
> variable PGADMIN_TESTING_MODE to check the testing status and accordingly
> set the TEST_SQLITE_PATH (i.e. Database path for testing).
>
> Thanks,
> Khushboo
>
>
>
> --
> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>



-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers


Re: [pgadmin-hackers] Re: Server side cursor limitations for on demand loading of data in query tool [RM2137] [pgAdmin4]

2017-06-15 Thread Dave Page
Sounds good, thanks.

On Thu, Jun 15, 2017 at 9:54 PM, Harshal Dhumal
<harshal.dhu...@enterprisedb.com> wrote:
> Hi
>
> On Fri, Jun 16, 2017 at 2:07 AM, Dave Page <dp...@pgadmin.org> wrote:
>>
>> Hi
>>
>> On Thu, Jun 15, 2017 at 9:30 PM, Harshal Dhumal
>> <harshal.dhu...@enterprisedb.com> wrote:
>> > Hi Dave,
>> >
>> > Please find attached updated patch.
>> >
>> > On Thu, Jun 15, 2017 at 3:58 PM, Dave Page <dp...@pgadmin.org> wrote:
>> >>
>> >> Hi
>> >>
>> >> On Wed, Jun 14, 2017 at 11:36 PM, Harshal Dhumal
>> >> <harshal.dhu...@enterprisedb.com> wrote:
>> >>>
>> >>> Hi Dave,
>> >>>
>> >>> Please find rebased patch for RM2137.
>> >>
>> >>
>> >> Looking very good. The only issues I see are:
>> >>
>> >> - The row headers should auto-size such that they can display the row
>> >> numbers if the last row was displayed. E.g. if there are 12345 rows in
>> >> total, then the row header should be sized to display 5 digits.
>> >>
>> > Fixed.
>> >
>> >
>> >>
>> >> - The tests are comprehensive, which is awesome. However, every time I
>> >> ran
>> >> them, at least one of the feature tests failed. Unfortunately, it was a
>> >> different one each time. In the last two runs, I got:
>> >>
>> >>  ==
>> >> ERROR: runTest
>> >> (pgadmin.feature_tests.query_tool_tests.QueryToolFeatureTest)
>> >> Query tool feature test
>> >> --
>> >> Traceback (most recent call last):
>> >>   File
>> >>
>> >> "/Users/dpage/git/pgadmin4/web/regression/feature_utils/base_feature_test.py",
>> >> line 40, in setUp
>> >> self.before()
>> >>   File
>> >>
>> >> "/Users/dpage/git/pgadmin4/web/pgadmin/feature_tests/query_tool_tests.py",
>> >> line 40, in before
>> >> self._connects_to_server()
>> >>   File
>> >>
>> >> "/Users/dpage/git/pgadmin4/web/pgadmin/feature_tests/query_tool_tests.py",
>> >> line 144, in _connects_to_server
>> >> self.page.driver.find_element_by_link_text("Create"))\
>> >>   File
>> >>
>> >> "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/selenium/webdriver/remote/webdriver.py",
>> >> line 319, in find_element_by_link_text
>> >> return self.find_element(by=By.LINK_TEXT, value=link_text)
>> >>   File
>> >>
>> >> "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/selenium/webdriver/remote/webdriver.py",
>> >> line 756, in find_element
>> >> 'value': value})['value']
>> >>   File
>> >>
>> >> "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/selenium/webdriver/remote/webdriver.py",
>> >> line 238, in execute
>> >> self.error_handler.check_response(response)
>> >>   File
>> >>
>> >> "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/selenium/webdriver/remote/errorhandler.py",
>> >> line 193, in check_response
>> >> raise exception_class(message, screen, stacktrace)
>> >> NoSuchElementException: Message: no such element: Unable to locate
>> >> element: {"method":"link text","selector":"Create"}
>> >>   (Session info: chrome=58.0.3029.110)
>> >>   (Driver info: chromedriver=2.29.461585
>> >> (0be2cd95f834e9ee7c46bcc7cf405b483f5ae83b),platform=Mac OS X 10.12.3
>> >> x86_64)
>> >>
>> > I checked code from _connects_to_server function which is common in all
>> > features test cases. I didn't find anything wrong with this. If there is
>> > a
>> > bug in this function then all feature test must fail.
>> > Let me know if you are getting failure consistently in
>> > _connects_to_server
>> > function.
>>
>> I wondered if that one is a race condition. Do we need a short delay
>> before clicking the Object menu? I have seen this occasionally before.
>
>
> OK. In that case let's try putting 1-2 second delay and observer behaviour.
> 

Re: [pgadmin-hackers] Re: Server side cursor limitations for on demand loading of data in query tool [RM2137] [pgAdmin4]

2017-06-15 Thread Dave Page
Hi

On Thu, Jun 15, 2017 at 9:30 PM, Harshal Dhumal
<harshal.dhu...@enterprisedb.com> wrote:
> Hi Dave,
>
> Please find attached updated patch.
>
> On Thu, Jun 15, 2017 at 3:58 PM, Dave Page <dp...@pgadmin.org> wrote:
>>
>> Hi
>>
>> On Wed, Jun 14, 2017 at 11:36 PM, Harshal Dhumal
>> <harshal.dhu...@enterprisedb.com> wrote:
>>>
>>> Hi Dave,
>>>
>>> Please find rebased patch for RM2137.
>>
>>
>> Looking very good. The only issues I see are:
>>
>> - The row headers should auto-size such that they can display the row
>> numbers if the last row was displayed. E.g. if there are 12345 rows in
>> total, then the row header should be sized to display 5 digits.
>>
> Fixed.
>
>
>>
>> - The tests are comprehensive, which is awesome. However, every time I ran
>> them, at least one of the feature tests failed. Unfortunately, it was a
>> different one each time. In the last two runs, I got:
>>
>>  ==
>> ERROR: runTest
>> (pgadmin.feature_tests.query_tool_tests.QueryToolFeatureTest)
>> Query tool feature test
>> --
>> Traceback (most recent call last):
>>   File
>> "/Users/dpage/git/pgadmin4/web/regression/feature_utils/base_feature_test.py",
>> line 40, in setUp
>> self.before()
>>   File
>> "/Users/dpage/git/pgadmin4/web/pgadmin/feature_tests/query_tool_tests.py",
>> line 40, in before
>> self._connects_to_server()
>>   File
>> "/Users/dpage/git/pgadmin4/web/pgadmin/feature_tests/query_tool_tests.py",
>> line 144, in _connects_to_server
>> self.page.driver.find_element_by_link_text("Create"))\
>>   File
>> "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/selenium/webdriver/remote/webdriver.py",
>> line 319, in find_element_by_link_text
>> return self.find_element(by=By.LINK_TEXT, value=link_text)
>>   File
>> "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/selenium/webdriver/remote/webdriver.py",
>> line 756, in find_element
>> 'value': value})['value']
>>   File
>> "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/selenium/webdriver/remote/webdriver.py",
>> line 238, in execute
>> self.error_handler.check_response(response)
>>   File
>> "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/selenium/webdriver/remote/errorhandler.py",
>> line 193, in check_response
>> raise exception_class(message, screen, stacktrace)
>> NoSuchElementException: Message: no such element: Unable to locate
>> element: {"method":"link text","selector":"Create"}
>>   (Session info: chrome=58.0.3029.110)
>>   (Driver info: chromedriver=2.29.461585
>> (0be2cd95f834e9ee7c46bcc7cf405b483f5ae83b),platform=Mac OS X 10.12.3 x86_64)
>>
> I checked code from _connects_to_server function which is common in all
> features test cases. I didn't find anything wrong with this. If there is a
> bug in this function then all feature test must fail.
> Let me know if you are getting failure consistently in _connects_to_server
> function.

I wondered if that one is a race condition. Do we need a short delay
before clicking the Object menu? I have seen this occasionally before.

>>
>>
>> ==
>> ERROR: runTest
>> (pgadmin.feature_tests.query_tool_tests.QueryToolFeatureTest)
>> Query tool feature test
>> --
>> Traceback (most recent call last):
>>   File
>> "/Users/dpage/git/pgadmin4/web/pgadmin/feature_tests/query_tool_tests.py",
>> line 119, in runTest
>> self._query_tool_auto_rollback_enabled()
>>   File
>> "/Users/dpage/git/pgadmin4/web/pgadmin/feature_tests/query_tool_tests.py",
>> line 697, in _query_tool_auto_rollback_enabled
>> '//div[contains(@class, "sql-editor-message") and contains(string(),
>> "COMMIT")]'
>>   File
>> "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/selenium/webdriver/remote/webdriver.py",
>> line 295, in find_element_by_xpath
>> return self.find_element(by=By.XPATH, value=xpath)
>>   File
>> "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/selenium/webdriver/remote/webdriv

Re: [pgadmin-hackers][patch] History Detail Pane

2017-06-15 Thread Dave Page
Hi

We use Qt 5.8 at the moment, with the updated QtWebKit TP5 release
from https://github.com/annulen/webkit/releases. The issue occurs on
Windows and Mac, and probably Linux as well.

Test builds can be found here: https://developer.pgadmin.org/~dpage/debug/

On Thu, Jun 15, 2017 at 2:33 PM, Sarah McAlear <smcal...@pivotal.io> wrote:
> Hi Dave!
>
> Just to verify, which version of QT are you using? The Readme calls for 5.5
> at the newest. Could you send us the compiled version of the app? Are you
> only seeing this on Windows?
>
> Thanks,
> Sarah & Shruti & João
>
> On Wed, Jun 14, 2017 at 3:46 PM, Sarah McAlear <smcal...@pivotal.io> wrote:
>>
>> Sounds good! We're looking into it.
>>
>> On Wed, Jun 14, 2017 at 12:15 PM, Robert Eckhardt <reckha...@pivotal.io>
>> wrote:
>>>
>>> Absolutely makes sense.
>>>
>>> Matt, Sarah,
>>>
>>> Do we understand the issues Dave is mentioning well enough to look into
>>> it and tackle it?
>>>
>>> -- Rob
>>>
>>> On Wed, Jun 14, 2017 at 8:12 AM, Dave Page <dp...@pgadmin.org> wrote:
>>>>
>>>> Hi,
>>>>
>>>> Before I commit anything else for this patch, we need to fix the
>>>> existing changes so they work in the desktop runtime (see the previous
>>>> thread with the patches for the history pane changes). Have any of
>>>> your team been able to look at that yet?
>>>>
>>>> On Wed, Jun 14, 2017 at 4:07 PM, Sarah McAlear <smcal...@pivotal.io>
>>>> wrote:
>>>> > Hi Hackers!
>>>> >
>>>> > This patch includes a new pane in the history tab that displays the
>>>> > full
>>>> > formatted query and meta data about the query.
>>>> >
>>>> > Thanks!
>>>> > Shruti & Sarah
>>>> >
>>>> >
>>>> >
>>>> >
>>>> >
>>>> >
>>>> > --
>>>> > Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
>>>> > To make changes to your subscription:
>>>> > http://www.postgresql.org/mailpref/pgadmin-hackers
>>>> >
>>>>
>>>>
>>>>
>>>> --
>>>> Dave Page
>>>> Blog: http://pgsnake.blogspot.com
>>>> Twitter: @pgsnake
>>>>
>>>> EnterpriseDB UK: http://www.enterprisedb.com
>>>> The Enterprise PostgreSQL Company
>>>>
>>>>
>>>> --
>>>> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
>>>> To make changes to your subscription:
>>>> http://www.postgresql.org/mailpref/pgadmin-hackers
>>>
>>>
>>
>



-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers


[pgadmin-hackers] pgAdmin 4 commit: Fix Yarn tasks for Windows

2017-06-15 Thread Dave Page
Fix Yarn tasks for Windows

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=5d45dee686056663795c0dbea5a310d8950df2e4

Modified Files
--
Make-MinGW.bat  | 4 ++--
Make.bat| 4 ++--
web/regression/javascript/fake_endpoints.js | 2 +-
3 files changed, 5 insertions(+), 5 deletions(-)


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers


Re: [pgadmin-hackers] Minor typo in web/config.py

2017-06-15 Thread Dave Page
Thanks, patch applied.

On Thu, Jun 15, 2017 at 12:24 PM, Johan Van de Wauw
<johan.vandew...@gmail.com> wrote:
> There is a minor typo in the web/config.py
>
> patch attached
>
> Kind Regards,
> Johan
>
>
> --
> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>



-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers


[pgadmin-hackers] pgAdmin 4 commit: Fix a typo in the config file

2017-06-15 Thread Dave Page
Fix a typo in the config file

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=827aa72e99364cf78f57d7ac1a906f644c961e5e
Author: Johan Van de Wauw 

Modified Files
--
web/config.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers


Re: [pgadmin-hackers] pgAdmin 4 commit: Use a more sensible name for Query Tool tabs. Fixes #

2017-06-15 Thread Dave Page
Thanks, applied.

When you get some spare time (after the webpacking work that I believe
you're doing), could you please add a feature test (or modify a suitable
existing one) to ensure the various script options work as they should?

Thanks again!

On Thu, Jun 15, 2017 at 11:55 AM, Surinder Kumar <
surinder.ku...@enterprisedb.com> wrote:

> Hi Dave,
>
> Please find attached patch. It should work.
> In previous patch I was unaware that i added untracked file to tracked.
>
> On Thu, Jun 15, 2017 at 4:10 PM, Dave Page <dp...@pgadmin.org> wrote:
>
>> Hi
>>
>> Was this patch generated against a WIP branch? I get:
>>
>> (pgadmin4)piranha:pgadmin4 dpage$ git apply ~/Downloads/fix_scripts_in_que
>> ry_tool.patch
>> error: web/pgadmin/static/js/setup_connection.js: No such file or
>> directory
>>
>> On Thu, Jun 15, 2017 at 6:36 AM, Surinder Kumar <
>> surinder.ku...@enterprisedb.com> wrote:
>>
>>> Hi
>>>
>>> PFA patch which fixes the issue Harshal reported.
>>>
>>> Thanks,
>>> Surinder
>>>
>>> On Thu, Jun 15, 2017 at 3:52 AM, Harshal Dhumal <
>>> harshal.dhu...@enterprisedb.com> wrote:
>>>
>>>> Surinder,
>>>>
>>>> I guess this broke the script options (Create, Delete, Select, Insert,
>>>> Update)
>>>>
>>>>
>>>> VM4124 datagrid.js:440 Uncaught TypeError: self.get_panel_title is not
>>>> a function at Object.success (VM4124 datagrid.js:440) at fire (
>>>> jquery-1.11.2.js:3143) at Object.fireWith [as resolveWith] (
>>>> jquery-1.11.2.js:3255) at done (jquery-1.11.2.js:9309) at
>>>> XMLHttpRequest.callback (jquery-1.11.2.js:9713)
>>>> success @ VM4124 datagrid.js:440
>>>> fire @ jquery-1.11.2.js:3143
>>>> fireWith @ jquery-1.11.2.js:3255
>>>> done @ jquery-1.11.2.js:9309
>>>> callback @ jquery-1.11.2.js:9713
>>>>
>>>>
>>>>
>>>>
>>>> --
>>>> *Harshal Dhumal*
>>>> *Sr. Software Engineer*
>>>>
>>>> EnterpriseDB India: http://www.enterprisedb.com
>>>> The Enterprise PostgreSQL Company
>>>>
>>>> On Tue, Jun 13, 2017 at 4:04 PM, Dave Page <dp...@pgadmin.org> wrote:
>>>>
>>>>> Use a more sensible name for Query Tool tabs. Fixes #2482
>>>>>
>>>>> Branch
>>>>> --
>>>>> master
>>>>>
>>>>> Details
>>>>> ---
>>>>> https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdif
>>>>> f;h=57d866f7b70996a82a881b20248c3285ab3a6900
>>>>> Author: Surinder Kumar <surinder.ku...@enterprisedb.com>
>>>>>
>>>>> Modified Files
>>>>> --
>>>>> web/pgadmin/browser/templates/browser/js/node.js   |  4 +-
>>>>> web/pgadmin/static/css/webcabin.overrides.css  | 13 +
>>>>> .../datagrid/templates/datagrid/js/datagrid.js | 58
>>>>> --
>>>>> .../sqleditor/templates/sqleditor/js/sqleditor.js  |  5 +-
>>>>> 4 files changed, 49 insertions(+), 31 deletions(-)
>>>>>
>>>>>
>>>>> --
>>>>> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
>>>>> To make changes to your subscription:
>>>>> http://www.postgresql.org/mailpref/pgadmin-hackers
>>>>>
>>>>
>>>>
>>>
>>>
>>> --
>>> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
>>> To make changes to your subscription:
>>> http://www.postgresql.org/mailpref/pgadmin-hackers
>>>
>>>
>>
>>
>> --
>> Dave Page
>> Blog: http://pgsnake.blogspot.com
>> Twitter: @pgsnake
>>
>> EnterpriseDB UK: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>
>


-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


[pgadmin-hackers] pgAdmin 4 commit: Fix script options which were inadvertently broken in

2017-06-15 Thread Dave Page
Fix script options which were inadvertently broken in the query tool tab naming 
patch.

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=2a87585665049fb67ca9d51fd949b3bd7d25b077
Author: Surinder Kumar 

Modified Files
--
web/pgadmin/browser/templates/browser/js/node.js   |  5 +++--
web/pgadmin/static/js/sqleditor_utils.js   |  3 +++
.../datagrid/templates/datagrid/js/datagrid.js | 22 +++---
web/regression/javascript/sqleditor_utils_spec.js  |  5 +
4 files changed, 26 insertions(+), 9 deletions(-)


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers


[pgadmin-hackers] pgAdmin 4 commit: Add double precision[] tests to the query tool.

2017-06-15 Thread Dave Page
Add double precision[] tests to the query tool.

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=d70c3003d3fdadfbcfff4f677f25a9f3f35471cd
Author: Murtuza Zabuawala 

Modified Files
--
.../feature_tests/pg_datatype_validation_test.py   | 77 --
1 file changed, 58 insertions(+), 19 deletions(-)


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers


Re: [pgadmin-hackers] [pgAdmin4][PATCH] To fix the issue in Grant wizard

2017-06-15 Thread Dave Page
Thanks, applied.

On Thu, Jun 15, 2017 at 9:56 AM, Murtuza Zabuawala
<murtuza.zabuaw...@enterprisedb.com> wrote:
> Hi,
>
> PFA minor patch to fix the issue in Grant wizard, In IE browser grant wizard
> do not close if user tries to close it by clicking Cancel button or Close
> button.
> RM#2142
>
> --
> Regards,
> Murtuza Zabuawala
> EnterpriseDB: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
>
> --
> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>



-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers


[pgadmin-hackers] pgAdmin 4 commit: Fix canceling of Grant Wizard on Windows. Fixes #2142

2017-06-15 Thread Dave Page
Fix canceling of Grant Wizard on Windows. Fixes #2142

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=8376d33d775ddb79ecedae93f9d969d8955693f5
Author: Murtuza Zabuawala 

Modified Files
--
.../tools/grant_wizard/templates/grant_wizard/js/grant_wizard.js| 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers


Re: [pgadmin-hackers] pgAdmin 4 commit: Use a more sensible name for Query Tool tabs. Fixes #

2017-06-15 Thread Dave Page
Hi

Was this patch generated against a WIP branch? I get:

(pgadmin4)piranha:pgadmin4 dpage$ git apply
~/Downloads/fix_scripts_in_query_tool.patch
error: web/pgadmin/static/js/setup_connection.js: No such file or directory

On Thu, Jun 15, 2017 at 6:36 AM, Surinder Kumar <
surinder.ku...@enterprisedb.com> wrote:

> Hi
>
> PFA patch which fixes the issue Harshal reported.
>
> Thanks,
> Surinder
>
> On Thu, Jun 15, 2017 at 3:52 AM, Harshal Dhumal <
> harshal.dhu...@enterprisedb.com> wrote:
>
>> Surinder,
>>
>> I guess this broke the script options (Create, Delete, Select, Insert,
>> Update)
>>
>>
>> VM4124 datagrid.js:440 Uncaught TypeError: self.get_panel_title is not a
>> function at Object.success (VM4124 datagrid.js:440) at fire (
>> jquery-1.11.2.js:3143) at Object.fireWith [as resolveWith] (
>> jquery-1.11.2.js:3255) at done (jquery-1.11.2.js:9309) at
>> XMLHttpRequest.callback (jquery-1.11.2.js:9713)
>> success @ VM4124 datagrid.js:440
>> fire @ jquery-1.11.2.js:3143
>> fireWith @ jquery-1.11.2.js:3255
>> done @ jquery-1.11.2.js:9309
>> callback @ jquery-1.11.2.js:9713
>>
>>
>>
>>
>> --
>> *Harshal Dhumal*
>> *Sr. Software Engineer*
>>
>> EnterpriseDB India: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>> On Tue, Jun 13, 2017 at 4:04 PM, Dave Page <dp...@pgadmin.org> wrote:
>>
>>> Use a more sensible name for Query Tool tabs. Fixes #2482
>>>
>>> Branch
>>> --
>>> master
>>>
>>> Details
>>> ---
>>> https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdif
>>> f;h=57d866f7b70996a82a881b20248c3285ab3a6900
>>> Author: Surinder Kumar <surinder.ku...@enterprisedb.com>
>>>
>>> Modified Files
>>> --
>>> web/pgadmin/browser/templates/browser/js/node.js   |  4 +-
>>> web/pgadmin/static/css/webcabin.overrides.css  | 13 +
>>> .../datagrid/templates/datagrid/js/datagrid.js | 58
>>> --
>>> .../sqleditor/templates/sqleditor/js/sqleditor.js  |  5 +-
>>> 4 files changed, 49 insertions(+), 31 deletions(-)
>>>
>>>
>>> --
>>> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
>>> To make changes to your subscription:
>>> http://www.postgresql.org/mailpref/pgadmin-hackers
>>>
>>
>>
>
>
> --
> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>
>


-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


Re: [pgadmin-hackers] [pgAdmin4][PATCH] Improvements to Query Results Grid User Experience

2017-06-15 Thread Dave Page
On Fri, Jun 9, 2017 at 9:03 AM, Dave Page <dp...@pgadmin.org> wrote:
> On Thu, Jun 8, 2017 at 7:31 PM, Sarah McAlear <smcal...@pivotal.io> wrote:
>>> Thanks. When I run the tests my browser opens in some default size
>>> that's always consistent, but doesn't match my normal Chrome sessions,
>>> or the 1024x1024 default set in app_starter.py.
>>
>>
>> This looks like an issue with string edit box placement in the
>> implementation. We created an issue for this (RM2477).
>
> That was my guess too.
>
>>> Anyway - I found another issue. If I select one or more columns or
>>> rows, or an arbitrary selection of cells, copy/paste seems to work
>>> fine. However, if I click the Select All arrow, for a small resultset
>>> (e.g. SELECT * FROM pg_database with 18 rows) it works fine, but if I
>>> do the same with the contents of pg_class, which has 1342 rows on this
>>> DB, it seems to fail to populate the clipboard and ends up pasting
>>> whatever was copied previously instead. If I use the Copy button, even
>>> on a fast machine it seems to pause for a second or so before failing
>>> to put the data on the clipboard.
>>
>>
>> We were able to reproduce this with "SELECT generate_series(1, 5)"
>> The issue was still present for us when we ran the app at each of 2fddf750
>> and 495a3cedb
>> Could we move this discussion to a new thread as it doesn't seem related to
>> these changes?
>
> Something in these changes caused it to start manifesting, but I agree
> the underlying issue was probably there anyway. I'm happy to move to a
> different thread.

I've created a ticket for this: https://redmine.postgresql.org/issues/2489


-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers


Re: [pgadmin-hackers][patch] History Detail Pane

2017-06-14 Thread Dave Page
Hi,

Before I commit anything else for this patch, we need to fix the
existing changes so they work in the desktop runtime (see the previous
thread with the patches for the history pane changes). Have any of
your team been able to look at that yet?

On Wed, Jun 14, 2017 at 4:07 PM, Sarah McAlear <smcal...@pivotal.io> wrote:
> Hi Hackers!
>
> This patch includes a new pane in the history tab that displays the full
> formatted query and meta data about the query.
>
> Thanks!
> Shruti & Sarah
>
>
>
>
>
>
> --
> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>



-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers


[pgadmin-hackers] pgAdmin 4 commit: Add some more Makefile targets for running different

2017-06-14 Thread Dave Page
Add some more Makefile targets for running different test suites.

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=6938fbafb538997e8a37a19827b03ad402572829

Modified Files
--
Makefile | 11 ++-
1 file changed, 10 insertions(+), 1 deletion(-)


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers


Re: [pgadmin-hackers] Re: Server side cursor limitations for on demand loading of data in query tool [RM2137] [pgAdmin4]

2017-06-14 Thread Dave Page
Hi,

Sorry - it's drifted out again, I suspect because of the work Ashesh
has been doing. Can you rebase please? Check with Ashesh first though,
in case he's about ready to commit another big change.

Thanks.

On Fri, Jun 9, 2017 at 10:08 AM, Harshal Dhumal
<harshal.dhu...@enterprisedb.com> wrote:
> Hi,
>
>
> Please find rebased patch
>
> --
> Harshal Dhumal
> Sr. Software Engineer
>
> EnterpriseDB India: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
> On Thu, Jun 8, 2017 at 6:40 PM, Harshal Dhumal
> <harshal.dhu...@enterprisedb.com> wrote:
>>
>> Ignore this patch.
>> Rebase and migration of feature tests and jasmine tests required.
>>
>> --
>> Harshal Dhumal
>> Sr. Software Engineer
>>
>> EnterpriseDB India: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>> On Thu, Jun 8, 2017 at 3:56 PM, Harshal Dhumal
>> <harshal.dhu...@enterprisedb.com> wrote:
>>>
>>> Hi,
>>> Please find attached updated patch for feature RM2137.
>>>
>>> Changes in this patch:
>>> 1. Patch rebased.
>>>
>>> 2. Updated existing feature tests which requires changes due to this
>>> feature.
>>>  affected feature test cases:
>>>  i. PGDataypeFeatureTest
>>>  ii. CheckForXssFeatureTest
>>>
>>> 3. Updated existing jasmine test cases which requires changes due to this
>>> feature.
>>>  affected jasmine test cases:
>>>  i. copy data
>>>  ii. range_boundary_navigator
>>>  iii. row_selector
>>>  iv. set_stages_rows
>>>
>>> 4. New feature tests added
>>> i. on demand result set on scrolling.
>>> ii. on demand result set on grid select all.
>>> iii. on demand result set on column select all.
>>> iv. explain query
>>> v. explain query with verbose
>>> vi. explain query with costs
>>> vii. explain analyze query
>>> viii. explain analyze query with buffers
>>> ix. explain analyze query with timing
>>> x. auto commit disabled.
>>> xi. auto commit enabled.
>>> xii. auto rollback enabled.
>>> xiii. cancel query.
>>>
>>>
>>>
>>> --
>>> Harshal Dhumal
>>> Sr. Software Engineer
>>>
>>> EnterpriseDB India: http://www.enterprisedb.com
>>> The Enterprise PostgreSQL Company
>>>
>>> On Tue, May 16, 2017 at 8:14 PM, Dave Page <dp...@pgadmin.org> wrote:
>>>>
>>>>
>>>>
>>>> On Mon, May 15, 2017 at 7:40 PM, Harshal Dhumal
>>>> <harshal.dhu...@enterprisedb.com> wrote:
>>>>>
>>>>> Hi,
>>>>>
>>>>> On Sat, May 13, 2017 at 12:35 AM, Joao Pedro De Almeida Pereira
>>>>> <jdealmeidapere...@pivotal.io> wrote:
>>>>>>
>>>>>> We were only able to apply the patch on 1f903ba2 (were seeing patch
>>>>>> does not apply due to sqleditor.js conflicts)
>>>>>> The javascript tests passed, but we were unable to copy rows or
>>>>>> columns or cells when running the application. Could you run feature 
>>>>>> tests?
>>>>>
>>>>> There are three modes sqleditor can be launched
>>>>> 1. Query tool  (Tools menus -> Query Tool)
>>>>> 2. Datagrid.  (Right click on any table/view  -> View Data -> View
>>>>> All/First 100/Last 100/Filtered rows)
>>>>> 3. Scripts (Right click on any table/view ->
>>>>> INSERT/CREATE/UPDATE/DELETE/SELECT)
>>>>>
>>>>> Paste functionality is only enabled in Datagrid and table has Primary
>>>>> key otherwise it's disabled. In your case row might have been copied but 
>>>>> you
>>>>> were unable paste because you might be trying to paste the rows in Query
>>>>> tool. Please try again in Datagrid with table having Primary key.
>>>>>
>>>>>>
>>>>>>
>>>>>> Now that more functionality is being added to sqleditor.js, this may
>>>>>> be a good time to extract the functionality to separate files. This will
>>>>>> increase readability, and encourage separation of concerns. It will also
>>>>>> make changes easier to test in isolation.
>>>>>
>>>>> Ok. Let me check if I can separate out ant functionali

Re: [pgadmin-hackers] Declarative partitioning in pgAdmin4

2017-06-14 Thread Dave Page
On Wed, Jun 14, 2017 at 1:06 PM, Ashesh Vashi <ashesh.va...@enterprisedb.com
> wrote:

> On Wed, Jun 14, 2017 at 1:59 PM, Dave Page <dp...@pgadmin.org> wrote:
>
>>
>>
>> On Tue, Jun 13, 2017 at 2:59 PM, Akshay Joshi <
>> akshay.jo...@enterprisedb.com> wrote:
>>
>>> Hi All
>>>
>>> For further implementation following task needs to be work upon:
>>>
>>>- How to parse and show partitions keys. For example user has
>>>created below partitioned table
>>>
>>> CREATE TABLE public.sales
>>> (
>>> country character varying COLLATE pg_catalog."default" NOT NULL,
>>> sales bigint,
>>> saledate date
>>> ) PARTITION BY RANGE (*country, date_part('year'::text, sale date)*)
>>>
>>> When user open the properties dialog I am not able to figure out how to
>>> parse keys(displayed in bold in above example) and show them in our control
>>> that we used. For the time being I have hide that control in 'Edit' mode
>>> (Refer Attach Partition.png)
>>>
>>>
>> I assume psql with display that info with \dt or similar? What does it
>> do? Failing that, look at pg_dump?
>>
> psql, and pg_dump use 'pg_get_partkeydef' function for reverse
> engineering, and we too.
> They don't need particular key information.
>
> In properties dialog, we need to find out - what individual partition key
> is? (column/expression).
>
> Let me give an example.
> I have a partition table with the following definition (with two partition
> keys).
>
> *CREATE TABLE public.sales*
> *(*
> *country character varying COLLATE pg_catalog."default" NOT NULL,*
> *sales bigint,*
> *saledate date*
> *) PARTITION BY RANGE (country, EXTRACT(year from saledate));*
>
> And, the following query will give as:
> *SELECT relname, pg_get_partkeydef(oid) FROM pg_catalog.pg_class WHERE
> relname like 'sal%';*
>
>  relname | *pg_get_partkeydef*
> -+
>  sales   | *RANGE (country, date_part('year'::text, saledate))*
>
> Here - we have two option in edit mode.
> 1. Parse the output of the  '*pg_get_partkeydef'*, and identify all
> individual keys, and its detailed information (i.e. column/expression)
> 2. Show that output about the partition keys in static control, and hide
> the Partition type, partition keys controls.
>
> I prefer the second option, as user can not modify the partition keys/type
> (RANGE/LIST), and we will not have to write logic to parse the keys from
> that output.
>
> What do you say?
>

I agree.


>
> -- Thanks, Ashesh
>
>>
>>
>>>
>>>- *Support of sub partitioning*: To implement sub-partitioning,
>>>specify the PARTITION BY clause in the commands used to create individual
>>>partitions, for example:
>>>-
>>>
>>>CREATE TABLE measurement_y2006 PARTITION OF measurement
>>>FOR VALUES FROM ('2006-02-01') TO ('2006-03-01')
>>>PARTITION BY RANGE (peaktemp);
>>>
>>>
>>>To achieve above I have made some changes in GUI (Refer Sub
>>> Partition.png).
>>>*Complex and challenging part here is "measurement_y2006" is
>>> partition of "measurement" and parent table for other partitions too which
>>> user can create later. How we will going to show this in browser tree? *
>>>One option could be
>>>Tables
>>>  ->measurement(table)
>>>->Partitions
>>>  ->measurement_y2006(Partition of measurement and parent
>>> of p1)
>>>->Partitions
>>>  ->p1
>>>
>>
>> Urgh. But yeah. I think that makes logical sense.
>>
>>
>>>
>>>- *Attach Partitions*: To implement attach N partitions I have made
>>>some changes in GUI( Refer Attach Partition.png). Attach Partitions
>>>control will only be visible in "Edit" mode.
>>>
>>> I have only modified the UI changes, there are lots of work needs to be
>>> done to complete that.
>>>
>>
>> I don't think I'd include Attach on the dialog. I think it should be a
>> separate menu option, with a simple dialogue to let the user choose the
>> table to attach.
>>
>> The reason for that is that Attach is an action not a property. On the
>> Properties panels we expect any chang

[pgadmin-hackers] pgAdmin 4 commit: Ensure text editors render in an appropriate place on

2017-06-14 Thread Dave Page
Ensure text editors render in an appropriate place on the results grid. Fixes 
#2477

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=fdc9eed51479e0057420f116f4b3b7425a12f377
Author: Surinder Kumar 

Modified Files
--
web/pgadmin/feature_tests/view_data_dml_queries.py |  14 +-
web/pgadmin/static/css/pgadmin.style.css   |   8 +-
.../static/js/slickgrid/slick.pgadmin.editors.js   | 189 +
.../tools/sqleditor/static/css/sqleditor.css   |  21 +++
.../sqleditor/templates/sqleditor/js/sqleditor.js  |   8 +-
5 files changed, 121 insertions(+), 119 deletions(-)


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers


[pgadmin-hackers] pgAdmin 4 commit: Un-break the feature tests. Fixes from Surinder and m

2017-06-14 Thread Dave Page
Un-break the feature tests. Fixes from Surinder and myself.

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=2b4a8ed89c9374fa9e0f9c0eb190662979d0bb6b
Author: Surinder Kumar 

Modified Files
--
web/pgadmin/feature_tests/copy_selected_query_results_feature_test.py | 2 +-
web/pgadmin/feature_tests/query_tool_journey_test.py  | 2 +-
web/regression/feature_utils/pgadmin_page.py  | 2 +-
3 files changed, 3 insertions(+), 3 deletions(-)


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers


Re: [pgadmin-hackers] [pgAdmin4][Patch][RM_2482]: Query tool/ Edit grid panel should have meaningful title

2017-06-14 Thread Dave Page
Thanks Surinder. That, along with another fix seems to have got the
tests working fully again.

On Tue, Jun 13, 2017 at 6:37 PM, Surinder Kumar
<surinder.ku...@enterprisedb.com> wrote:
> Hi
>
> PFA patch.
>
> On Tue, Jun 13, 2017 at 9:54 PM, Dave Page <dp...@pgadmin.org> wrote:
>>
>> Hmm, this seems to have broken the feature tests. Can you look at that
>> ASAP please? I think it's because the tab text has changed.
>
> Yes, now it will search for 'Query -' instead of 'Query-1'.
>>
>>
>> On Tue, Jun 13, 2017 at 11:34 AM, Dave Page <dp...@pgadmin.org> wrote:
>> > Thanks, patch applied.
>> >
>> > On Tue, Jun 13, 2017 at 6:24 AM, Surinder Kumar
>> > <surinder.ku...@enterprisedb.com> wrote:
>> >> Hi
>> >>
>> >> Changes:
>> >>
>> >> 1) When Query tool is opened, right now - panel title is displayed as
>> >> "Query
>> >> - 1 ", instead it should display Query - [db_name] on [server_name] as
>> >> in
>> >> pgAdmin3.
>> >>
>> >> 2) When Edit grid is opened for table, the panel title should display
>> >> Edit Data - [server_name] - [db_name] - [table_name]
>> >>
>> >> These names are more meaningful instead of "Query - #'. helpful while
>> >> switching to panel tabs.
>> >>
>> >> 3) If panel is inactive and its title is quite long, show
>> >> ellipsis(...),
>> >> otherwise display full title.
>> >>
>> >> 4) Add tooltips to Query tool/Edit grid panel on mouse hover of tab.
>> >>
>> >> Also tested with preference settings > Open query tool in new tab. It
>> >> works!!.
>> >>
>> >> Please find attached patch
>> >>
>> >> Thanks
>> >> Surinder
>> >>
>> >>
>> >> --
>> >> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
>> >> To make changes to your subscription:
>> >> http://www.postgresql.org/mailpref/pgadmin-hackers
>> >>
>> >
>> >
>> >
>> > --
>> > Dave Page
>> > Blog: http://pgsnake.blogspot.com
>> > Twitter: @pgsnake
>> >
>> > EnterpriseDB UK: http://www.enterprisedb.com
>> > The Enterprise PostgreSQL Company
>>
>>
>>
>> --
>> Dave Page
>> Blog: http://pgsnake.blogspot.com
>> Twitter: @pgsnake
>>
>> EnterpriseDB UK: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>
>



-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers


Re: [pgadmin-hackers][patch] Correct bundle test that polluted Python modules

2017-06-14 Thread Dave Page
Thanks, that got it. Applied!

On Tue, Jun 13, 2017 at 4:51 PM, Joao Pedro De Almeida Pereira
<jdealmeidapere...@pivotal.io> wrote:
> Hi Hackers,
>
> Good catch Dave.
>
> You can find attached the new diff with the correction of the problem above.
>
> Thanks
> Shruti & Joao
>
> On Tue, Jun 13, 2017 at 10:35 AM, Dave Page <dp...@pgadmin.org> wrote:
>>
>> Hi
>>
>> On Tue, Jun 13, 2017 at 3:25 PM, Joao Pedro De Almeida Pereira
>> <jdealmeidapere...@pivotal.io> wrote:
>> > Hi Hackers,
>> >
>> > Attached you can find the patch that corrects that Bundle tests that was
>> > polluting the os and subprocess modules.
>> >
>> > This patch reverts the commit that skipped the test.
>>
>> This is almost exactly what Ashesh and I came up with (along with a
>> few other variations). Unfortunately, whilst all the other tests now
>> pass, the second execution of the bundler test fails with:
>>
>> ==
>> FAIL: runTest
>> (pgadmin.utils.javascript.tests.test_javascript_bundler.JavascriptBundlerTestCase)
>> scenario name: JavascriptBundlerTestCase
>> --
>> Traceback (most recent call last):
>>   File
>> "/Users/dpage/git/pgadmin4/web/pgadmin/utils/javascript/tests/test_javascript_bundler.py",
>> line 44, in runTest
>> self._bundling_succeeds()
>>   File
>> "/Users/dpage/git/pgadmin4/web/pgadmin/utils/javascript/tests/test_javascript_bundler.py",
>> line 70, in _bundling_succeeds
>> self.mockSubprocess.call.assert_called_once_with(['yarn', 'run',
>> 'bundle:dev'])
>>   File
>> "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/mock/mock.py",
>> line 947, in assert_called_once_with
>> raise AssertionError(msg)
>> AssertionError: Expected 'call' to be called once. Called 0 times.
>>
>> --
>>
>> --
>> Dave Page
>> Blog: http://pgsnake.blogspot.com
>> Twitter: @pgsnake
>>
>> EnterpriseDB UK: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>
>



-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers


Re: [pgadmin-hackers] Declarative partitioning in pgAdmin4

2017-06-14 Thread Dave Page
On Tue, Jun 13, 2017 at 2:59 PM, Akshay Joshi <akshay.jo...@enterprisedb.com
> wrote:

> Hi All
>
> For further implementation following task needs to be work upon:
>
>- How to parse and show partitions keys. For example user has created
>below partitioned table
>
> CREATE TABLE public.sales
> (
> country character varying COLLATE pg_catalog."default" NOT NULL,
> sales bigint,
> saledate date
> ) PARTITION BY RANGE (*country, date_part('year'::text, sale date)*)
>
> When user open the properties dialog I am not able to figure out how to
> parse keys(displayed in bold in above example) and show them in our control
> that we used. For the time being I have hide that control in 'Edit' mode
> (Refer Attach Partition.png)
>
>
I assume psql with display that info with \dt or similar? What does it do?
Failing that, look at pg_dump?


>
>- *Support of sub partitioning*: To implement sub-partitioning,
>specify the PARTITION BY clause in the commands used to create individual
>partitions, for example:
>-
>
>CREATE TABLE measurement_y2006 PARTITION OF measurement
>FOR VALUES FROM ('2006-02-01') TO ('2006-03-01')
>PARTITION BY RANGE (peaktemp);
>
>
>To achieve above I have made some changes in GUI (Refer Sub
> Partition.png).
>*Complex and challenging part here is "measurement_y2006" is
> partition of "measurement" and parent table for other partitions too which
> user can create later. How we will going to show this in browser tree? *
>One option could be
>Tables
>  ->measurement(table)
>->Partitions
>  ->measurement_y2006(Partition of measurement and parent
> of p1)
>->Partitions
>  ->p1
>

Urgh. But yeah. I think that makes logical sense.


>
>- *Attach Partitions*: To implement attach N partitions I have made
>some changes in GUI( Refer Attach Partition.png). Attach Partitions
>control will only be visible in "Edit" mode.
>
> I have only modified the UI changes, there are lots of work needs to be
> done to complete that.
>

I don't think I'd include Attach on the dialog. I think it should be a
separate menu option, with a simple dialogue to let the user choose the
table to attach.

The reason for that is that Attach is an action not a property. On the
Properties panels we expect any changes we make to be the same the next
time the dialogue is opened - e.g. if you toggle "Enable Trigger" to
disabled and hit OK, then next time you open the dialogue you see the
switch in the same position. With Attach, that's not the case - you'll list
one or more tables to attach, hit OK, and when you next open the Properties
dialogue, those partitions will be listed in the partition list, not the
Attach list.


> Please review the design. Suggestions/Comments are welcome.
>
>
> On Tue, Jun 6, 2017 at 4:30 PM, Robert Eckhardt <reckha...@pivotal.io>
> wrote:
>
>>
>>
>> On Tue, Jun 6, 2017 at 4:32 AM, Dave Page <dp...@pgadmin.org> wrote:
>>
>>>
>>> For roll up this pattern seems obvious, identify the n partitions you
>>>> need/want to combine and then run a job to combine them.
>>>>
>>>
>>> You're thinking Greenplum :-). There is no roll up in PostgreSQL, unless
>>> you're thinking we should create such a feature in pgAdmin.
>>>
>>> Of course, I have no objection to extending what we do in PG to add GP
>>> feature support, but let's start with PG.
>>>
>>
>> No not at all. That was a very specific and consistent pattern described
>> by users leveraging time based range partitions in Postgres. I'm not sure
>> if that same use case will be supported with partitioning as implemented in
>> Postgres 10 but it is a Postgres pattern.
>>
>> -- Rob
>>
>>
>>>
>>>
>>>>
>>>> For other patterns such as creating indexes and such it requires a bit
>>>> more thought. Generally users described wanting to treat all of the
>>>> children like a single table (just like Oracle), however, other users
>>>> described potentially modifying chunks of partitions differently depending
>>>> on some criterion. This means that users will need to identify the subset
>>>> they want to optimize and then ideally be able to act on them all at once.
>>>>
>>>
>>> Right.
>>>
>>>
>>>>
>>>> -- Rob
>>>>
>>>>
>>>>
>>>>

Re: [pgadmin-hackers] [pgAdmin4][Patch][RM_2482]: Query tool/ Edit grid panel should have meaningful title

2017-06-13 Thread Dave Page
Hmm, this seems to have broken the feature tests. Can you look at that
ASAP please? I think it's because the tab text has changed.

On Tue, Jun 13, 2017 at 11:34 AM, Dave Page <dp...@pgadmin.org> wrote:
> Thanks, patch applied.
>
> On Tue, Jun 13, 2017 at 6:24 AM, Surinder Kumar
> <surinder.ku...@enterprisedb.com> wrote:
>> Hi
>>
>> Changes:
>>
>> 1) When Query tool is opened, right now - panel title is displayed as "Query
>> - 1 ", instead it should display Query - [db_name] on [server_name] as in
>> pgAdmin3.
>>
>> 2) When Edit grid is opened for table, the panel title should display
>> Edit Data - [server_name] - [db_name] - [table_name]
>>
>> These names are more meaningful instead of "Query - #'. helpful while
>> switching to panel tabs.
>>
>> 3) If panel is inactive and its title is quite long, show ellipsis(...),
>> otherwise display full title.
>>
>> 4) Add tooltips to Query tool/Edit grid panel on mouse hover of tab.
>>
>> Also tested with preference settings > Open query tool in new tab. It
>> works!!.
>>
>> Please find attached patch
>>
>> Thanks
>> Surinder
>>
>>
>> --
>> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
>> To make changes to your subscription:
>> http://www.postgresql.org/mailpref/pgadmin-hackers
>>
>
>
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company



-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers


Re: [pgadmin-hackers][patch] Correct bundle test that polluted Python modules

2017-06-13 Thread Dave Page
Hi

On Tue, Jun 13, 2017 at 3:25 PM, Joao Pedro De Almeida Pereira
<jdealmeidapere...@pivotal.io> wrote:
> Hi Hackers,
>
> Attached you can find the patch that corrects that Bundle tests that was
> polluting the os and subprocess modules.
>
> This patch reverts the commit that skipped the test.

This is almost exactly what Ashesh and I came up with (along with a
few other variations). Unfortunately, whilst all the other tests now
pass, the second execution of the bundler test fails with:

==
FAIL: runTest 
(pgadmin.utils.javascript.tests.test_javascript_bundler.JavascriptBundlerTestCase)
scenario name: JavascriptBundlerTestCase
--
Traceback (most recent call last):
  File 
"/Users/dpage/git/pgadmin4/web/pgadmin/utils/javascript/tests/test_javascript_bundler.py",
line 44, in runTest
self._bundling_succeeds()
  File 
"/Users/dpage/git/pgadmin4/web/pgadmin/utils/javascript/tests/test_javascript_bundler.py",
line 70, in _bundling_succeeds
self.mockSubprocess.call.assert_called_once_with(['yarn', 'run',
'bundle:dev'])
  File 
"/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/mock/mock.py",
line 947, in assert_called_once_with
raise AssertionError(msg)
AssertionError: Expected 'call' to be called once. Called 0 times.

------

-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers


Re: [pgadmin-hackers] pgAdmin 4 commit: Temporarily disable the Javascript bundler test until

2017-06-13 Thread Dave Page
Pivotal team,

Per the commit below, and the probably many messages you've likely
seen from Jenkins, I've had to disable the JavascriptBundler test. It
works fine if you're testing a single server, but if you have more
than one enabled in test_config.json, then it will fail on the second
(and I imagine subsequent) servers.

Can you take a look at this please?

Thanks.

On Tue, Jun 13, 2017 at 2:22 PM, Dave Page <dp...@pgadmin.org> wrote:
> Temporarily disable the Javascript bundler test until it handle more than one 
> run.
>
> Branch
> --
> master
>
> Details
> ---
> https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=cb97722fc3826f94f375f5f48807a486383ee3a9
>
> Modified Files
> --
> web/pgadmin/utils/javascript/tests/test_javascript_bundler.py | 1 +
> 1 file changed, 1 insertion(+)
>
>
> --
> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers



-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers


[pgadmin-hackers] pgAdmin 4 commit: Temporarily disable the Javascript bundler test until

2017-06-13 Thread Dave Page
Temporarily disable the Javascript bundler test until it handle more than one 
run.

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=cb97722fc3826f94f375f5f48807a486383ee3a9

Modified Files
--
web/pgadmin/utils/javascript/tests/test_javascript_bundler.py | 1 +
1 file changed, 1 insertion(+)


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers


Re: [pgadmin-hackers] [pgAdmin4] [PATCH] History Tab rewrite in React

2017-06-13 Thread Dave Page
On Tue, Jun 13, 2017 at 11:47 AM, Surinder Kumar
<surinder.ku...@enterprisedb.com> wrote:
> On Tue, Jun 13, 2017 at 4:05 PM, Dave Page <dp...@pgadmin.org> wrote:
>>
>> On Tue, Jun 13, 2017 at 11:31 AM, Surinder Kumar
>> <surinder.ku...@enterprisedb.com> wrote:
>> >
>> > On Tue, Jun 13, 2017 at 3:56 PM, Dave Page <dp...@pgadmin.org> wrote:
>> >>
>> >> On Tue, Jun 13, 2017 at 11:22 AM, Ashesh Vashi
>> >> <ashesh.va...@enterprisedb.com> wrote:
>> >> > On Tue, Jun 13, 2017 at 2:47 PM, Dave Page <dp...@pgadmin.org> wrote:
>> >> >>
>> >> >> And then I find a problem. Sigh.
>> >> >>
>> >> >> When running in the desktop runtime, under QtWekKit (the forked,
>> >> >> updated version that is by far the best of the browser engines we've
>> >> >> used), we get the attached error at startup. I don't see this under
>> >> >> QtWebEngine, though as we've already found, that's not usable for
>> >> >> other reasons.
>> >> >>
>> >> >> Is this fixable?
>> >> >
>> >> > As per 'http://qtwebkit.blogspot.in/2016/08/qtwebkit-im-back.html':
>> >> > "
>> >> > WebKit engine itself has not been updated since Qt 5.2 release.
>> >> > That's
>> >> > why
>> >> > it didn't support recent changes in Web standards that happened after
>> >> > 2013,
>> >> > including: new JavaScript language standard ES2015 (also known as
>> >> > ES6),
>> >> > as
>> >> > well as improvements in DOM API and CSS.
>> >> > ...
>> >> > "
>> >> >
>> >> > Could this be a reason?
>> >>
>> >> For the old webkit, certainly, but if you read further down, the
>> >> version we're using has been updated and does now claim to support
>> >> most of ES2015.
>> >
>> > In fact the modern browsers don't support ES6 JS so the JS files
>> > containing
>> > ES6 code are first transpiled using babel into JS that browsers
>> > supports.
>>
>> Well, we *could* do that, but are we? I'm not sure the current code
>> does anything more than lint and webpack it.
>
> Yes. babel is used in webpack config which converts JSX, JS and react JS
> library code into browser supportable JS code and put them into generated
> directory which we are then imported in sqleditor.js

Ahh, yes - I see it (still getting my head around this stuff). So,
perhaps we need a different transform to support webkit?


-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers


Re: [pgadmin-hackers] [pgAdmin4] [PATCH] History Tab rewrite in React

2017-06-13 Thread Dave Page
On Tue, Jun 13, 2017 at 11:31 AM, Surinder Kumar
<surinder.ku...@enterprisedb.com> wrote:
>
> On Tue, Jun 13, 2017 at 3:56 PM, Dave Page <dp...@pgadmin.org> wrote:
>>
>> On Tue, Jun 13, 2017 at 11:22 AM, Ashesh Vashi
>> <ashesh.va...@enterprisedb.com> wrote:
>> > On Tue, Jun 13, 2017 at 2:47 PM, Dave Page <dp...@pgadmin.org> wrote:
>> >>
>> >> And then I find a problem. Sigh.
>> >>
>> >> When running in the desktop runtime, under QtWekKit (the forked,
>> >> updated version that is by far the best of the browser engines we've
>> >> used), we get the attached error at startup. I don't see this under
>> >> QtWebEngine, though as we've already found, that's not usable for
>> >> other reasons.
>> >>
>> >> Is this fixable?
>> >
>> > As per 'http://qtwebkit.blogspot.in/2016/08/qtwebkit-im-back.html':
>> > "
>> > WebKit engine itself has not been updated since Qt 5.2 release. That's
>> > why
>> > it didn't support recent changes in Web standards that happened after
>> > 2013,
>> > including: new JavaScript language standard ES2015 (also known as ES6),
>> > as
>> > well as improvements in DOM API and CSS.
>> > ...
>> > "
>> >
>> > Could this be a reason?
>>
>> For the old webkit, certainly, but if you read further down, the
>> version we're using has been updated and does now claim to support
>> most of ES2015.
>
> In fact the modern browsers don't support ES6 JS so the JS files containing
> ES6 code are first transpiled using babel into JS that browsers supports.

Well, we *could* do that, but are we? I'm not sure the current code
does anything more than lint and webpack it.

-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers


Re: [pgadmin-hackers] [pgAdmin4][Patch][RM_2482]: Query tool/ Edit grid panel should have meaningful title

2017-06-13 Thread Dave Page
Thanks, patch applied.

On Tue, Jun 13, 2017 at 6:24 AM, Surinder Kumar
<surinder.ku...@enterprisedb.com> wrote:
> Hi
>
> Changes:
>
> 1) When Query tool is opened, right now - panel title is displayed as "Query
> - 1 ", instead it should display Query - [db_name] on [server_name] as in
> pgAdmin3.
>
> 2) When Edit grid is opened for table, the panel title should display
> Edit Data - [server_name] - [db_name] - [table_name]
>
> These names are more meaningful instead of "Query - #'. helpful while
> switching to panel tabs.
>
> 3) If panel is inactive and its title is quite long, show ellipsis(...),
> otherwise display full title.
>
> 4) Add tooltips to Query tool/Edit grid panel on mouse hover of tab.
>
> Also tested with preference settings > Open query tool in new tab. It
> works!!.
>
> Please find attached patch
>
> Thanks
> Surinder
>
>
> --
> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>



-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers


[pgadmin-hackers] pgAdmin 4 commit: Use a more sensible name for Query Tool tabs. Fixes #

2017-06-13 Thread Dave Page
Use a more sensible name for Query Tool tabs. Fixes #2482

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=57d866f7b70996a82a881b20248c3285ab3a6900
Author: Surinder Kumar 

Modified Files
--
web/pgadmin/browser/templates/browser/js/node.js   |  4 +-
web/pgadmin/static/css/webcabin.overrides.css  | 13 +
.../datagrid/templates/datagrid/js/datagrid.js | 58 --
.../sqleditor/templates/sqleditor/js/sqleditor.js  |  5 +-
4 files changed, 49 insertions(+), 31 deletions(-)


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers


Re: [pgadmin-hackers] [pgAdmin4] [PATCH] History Tab rewrite in React

2017-06-13 Thread Dave Page
On Tue, Jun 13, 2017 at 11:22 AM, Ashesh Vashi
<ashesh.va...@enterprisedb.com> wrote:
> On Tue, Jun 13, 2017 at 2:47 PM, Dave Page <dp...@pgadmin.org> wrote:
>>
>> And then I find a problem. Sigh.
>>
>> When running in the desktop runtime, under QtWekKit (the forked,
>> updated version that is by far the best of the browser engines we've
>> used), we get the attached error at startup. I don't see this under
>> QtWebEngine, though as we've already found, that's not usable for
>> other reasons.
>>
>> Is this fixable?
>
> As per 'http://qtwebkit.blogspot.in/2016/08/qtwebkit-im-back.html':
> "
> WebKit engine itself has not been updated since Qt 5.2 release. That's why
> it didn't support recent changes in Web standards that happened after 2013,
> including: new JavaScript language standard ES2015 (also known as ES6), as
> well as improvements in DOM API and CSS.
> ...
> "
>
> Could this be a reason?

For the old webkit, certainly, but if you read further down, the
version we're using has been updated and does now claim to support
most of ES2015.

-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers


Re: [pgadmin-hackers] pgAdmin 4 commit: Required mock package for python < 3.3.

2017-06-13 Thread Dave Page
On Tue, Jun 13, 2017 at 11:25 AM, Ashesh Vashi <
ashesh.va...@enterprisedb.com> wrote:

> On Tue, Jun 13, 2017 at 3:52 PM, Ashesh Vashi <
> ashesh.va...@enterprisedb.com> wrote:
>
>> Oops.
>> let me revert it back.
>>
> 'web/regressions/requirements.txt' needs to change as it is not require
> for Python >= 3.3.
> Will do the change.
>

OK, thanks.


>
>> --
>>
>> Thanks & Regards,
>>
>> Ashesh Vashi
>> EnterpriseDB INDIA: Enterprise PostgreSQL Company
>> <http://www.enterprisedb.com>
>>
>>
>> *http://www.linkedin.com/in/asheshvashi*
>> <http://www.linkedin.com/in/asheshvashi>
>>
>> On Tue, Jun 13, 2017 at 3:50 PM, Dave Page <dp...@pgadmin.org> wrote:
>>
>>> Is mock required at runtime, or just for tests? It's already in
>>> web/regressions/requirements.txt
>>>
>>> On Tue, Jun 13, 2017 at 11:13 AM, Ashesh Vashi
>>> <ashesh.va...@enterprisedb.com> wrote:
>>> > Required mock package for python < 3.3.
>>> > It was required for the commit:
>>> > 1208206bc0eca2d135469258e8a209b983e668be
>>> >
>>> > Also, do not fetch the scenario-name, when it is not avaiable (but -
>>> use
>>> > default vaule as the stringified test-case itself).
>>> >
>>> > Branch
>>> > --
>>> > master
>>> >
>>> > Details
>>> > ---
>>> > https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdif
>>> f;h=903389d7b76046141c92a720e9e515cc4bb46274
>>> >
>>> > Modified Files
>>> > --
>>> > requirements.txt   | 3 ++-
>>> > web/regression/runtests.py | 8 +++++---
>>> > 2 files changed, 7 insertions(+), 4 deletions(-)
>>> >
>>> >
>>> > --
>>> > Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
>>> > To make changes to your subscription:
>>> > http://www.postgresql.org/mailpref/pgadmin-hackers
>>>
>>>
>>>
>>> --
>>> Dave Page
>>> Blog: http://pgsnake.blogspot.com
>>> Twitter: @pgsnake
>>>
>>> EnterpriseDB UK: http://www.enterprisedb.com
>>> The Enterprise PostgreSQL Company
>>>
>>
>>
>


-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


Re: [pgadmin-hackers] pgAdmin 4 commit: Required mock package for python < 3.3.

2017-06-13 Thread Dave Page
Is mock required at runtime, or just for tests? It's already in
web/regressions/requirements.txt

On Tue, Jun 13, 2017 at 11:13 AM, Ashesh Vashi
<ashesh.va...@enterprisedb.com> wrote:
> Required mock package for python < 3.3.
> It was required for the commit:
> 1208206bc0eca2d135469258e8a209b983e668be
>
> Also, do not fetch the scenario-name, when it is not avaiable (but - use
> default vaule as the stringified test-case itself).
>
> Branch
> --
> master
>
> Details
> ---
> https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=903389d7b76046141c92a720e9e515cc4bb46274
>
> Modified Files
> --
> requirements.txt   | 3 ++-
> web/regression/runtests.py | 8 +---
> 2 files changed, 7 insertions(+), 4 deletions(-)
>
>
> --
> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers



-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers


Re: [pgadmin-hackers] [pgAdmin4] [PATCH] Skip CheckForViewDataTest test based on the DB version

2017-06-13 Thread Dave Page
Thanks, applied.

On Mon, Jun 12, 2017 at 8:14 PM, Joao Pedro De Almeida Pereira
<jdealmeidapere...@pivotal.io> wrote:
> Hello Hackers,
> We sent the wrong patch. Attached is the correct one.
>
> Sorry
>
> Shruti & Joao
>
> On Mon, Jun 12, 2017 at 3:08 PM, Joao Pedro De Almeida Pereira
> <jdealmeidapere...@pivotal.io> wrote:
>>
>> Hi Hackers,
>>
>> We were trying to run the feature tests against GreenPlum and one of the
>> tests was failing (CheckForViewDataTest). In this test, we are creating a
>> table using COLLATE, and the COLLATE command is only available starting in
>> version 9.1 of Postgres, per the documentation. We decided to skip this test
>> for now for all PG Versions below 9.1
>>
>> Thanks
>> Shruti & Joao
>
>
>
>
> --
> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>



-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers


[pgadmin-hackers] pgAdmin 4 commit: Skip a test that uses the COLLATE option on PG versio

2017-06-13 Thread Dave Page
Skip a test that uses the COLLATE option on PG versions below 9.1 (e.g. 
Greenplum).

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=a9ce9c97173e904792073597f90ff30c4bfdc1fc
Author: Joao Pedro De Almeida Pereira 

Modified Files
--
web/pgadmin/feature_tests/view_data_dml_queries.py | 4 
1 file changed, 4 insertions(+)


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers


Re: [pgadmin-hackers] [pgAdmin4][Patch][RM_ 2477]: New Line text edit pop up renders off page when the size of the grid exceeds the size of the window

2017-06-13 Thread Dave Page
On Mon, Jun 12, 2017 at 5:55 PM, Shirley Wang <sw...@pivotal.io> wrote:
>>>
>>>
>>> On Mon, Jun 12, 2017 at 2:27 PM, Surinder Kumar
>>> <surinder.ku...@enterprisedb.com> wrote:
>>> > Hi
>>> >
>>> > The current font-family applied to slick-grid is
>>> > 'Verdana,Arial,sans-serif'.
>>> > I tried changing it to "Helvetica Neue", Helvetica, Arial, sans-serif
>>> > but
>>> > the font size and spacing between text is reduced. so to match style I
>>> > used
>>> > "Verdana".
>>> >
>>> > Also, as per my knowledge, the Helvetica font will work only for
>>> > Operating
>>> > Systems where this font actually exists in system, otherwise it will
>>> > pick
>>> > Arial font.
>>> >
>>> > The right way to use 'Helvetica' is to download its 'ttf' and 'eot'
>>> > files
>>> > and use in CSS so that it appears same on all machines:
>>> >
>>> > https://stackoverflow.com/questions/13013616/css-helvetica-neue-not-working
>>> >
>>> > But it seems it is not available for free
>>> > https://www.myfonts.com/fonts/linotype/neue-helvetica/licensing.html
>>>
>>> Oh, that's not good. I assume we were relying on it being on a users
>>> machine already. I think we need to do one of two things:
>>>
>>> 1) Default to a font that we know should exist everywhere.
>>> 2) Have a fallback from Helvetica Neue to Arial or similar.
>>>
>>> 3) Choose something completely new and free, and ship it with the app.
>>>
>>> I prefer 1 if possible, then 2, finally 3.
>>>
>>> Shirley, any thoughts?
>
>
> Option 1 would require us choosing something new and free (there are a lot
> of webfonts you can get from Google) but would take some time to pick the
> appropriate one.
>
> Option 2 would be the best option for now. We should stick with Helvetica
> and Arial until we have more time to choose the right font.

Sounds good to me.

Surinder, can you make that change please? And update any other font
definitions in our CSS to have the same fallback?

Thanks.

-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers


Re: [pgadmin-hackers] [pgAdmin4][Patch]: Added the shortcut (CTRL + 0) to reset the zoom level in runtime

2017-06-13 Thread Dave Page
Nice work! Committed (along with an update to the docs).

Congratulations on your first C++ patch :-)

On Tue, Jun 13, 2017 at 7:07 AM, Khushboo Vashi
<khushboo.va...@enterprisedb.com> wrote:
> Hi,
>
> On Mon, Jun 12, 2017 at 5:27 PM, Dave Page <dp...@pgadmin.org> wrote:
>>
>> Hi
>>
>> On Mon, Jun 12, 2017 at 5:33 AM, Khushboo Vashi
>> <khushboo.va...@enterprisedb.com> wrote:
>> > Hi,
>> >
>> > Please find the attached patch to reset the zoom level in the desktop
>> > runtime.
>> >
>> > Added the new shortcut CTRL + 0 to reset the zoom level.
>>
>> The code looks good, however I don't think resetting to the startup
>> value is really what we want. Shouldn't it reset it to 1.0?
>>
> I have changed the code.
> Also, introduced a single slot for Zoom In/Out/Reset rather than 3
> different.
>>
>> --
>> Dave Page
>> Blog: http://pgsnake.blogspot.com
>> Twitter: @pgsnake
>>
>> EnterpriseDB UK: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>
>



-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers


[pgadmin-hackers] pgAdmin 4 commit: Add a shortcut (Ctrl/Cmd + 0 (zero)) to the runtime t

2017-06-13 Thread Dave Page
Add a shortcut (Ctrl/Cmd + 0 (zero)) to the runtime to allow the zoom level to 
be reset. Fixes #2485

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=3a5fda44e400492bd76811906f5261334d819956
Author: Khushboo Vashi 

Modified Files
--
docs/en_US/keyboard_shortcuts.rst |  2 ++
runtime/BrowserWindow.cpp | 69 +++
runtime/BrowserWindow.h   |  5 +--
3 files changed, 32 insertions(+), 44 deletions(-)


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers


Re: [pgadmin-hackers] [pgAdmin4] [PATCH] History Tab rewrite in React

2017-06-13 Thread Dave Page
Hi

On Mon, Jun 12, 2017 at 7:22 PM, Shruti B Iyer <si...@pivotal.io> wrote:
> Hi Dave,
>
> We regenerated the patch to add new tasks to package.json to compile react
> code for development and to not minimize it. This should fix the error you
> captured in the screenshot.
>
> The new task to lint and bundle everything for development is:
> yarn run bundle:dev
>
> The new task only bundle everything is:
> yarn run webpacker:dev
>
> We also changed the task test:feature to bundle without optimization before
> we start the tests.
>
> When we ran these commands in our machine, they did not display any error.
> Is it possible that you forgot to run yarn install before running the
> webpacker task? We are asking this because the errors look like missing node
> packages.

I did run an install, yes. This patch does work though, so applied - thanks!

Could you answer my earlier question about the need for the delay in
app_starter.py please?

Thanks.

> On Mon, Jun 12, 2017 at 12:15 PM Dave Page <dp...@pgadmin.org> wrote:
>>
>> To add to that; running the JS tests gives:
>>
>> ERROR in ./regression/javascript/history/query_history_entry_spec.jsx
>> Module not found: Error: Can't resolve 'jasmine-enzyme' in
>> '/Users/dpage/git/pgadmin4/web/regression/javascript/history'
>>  @ ./regression/javascript/history/query_history_entry_spec.jsx 13:21-46
>>
>> ERROR in ./pgadmin/static/jsx/history/query_history_entry.jsx
>> Module not found: Error: Can't resolve 'immutability-helper' in
>> '/Users/dpage/git/pgadmin4/web/pgadmin/static/jsx/history'
>>  @ ./pgadmin/static/jsx/history/query_history_entry.jsx 13:26-56
>>  @ ./regression/javascript/history/query_history_entry_spec.jsx
>>
>> ERROR in ./pgadmin/static/jsx/history/query_history_entry.jsx
>> Module not found: Error: Can't resolve 'moment' in
>> '/Users/dpage/git/pgadmin4/web/pgadmin/static/jsx/history'
>>  @ ./pgadmin/static/jsx/history/query_history_entry.jsx 17:14-31
>>  @ ./regression/javascript/history/query_history_entry_spec.jsx
>>
>> ERROR in ./regression/javascript/history/query_history_spec.jsx
>> Module not found: Error: Can't resolve 'jasmine-enzyme' in
>> '/Users/dpage/git/pgadmin4/web/regression/javascript/history'
>>  @ ./regression/javascript/history/query_history_spec.jsx 19:21-46
>> webpack: Failed to compile.
>> PhantomJS 2.1.1 (Mac OS X 0.0.0) ERROR
>>   Error: Cannot find module "immutability-helper"
>>   at regression/javascript/history/query_history_entry_spec.jsx:30705
>>
>>
>> PhantomJS 2.1.1 (Mac OS X 0.0.0) ERROR
>>   Error: Cannot find module "immutability-helper"
>>   at regression/javascript/history/query_history_spec.jsx:30705
>>
>>
>> error Command failed with exit code 1.
>> info Visit https://yarnpkg.com/en/docs/cli/run for documentation about
>> this command.
>> error Command failed with exit code 1.
>> info Visit https://yarnpkg.com/en/docs/cli/run for documentation about
>> this command.
>>
>>
>> Also, while I think of it, why the addition of the delay to
>> app_starter.py?
>>
>>
>> On Mon, Jun 12, 2017 at 5:12 PM, Dave Page <dp...@pgadmin.org> wrote:
>> > Hi,
>> >
>> > So 01 and 02 are now committed :-).
>> >
>> > 03 has a couple of problems though (likely the same):
>> >
>> > - Running the webpacker results in:
>> >
>> > (pgadmin4)piranha:web dpage$ yarn run webpacker
>> > yarn run v0.24.4
>> > $ yarn run webpack -- --optimize-minimize --config webpack.config.js
>> > yarn run v0.24.4
>> > $ "/Users/dpage/git/pgadmin4/web/node_modules/.bin/webpack"
>> > --optimize-minimize --config webpack.config.js
>> > (node:19446) DeprecationWarning: loaderUtils.parseQuery() received a
>> > non-string value which can be problematic, see
>> > https://github.com/webpack/loader-utils/issues/56
>> > parseQuery() will be replaced with getOptions() in the next major
>> > version of loader-utils.
>> > Hash: a5e75aa70eb6b09bdb78
>> > Version: webpack 2.3.3
>> > Time: 3983ms
>> >  Asset Size  Chunks Chunk Names
>> > reactComponents.js   222 kB   0  [emitted]  reactComponents
>> > history.js  1.58 kB   1  [emitted]  history
>> >[0] /Users/dpage/git/pgadmin4/web/~/process/browser.js 5.42 kB {0}
>> > [built]
>> >   [18] /Users/dpage/git/pgadmin4/web/~/react-dom/lib/ReactReconciler.js
>> > 6.21 kB {0} [built]
>> >   [19] /Users/dpage/git/pgadmin4/web/~/

[pgadmin-hackers] pgAdmin 4 commit: Initial re-vamp of the History tab.

2017-06-13 Thread Dave Page
Initial re-vamp of the History tab.

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=1208206bc0eca2d135469258e8a209b983e668be
Author: Shruti B Iyer 

Modified Files
--
web/.eslintrc.js   |   7 +-
web/karma.conf.js  |   2 +-
web/package.json   |   6 +
.../feature_tests/query_tool_journey_test.py   | 111 +
.../xss_checks_pgadmin_debugger_test.py|   2 +-
.../static/js/history/history_collection.js|  34 
web/pgadmin/static/js/history/index.js |  14 ++
web/pgadmin/static/jsx/components.jsx  |   2 +
web/pgadmin/static/jsx/history/query_history.jsx   |  49 ++
.../static/jsx/history/query_history_entry.jsx |  93 +++
.../sqleditor/templates/sqleditor/js/sqleditor.js  | 179 -
web/pgadmin/utils/javascript/javascript_bundler.py |   2 +-
.../javascript/tests/test_javascript_bundler.py|   4 +-
web/regression/feature_utils/app_starter.py|   2 +
web/regression/feature_utils/pgadmin_page.py   |  28 ++--
.../javascript/check_node_visibility_spec.js   |  32 
.../javascript/check_node_visiblity_spec.js|  32 
.../javascript/history/history_collection_spec.js  |  83 ++
.../history/query_history_entry_spec.jsx   |  50 ++
.../javascript/history/query_history_spec.jsx  | 103 
web/regression/python_test_utils/test_utils.py |   2 +
web/webpack.config.js  |  11 +-
web/webpack.test.config.js |  10 +-
web/yarn.lock  |  79 -
24 files changed, 726 insertions(+), 211 deletions(-)


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers


Re: [pgadmin-hackers] [pgAdmin4][Patch]: Fixed RM 2324 - PostGIS datatypes not showing up properly on SQL tab.

2017-06-13 Thread Dave Page
Thanks, applied.

On Tue, Jun 13, 2017 at 4:45 AM, Khushboo Vashi <
khushboo.va...@enterprisedb.com> wrote:

> Hi,
>
> On Mon, Jun 12, 2017 at 8:24 PM, Dave Page <dp...@pgadmin.org> wrote:
>
>> Hi Khushboo,
>>
>> Looks like this patch broke the regressions tests :-(. Can you take a
>> look ASAP please?
>>
>> please find the attached fix. However I didn't get any error while
> running regression tests.
>
>> Thanks!
>>
>> 2017-06-12 10:04:11,938: INFO werkzeug: 127.0.0.1 - - [12/Jun/2017
>> 10:04:11] "GET /browser/table/sql/1/1/12669/2200/81920 HTTP/1.1" 500 -
>> Traceback (most recent call last):
>>   File "/Users/pivotal/.pyenv/versions/2.7.10/envs/pgadmin/lib/pyth
>> on2.7/site-packages/flask/app.py", line 2000, in __call__
>> return self.wsgi_app(environ, start_response)
>>   File "/Users/pivotal/.pyenv/versions/2.7.10/envs/pgadmin/lib/pyth
>> on2.7/site-packages/flask/app.py", line 1991, in wsgi_app
>> response = self.make_response(self.handle_exception(e))
>>   File "/Users/pivotal/.pyenv/versions/2.7.10/envs/pgadmin/lib/pyth
>> on2.7/site-packages/flask/app.py", line 1567, in handle_exception
>> reraise(exc_type, exc_value, tb)
>>   File "/Users/pivotal/.pyenv/versions/2.7.10/envs/pgadmin/lib/pyth
>> on2.7/site-packages/flask/app.py", line 1988, in wsgi_app
>> response = self.full_dispatch_request()
>>   File "/Users/pivotal/.pyenv/versions/2.7.10/envs/pgadmin/lib/pyth
>> on2.7/site-packages/flask/app.py", line 1641, in full_dispatch_request
>> rv = self.handle_user_exception(e)
>>   File "/Users/pivotal/.pyenv/versions/2.7.10/envs/pgadmin/lib/pyth
>> on2.7/site-packages/flask/app.py", line 1544, in handle_user_exception
>> reraise(exc_type, exc_value, tb)
>>   File "/Users/pivotal/.pyenv/versions/2.7.10/envs/pgadmin/lib/pyth
>> on2.7/site-packages/flask/app.py", line 1639, in full_dispatch_request
>> rv = self.dispatch_request()
>>   File "/Users/pivotal/.pyenv/versions/2.7.10/envs/pgadmin/lib/pyth
>> on2.7/site-packages/flask/app.py", line 1625, in dispatch_request
>> return self.view_functions[rule.endpoint](**req.view_args)
>>   File "/Users/pivotal/.pyenv/versions/2.7.10/envs/pgadmin/lib/pyth
>> on2.7/site-packages/flask/views.py", line 84, in view
>> return self.dispatch_request(*args, **kwargs)
>>   File "/Users/pivotal/workspace/pgadmin4/web/pgadmin/browser/utils.py",
>> line 235, in dispatch_request
>> return method(*args, **kwargs)
>>   File "/Users/pivotal/workspace/pgadmin4/web/pgadmin/browser/serve
>> r_groups/servers/databases/schemas/tables/__init__.py", line 315, in wrap
>> return f(*args, **kwargs)
>>   File "/Users/pivotal/workspace/pgadmin4/web/pgadmin/browser/serve
>> r_groups/servers/databases/schemas/tables/__init__.py", line 2555, in sql
>> data = self._formatter(did, scid, tid, data)
>>   File "/Users/pivotal/workspace/pgadmin4/web/pgadmin/browser/serve
>> r_groups/servers/databases/schemas/tables/__init__.py", line 1081, in
>> _formatter
>> data = self._columns_formatter(tid, data)
>>   File "/Users/pivotal/workspace/pgadmin4/web/pgadmin/browser/serve
>> r_groups/servers/databases/schemas/tables/__init__.py", line 663, in
>> _columns_formatter
>> column['attlen'] = matchObj.group(1)
>> AttributeError: 'NoneType' object has no attribute 'group'
>>
>>
>> On Mon, Jun 12, 2017 at 12:49 PM, Dave Page <dp...@pgadmin.org> wrote:
>>
>>> Thanks, applied.
>>>
>>> On Fri, Jun 9, 2017 at 10:18 AM, Khushboo Vashi <
>>> khushboo.va...@enterprisedb.com> wrote:
>>>
>>>> Hi,
>>>>
>>>> Please find the attached updated patch.
>>>>
>>>> Fixed the PostGIS Datatypes in SQL tab, Create / Update dialogues for
>>>> Table, Column, Foreign Table and Type node.
>>>>
>>>> Regarding  the review comment given by Dave (Also, I there should be a
>>>> space between the , and value in the_geom geometry(MultiPolygon,3310).),
>>>> won't be fixed as this format is returned by format_type() function itself.
>>>>
>>>> As per the conversation with Dave, I have logged RM #2473
>>>> <https://redmine.postgresql.org/issues/2473> to add support for
>>>> PostGIS Datatypes.
>>>>
>>>> Thanks,
>>>> Khushboo
>>>>
>>>> On Tue, Jun 6, 2017 at 6:49 PM, Dave

[pgadmin-hackers] pgAdmin 4 commit: Fix the fix for RM2324.

2017-06-13 Thread Dave Page
Fix the fix for RM2324.

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=16a15bf9344ed9938cade6eb7090cd7149c4b550
Author: Khushboo Vashi 

Modified Files
--
.../servers/databases/schemas/tables/__init__.py  | 18 +++---
.../databases/schemas/tables/column/__init__.py   | 19 +++
.../servers/databases/schemas/types/__init__.py   | 17 ++---
3 files changed, 32 insertions(+), 22 deletions(-)


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers


Re: [pgadmin-hackers] PG Admin 4

2017-06-13 Thread Dave Page
Hi

On Tue, Jun 13, 2017 at 3:09 AM, Matt Owen <matt.o...@theta.co.nz> wrote:

> Hi
>
>
>
> PGADMIN4 looks great –
>

Thanks!


> however Is there a way to disable the dashboard stuff – the “remove panel”
> option doesn’t seem to work that we can see (you can float it but not close
> it).  We are accessing an Amazon RDS a long way away and its quite slow and
> the server status refreshing function we suspect is slowing things down
>
> Could be doing something wrong – but couldn’t seem to find it.
>

You cannot remove the dashboard panel, but if you go to File -> Preferences
-> Dashboard -> Graphs, you can adjust the refresh intervals to very high
values to work around the issue.


>
>
>
>
>
>
>
>
> Regards
>
>
>
> Matt
>
>
>
>
>
>
>
>
>
> Matt Owen | Principal Consultant | Theta
>
>
> [image: Theta Logo]
>
>
>
> Level 2, Theta House, 8-10 Beresford Square, Auckland Central 1010, NZ
>
> M. +64274394930 <+64%20274%20394%20930>
>
> matt.o...@theta.co.nz | theta.co.nz <https://www.theta.co.nz>
>
>
> [image: FaceBook Logo] <https://www.facebook.com/thetasystems/>  [image:
> Twitter Logo] <https://twitter.com/thetanet>  [image: LinkedIn Logo]
> <https://www.linkedin.com/company/theta-systems-ltd>
>
>
> --
>
> This information is intended for the addressee only. It may contain
> confidential and legally privileged information. If you are not the
> intended recipient, please reply to advise the sender and do not disclose,
> copy or redistribute this document or any information contained herein.
>
> Please consider the environment before printing this email.
>



-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


Re: [pgadmin-hackers] [pgAdmin4] [PATCH] Translatable Text in Query Results Header

2017-06-12 Thread Dave Page
Thanks, applied.

On Mon, Jun 12, 2017 at 4:43 PM, Shruti B Iyer <si...@pivotal.io> wrote:
> Hi Hackers!
>
> Attached is a minor patch that wraps with gettext() the "Select/Deselect
> All" text in the top left corner of the query results grid.
>
> Thanks,
> Matt and Shruti
>
>
> --
> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>



-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers


[pgadmin-hackers] pgAdmin 4 commit: Bring React into the tree, and add linting and bundli

2017-06-12 Thread Dave Page
Bring React into the tree, and add linting and bundling framework for the JS 
etc.

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=659eb1c1e821e2ea414dc00d22022b8a2d7c91f7
Author: Shruti B Iyer 

Modified Files
--
.gitignore |1 +
Make-MinGW.bat |6 +
Make.bat   |6 +
pkg/mac/build.sh   |5 +
pkg/pip/build.sh   |9 +
pkg/src/build.sh   |   11 +
web/karma.conf.js  |   55 +-
web/package.json   |   45 +-
web/pgAdmin4.py|   28 +-
web/pgadmin/static/jsx/components.jsx  |8 +
web/pgadmin/utils/javascript/__init__.py   |8 +
web/pgadmin/utils/javascript/javascript_bundler.py |   62 +
web/pgadmin/utils/javascript/tests/__init__.py |8 +
.../javascript/tests/test_javascript_bundler.py|  117 +
web/regression/README  |9 +-
web/regression/javascript/browser/menu_spec.js |8 +-
web/regression/javascript/gettext_spec.js  |   65 +-
.../jasmine_capture_warnings_beforeall.js  |   23 +
.../javascript/selection/column_selector_spec.js   |  708 +--
.../javascript/selection/copy_data_spec.js |  227 +-
.../javascript/selection/grid_selector_spec.js |  209 +-
.../selection/range_boundary_navigator_spec.js |   22 +-
.../selection/range_selection_helper_spec.js   |  132 +-
.../javascript/selection/row_selector_spec.js  |  558 +--
.../selection/xcell_selection_model_spec.js|  778 ++--
.../javascript/slickgrid/cell_selector_spec.js |  110 +-
.../handle_query_output_keyboard_event_spec.js |  208 +-
web/regression/javascript/test-main.js |  139 -
web/regression/requirements.txt|1 +
web/webpack.config.js  |   29 +
web/webpack.test.config.js |   71 +
web/yarn.lock  | 4526 
32 files changed, 6516 insertions(+), 1676 deletions(-)


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers


[pgadmin-hackers] pgAdmin 4 commit: Add a missing translation call.

2017-06-12 Thread Dave Page
Add a missing translation call.

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=f1acad85db4b9bf8a201cd8b6d90c703322a0073
Author: Shruti B Iyer 

Modified Files
--
web/pgadmin/static/js/selection/grid_selector.js | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers


[pgadmin-hackers] pgAdmin 4 commit: Add linting support, and, well, lint.

2017-06-12 Thread Dave Page
Add linting support, and, well, lint.

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=3f4f8b9e77204a62ecdbf99caf296b6ac39b0f5e
Author: Shruti B Iyer 

Modified Files
--
web/.eslintrc.js   |  45 +
web/karma.conf.js  |   4 +-
web/package.json   |  10 +-
.../static/js/selection/active_cell_capture.js |  10 +-
web/pgadmin/static/js/selection/clipboard.js   |   4 +-
web/pgadmin/static/js/selection/column_selector.js |  28 +++---
web/pgadmin/static/js/selection/copy_data.js   |  22 +
web/pgadmin/static/js/selection/grid_selector.js   | 105 ++---
.../js/selection/range_boundary_navigator.js   |   8 +-
.../static/js/selection/range_selection_helper.js  |  24 ++---
web/pgadmin/static/js/selection/row_selector.js|  12 +--
web/pgadmin/static/js/selection/set_staged_rows.js |  10 +-
.../static/js/selection/xcell_selection_model.js   |  53 +--
web/regression/javascript/browser/menu_spec.js |   2 +-
.../javascript/check_node_visiblity_spec.js|  16 ++--
web/regression/javascript/fake_translations.js |   2 +-
.../selection/active_cell_capture_spec.js  |  23 ++---
.../javascript/selection/column_selector_spec.js   |  32 ---
.../javascript/selection/copy_data_spec.js |  65 +++--
.../javascript/selection/grid_selector_spec.js |  10 +-
.../selection/range_boundary_navigator_spec.js |  75 ---
.../selection/range_selection_helper_spec.js   |  36 +++
.../javascript/selection/row_selector_spec.js  |  19 ++--
.../javascript/selection/set_staged_rows_spec.js   |  28 +++---
.../selection/xcell_selection_model_spec.js|  23 ++---
web/regression/javascript/size_prettify_spec.js|  56 +--
.../javascript/slickgrid/cell_selector_spec.js |  29 +++---
.../handle_query_output_keyboard_event_spec.js |  44 +
web/regression/javascript/sqleditor_utils_spec.js  |  12 +--
web/webpack.test.config.js |   1 -
web/yarn.lock  |  16 +---
31 files changed, 424 insertions(+), 400 deletions(-)


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers


Re: [pgadmin-hackers] [pgAdmin4] [PATCH] History Tab rewrite in React

2017-06-12 Thread Dave Page
To add to that; running the JS tests gives:

ERROR in ./regression/javascript/history/query_history_entry_spec.jsx
Module not found: Error: Can't resolve 'jasmine-enzyme' in
'/Users/dpage/git/pgadmin4/web/regression/javascript/history'
 @ ./regression/javascript/history/query_history_entry_spec.jsx 13:21-46

ERROR in ./pgadmin/static/jsx/history/query_history_entry.jsx
Module not found: Error: Can't resolve 'immutability-helper' in
'/Users/dpage/git/pgadmin4/web/pgadmin/static/jsx/history'
 @ ./pgadmin/static/jsx/history/query_history_entry.jsx 13:26-56
 @ ./regression/javascript/history/query_history_entry_spec.jsx

ERROR in ./pgadmin/static/jsx/history/query_history_entry.jsx
Module not found: Error: Can't resolve 'moment' in
'/Users/dpage/git/pgadmin4/web/pgadmin/static/jsx/history'
 @ ./pgadmin/static/jsx/history/query_history_entry.jsx 17:14-31
 @ ./regression/javascript/history/query_history_entry_spec.jsx

ERROR in ./regression/javascript/history/query_history_spec.jsx
Module not found: Error: Can't resolve 'jasmine-enzyme' in
'/Users/dpage/git/pgadmin4/web/regression/javascript/history'
 @ ./regression/javascript/history/query_history_spec.jsx 19:21-46
webpack: Failed to compile.
PhantomJS 2.1.1 (Mac OS X 0.0.0) ERROR
  Error: Cannot find module "immutability-helper"
  at regression/javascript/history/query_history_entry_spec.jsx:30705


PhantomJS 2.1.1 (Mac OS X 0.0.0) ERROR
  Error: Cannot find module "immutability-helper"
  at regression/javascript/history/query_history_spec.jsx:30705


error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about
this command.
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about
this command.


Also, while I think of it, why the addition of the delay to app_starter.py?


On Mon, Jun 12, 2017 at 5:12 PM, Dave Page <dp...@pgadmin.org> wrote:
> Hi,
>
> So 01 and 02 are now committed :-).
>
> 03 has a couple of problems though (likely the same):
>
> - Running the webpacker results in:
>
> (pgadmin4)piranha:web dpage$ yarn run webpacker
> yarn run v0.24.4
> $ yarn run webpack -- --optimize-minimize --config webpack.config.js
> yarn run v0.24.4
> $ "/Users/dpage/git/pgadmin4/web/node_modules/.bin/webpack"
> --optimize-minimize --config webpack.config.js
> (node:19446) DeprecationWarning: loaderUtils.parseQuery() received a
> non-string value which can be problematic, see
> https://github.com/webpack/loader-utils/issues/56
> parseQuery() will be replaced with getOptions() in the next major
> version of loader-utils.
> Hash: a5e75aa70eb6b09bdb78
> Version: webpack 2.3.3
> Time: 3983ms
>  Asset Size  Chunks Chunk Names
> reactComponents.js   222 kB   0  [emitted]  reactComponents
> history.js  1.58 kB   1  [emitted]  history
>[0] /Users/dpage/git/pgadmin4/web/~/process/browser.js 5.42 kB {0} [built]
>   [18] /Users/dpage/git/pgadmin4/web/~/react-dom/lib/ReactReconciler.js
> 6.21 kB {0} [built]
>   [19] /Users/dpage/git/pgadmin4/web/~/react/lib/React.js 2.69 kB {0} [built]
>   [31] /Users/dpage/git/pgadmin4/web/~/react/react.js 56 bytes {0} [built]
>   [80] ./js/history/history_collection.js 1.91 kB {1} [built]
>   [81] ./jsx/history/query_history.jsx 3.65 kB {0} [built]
>   [82] /Users/dpage/git/pgadmin4/web/~/react-dom/index.js 59 bytes {0} [built]
>   [83] ./js/history/index.js 690 bytes {1} [built]
>   [84] ./jsx/components.jsx 599 bytes {0} [built]
>   [85] ./jsx/history/query_history_entry.jsx 5.21 kB {0} [built]
>  [113] /Users/dpage/git/pgadmin4/web/~/react-dom/lib/ReactDOM.js 5.14
> kB {0} [built]
>  [175] /Users/dpage/git/pgadmin4/web/~/react/lib/ReactDOMFactories.js
> 5.53 kB {0} [built]
>  [176] /Users/dpage/git/pgadmin4/web/~/react/lib/ReactPropTypes.js
> 15.8 kB {0} [built]
>  [177] /Users/dpage/git/pgadmin4/web/~/react/lib/ReactPureComponent.js
> 1.32 kB {0} [built]
>  [178] /Users/dpage/git/pgadmin4/web/~/react/lib/ReactVersion.js 350
> bytes {0} [built]
> + 167 hidden modules
>
> ERROR in ./jsx/history/query_history_entry.jsx
> Module not found: Error: Can't resolve 'immutability-helper' in
> '/Users/dpage/git/pgadmin4/web/pgadmin/static/jsx/history'
>  @ ./jsx/history/query_history_entry.jsx 13:26-56
>  @ ./jsx/history/query_history.jsx
>  @ ./jsx/components.jsx
>
> ERROR in ./jsx/history/query_history_entry.jsx
> Module not found: Error: Can't resolve 'moment' in
> '/Users/dpage/git/pgadmin4/web/pgadmin/static/jsx/history'
>  @ ./jsx/history/query_history_entry.jsx 17:14-31
>  @ ./jsx/history/query_history.jsx
>  @ ./jsx/components.jsx
> error Command failed with exit code 2.
> info Visit https://yarnpkg.com/en/docs/cli/run for documentation about
> this command.
> 

[pgadmin-hackers] PACKAGERS BEWARE: Build changes required

2017-06-12 Thread Dave Page
I've just committed a couple of patches that change the requirements
for building pgAdmin for packages:

- You will need node.js and yarn to be installed for building

- During the build process, do something like this:

cd $PGADMIN_SRC/web
yarn install
yarn run bundle

This will create web/node_modules and pgadmin/static/js/generated
directories that will need to be included in packages.

This is part of a numer of in-progress changes:

1) To remove all vendor code from the pgAdmin source tree. Eventually
is should all be installed using Yarn into a vendor/ directory. Each
developer/packager will need to do this.

2) Web-packing of all the JS and CSS code. This will minimise all the
JS/CSS to reduce file transfer sizes, and bundle it together into as
few files as possible to minimise client/server round trips.

3) A move towards React to improve UI rendering/generation etc.

-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers


Re: [pgadmin-hackers] [pgAdmin4][Patch][Feature_1535]: Pressing ESC from within a dialog box should act like "Cancel" button

2017-06-12 Thread Dave Page
Thanks, applied.

On Mon, Jun 12, 2017 at 3:52 PM, Surinder Kumar
<surinder.ku...@enterprisedb.com> wrote:
> Hi Dave,
>
> Please find updated patch.
>
> On Mon, Jun 12, 2017 at 7:58 PM, Dave Page <dp...@pgadmin.org> wrote:
>>
>> Hi
>>
>> On Mon, Jun 12, 2017 at 2:03 PM, Surinder Kumar
>> <surinder.ku...@enterprisedb.com> wrote:
>> > Hi
>> >
>> > I confirm this is updated patch.
>>
>> Thanks. Something else seems to have changed that I can't spot. Only
>>  should be ignored if a child control has focus - Escape and
>> F1 should continue to work. I tried moving the:
>>
>> if (panel && panel['_type'] !== 'node_props') return;
>>
>> into the branch for keyCode.ENTER, but that doesn't seem to help.
>
> Fixed.
>>
>>
>> --
>> Dave Page
>> Blog: http://pgsnake.blogspot.com
>> Twitter: @pgsnake
>>
>> EnterpriseDB UK: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>
>



-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers


[pgadmin-hackers] pgAdmin 4 commit: Teach dialogues about Escape to cancel, Enter to Save

2017-06-12 Thread Dave Page
Teach dialogues about Escape to cancel, Enter to Save/OK, and F1 for help. 
Fixes #1535

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=af43ccfc07bd1f919015b79ce9c9e7e06d92cf6a
Author: Surinder Kumar 

Modified Files
--
.../templates/tablespaces/js/tablespaces.js|   4 +-
.../servers/templates/servers/servers.js   |   2 +-
web/pgadmin/browser/templates/browser/js/node.js   | 150 +
.../templates/file_manager/js/file_manager.js  |   6 +-
.../templates/preferences/preferences.js   |   4 +-
.../tools/backup/templates/backup/js/backup.js |  12 +-
.../debugger/templates/debugger/js/debugger_ui.js  |   2 +-
.../templates/import_export/js/import_export.js|   2 +-
.../templates/maintenance/js/maintenance.js|   6 +-
.../tools/restore/templates/restore/js/restore.js  |   6 +-
.../user_management/js/user_management.js  |   2 +-
11 files changed, 118 insertions(+), 78 deletions(-)


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers


Re: [pgadmin-hackers] [pgAdmin4][Patch]: Fixed RM 2324 - PostGIS datatypes not showing up properly on SQL tab.

2017-06-12 Thread Dave Page
Hi Khushboo,

Looks like this patch broke the regressions tests :-(. Can you take a look
ASAP please?

Thanks!

2017-06-12 10:04:11,938: INFO werkzeug: 127.0.0.1 - - [12/Jun/2017
10:04:11] "GET /browser/table/sql/1/1/12669/2200/81920 HTTP/1.1" 500 -
Traceback (most recent call last):
  File "/Users/pivotal/.pyenv/versions/2.7.10/envs/pgadmin/
lib/python2.7/site-packages/flask/app.py", line 2000, in __call__
return self.wsgi_app(environ, start_response)
  File "/Users/pivotal/.pyenv/versions/2.7.10/envs/pgadmin/
lib/python2.7/site-packages/flask/app.py", line 1991, in wsgi_app
response = self.make_response(self.handle_exception(e))
  File "/Users/pivotal/.pyenv/versions/2.7.10/envs/pgadmin/
lib/python2.7/site-packages/flask/app.py", line 1567, in handle_exception
reraise(exc_type, exc_value, tb)
  File "/Users/pivotal/.pyenv/versions/2.7.10/envs/pgadmin/
lib/python2.7/site-packages/flask/app.py", line 1988, in wsgi_app
response = self.full_dispatch_request()
  File "/Users/pivotal/.pyenv/versions/2.7.10/envs/pgadmin/
lib/python2.7/site-packages/flask/app.py", line 1641, in
full_dispatch_request
rv = self.handle_user_exception(e)
  File "/Users/pivotal/.pyenv/versions/2.7.10/envs/pgadmin/
lib/python2.7/site-packages/flask/app.py", line 1544, in
handle_user_exception
reraise(exc_type, exc_value, tb)
  File "/Users/pivotal/.pyenv/versions/2.7.10/envs/pgadmin/
lib/python2.7/site-packages/flask/app.py", line 1639, in
full_dispatch_request
rv = self.dispatch_request()
  File "/Users/pivotal/.pyenv/versions/2.7.10/envs/pgadmin/
lib/python2.7/site-packages/flask/app.py", line 1625, in dispatch_request
return self.view_functions[rule.endpoint](**req.view_args)
  File "/Users/pivotal/.pyenv/versions/2.7.10/envs/pgadmin/
lib/python2.7/site-packages/flask/views.py", line 84, in view
return self.dispatch_request(*args, **kwargs)
  File "/Users/pivotal/workspace/pgadmin4/web/pgadmin/browser/utils.py",
line 235, in dispatch_request
return method(*args, **kwargs)
  File "/Users/pivotal/workspace/pgadmin4/web/pgadmin/browser/
server_groups/servers/databases/schemas/tables/__init__.py", line 315, in
wrap
return f(*args, **kwargs)
  File "/Users/pivotal/workspace/pgadmin4/web/pgadmin/browser/
server_groups/servers/databases/schemas/tables/__init__.py", line 2555, in
sql
data = self._formatter(did, scid, tid, data)
  File "/Users/pivotal/workspace/pgadmin4/web/pgadmin/browser/
server_groups/servers/databases/schemas/tables/__init__.py", line 1081, in
_formatter
data = self._columns_formatter(tid, data)
  File "/Users/pivotal/workspace/pgadmin4/web/pgadmin/browser/
server_groups/servers/databases/schemas/tables/__init__.py", line 663, in
_columns_formatter
column['attlen'] = matchObj.group(1)
AttributeError: 'NoneType' object has no attribute 'group'


On Mon, Jun 12, 2017 at 12:49 PM, Dave Page <dp...@pgadmin.org> wrote:

> Thanks, applied.
>
> On Fri, Jun 9, 2017 at 10:18 AM, Khushboo Vashi <
> khushboo.va...@enterprisedb.com> wrote:
>
>> Hi,
>>
>> Please find the attached updated patch.
>>
>> Fixed the PostGIS Datatypes in SQL tab, Create / Update dialogues for
>> Table, Column, Foreign Table and Type node.
>>
>> Regarding  the review comment given by Dave (Also, I there should be a
>> space between the , and value in the_geom geometry(MultiPolygon,3310).),
>> won't be fixed as this format is returned by format_type() function itself.
>>
>> As per the conversation with Dave, I have logged RM #2473
>> <https://redmine.postgresql.org/issues/2473> to add support for PostGIS
>> Datatypes.
>>
>> Thanks,
>> Khushboo
>>
>> On Tue, Jun 6, 2017 at 6:49 PM, Dave Page <dp...@pgadmin.org> wrote:
>>
>>>
>>>
>>> On Tue, Jun 6, 2017 at 2:15 PM, Khushboo Vashi <
>>> khushboo.va...@enterprisedb.com> wrote:
>>>
>>>>
>>>>
>>>> On 6 Jun 2017 18:36, "Dave Page" <dp...@pgadmin.org> wrote:
>>>>
>>>>
>>>>
>>>> On Tue, Jun 6, 2017 at 1:23 PM, Khushboo Vashi <
>>>> khushboo.va...@enterprisedb.com> wrote:
>>>>
>>>>>
>>>>>
>>>>> On 6 Jun 2017 17:42, "Dave Page" <dp...@pgadmin.org> wrote:
>>>>>
>>>>> Hi
>>>>>
>>>>> The table and column dialogues seem to have related problems. For
>>>>> example, the table dialogue shows the length of the geometry field in the
>>>>> test case as 847,380, whilst the column dialogue shows no length at all.
>>>>>
>&

Re: [pgadmin-hackers] [pgAdmin4] [PATCH] History Tab rewrite in React

2017-06-12 Thread Dave Page
Hi Shruti

On Mon, Jun 12, 2017 at 3:24 PM, Shruti B Iyer <si...@pivotal.io> wrote:
>
> Hello Dave,
>
> Thanks for making those fixes and sharing them with us. We tried applying
> the patch and it looks like there are some missing file changes from your
> patch that were present in ours, like the Make.bat file changes. But we will
> add them when we send you the new patches.

Hmm, I wonder if I missed them because I applied the patch in a sub directory.

> While trying to generate the new patches we realized some tests are failing
> in master branch due to an internal server error:
>
> 2017-06-12 10:04:11,938: INFO werkzeug: 127.0.0.1 - - [12/Jun/2017 10:04:11]
> "GET /browser/table/sql/1/1/12669/2200/81920 HTTP/1.1" 500 -
> Traceback (most recent call last):
>   File
> "/Users/pivotal/.pyenv/versions/2.7.10/envs/pgadmin/lib/python2.7/site-packages/flask/app.py",
> line 2000, in __call__
> return self.wsgi_app(environ, start_response)
>   File
> "/Users/pivotal/.pyenv/versions/2.7.10/envs/pgadmin/lib/python2.7/site-packages/flask/app.py",
> line 1991, in wsgi_app
> response = self.make_response(self.handle_exception(e))
>   File
> "/Users/pivotal/.pyenv/versions/2.7.10/envs/pgadmin/lib/python2.7/site-packages/flask/app.py",
> line 1567, in handle_exception
> reraise(exc_type, exc_value, tb)
>   File
> "/Users/pivotal/.pyenv/versions/2.7.10/envs/pgadmin/lib/python2.7/site-packages/flask/app.py",
> line 1988, in wsgi_app
> response = self.full_dispatch_request()
>   File
> "/Users/pivotal/.pyenv/versions/2.7.10/envs/pgadmin/lib/python2.7/site-packages/flask/app.py",
> line 1641, in full_dispatch_request
> rv = self.handle_user_exception(e)
>   File
> "/Users/pivotal/.pyenv/versions/2.7.10/envs/pgadmin/lib/python2.7/site-packages/flask/app.py",
> line 1544, in handle_user_exception
> reraise(exc_type, exc_value, tb)
>   File
> "/Users/pivotal/.pyenv/versions/2.7.10/envs/pgadmin/lib/python2.7/site-packages/flask/app.py",
> line 1639, in full_dispatch_request
> rv = self.dispatch_request()
>   File
> "/Users/pivotal/.pyenv/versions/2.7.10/envs/pgadmin/lib/python2.7/site-packages/flask/app.py",
> line 1625, in dispatch_request
> return self.view_functions[rule.endpoint](**req.view_args)
>   File
> "/Users/pivotal/.pyenv/versions/2.7.10/envs/pgadmin/lib/python2.7/site-packages/flask/views.py",
> line 84, in view
> return self.dispatch_request(*args, **kwargs)
>   File "/Users/pivotal/workspace/pgadmin4/web/pgadmin/browser/utils.py",
> line 235, in dispatch_request
> return method(*args, **kwargs)
>   File
> "/Users/pivotal/workspace/pgadmin4/web/pgadmin/browser/server_groups/servers/databases/schemas/tables/__init__.py",
> line 315, in wrap
> return f(*args, **kwargs)
>   File
> "/Users/pivotal/workspace/pgadmin4/web/pgadmin/browser/server_groups/servers/databases/schemas/tables/__init__.py",
> line 2555, in sql
> data = self._formatter(did, scid, tid, data)
>   File
> "/Users/pivotal/workspace/pgadmin4/web/pgadmin/browser/server_groups/servers/databases/schemas/tables/__init__.py",
> line 1081, in _formatter
> data = self._columns_formatter(tid, data)
>   File
> "/Users/pivotal/workspace/pgadmin4/web/pgadmin/browser/server_groups/servers/databases/schemas/tables/__init__.py",
> line 663, in _columns_formatter
> column['attlen'] = matchObj.group(1)
> AttributeError: 'NoneType' object has no attribute 'group'
>
> Was this introduced in a previous patch?

Yes, it looks like it. For some reason it's not failing on the Jenkins
server though. I'll ask Khushboo to fix it.

> We will recreate the patches and send them ASAP.

Thanks!

> Thanks
> Shruti & Joao
>
> On Mon, Jun 12, 2017 at 6:59 AM Dave Page <dp...@pgadmin.org> wrote:
>>
>> Hi
>>
>> OK, so Ashesh and I spend much of the morning on this.
>>
>> Patch 01 - Applied.
>> Patch 02:
>>
>> - karma.conf.js wouldn't patch; I've manually handled that.
>> - test-main.js wouldn't patch. The diff looked like it was trying to
>> empty it; I have removed it instead.
>> - The imports in pgAdmin4.py need to be made after the app root is
>> added to the path.
>> - The JS bundler should be in pgadmin/utils, not pgadmin/tools (which
>> is intended for plugin modules)
>> - The tests were failing following some changes Ashesh pushed earlier
>> to add a client-side url_for function.
>> - pgAdmin4.py was attempting to run the bundler on every startup. I've
>> wrapped those called in "if config.DEBUG:" conditionals, 

Re: [pgadmin-hackers] [pgAdmin4][Patch][RM_ 2477]: New Line text edit pop up renders off page when the size of the grid exceeds the size of the window

2017-06-12 Thread Dave Page
Adding Shirley...

Hi

On Mon, Jun 12, 2017 at 2:27 PM, Surinder Kumar
<surinder.ku...@enterprisedb.com> wrote:
> Hi
>
> The current font-family applied to slick-grid is 'Verdana,Arial,sans-serif'.
> I tried changing it to "Helvetica Neue", Helvetica, Arial, sans-serif but
> the font size and spacing between text is reduced. so to match style I used
> "Verdana".
>
> Also, as per my knowledge, the Helvetica font will work only for Operating
> Systems where this font actually exists in system, otherwise it will pick
> Arial font.
>
> The right way to use 'Helvetica' is to download its 'ttf' and 'eot' files
> and use in CSS so that it appears same on all machines:
> https://stackoverflow.com/questions/13013616/css-helvetica-neue-not-working
>
> But it seems it is not available for free
> https://www.myfonts.com/fonts/linotype/neue-helvetica/licensing.html

Oh, that's not good. I assume we were relying on it being on a users
machine already. I think we need to do one of two things:

1) Default to a font that we know should exist everywhere.
2) Have a fallback from Helvetica Neue to Arial or similar.
3) Choose something completely new and free, and ship it with the app.

I prefer 1 if possible, then 2, finally 3.

Shirley, any thoughts?


> On Mon, Jun 12, 2017 at 6:16 PM, Dave Page <dp...@pgadmin.org> wrote:
>>
>> Hi
>>
>> Can you update this so that the CSS all follows the standards in the
>> WIP styleguide please? I see that the current patch is using the wrong
>> font for example.
>>
>> http://pgadmin4-styleguide.cfapps.io/
>>
>> Thanks!
>>
>> On Mon, Jun 12, 2017 at 11:57 AM, Surinder Kumar
>> <surinder.ku...@enterprisedb.com> wrote:
>> > Hi
>> >
>> > Changes:
>> >
>> > 1) Calculate text editor position properly when the size of the grid
>> > exceeds
>> > the size of the window.
>> >
>> > 2) Assign NumberEditor to cell types('oid', 'xid', 'real').
>> >
>> > 3) Remove inline styles from rendered editors and move its styles to CSS
>> > file.
>> >
>> > Please find attached patch and review.
>> >
>> > Thanks
>> > Surinder
>> >
>> >
>> > --
>> > Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
>> > To make changes to your subscription:
>> > http://www.postgresql.org/mailpref/pgadmin-hackers
>> >
>>
>>
>>
>> --
>> Dave Page
>> Blog: http://pgsnake.blogspot.com
>> Twitter: @pgsnake
>>
>> EnterpriseDB UK: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>
>



-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers


Re: [pgadmin-hackers] [pgAdmin4][Patch][Feature_1535]: Pressing ESC from within a dialog box should act like "Cancel" button

2017-06-12 Thread Dave Page
Hi

On Mon, Jun 12, 2017 at 2:03 PM, Surinder Kumar
<surinder.ku...@enterprisedb.com> wrote:
> Hi
>
> I confirm this is updated patch.

Thanks. Something else seems to have changed that I can't spot. Only
 should be ignored if a child control has focus - Escape and
F1 should continue to work. I tried moving the:

if (panel && panel['_type'] !== 'node_props') return;

into the branch for keyCode.ENTER, but that doesn't seem to help.

-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers


Re: [pgadmin-hackers] [pgAdmin4][PATCH] To fix the issue in Role Membership control

2017-06-12 Thread Dave Page
Thanks applied.

On Mon, Jun 12, 2017 at 1:46 PM, Murtuza Zabuawala
<murtuza.zabuaw...@enterprisedb.com> wrote:
> Hi,
>
> PFA minor patch to fix the issue in Role Membership control, In edit mode
> user was unable to toggle grant admin privileges to membership roles.
> RM#2086
>
> --
> Regards,
> Murtuza Zabuawala
> EnterpriseDB: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
>
> --
> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>



-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers


[pgadmin-hackers] pgAdmin 4 commit: Allow editing of the WITH ADMIN option of role member

2017-06-12 Thread Dave Page
Allow editing of the WITH ADMIN option of role membership. Fixes #2086

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=ec5bc23dfdb41da1b5ccd4ab2ab2e6244d8b5ebd
Author: Murtuza Zabuawala 

Modified Files
--
.../browser/server_groups/servers/roles/templates/role/js/role.js| 1 +
1 file changed, 1 insertion(+)


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers


Re: [pgadmin-hackers] [pgAdmin4][Patch][Feature_1535]: Pressing ESC from within a dialog box should act like "Cancel" button

2017-06-12 Thread Dave Page
Hi

Is that the correct patch? Hitting  in a comment text area is
still causing the dialogue to close.

Thanks.

On Mon, Jun 12, 2017 at 12:55 PM, Surinder Kumar
<surinder.ku...@enterprisedb.com> wrote:
> Hi
>
> Please find rebased patch
>
> Thanks
>
> On Mon, Jun 12, 2017 at 5:20 PM, Dave Page <dp...@pgadmin.org> wrote:
>>
>> Could you rebase this please?
>>
>> Thanks.
>>
>> On Fri, Jun 9, 2017 at 10:40 AM, Surinder Kumar
>> <surinder.ku...@enterprisedb.com> wrote:
>> > Ignore previous patch as it doesn't contains new changes.
>> > Please find attached patch.
>> >
>> >
>> > On Fri, Jun 9, 2017 at 3:06 PM, Surinder Kumar
>> > <surinder.ku...@enterprisedb.com> wrote:
>> >>
>> >> Hi
>> >>
>> >> PFA patch and review.
>> >>
>> >>
>> >> On Fri, Jun 9, 2017 at 1:47 PM, Dave Page <dp...@pgadmin.org> wrote:
>> >>>
>> >>> Hi
>> >>>
>> >>> Ahh, now we have a bug. In the properties dialogues, if you edit a
>> >>> comment, as soon as the Save button gets enabled, hitting Return will
>> >>> Save the changes instead of adding a newline to the comment. That's
>> >>> clearly not right :-(
>> >>
>> >> Now if event.target is its child elements(for example input, textarea
>> >> etc), the function "handleKeyDown(event)" won't call.
>> >>>
>> >>>
>> >>> On Fri, Jun 9, 2017 at 7:48 AM, Surinder Kumar
>> >>> <surinder.ku...@enterprisedb.com> wrote:
>> >>> > Hi
>> >>> >
>> >>> > Please find updated patch.
>> >>> >
>> >>> > Thanks,
>> >>> > Surinder
>> >>> >
>> >>> > On Thu, Jun 8, 2017 at 7:16 PM, Dave Page <dp...@pgadmin.org> wrote:
>> >>> >>
>> >>> >> Hi
>> >>> >>
>> >>> >> On Thu, Jun 8, 2017 at 5:38 AM, Surinder Kumar
>> >>> >> <surinder.ku...@enterprisedb.com> wrote:
>> >>> >> > Hi
>> >>> >> >
>> >>> >> > The attribute key for Ok, Save buttons should be mapped to
>> >>> >> > 13(Enter),
>> >>> >> > for Help - 112(F1) and
>> >>> >> > for Cancel - 27(Esc)
>> >>> >> > The above changes are made into all dialog related template
>> >>> >> > files.
>> >>> >> >
>> >>> >> > PFA patch and review.
>> >>> >>
>> >>> >> Looks good. Just a couple of thoughts:
>> >>> >>
>> >>> >> - You've missed the object property dialogues. This really needs to
>> >>> >> be
>> >>> >> consistent across all dialogues :-)
>> >>> >>
>> >>> >> - The behaviour with Enter is a bit odd, because priority will be
>> >>> >> given the the focussed control to handle it. That's what we want if
>> >>> >> it's a text area for example, but on the other hand, if you open
>> >>> >> the
>> >>> >> Preference dialogue, then the Help button gets focus first, so
>> >>> >> Enter
>> >>> >> there will end up opening the docs. I suspect in most cases the
>> >>> >> behaviour you've got is fine, so I'm not inclined to change it.
>> >>> >> > >>> >> a little> Hmm, I see similar behaviour in some other apps. Let's
>> >>> >> leave
>> >>> >> it as you've done it :-)
>> >>> >>
>> >>> >> Please add support for the properties dialogues, then I think we're
>> >>> >> good
>> >>> >> to go.
>> >>> >
>> >>> > Done.
>> >>> >>
>> >>> >>
>> >>> >> Thanks!
>> >>> >>
>> >>> >> --
>> >>> >> Dave Page
>> >>> >> Blog: http://pgsnake.blogspot.com
>> >>> >> Twitter: @pgsnake
>> >>> >>
>> >>> >> EnterpriseDB UK: http://www.enterprisedb.com
>> >>> >> The Enterprise PostgreSQL Company
>> >>> >
>> >>> >
>> >>>
>> >>>
>> >>>
>> >>> --
>> >>> Dave Page
>> >>> Blog: http://pgsnake.blogspot.com
>> >>> Twitter: @pgsnake
>> >>>
>> >>> EnterpriseDB UK: http://www.enterprisedb.com
>> >>> The Enterprise PostgreSQL Company
>> >>
>> >>
>> >
>>
>>
>>
>> --
>> Dave Page
>> Blog: http://pgsnake.blogspot.com
>> Twitter: @pgsnake
>>
>> EnterpriseDB UK: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>
>



-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers


[pgadmin-hackers] pgAdmin 4 commit: Refresh the SQL editor view on resize to ensure the c

2017-06-12 Thread Dave Page
Refresh the SQL editor view on resize to ensure the contents are re-rendered 
for the new viewport. Fixes #2078

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=3743c6e86ed74b8ae6f4776f27e1555c4ee64e89
Author: Murtuza Zabuawala 

Modified Files
--
.../tools/sqleditor/templates/sqleditor/js/sqleditor.js| 10 ++
1 file changed, 10 insertions(+)


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers


Re: [pgadmin-hackers] [pgAdmin4][PATCH] CREATE Script do not display properly on panel resize

2017-06-12 Thread Dave Page
Thanks, patch applied!

On Mon, Jun 12, 2017 at 11:48 AM, Murtuza Zabuawala
<murtuza.zabuaw...@enterprisedb.com> wrote:
> Hi,
>
> PFA patch to fix the issue where SQL Panel in query tool displays truncated
> sql on resize.
> RM#2078
>
> Steps to re-produce the issue:
> 1) Create table provided by user from RM.
> 2) Right click on newly created table
> 3) Select 'Script' -> 'CREATE Script'
> 4) Drag the splitter down side to maximise SQL Panel area.
> *** Do not click on SQL area ***
> 5) You will see truncated sql.
> --
> Regards,
> Murtuza Zabuawala
> EnterpriseDB: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
>
> --
> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>



-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers


Re: [pgadmin-hackers] [pgAdmin4][PATCH] To fix the issue in displaying Trigger SQL

2017-06-12 Thread Dave Page
Thanks, patch applied.

On Mon, Jun 12, 2017 at 10:54 AM, Murtuza Zabuawala
<murtuza.zabuaw...@enterprisedb.com> wrote:
> Hi,
>
> PFA patch to fix the issue in Table node where it was not displaying
> reversed engineered sql for Trigger(s) properly, if trigger function
> associated with that trigger has parameters.
> RM#2043
>
> --
> Regards,
> Murtuza Zabuawala
> EnterpriseDB: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
>
> --
> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>



-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers


[pgadmin-hackers] pgAdmin 4 commit: Properly handle trigger functions with parameters. Fi

2017-06-12 Thread Dave Page
Properly handle trigger functions with parameters. Fixes #2043

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=c435d488853b7b52f33b8d01fe98b5938e6fd835
Author: Murtuza Zabuawala 

Modified Files
--
.../servers/databases/schemas/tables/__init__.py   | 50 --
.../databases/schemas/tables/triggers/__init__.py  |  2 +-
2 files changed, 48 insertions(+), 4 deletions(-)


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers


Re: [pgadmin-hackers] [pgAdmin4][Patch]: Added the shortcut (CTRL + 0) to reset the zoom level in runtime

2017-06-12 Thread Dave Page
Hi

On Mon, Jun 12, 2017 at 5:33 AM, Khushboo Vashi
<khushboo.va...@enterprisedb.com> wrote:
> Hi,
>
> Please find the attached patch to reset the zoom level in the desktop
> runtime.
>
> Added the new shortcut CTRL + 0 to reset the zoom level.

The code looks good, however I don't think resetting to the startup
value is really what we want. Shouldn't it reset it to 1.0?

-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers


[pgadmin-hackers] pgAdmin 4 commit: Fix the PostGIS Datatypes in SQL tab, Create / Update

2017-06-12 Thread Dave Page
Fix the PostGIS Datatypes in SQL tab, Create / Update dialogues for Table, 
Column, Foreign Table and Type node. Fixes #2324

Note that this doesn't add full support for PostGIS types to the table/column 
dialogues, which still can't handle the typmod usage. It does bring support to 
parity with pgAdmin 3 though.

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=8bd8ae001bd7c3141d8b5a22b00907b9fbe046f5
Author: Khushboo Vashi 

Modified Files
--
.../databases/schemas/foreign_tables/__init__.py   |  8 ++--
.../foreign_tables/sql/9.2_plus/create.sql |  2 +-
.../foreign_tables/sql/9.5_plus/create.sql |  2 +-
.../foreign_tables/sql/default/create.sql  |  2 +-
.../servers/databases/schemas/tables/__init__.py   | 24 ++-
.../databases/schemas/tables/column/__init__.py| 29 +++--
.../templates/column/sql/9.1_plus/properties.sql   |  1 +
.../tables/templates/column/sql/default/create.sql |  2 +-
.../templates/column/sql/default/properties.sql|  1 +
.../tables/templates/table/sql/default/create.sql  |  2 +-
.../servers/databases/schemas/types/__init__.py| 42 +--
.../type/sql/default/additional_properties.sql |  4 +-
.../types/templates/type/sql/default/create.sql|  2 +-
.../servers/databases/schemas/utils.py | 48 ++
14 files changed, 97 insertions(+), 72 deletions(-)


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers


Re: [pgadmin-hackers] [pgAdmin4][Patch]: Fixed RM 2324 - PostGIS datatypes not showing up properly on SQL tab.

2017-06-12 Thread Dave Page
Thanks, applied.

On Fri, Jun 9, 2017 at 10:18 AM, Khushboo Vashi <
khushboo.va...@enterprisedb.com> wrote:

> Hi,
>
> Please find the attached updated patch.
>
> Fixed the PostGIS Datatypes in SQL tab, Create / Update dialogues for
> Table, Column, Foreign Table and Type node.
>
> Regarding  the review comment given by Dave (Also, I there should be a
> space between the , and value in the_geom geometry(MultiPolygon,3310).),
> won't be fixed as this format is returned by format_type() function itself.
>
> As per the conversation with Dave, I have logged RM #2473
> <https://redmine.postgresql.org/issues/2473> to add support for PostGIS
> Datatypes.
>
> Thanks,
> Khushboo
>
> On Tue, Jun 6, 2017 at 6:49 PM, Dave Page <dp...@pgadmin.org> wrote:
>
>>
>>
>> On Tue, Jun 6, 2017 at 2:15 PM, Khushboo Vashi <
>> khushboo.va...@enterprisedb.com> wrote:
>>
>>>
>>>
>>> On 6 Jun 2017 18:36, "Dave Page" <dp...@pgadmin.org> wrote:
>>>
>>>
>>>
>>> On Tue, Jun 6, 2017 at 1:23 PM, Khushboo Vashi <
>>> khushboo.va...@enterprisedb.com> wrote:
>>>
>>>>
>>>>
>>>> On 6 Jun 2017 17:42, "Dave Page" <dp...@pgadmin.org> wrote:
>>>>
>>>> Hi
>>>>
>>>> The table and column dialogues seem to have related problems. For
>>>> example, the table dialogue shows the length of the geometry field in the
>>>> test case as 847,380, whilst the column dialogue shows no length at all.
>>>>
>>>> What should be there in length and precision fields in this case?
>>>>
>>>
>>> I have no idea :-). What did pgAdmin 3 do here? I assume there's some
>>> way to decode the typmod into the desired values, and map them back to
>>> appropriate SQL.
>>>
>>> I will try to figure out the way.
>>> pgAdmin 3 has the same issue, so I have asked for the suggestion.
>>>
>>
>> Oh, OK - thanks. Maybe we need to reuse the length and precision fields
>> for these types. That is, I believe, essentially how PostGIS passes extra
>> info to the column definitions.
>>
>>
>>>
>>>
>>>> Also, I there should be a space between the , and value in the_geom
>>>> geometry(MultiPolygon,3310).
>>>>
>>>> Thanks.
>>>>
>>>> On Mon, Jun 5, 2017 at 8:32 AM, Khushboo Vashi <
>>>> khushboo.va...@enterprisedb.com> wrote:
>>>>
>>>>> Hi,
>>>>>
>>>>> Fixed PostGIS datatype on SQL tab for Table, column, Foreign Table and
>>>>> Type node.
>>>>>
>>>>> Please find the attached updated patch.
>>>>>
>>>>>
>>>>> Thanks,
>>>>> Khushboo
>>>>>
>>>>> On Thu, Jun 1, 2017 at 6:36 PM, Murtuza Zabuawala <
>>>>> murtuza.zabuaw...@enterprisedb.com> wrote:
>>>>>
>>>>>>
>>>>>> On Thu, Jun 1, 2017 at 5:27 PM, Khushboo Vashi <
>>>>>> khushboo.va...@enterprisedb.com> wrote:
>>>>>>
>>>>>>> Hi,
>>>>>>>
>>>>>>>
>>>>>>> On Thu, Jun 1, 2017 at 4:57 PM, Murtuza Zabuawala <
>>>>>>> murtuza.zabuaw...@enterprisedb.com> wrote:
>>>>>>>
>>>>>>>> Hi Khushboo,
>>>>>>>>
>>>>>>>> Please include Type node and Foreign Table node in your fix :-)
>>>>>>>>
>>>>>>>> I don't think Type node requires this change.
>>>>>>>
>>>>>>> Yes, It do require because user can create composite type from
>>>>>> existing types.
>>>>>> [image: Inline image 1]
>>>>>>
>>>>>>> Foreign table changes added in the attached updated patch.
>>>>>>>
>>>>>>>> --
>>>>>>>>
>>>>>>> Thanks Murtuza for pointing this out.
>>>>>
>>>>>
>>>>>> Regards,
>>>>>>>> Murtuza Zabuawala
>>>>>>>> EnterpriseDB: http://www.enterprisedb.com
>>>>>>>> The Enterprise PostgreSQL Company
>>>>>>>>
>>>>>>>> On Thu, Jun 1, 2017 at 3:23 PM, Khushboo Vashi <
>>>>>>>> khushboo.va...@enterprisedb.com> wrote:
>>>>>>>>
>>>>>>>>> Hi,
>>>>>>>>>
>>>>>>>>> Please find the attached patch to fix RM #2324 : PostGIS datatypes
>>>>>>>>> not showing up properly on SQL tab.
>>>>>>>>>
>>>>>>>>> Thanks,
>>>>>>>>> Khushboo
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> --
>>>>>>>>> Sent via pgadmin-hackers mailing list (
>>>>>>>>> pgadmin-hackers@postgresql.org)
>>>>>>>>> To make changes to your subscription:
>>>>>>>>> http://www.postgresql.org/mailpref/pgadmin-hackers
>>>>>>>>>
>>>>>>>>>
>>>>>>>>
>>>>>>>
>>>>>>
>>>>>
>>>>>
>>>>> --
>>>>> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
>>>>> To make changes to your subscription:
>>>>> http://www.postgresql.org/mailpref/pgadmin-hackers
>>>>>
>>>>>
>>>>
>>>>
>>>> --
>>>> Dave Page
>>>> Blog: http://pgsnake.blogspot.com
>>>> Twitter: @pgsnake
>>>>
>>>> EnterpriseDB UK: http://www.enterprisedb.com
>>>> The Enterprise PostgreSQL Company
>>>>
>>>>
>>>>
>>>
>>>
>>> --
>>> Dave Page
>>> Blog: http://pgsnake.blogspot.com
>>> Twitter: @pgsnake
>>>
>>> EnterpriseDB UK: http://www.enterprisedb.com
>>> The Enterprise PostgreSQL Company
>>>
>>>
>>>
>>
>>
>> --
>> Dave Page
>> Blog: http://pgsnake.blogspot.com
>> Twitter: @pgsnake
>>
>> EnterpriseDB UK: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>
>


-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


[pgadmin-hackers] pgAdmin 4 commit: Stop ignoring yarn.lock, per discussion with Pivotal

2017-06-12 Thread Dave Page
Stop ignoring yarn.lock, per discussion with Pivotal team.

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=59da69087cd32ea9e4996f87bae62c8c31dc632b
Author: George Gelashvili 

Modified Files
--
.gitignore| 1 -
web/yarn.lock | 0
2 files changed, 1 deletion(-)


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers


[pgadmin-hackers] pgAdmin 4 commit: Another minor perf tweak for the runtime.

2017-06-11 Thread Dave Page
Another minor perf tweak for the runtime.

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=ef4b8e8c1c563d51641c2eb2f2f81475a00a09d9

Modified Files
--
runtime/Server.cpp | 1 +
1 file changed, 1 insertion(+)


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers


[pgadmin-hackers] pgAdmin 4 commit: Couple of minor performance tweaks. Tests on my Windo

2017-06-11 Thread Dave Page
Couple of minor performance tweaks. Tests on my Windows VM show a consistent 
30% startup time reduction.

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=f0d287588ace15dee3e4e9447ec54d9b4fef8491

Modified Files
--
runtime/pgAdmin4.cpp | 8 +---
web/config.py| 2 +-
2 files changed, 2 insertions(+), 8 deletions(-)


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers


Re: [pgadmin-hackers] Re: [pgAdmin4][Patch][Feature #1971]: Remember column sizes between executions of the same query in the query tool

2017-06-09 Thread Dave Page
Thanks, applied.

On Fri, Jun 9, 2017 at 8:39 AM, Surinder Kumar
<surinder.ku...@enterprisedb.com> wrote:
> Hi
>
> As the patch "Improvements to Query Results"
> is merged, the columns width in edit grid needs some adjustments as
> 'checkboxes' are removed from columns.
>
> PFA patch.
>
> On Thu, Jun 8, 2017 at 5:12 PM, Dave Page <dp...@pgadmin.org> wrote:
>>
>> Nice! Thanks, patch applied.
>>
>> On Wed, Jun 7, 2017 at 4:03 PM, Surinder Kumar
>> <surinder.ku...@enterprisedb.com> wrote:
>> > PFA patch after rebase
>> >
>> > On Wed, Jun 7, 2017 at 6:26 PM, Surinder Kumar
>> > <surinder.ku...@enterprisedb.com> wrote:
>> >>
>> >> Hi
>> >>
>> >> Please find rebased patch.
>> >>
>> >> On Wed, Jun 7, 2017 at 6:15 PM, Dave Page <dp...@pgadmin.org> wrote:
>> >>>
>> >>> Hi,
>> >>>
>> >>> Could you rebase this please?
>> >>>
>> >>> Thanks.
>> >>>
>> >>> On Tue, Jun 6, 2017 at 9:22 AM, Surinder Kumar
>> >>> <surinder.ku...@enterprisedb.com> wrote:
>> >>> > Hi All,
>> >>> >
>> >>> > Please find updated patch which includes Jasmine test cases for
>> >>> > functions
>> >>> > getHash and calculateColumnWidth
>> >>> >
>> >>> > Thanks,
>> >>> > Surinder
>> >>> >
>> >>> > On Mon, Jun 5, 2017 at 11:38 PM, Shruti B Iyer <si...@pivotal.io>
>> >>> > wrote:
>> >>> >>
>> >>> >> Hi Surinder!
>> >>> >>
>> >>> >> We reviewed this patch. The changes look good and we especially
>> >>> >> like
>> >>> >> that
>> >>> >> you have extracted out the new utility functions and the
>> >>> >> epicRandomString
>> >>> >> function too.
>> >>> >>
>> >>> >> This patch will likely affect the Query Results patch that is
>> >>> >> currently
>> >>> >> under review. In order to assist either us or yourself when making
>> >>> >> a
>> >>> >> merge
>> >>> >> between these patches, it would help to have jasmine unit testing
>> >>> >> for
>> >>> >> the
>> >>> >> two new functions, getHash and calculate_column_width.
>> >>> >>
>> >>> >> Also, we suggest that you rename calculate_column_width to
>> >>> >> calculateColumnWidth for consistency with javascript code style.
>> >>> >>
>> >>> >> Thanks,
>> >>> >> Shruti and Matt
>> >>> >>
>> >>> >> On Mon, Jun 5, 2017 at 9:16 AM Surinder Kumar
>> >>> >> <surinder.ku...@enterprisedb.com> wrote:
>> >>> >>>
>> >>> >>> Staged changes are missed in previous patch, so please ignore.
>> >>> >>> Please find attached updated patch.
>> >>> >>>
>> >>> >>> On Mon, Jun 5, 2017 at 4:29 PM, Surinder Kumar
>> >>> >>> <surinder.ku...@enterprisedb.com> wrote:
>> >>> >>>>
>> >>> >>>> Hi
>> >>> >>>>
>> >>> >>>> This patch contains two fixes:
>> >>> >>>>
>> >>> >>>> 1) In Query/tool or Edit grid, the width of table column header
>> >>> >>>> is
>> >>> >>>> fixed
>> >>> >>>> depending on the column type(int, boolean, char etc.) due to
>> >>> >>>> which
>> >>> >>>> the
>> >>> >>>> column name or type appears cut from right and doesn't looks good
>> >>> >>>> from user
>> >>> >>>> point of view. The main concern was to display as much as the
>> >>> >>>> content of
>> >>> >>>> column should be displayed.
>> >>> >>>>
>> >>> >>>> Now the width of column is decided using the text length of
>> >>> >>>> column
>> >>> >>>> name
>> >>

[pgadmin-hackers] pgAdmin 4 commit: Fine tune result grid column sizing now we don't have

2017-06-09 Thread Dave Page
Fine tune result grid column sizing now we don't have checkboxes.

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=49976b193476c7626c305853c23cbf9a98af68e8
Author: Surinder Kumar 

Modified Files
--
web/pgadmin/static/js/sqleditor_utils.js   |  2 +-
.../tools/sqleditor/templates/sqleditor/js/sqleditor.js| 10 +-
2 files changed, 6 insertions(+), 6 deletions(-)


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers


Re: [pgadmin-hackers] [pgAdmin4][Patch][Feature_1535]: Pressing ESC from within a dialog box should act like "Cancel" button

2017-06-09 Thread Dave Page
Hi

Ahh, now we have a bug. In the properties dialogues, if you edit a
comment, as soon as the Save button gets enabled, hitting Return will
Save the changes instead of adding a newline to the comment. That's
clearly not right :-(

On Fri, Jun 9, 2017 at 7:48 AM, Surinder Kumar
<surinder.ku...@enterprisedb.com> wrote:
> Hi
>
> Please find updated patch.
>
> Thanks,
> Surinder
>
> On Thu, Jun 8, 2017 at 7:16 PM, Dave Page <dp...@pgadmin.org> wrote:
>>
>> Hi
>>
>> On Thu, Jun 8, 2017 at 5:38 AM, Surinder Kumar
>> <surinder.ku...@enterprisedb.com> wrote:
>> > Hi
>> >
>> > The attribute key for Ok, Save buttons should be mapped to 13(Enter),
>> > for Help - 112(F1) and
>> > for Cancel - 27(Esc)
>> > The above changes are made into all dialog related template files.
>> >
>> > PFA patch and review.
>>
>> Looks good. Just a couple of thoughts:
>>
>> - You've missed the object property dialogues. This really needs to be
>> consistent across all dialogues :-)
>>
>> - The behaviour with Enter is a bit odd, because priority will be
>> given the the focussed control to handle it. That's what we want if
>> it's a text area for example, but on the other hand, if you open the
>> Preference dialogue, then the Help button gets focus first, so Enter
>> there will end up opening the docs. I suspect in most cases the
>> behaviour you've got is fine, so I'm not inclined to change it. > a little> Hmm, I see similar behaviour in some other apps. Let's leave
>> it as you've done it :-)
>>
>> Please add support for the properties dialogues, then I think we're good
>> to go.
>
> Done.
>>
>>
>> Thanks!
>>
>> --
>> Dave Page
>> Blog: http://pgsnake.blogspot.com
>> Twitter: @pgsnake
>>
>> EnterpriseDB UK: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>
>



-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers


Re: [pgadmin-hackers][patch] Changing the ACI tree font to Helvetica

2017-06-09 Thread Dave Page
Thanks - I'm not 100% sure it's as easy to read as it was. Oddly, I
wonder if the size needs reducing a little (to increase the whitespace
around each label), but I think we need more eyes on it to decide if
I'm just imagining that so I've committed it for now, and we can tweak
later if needed.

On Thu, Jun 8, 2017 at 10:54 PM, Sarah McAlear <smcal...@pivotal.io> wrote:
> Hi Hackers,
>
> This patch changes the ACI Tree font to the font used in the rest of the
> project and increases the size to match, Helvetica.
>
> Thanks,
> Shirley & Sarah
>
>
>
>
> --
> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>



-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers


[pgadmin-hackers] pgAdmin 4 commit: Use the correct font for the treeview.

2017-06-09 Thread Dave Page
Use the correct font for the treeview.

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=ee4a84778457e3ca022be4e2c7f730c98a5e3422
Author: Sarah McAlear 

Modified Files
--
web/pgadmin/static/css/aci_tree.overrides.css | 4 
web/pgadmin/templates/base.html   | 1 +
2 files changed, 5 insertions(+)


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers


Re: [pgadmin-hackers] [pgAdmin4][PATCH] Improvements to Query Results Grid User Experience

2017-06-09 Thread Dave Page
On Thu, Jun 8, 2017 at 7:31 PM, Sarah McAlear <smcal...@pivotal.io> wrote:
>> Thanks. When I run the tests my browser opens in some default size
>> that's always consistent, but doesn't match my normal Chrome sessions,
>> or the 1024x1024 default set in app_starter.py.
>
>
> This looks like an issue with string edit box placement in the
> implementation. We created an issue for this (RM2477).

That was my guess too.

>> Anyway - I found another issue. If I select one or more columns or
>> rows, or an arbitrary selection of cells, copy/paste seems to work
>> fine. However, if I click the Select All arrow, for a small resultset
>> (e.g. SELECT * FROM pg_database with 18 rows) it works fine, but if I
>> do the same with the contents of pg_class, which has 1342 rows on this
>> DB, it seems to fail to populate the clipboard and ends up pasting
>> whatever was copied previously instead. If I use the Copy button, even
>> on a fast machine it seems to pause for a second or so before failing
>> to put the data on the clipboard.
>
>
> We were able to reproduce this with "SELECT generate_series(1, 5)"
> The issue was still present for us when we ran the app at each of 2fddf750
> and 495a3cedb
> Could we move this discussion to a new thread as it doesn't seem related to
> these changes?

Something in these changes caused it to start manifesting, but I agree
the underlying issue was probably there anyway. I'm happy to move to a
different thread.

-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers


Re: [pgadmin-hackers] [pgAdmin4][Patch]: UI improvements in data-grid/query tool

2017-06-08 Thread Dave Page
Thanks, applied!

On Thu, Jun 8, 2017 at 4:53 PM, Surinder Kumar
<surinder.ku...@enterprisedb.com> wrote:
> Hi
>
> I
> have
> replaced Silver, #222, and #aaa colors
> with relevant
> colors
> defined in pgadmin.styles.css
> Also, the header rows
> left &
>  right
> border
>  color is changed to #888 to match with bottom
>  border
> (#888)
> , now the header can easily be distinguished from the grid rows border
> styling.
>
> Please review and let me know if any changes.
>
>
> On Thu, Jun 8, 2017 at 7:51 PM, Dave Page <dp...@pgadmin.org> wrote:
>>
>> Exactly what my review was going to say :-)
>>
>> On Thu, Jun 8, 2017 at 3:07 PM, Sarah McAlear <smcal...@pivotal.io> wrote:
>> > Hi Surinder!
>> >
>> > We reviewed the patch and the changes look great. Could you change the
>> > grays
>> > to match the style guide?
>> >
>> > Silver, #222, and #aaa aren't listed in pgadmin.style.css.
>> >
>> > Thanks so much!
>> > Shirley & Sarah
>> >
>> > On Thu, Jun 8, 2017 at 9:34 AM, Surinder Kumar
>> > <surinder.ku...@enterprisedb.com> wrote:
>> >>
>> >> Hi,
>> >>
>> >> Changes:
>> >>
>> >> 1) Display only border-top for data-grid header instead of border on
>> >> whole
>> >> data-grid.
>> >>
>> >> 2) Remove dotted border from cell right for consistency.
>> >>
>> >> 3) Add border-bottom for header-row so that on scroll to bottom header
>> >> rows are differentiated from cells.
>> >>
>> >> Also, due to these changes, the vertical scrollbar which appears at
>> >> data-grid right side seems to fixed.
>> >>
>> >> PFA patch and review.
>> >>
>> >>
>> >> Thanks,
>> >> Surinder
>> >>
>> >>
>> >> --
>> >> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
>> >> To make changes to your subscription:
>> >> http://www.postgresql.org/mailpref/pgadmin-hackers
>> >>
>> >
>>
>>
>>
>> --
>> Dave Page
>> Blog: http://pgsnake.blogspot.com
>> Twitter: @pgsnake
>>
>> EnterpriseDB UK: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>
>



-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers


Re: [pgadmin-hackers] [pgAdmin4][Patch][RM_2450] : Internal Server Error displayed if click on statistic tab for PG 10 server

2017-06-08 Thread Dave Page
Hi Atul,

On Thu, Jun 8, 2017 at 3:03 PM, Atul Sharma
<atul.sha...@enterprisedb.com> wrote:
> Hi,
>
> The issue is fixed now. Added a new "stats.sql" file with updated columns
> for the version 10.0_plus
>
> PFA RM patch.

As PostgreSQL has moved to a 2 digit version number system instead of
3, I think the directory name should be 10_plus shouldn't it? Will
that work with the template search code? If not, can you please fix
that as well?

Thanks!

-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers


Re: [pgadmin-hackers] [pgAdmin4][Patch]: UI improvements in data-grid/query tool

2017-06-08 Thread Dave Page
Exactly what my review was going to say :-)

On Thu, Jun 8, 2017 at 3:07 PM, Sarah McAlear <smcal...@pivotal.io> wrote:
> Hi Surinder!
>
> We reviewed the patch and the changes look great. Could you change the grays
> to match the style guide?
>
> Silver, #222, and #aaa aren't listed in pgadmin.style.css.
>
> Thanks so much!
> Shirley & Sarah
>
> On Thu, Jun 8, 2017 at 9:34 AM, Surinder Kumar
> <surinder.ku...@enterprisedb.com> wrote:
>>
>> Hi,
>>
>> Changes:
>>
>> 1) Display only border-top for data-grid header instead of border on whole
>> data-grid.
>>
>> 2) Remove dotted border from cell right for consistency.
>>
>> 3) Add border-bottom for header-row so that on scroll to bottom header
>> rows are differentiated from cells.
>>
>> Also, due to these changes, the vertical scrollbar which appears at
>> data-grid right side seems to fixed.
>>
>> PFA patch and review.
>>
>>
>> Thanks,
>> Surinder
>>
>>
>> --
>> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
>> To make changes to your subscription:
>> http://www.postgresql.org/mailpref/pgadmin-hackers
>>
>



-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers


Re: [pgadmin-hackers] [pgAdmin4][PATCH] Improvements to Query Results Grid User Experience

2017-06-08 Thread Dave Page
Hi

On Thu, Jun 8, 2017 at 2:18 PM, Sarah McAlear <smcal...@pivotal.io> wrote:
> On Thu, Jun 8, 2017 at 8:34 AM, Dave Page <dp...@pgadmin.org> wrote:
>> - There are changes to SlickGrid, the addition of a function to scroll
>> a column into view. Is this submitted upstream and accepted?
>
> We have submitted the changes we made to the patch to Slick grid and they
> were accepted yesterday. We can get this in today or first thing tomorrow.

Great.

>>
>> - One of the regression tests now fails because it's trying to access
>> an element that's out of the clickable area. If I widen then browser
>> for testing it passes so I believe it's just the test that needs
>> fixing. Can you take a look at that ASAP please?
>
> We haven't seen this test fail but we can absolutely look into it. Our
> Chrome browser is always the same size. We can try fiddling with that to see
> if we can get it to fail.

Thanks. When I run the tests my browser opens in some default size
that's always consistent, but doesn't match my normal Chrome sessions,
or the 1024x1024 default set in app_starter.py.

Anyway - I found another issue. If I select one or more columns or
rows, or an arbitrary selection of cells, copy/paste seems to work
fine. However, if I click the Select All arrow, for a small resultset
(e.g. SELECT * FROM pg_database with 18 rows) it works fine, but if I
do the same with the contents of pg_class, which has 1342 rows on this
DB, it seems to fail to populate the clipboard and ends up pasting
whatever was copied previously instead. If I use the Copy button, even
on a fast machine it seems to pause for a second or so before failing
to put the data on the clipboard.

Can you take a look at that too please?

Thanks.

-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers


Re: [pgadmin-hackers] Fix for RM2421 [pgAdmin4][patch]

2017-06-08 Thread Dave Page
Thanks, applied.

On Thu, Jun 8, 2017 at 1:59 PM, Harshal Dhumal
<harshal.dhu...@enterprisedb.com> wrote:
> Please find attached rebased patch.
>
> --
> Harshal Dhumal
> Sr. Software Engineer
>
> EnterpriseDB India: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
> On Wed, Jun 7, 2017 at 6:59 PM, Dave Page <dp...@pgadmin.org> wrote:
>>
>> Can you rebase this please? I think Ashesh broke it :-p
>>
>> On Tue, Jun 6, 2017 at 7:42 AM, Harshal Dhumal
>> <harshal.dhu...@enterprisedb.com> wrote:
>> > Hi,
>> >
>> > On Mon, Jun 5, 2017 at 9:25 PM, Dave Page <dp...@pgadmin.org> wrote:
>> >>
>> >> Hi
>> >>
>> >> With this patch applied, it uses the field names instead of the labels
>> >> in error messages - e.g.
>> >>
>> >> 'dirty_rate_limit' must be numeric
>> >>
>> >> instead of:
>> >>
>> >> 'Dirty Rate Limit (KB)' must be numeric.
>> >
>> > Fixed. Please find attached updated patch.
>> >
>> >>
>> >>
>> >> Thanks.
>> >>
>> >> On Tue, May 30, 2017 at 8:28 AM, Harshal Dhumal
>> >> <harshal.dhu...@enterprisedb.com> wrote:
>> >> > Hi,
>> >> >
>> >> > Please find updated patch.
>> >> >
>> >> > --
>> >> > Harshal Dhumal
>> >> > Sr. Software Engineer
>> >> >
>> >> > EnterpriseDB India: http://www.enterprisedb.com
>> >> > The Enterprise PostgreSQL Company
>> >> >
>> >> > On Tue, May 30, 2017 at 12:30 PM, Harshal Dhumal
>> >> > <harshal.dhu...@enterprisedb.com> wrote:
>> >> >>
>> >> >> Hi,
>> >> >>
>> >> >> Please ignore this patch as I forgot to include few changes. I'll
>> >> >> send
>> >> >> updated one.
>> >> >>
>> >> >> --
>> >> >> Harshal Dhumal
>> >> >> Sr. Software Engineer
>> >> >>
>> >> >> EnterpriseDB India: http://www.enterprisedb.com
>> >> >> The Enterprise PostgreSQL Company
>> >> >>
>> >> >> On Mon, May 29, 2017 at 3:18 PM, Harshal Dhumal
>> >> >> <harshal.dhu...@enterprisedb.com> wrote:
>> >> >>>
>> >> >>> Hi,
>> >> >>>
>> >> >>> Here is updated patch for RM2421.
>> >> >>>
>> >> >>> Now I have moved all Numeric control level validations to
>> >> >>> datamodel.
>> >> >>> As
>> >> >>> existing implementation was causing
>> >> >>> issues with error messages in create/edit dialog when schema
>> >> >>> contains
>> >> >>> two
>> >> >>> or more Numeric controls.
>> >> >>>
>> >> >>> This is generic issue and not related to resource group. Also I
>> >> >>> have
>> >> >>> updated all other nodes which uses Numeric controls
>> >> >>>
>> >> >>>
>> >> >>>
>> >> >>> --
>> >> >>> Harshal Dhumal
>> >> >>> Sr. Software Engineer
>> >> >>>
>> >> >>> EnterpriseDB India: http://www.enterprisedb.com
>> >> >>> The Enterprise PostgreSQL Company
>> >> >>>
>> >> >>> On Fri, May 19, 2017 at 12:22 PM, Harshal Dhumal
>> >> >>> <harshal.dhu...@enterprisedb.com> wrote:
>> >> >>>>
>> >> >>>> Hi,
>> >> >>>>
>> >> >>>> On Thu, May 18, 2017 at 7:57 PM, Joao Pedro De Almeida Pereira
>> >> >>>> <jdealmeidapere...@pivotal.io> wrote:
>> >> >>>>>
>> >> >>>>> Hello Harshal,
>> >> >>>>>
>> >> >>>>> We review the patch and have some questions:
>> >> >>>>> 1) Is there any particular reason to initialize variables and
>> >> >>>>> functions
>> >> >>>>> in the same place? We believe that it would be more readable
>> >> >>>>> there
>> >> >>>>&g

[pgadmin-hackers] pgAdmin 4 commit: Fix integer/numeric validation on various dialogues.

2017-06-08 Thread Dave Page
Fix integer/numeric validation on various dialogues. Fixes #2421

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=aa400cbc12f34f219322a2b62f9f51e21d031f0e
Author: Harshal Dhumal 

Modified Files
--
.../templates/foreign_tables/js/foreign_tables.js  | 104 
.../sequences/templates/sequence/js/sequence.js|  87 --
.../resource_groups/js/resource_groups.js  |  61 +++
.../servers/roles/templates/role/js/role.js|   2 +-
.../servers/templates/servers/servers.js   |   3 +
web/pgadmin/browser/static/js/datamodel.js | 158 +++--
web/pgadmin/static/js/backform.pgadmin.js  | 187 +
7 files changed, 323 insertions(+), 279 deletions(-)


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers


Re: [pgadmin-hackers] [pgAdmin4][PATCH] Fix handling of double precision[] type

2017-06-08 Thread Dave Page
Thanks, applied.

Can you update the data types feature test to cover this case please?

Thanks.

On Thu, Jun 8, 2017 at 6:51 AM, Murtuza Zabuawala
<murtuza.zabuaw...@enterprisedb.com> wrote:
> Hi,
>
> PFA patch to fix the handling of  double precision[] type.
> RM#1928
>
> Steps to re-produce: Below given query fails to render result in Query tool,
> SELECT ARRAY[1, 'nan', 3]::float[];
>
> --
> Regards,
> Murtuza Zabuawala
> EnterpriseDB: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
>
> --
> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>



-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers


[pgadmin-hackers] pgAdmin 4 commit: Fix the handling of double precision[] type. Fixes #

2017-06-08 Thread Dave Page
Fix the handling of  double precision[] type. Fixes #1928

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=3bcbc505258e4583d94a40c6e0506046bdc21b98
Author: Murtuza Zabuawala 

Modified Files
--
web/pgadmin/utils/driver/psycopg2/__init__.py | 12 +---
1 file changed, 9 insertions(+), 3 deletions(-)


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers


Re: [pgadmin-hackers] [pgAdmin4][Patch][Feature_1535]: Pressing ESC from within a dialog box should act like "Cancel" button

2017-06-08 Thread Dave Page
Hi

On Thu, Jun 8, 2017 at 5:38 AM, Surinder Kumar
<surinder.ku...@enterprisedb.com> wrote:
> Hi
>
> The attribute key for Ok, Save buttons should be mapped to 13(Enter),
> for Help - 112(F1) and
> for Cancel - 27(Esc)
> The above changes are made into all dialog related template files.
>
> PFA patch and review.

Looks good. Just a couple of thoughts:

- You've missed the object property dialogues. This really needs to be
consistent across all dialogues :-)

- The behaviour with Enter is a bit odd, because priority will be
given the the focussed control to handle it. That's what we want if
it's a text area for example, but on the other hand, if you open the
Preference dialogue, then the Help button gets focus first, so Enter
there will end up opening the docs. I suspect in most cases the
behaviour you've got is fine, so I'm not inclined to change it.  Hmm, I see similar behaviour in some other apps. Let's leave
it as you've done it :-)

Please add support for the properties dialogues, then I think we're good to go.

Thanks!

-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers


Re: [pgadmin-hackers] [pgAdmin4][Patch][Feature_1533]: Set focus on first field when new dialog window is presented

2017-06-08 Thread Dave Page
Thanks, patch applied.

On Thu, Jun 8, 2017 at 5:34 AM, Surinder Kumar
<surinder.ku...@enterprisedb.com> wrote:
> Hi
>
> PFA patch and review.
>
> Thanks
> Surinder
>
>
> --
> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>



-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers


[pgadmin-hackers] pgAdmin 4 commit: Set focus on the first enabled field when a dialogue

2017-06-08 Thread Dave Page
Set focus on the first enabled field when a dialogue is opened. Fixes #1533

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=c9b717ed68797740a6ea8d3480627fe21777a8a8
Author: Surinder Kumar 

Modified Files
--
web/pgadmin/browser/templates/browser/js/node.js | 14 ++
1 file changed, 10 insertions(+), 4 deletions(-)


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers


Re: [pgadmin-hackers] [pgAdmin4] [PATCH] History Tab rewrite in React

2017-06-08 Thread Dave Page
Hi George

On Wed, Jun 7, 2017 at 10:21 PM, George Gelashvili
<ggelashv...@pivotal.io> wrote:
> Hi Dave,
>
> I split the linting out into an intermediate commit, and rebased on top of
> master.

Unfortunately, it still doesn't apply:

error: patch failed: web/regression/javascript/test-main.js:1
error: removal patch leaves file contents
error: web/regression/javascript/test-main.js: patch does not apply
Checking patch web/regression/requirements.txt...
Checking patch web/webpack.config.js...
Checking patch web/webpack.test.config.js...
Checking patch web/yarn.lock...
error: web/yarn.lock: already exists in working directory
Applied patch .gitignore cleanly.
Applied patch Make.bat cleanly.
Applied patch README cleanly.
Applied patch pkg/mac/build.sh cleanly.
Applied patch pkg/pip/build.sh cleanly.
Applied patch pkg/src/build.sh cleanly.
Applied patch web/.eslintrc.js cleanly.
Applied patch web/karma.conf.js cleanly.
Applied patch web/package.json cleanly.
Applied patch web/pgAdmin4.py cleanly.
Applied patch web/pgadmin/static/jsx/components.jsx cleanly.
Applied patch web/pgadmin/tools/javascript/__init__.py cleanly.
Applied patch web/pgadmin/tools/javascript/javascript_bundler.py cleanly.
Applied patch web/pgadmin/tools/javascript/tests/__init__.py cleanly.
Applied patch web/pgadmin/tools/javascript/tests/test_javascript_bundler.py
cleanly.
Applied patch web/regression/README cleanly.
Applied patch web/regression/javascript/jasmine_capture_warnings_beforeall.js
cleanly.
Applied patch web/regression/requirements.txt cleanly.
Applied patch web/webpack.config.js cleanly.
Applied patch web/webpack.test.config.js cleanly.

The second (lint update) patch is even worse, with significant number
change that just don't want to apply.

Clearly yarn.lock needs to be removed from there repo.

Once I can apply a version of this, how should I be running the linter
and the unit tests?

-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers


Re: [pgadmin-hackers] [pgAdmin4][PATCH] Improvements to Query Results Grid User Experience

2017-06-08 Thread Dave Page
Hi!

Thanks, patch applied... but I have one issue and one question:

- There are changes to SlickGrid, the addition of a function to scroll
a column into view. Is this submitted upstream and accepted?

- One of the regression tests now fails because it's trying to access
an element that's out of the clickable area. If I widen then browser
for testing it passes so I believe it's just the test that needs
fixing. Can you take a look at that ASAP please?

ERROR: runTest 
(pgadmin.feature_tests.view_data_dml_queries.CheckForViewDataTest)
Validate Insert, Update operations in View data with given test data
--
Traceback (most recent call last):
  File 
"/Users/dpage/git/pgadmin4/web/pgadmin/feature_tests/view_data_dml_queries.py",
line 100, in runTest
self._add_row()
  File 
"/Users/dpage/git/pgadmin4/web/pgadmin/feature_tests/view_data_dml_queries.py",
line 255, in _add_row
self._update_cell(cell_xpath, config_data[str(idx)])
  File 
"/Users/dpage/git/pgadmin4/web/pgadmin/feature_tests/view_data_dml_queries.py",
line 182, in _update_cell
save_btn_xpath
  File 
"/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/selenium/webdriver/remote/webelement.py",
line 77, in click
self._execute(Command.CLICK_ELEMENT)
  File 
"/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/selenium/webdriver/remote/webelement.py",
line 491, in _execute
return self._parent.execute(command, params)
  File 
"/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/selenium/webdriver/remote/webdriver.py",
line 238, in execute
self.error_handler.check_response(response)
  File 
"/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/selenium/webdriver/remote/errorhandler.py",
line 193, in check_response
raise exception_class(message, screen, stacktrace)
WebDriverException: Message: unknown error: Element is not clickable
at point (726, 397)
  (Session info: chrome=58.0.3029.110)
  (Driver info: chromedriver=2.29.461585
(0be2cd95f834e9ee7c46bcc7cf405b483f5ae83b),platform=Mac OS X 10.12.3
x86_64)

Thanks - this is a very nice improvement!


On Wed, Jun 7, 2017 at 9:47 PM, Sarah McAlear <smcal...@pivotal.io> wrote:
> Hello,
>
> Here is a new set of patches with the bug fixed. Good catch, Surinder!
>
> Thanks,
> Joao & Sarah
>
>
>
> On Tue, Jun 6, 2017 at 12:24 AM, Surinder Kumar
> <surinder.ku...@enterprisedb.com> wrote:
>>
>> Hi
>>
>> On Tue, Jun 6, 2017 at 12:13 AM, Shruti B Iyer <si...@pivotal.io> wrote:
>>>
>>> Hi Surinder,
>>>
>>> On Mon, Jun 5, 2017 at 2:09 PM Robert Eckhardt <reckha...@pivotal.io>
>>> wrote:
>>>>
>>>> On Mon, Jun 5, 2017 at 9:09 AM, Surinder Kumar
>>>> <surinder.ku...@enterprisedb.com> wrote:
>>>>>
>>>>> Hi Matthew,
>>>>>
>>>>> Couple of review comments:
>>>>> 1) Clicking on a new added row(after save) results in console error -
>>>>> screenshot attached.
>>>>
>>>>
>>>
>>> We tried to follow the steps you provided to replicate the bug but
>>> couldn't replicate the error.  Can you provide further instructions to help
>>> us replicate the bug? Perhaps share a screen video if that makes sense.
>>> Is this occurring on the Edit Table view?
>>
>> Sorry for wrong steps.
>> No need to add a new row, just double clicking on row selection column of
>> last row will throw that error.
>>>
>>>
>>> Thanks,
>>> Shruti and Matt
>>
>>
>



-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers


[pgadmin-hackers] pgAdmin 4 commit: Improvements to the Query Results grid:

2017-06-08 Thread Dave Page
Improvements to the Query Results grid:

- Improve the UI
- Allow copy/paste from sets of rows, columns or arbitrary blocks of cells

Patch by Matt, Shruti, Joao and Sarah @ Pivotal

Fixes #2476

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=01bfa88309940bdfe62d537a4be031dd8cbc2303
Author: Sarah McAlear 

Modified Files
--
.../tables/tests/test_column_properties_sql.py |   2 +-
.../connect_to_server_feature_test.py  |   2 +-
.../copy_selected_query_results_feature_test.py| 105 +++-
.../feature_tests/table_ddl_feature_test.py|   2 +-
web/pgadmin/feature_tests/view_data_dml_queries.py |   2 -
.../xss_checks_panels_and_query_tool_test.py   |   2 +-
.../xss_checks_pgadmin_debugger_test.py|   2 +-
web/pgadmin/static/img/select-all-icon.png | Bin 0 -> 132 bytes
.../static/js/selection/active_cell_capture.js | 191 +++
web/pgadmin/static/js/selection/column_selector.js | 109 ++--
web/pgadmin/static/js/selection/copy_data.js   |  15 +-
web/pgadmin/static/js/selection/grid_selector.js   |  59 +--
.../js/selection/range_boundary_navigator.js   |   7 +-
.../static/js/selection/range_selection_helper.js  | 112 -
web/pgadmin/static/js/selection/row_selector.js|  90 ++--
web/pgadmin/static/js/selection/set_staged_rows.js |  23 +-
.../static/js/selection/xcell_selection_model.js   | 228 +
web/pgadmin/static/js/slickgrid/cell_selector.js   |  18 +
.../handle_query_output_keyboard_event.js  |  21 +
.../js/slickgrid/pgslick.cellrangedecorator.js |  73 +++
.../js/slickgrid/pgslick.cellrangeselector.js  | 119 +
web/pgadmin/static/vendor/slickgrid/README |   9 -
web/pgadmin/static/vendor/slickgrid/README.md  |   9 +
.../slickgrid/controls/slick.columnpicker.js   |   9 +-
.../static/vendor/slickgrid/images/CheckboxN.png   | Bin 0 -> 257 bytes
.../static/vendor/slickgrid/images/CheckboxY.png   | Bin 0 -> 361 bytes
.../vendor/slickgrid/plugins/slick.autotooltips.js |  10 +-
.../slickgrid/plugins/slick.cellcopymanager.js |   6 +-
.../plugins/slick.cellexternalcopymanager.js   | 449 +
.../slickgrid/plugins/slick.cellrangeselector.js   |   9 +-
.../slickgrid/plugins/slick.cellselectionmodel.js  |  46 +-
.../slickgrid/plugins/slick.headerbuttons.js   |   6 +-
.../vendor/slickgrid/plugins/slick.headermenu.js   |   8 +-
.../slickgrid/plugins/slick.rowselectionmodel.js   |  10 +-
.../vendor/slickgrid/slick-default-theme.css   |  22 +-
web/pgadmin/static/vendor/slickgrid/slick.core.js  |  15 +-
.../static/vendor/slickgrid/slick.dataview.js  |  40 +-
.../static/vendor/slickgrid/slick.editors.js   |  67 +--
.../static/vendor/slickgrid/slick.formatters.js|  12 +-
web/pgadmin/static/vendor/slickgrid/slick.grid.css |  43 +-
web/pgadmin/static/vendor/slickgrid/slick.grid.js  | 554 ++---
.../slickgrid/slick.groupitemmetadataprovider.js   | 158 ++
.../vendor/slickgrid/slick.remotemodel-yahoo.js| 206 
.../static/vendor/slickgrid/slick.remotemodel.js   | 169 +++
.../tools/sqleditor/static/css/sqleditor.css   |  60 ++-
.../sqleditor/templates/sqleditor/js/sqleditor.js  | 107 ++--
.../utils/tests/test_versioned_template_loader.py  |  25 +-
web/regression/feature_utils/pgadmin_page.py   |  25 +
.../selection/active_cell_capture_spec.js  | 342 +
.../javascript/selection/column_selector_spec.js   | 346 ++---
.../javascript/selection/copy_data_spec.js |  44 +-
.../javascript/selection/grid_selector_spec.js |  49 +-
.../selection/range_boundary_navigator_spec.js |  19 +-
.../selection/range_selection_helper_spec.js   |  93 
.../javascript/selection/row_selector_spec.js  | 235 +++--
.../javascript/selection/set_staged_rows_spec.js   | 184 +++
.../selection/xcell_selection_model_spec.js| 513 +++
.../javascript/slickgrid/cell_selector_spec.js |  77 +++
.../handle_query_output_keyboard_event_spec.js | 143 ++
web/regression/javascript/test-main.js |  17 +-
web/regression/python_test_utils/test_utils.py |   8 +-
web/regression/requirements.txt|   2 +-
62 files changed, 4506 insertions(+), 822 deletions(-)


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers


Re: [pgadmin-hackers] [pgAdmin4][Patch]: Load module's JS files only when required

2017-06-08 Thread Dave Page
Hi

On Wed, Jun 7, 2017 at 7:10 PM, Joao Pedro De Almeida Pereira
<jdealmeidapere...@pivotal.io> wrote:
> Hello Dave,
> By the description on the email, it looks like the process is very similar
> to the Grunt process that we were talking about, but without the patch, it
> is a bit hard to get more specifics.
> Can you forward the patch so we can take a look at it.
>
> We believe that every effort done to eliminate templated Javascript and CSS
> files is well worth it, and should be followed.

Odd - the patch was sent to you as well. Oh well, here it is.

> On Tue, Jun 6, 2017 at 9:39 AM, Dave Page <dp...@pgadmin.org> wrote:
>>
>> Hi
>>
>> On Mon, Jun 5, 2017 at 10:22 AM, Surinder Kumar
>> <surinder.ku...@enterprisedb.com> wrote:
>> > Hi Dave,
>> >
>> > Please find attached patch for minifying CSS files and optimize images
>> > using
>> > Webpack.
>> >
>> > Steps to run:
>> >
>> > 1) After applying patch, go to web directory and run npm install on
>> > terminal
>> > to install packages which are used to parse/minify CSS files.
>> >
>> > 2) Run npm run build which creates dist folder inside
>> > web/pgadmin/static/
>> > directory to store processed images, fonts and css files.
>> >
>> > 3. Set DEBUG = False in config_local.py and then run python pgAdmin.py
>> > to
>> > start server.
>> > I kept generated main.css and overrides.css conditional in base.html to
>> > load
>> > them only when debug mode is False
>> >
>> >
>> > After running "npm run build", following files/directories are
>> > generated:
>> >
>> > 1) main.css -  about 20 vendor CSS files are packed into this file and
>> > more
>> > importantly the paths to images are preserved.
>> >
>> > 2) overrides.css - it contains bootstrap.overrides.css and pgadmin.css,
>> > they
>> > has to be packed separately and loaded after all CSS files are loaded
>> > because the purpose of these files is to override the vendor or modules
>> > css.
>> >
>> > 3) img - it contains the images used in CSS files. The name of image
>> > files
>> > can also be hashed names for caching purpose which we can use.
>> >
>> > 4) fonts - it contains the fonts used in fontawesome.css and other css
>> > files.
>> >
>> > This is a simple patch to demonstrate how CSS files will be minified
>> > with
>> > Webpack.
>>
>> I think this is a good, simple method. It handles debug v.s release,
>> and of course, any plugin modules can include their own images/CSS
>> without even having to worry about webpacking if installed later.
>>
>> > For now it minifies only vendor CSS files, I will add modules static
>> > files
>> > in the list later on.
>>
>> I think we need to do that to get a better idea of the benefits. We
>> also need to get some of the JS code in there as well (Ashesh should
>> be able to help with that - he told me he's de-templatised a lot of
>> that now).
>>
>> > Any thoughts on minifying template CSS files which are built dynamically
>> > and
>> > loaded with dependency on other modules?
>>
>> Let's look at why they are templates. Is that required, or could they
>> be made static?
>>
>> > Also, I looked into Flask-webpack which generates bundled assets using
>> > Webpack(webpack.config.js) and provide additionally global template tags
>> > to
>> > use in Jinja templates.
>> >
>> > But it might not work with latest version of Webpack as this repo is not
>> > updated since last 2 years. I need to check with latest version and I
>> > will
>> > update on this.
>>
>> Given how straightforward this seems to be, I'm not sure it's needed.
>>
>> Joao, any comments?
>>
>> Nice work - thanks!
>>
>> --
>> Dave Page
>> Blog: http://pgsnake.blogspot.com
>> Twitter: @pgsnake
>>
>> EnterpriseDB UK: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>
>



-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


bundle_css_using_webpack.patch
Description: Binary data

-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers


Re: [pgadmin-hackers] Re: [pgAdmin4][Patch][Feature #1971]: Remember column sizes between executions of the same query in the query tool

2017-06-08 Thread Dave Page
Nice! Thanks, patch applied.

On Wed, Jun 7, 2017 at 4:03 PM, Surinder Kumar
<surinder.ku...@enterprisedb.com> wrote:
> PFA patch after rebase
>
> On Wed, Jun 7, 2017 at 6:26 PM, Surinder Kumar
> <surinder.ku...@enterprisedb.com> wrote:
>>
>> Hi
>>
>> Please find rebased patch.
>>
>> On Wed, Jun 7, 2017 at 6:15 PM, Dave Page <dp...@pgadmin.org> wrote:
>>>
>>> Hi,
>>>
>>> Could you rebase this please?
>>>
>>> Thanks.
>>>
>>> On Tue, Jun 6, 2017 at 9:22 AM, Surinder Kumar
>>> <surinder.ku...@enterprisedb.com> wrote:
>>> > Hi All,
>>> >
>>> > Please find updated patch which includes Jasmine test cases for
>>> > functions
>>> > getHash and calculateColumnWidth
>>> >
>>> > Thanks,
>>> > Surinder
>>> >
>>> > On Mon, Jun 5, 2017 at 11:38 PM, Shruti B Iyer <si...@pivotal.io>
>>> > wrote:
>>> >>
>>> >> Hi Surinder!
>>> >>
>>> >> We reviewed this patch. The changes look good and we especially like
>>> >> that
>>> >> you have extracted out the new utility functions and the
>>> >> epicRandomString
>>> >> function too.
>>> >>
>>> >> This patch will likely affect the Query Results patch that is
>>> >> currently
>>> >> under review. In order to assist either us or yourself when making a
>>> >> merge
>>> >> between these patches, it would help to have jasmine unit testing for
>>> >> the
>>> >> two new functions, getHash and calculate_column_width.
>>> >>
>>> >> Also, we suggest that you rename calculate_column_width to
>>> >> calculateColumnWidth for consistency with javascript code style.
>>> >>
>>> >> Thanks,
>>> >> Shruti and Matt
>>> >>
>>> >> On Mon, Jun 5, 2017 at 9:16 AM Surinder Kumar
>>> >> <surinder.ku...@enterprisedb.com> wrote:
>>> >>>
>>> >>> Staged changes are missed in previous patch, so please ignore.
>>> >>> Please find attached updated patch.
>>> >>>
>>> >>> On Mon, Jun 5, 2017 at 4:29 PM, Surinder Kumar
>>> >>> <surinder.ku...@enterprisedb.com> wrote:
>>> >>>>
>>> >>>> Hi
>>> >>>>
>>> >>>> This patch contains two fixes:
>>> >>>>
>>> >>>> 1) In Query/tool or Edit grid, the width of table column header is
>>> >>>> fixed
>>> >>>> depending on the column type(int, boolean, char etc.) due to which
>>> >>>> the
>>> >>>> column name or type appears cut from right and doesn't looks good
>>> >>>> from user
>>> >>>> point of view. The main concern was to display as much as the
>>> >>>> content of
>>> >>>> column should be displayed.
>>> >>>>
>>> >>>> Now the width of column is decided using the text length of column
>>> >>>> name
>>> >>>> or column type so that the column takes exact width it required and
>>> >>>> it don't
>>> >>>> appears cut.
>>> >>>>
>>> >>>> 2) Remember column size after re-running a query.
>>> >>>>
>>> >>>> The approach is to extract table name from the query executed and
>>> >>>> use it
>>> >>>> to store its columns width.
>>> >>>> Whenever the column(s) width of a table is adjusted, the
>>> >>>> corresponding
>>> >>>> values are updated into the object and used every time the same
>>> >>>> query is
>>> >>>> executed.
>>> >>>>
>>> >>>> If a query is executed for e.g:
>>> >>>>
>>> >>>> SELECT generate_series(1, 1000) as id, generate_series(1, 1000) as
>>> >>>> name,
>>> >>>> generate_series(1, 1000) as age
>>> >>>>
>>> >>>> it
>>> >>>> displays 3 columns
>>> >>>> but don't have any table name. In that case,
>>> >>>>  i use a hash generator function which returns unique hash for a
>>> >>>> query
>>> >>>> written in query editor and adjusted column(s) width are stored
>>> >>>> against that
>>> >>>> hash in object.
>>> >>>>
>>> >>>> Is there any way to get temporary table name(avoiding unique hash)
>>> >>>> for
>>> >>>> such queries ?
>>> >>>>
>>> >>>> Also, Moved utilities functions into pgadmin/static/utils.js
>>> >>>>
>>> >>>> Please find attached patch and review.
>>> >>>>
>>> >>>> Thanks,
>>> >>>> Surinder Kumar
>>> >>>
>>> >>>
>>> >>>
>>> >>> --
>>> >>> Sent via pgadmin-hackers mailing list
>>> >>> (pgadmin-hackers@postgresql.org)
>>> >>> To make changes to your subscription:
>>> >>> http://www.postgresql.org/mailpref/pgadmin-hackers
>>> >
>>> >
>>> >
>>> >
>>> > --
>>> > Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
>>> > To make changes to your subscription:
>>> > http://www.postgresql.org/mailpref/pgadmin-hackers
>>> >
>>>
>>>
>>>
>>> --
>>> Dave Page
>>> Blog: http://pgsnake.blogspot.com
>>> Twitter: @pgsnake
>>>
>>> EnterpriseDB UK: http://www.enterprisedb.com
>>> The Enterprise PostgreSQL Company
>>
>>
>



-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers


[pgadmin-hackers] pgAdmin 4 commit: Retain column sizing in the query tool results grid w

2017-06-08 Thread Dave Page
Retain column sizing in the query tool results grid when the same query is 
re-run multiple times in a row. Fixes #1971

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=2fddf750e6a664a2d82756bf896bdacad1e10b2a
Author: Surinder Kumar 

Modified Files
--
web/pgadmin/static/js/sqleditor_utils.js   |  58 ++
.../sqleditor/templates/sqleditor/js/sqleditor.js  | 120 -
web/regression/javascript/sqleditor_utils_spec.js  |  27 +
3 files changed, 129 insertions(+), 76 deletions(-)


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers


[pgadmin-hackers] pgAdmin 4 commit: Fix an intermittent error seen during result polling.

2017-06-08 Thread Dave Page
Fix an intermittent error seen during result polling. Fixes #2470

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=678b891ff76fea6f2c287d1eb3bc84ff242c61b4
Author: Murtuza Zabuawala 

Modified Files
--
web/pgadmin/utils/driver/psycopg2/__init__.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers


Re: [pgadmin-hackers] [pgAdmin4] To fix the error "ValueError: too many values to unpack" while polling

2017-06-08 Thread Dave Page
Thanks, applied.

On Wed, Jun 7, 2017 at 1:26 PM, Murtuza Zabuawala
<murtuza.zabuaw...@enterprisedb.com> wrote:
> Hi,
>
> PFA minor patch to fix the issue in query tool result polling causing
> exception,
> ValueError: too many values to unpack
> RM#2470
>
> --
> Regards,
> Murtuza Zabuawala
> EnterpriseDB: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
>
> --
> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>



-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers


Re: [pgadmin-hackers] [pgAdmin4] To fix issues in pgAgent's modules

2017-06-08 Thread Dave Page
Thanks, applied.

On Wed, Jun 7, 2017 at 12:54 PM, Murtuza Zabuawala
<murtuza.zabuaw...@enterprisedb.com> wrote:
> Hi,
>
> Please find attached patch to fix the issues in pgAgent's Schedule and Step
> module.
>
> 1) Error on clicking SQL panel when Schedule OR Step node is selected in
> browser.
> RM#1888
>
> 2) Error while dropping Schedule OR Step node.
> RM#1889
>
> 3) Newly created Schedule/Step node was not displaying in browser.
> RM#1890
>
> Other misc changes are for PEP-8.
>
> --
> Regards,
> Murtuza Zabuawala
> EnterpriseDB: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
>
> --
> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>



-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers


[pgadmin-hackers] pgAdmin 4 commit: Fix various issues with pgAgent job steps and schedul

2017-06-08 Thread Dave Page
Fix various issues with pgAgent job steps and schedules:

1) Error on clicking SQL panel when Schedule OR Step node is selected in 
browser. Fixes #1888

2) Error while dropping Schedule OR Step node. Fixes #1889

3) Newly created Schedule/Step node was not displaying in browser. Fixes #1890

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=b149fe371e56d8b11c76bd4dc4f54eecd5cba8f1
Author: Murtuza Zabuawala 

Modified Files
--
.../server_groups/servers/pgagent/__init__.py  |   2 +-
.../servers/pgagent/schedules/__init__.py  | 192 +++--
.../servers/pgagent/steps/__init__.py  | 110 +---
.../steps/templates/pga_jobstep/js/pga_jobstep.js  |   2 +-
4 files changed, 227 insertions(+), 79 deletions(-)


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers


[pgadmin-hackers] pgAdmin 4 commit: Fix a couple of missing greys.

2017-06-07 Thread Dave Page
Fix a couple of missing greys.

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=88737248ab9d2615ea6a16bef3913634020989f0
Author: Surinder Kumar 

Modified Files
--
web/pgadmin/browser/templates/browser/js/node.js | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers


Re: [pgadmin-hackers] [pgAdmin4][PATCH] Consolidating gray colors in the application

2017-06-07 Thread Dave Page
Thanks, applied.

On Wed, Jun 7, 2017 at 3:48 PM, Surinder Kumar
<surinder.ku...@enterprisedb.com> wrote:
> Hi
>
> I have used classes 'bg-gray-2 border-gray-3' for styling header and footer
> of properties panel which are also used in other places.
>
> Please find attached patch.
>
>
> On Wed, Jun 7, 2017 at 6:59 PM, Robert Eckhardt <reckha...@pivotal.io>
> wrote:
>>
>> Thank you.
>>
>> -- Rob
>>
>> On Wed, Jun 7, 2017 at 9:28 AM, Surinder Kumar
>> <surinder.ku...@enterprisedb.com> wrote:
>>>
>>> Sure I will send.
>>>
>>> On Wed, Jun 7, 2017 at 6:54 PM, Dave Page <dp...@pgadmin.org> wrote:
>>>>
>>>> On Wed, Jun 7, 2017 at 2:22 PM, Surinder Kumar
>>>> <surinder.ku...@enterprisedb.com> wrote:
>>>> > Hi
>>>> >
>>>> > With the latest pull, I found:
>>>> > The header color of Properties panel disappears and background color
>>>> > of
>>>> > footer area in Edit Properties panel is changed.
>>>>
>>>> Oh, I missed that :-(. Can you come up with a quick fix using the new
>>>> classes?
>>>>
>>>> --
>>>> Dave Page
>>>> Blog: http://pgsnake.blogspot.com
>>>> Twitter: @pgsnake
>>>>
>>>> EnterpriseDB UK: http://www.enterprisedb.com
>>>> The Enterprise PostgreSQL Company
>>>
>>>
>>
>



-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers


Re: [pgadmin-hackers] [pgAdmin4] [PATCH] History Tab rewrite in React

2017-06-07 Thread Dave Page
t;> other Build system in the other thread, but we need to have some decision
>>>>> because this patch needs a build system.
>>>>> If we remove Grunt from this patch we will need to execute the
>>>>> following command every time the application run:
>>>>>
>>>>> yarn run eslint pgadmin/static/jsx/**/*.jsx
>>>>> pgadmin/static/js/selection/*.js regression/javascript/**/*.jsx
>>>>> regression/javascript/**/*.js *.js && yarn run webpack -- --config
>>>>> webpack.config.js && python web/pgAdmin4
>>>>>
>>>>> And to run the jasmine tests:
>>>>>
>>>>> yarn run eslint pgadmin/static/jsx/**/*.jsx
>>>>> pgadmin/static/js/selection/*.js regression/javascript/**/*.jsx
>>>>> regression/javascript/**/*.js *.js && yarn run karma start
>>>>>
>>>>> And to run the feature tests:
>>>>>
>>>>> yarn run eslint pgadmin/static/jsx/**/*.jsx
>>>>> pgadmin/static/js/selection/*.js regression/javascript/**/*.jsx
>>>>> regression/javascript/**/*.js *.js && yarn run webpack -- --config
>>>>> webpack.config.js && python runtests.py
>>>>>
>>>>> Is this a solution that is acceptable?
>>>>
>>>>
>>>> As per my knowledge, Grunt can run the tasks and bundle the JS and CSS
>>>> files (using r.js which is not preferred). But Webpack can not do both. It
>>>> can only bundle files, it has to be used with either Grunt or Gulp to
>>>> execute tasks.
>>>>
>>>> Is it possible to run the task listed above by configuring them in
>>>> "scripts" in package.json file and running concurrently ?
>>>>
>>>> scripts: {
>>>>  "task-name1": "yarn run eslint filename",
>>>> "task-name2": "yarn run karma start", so on...
>>>> }
>>>>
>>>> and run them using following command:
>>>> npm run task-name1
>>>>
>>>>>
>>>>>
>>>>>> However; this patch is supposed to be about the history tab rewrite.
>>>>>> Whatever solution we use for webpacking/transpiling/linting/minifying
>>>>>> etc, it should be a standalone change as it's decidedly non-trivial.
>>>>>
>>>>> We split this patch into 2 different commits:
>>>>> 1 - Add React and all the tools needed to work with it, this includes
>>>>> Grunt, Webpack and ESLint
>>>>> 2 - Change the history tab
>>>>>
>>>>> Do you want a single commit for each of the following?
>>>>>   React (just adds the React library via yarn)
>>>>>   Webpack (adds Webpack library via yarn and creates the
>>>>> webpack.config.js)
>>>>>   ESLint (adds ESLint library via yarn, creates .eslintrc config file,
>>>>> and corrects all lint errors that previously existed)
>>>>>   Grunt (adds Grunt library via yarn and creates Gruntfile.js config,
>>>>> creating a pipeline of the previous three libraries/tasks)
>>>>>   Our change to History
>>>>>
>>>>> Thanks
>>>>> Joao & Matt
>>>>>
>>>>> On Tue, May 30, 2017 at 10:10 AM, Dave Page <dp...@pgadmin.org> wrote:
>>>>>>
>>>>>> Hi
>>>>>>
>>>>>> On Tue, May 30, 2017 at 2:47 PM, Matthew Kleiman <mklei...@pivotal.io>
>>>>>> wrote:
>>>>>> > Hi Dave,
>>>>>> >
>>>>>> > We are currently using the Grunt taskrunner to run the following
>>>>>> > tasks:
>>>>>> >
>>>>>> > lint the javascript code
>>>>>> > start javascript tests
>>>>>> > invoke webpack to transpile and bundle js and jsx files
>>>>>> > minify javascript
>>>>>> >
>>>>>> > In order to remove Grunt from the application, we will need some
>>>>>> > other tool
>>>>>> > to execute these listed tasks.
>>>>>> >
>>>>>> > There are other tools available, like Gulp.js, that we could use
>>>>>> > instead of
>>>>>> > Grunt. We would like to understand your motivation for removing
>>>>>> > Grunt so we
>>>>>> > can find a better solution.
>>>>>>
>>>>>> The motivation is simple - we want a solution that works for the whole
>>>>>> app, can handle debug vs. release execution, pluggable modules, and
>>>>>> installations in read-only directories.
>>>>>>
>>>>>> Per the other thread on the subject (that Joao suggested continuing
>>>>>> discussion on), Surinder is currently looking into flask-webpack. I
>>>>>> spent some time playing with grunt and some other options last week.
>>>>>>
>>>>>> However; this patch is supposed to be about the history tab rewrite.
>>>>>> Whatever solution we use for webpacking/transpiling/linting/minifying
>>>>>> etc, it should be a standalone change as it's decidedly non-trivial.
>>>>>>
>>>>>> --
>>>>>> Dave Page
>>>>>> Blog: http://pgsnake.blogspot.com
>>>>>> Twitter: @pgsnake
>>>>>>
>>>>>> EnterpriseDB UK: http://www.enterprisedb.com
>>>>>> The Enterprise PostgreSQL Company
>>>>>
>>>>>
>>>>
>>>
>>
>



-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers


  1   2   3   4   5   6   7   8   9   10   >