Re: [pgadmin-hackers] [pgAdmin4][Patch]: Select2 control destroy issue [Minor fix]

[Dave Page]

Thanks, applied.

On Fri, Oct 21, 2016 at 3:55 PM, Surinder Kumar
 wrote:
> I missed to add the check "destroy only if select2 has destroy property'. in
> previous patch.
> It was reproducible when I select access method of exclusion constraint from
> combo box.
>
> Please find attached patch and review.
>
> On Sat, Oct 15, 2016 at 12:50 AM, Dave Page  wrote:
>>
>> Thanks, applied.
>>
>>
>> On Friday, October 14, 2016, Surinder Kumar
>>  wrote:
>>>
>>> Hi
>>>
>>> While clicking on Select2 control, it tries to destroy the control and
>>> thus it doesn't get this object sometimes and throws error.
>>>
>>> It should attempt to destroy the select2 object only if this object is
>>> not undefined.
>>> Adds proper check to handle the case.
>>>
>>> Please find minor patch and review.
>>>
>>> Thanks
>>> Surinder Kumar
>>
>>
>>
>> --
>> Dave Page
>> Blog: http://pgsnake.blogspot.com
>> Twitter: @pgsnake
>>
>> EnterpriseDB UK: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>



-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers] [pgAdmin4][Patch]: Select2 control destroy issue [Minor fix]

[Surinder Kumar]

​I missed to add the check "destroy only if select2 has destroy property'.
in previous patch.
It was reproducible when I select access method of exclusion constraint
from combo box.

Please find attached patch and review.

On Sat, Oct 15, 2016 at 12:50 AM, Dave Page  wrote:

> Thanks, applied.
>
>
> On Friday, October 14, 2016, Surinder Kumar  com> wrote:
>
>> Hi
>>
>> While clicking on Select2 control, it tries to destroy the control and
>> thus it doesn't get this object sometimes and throws error.
>>
>> It should attempt to destroy the select2 object only if this object is
>> not undefined.
>> Adds proper check to handle the case.
>>
>> Please find minor patch and review.
>>
>> Thanks
>> Surinder Kumar
>>
>
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
>


select2_control_destroy_issue_v2.patch
Description: Binary data

-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers] [pgAdmin4][Patch]: Select2 control destroy issue [Minor fix]

[Dave Page]

Thanks, applied.

On Friday, October 14, 2016, Surinder Kumar 
wrote:

> Hi
>
> While clicking on Select2 control, it tries to destroy the control and
> thus it doesn't get this object sometimes and throws error.
>
> It should attempt to destroy the select2 object only if this object is not
> undefined.
> Adds proper check to handle the case.
>
> Please find minor patch and review.
>
> Thanks
> Surinder Kumar
>


-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

[pgadmin-hackers] [pgAdmin4][Patch]: Select2 control destroy issue [Minor fix]

[Surinder Kumar]

Hi

While clicking on Select2 control, it tries to destroy the control and thus
it doesn't get this object sometimes and throws error.

It should attempt to destroy the select2 object only if this object is not
undefined.
Adds proper check to handle the case.

Please find minor patch and review.

Thanks
Surinder Kumar


select2_control_destroy_issue.patch
Description: Binary data

-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers