Re: [pgadmin-hackers] [pgAdmin4][Patch][RM_2482]: Query tool/ Edit grid panel should have meaningful title

Thanks Surinder. That, along with another fix seems to have got the tests working fully again. On Tue, Jun 13, 2017 at 6:37 PM, Surinder Kumar wrote: > Hi > > PFA patch. > > On Tue, Jun 13, 2017 at 9:54 PM, Dave Page wrote: >> >> Hmm, this seems to have broken the feature tests. Can you look at

Re: [pgadmin-hackers] [pgAdmin4][Patch][RM_2482]: Query tool/ Edit grid panel should have meaningful title

On Tue, Jun 13, 2017 at 11:24 PM, Shirley Wang wrote: > > > On Tue, Jun 13, 2017 at 10:42 AM Surinder Kumar < > surinder.ku...@enterprisedb.com> wrote: > >> On Tue, Jun 13, 2017 at 10:08 PM, Shirley Wang wrote: >> >>> Awesome!! This is super helpful :) >>> >>> Does this affect a new query window

Re: [pgadmin-hackers] [pgAdmin4][Patch][RM_2482]: Query tool/ Edit grid panel should have meaningful title

On Tue, Jun 13, 2017 at 10:42 AM Surinder Kumar < surinder.ku...@enterprisedb.com> wrote: > On Tue, Jun 13, 2017 at 10:08 PM, Shirley Wang wrote: > >> Awesome!! This is super helpful :) >> >> Does this affect a new query window (currently the title is 'Query - >> untitled')? >> > ​Yes, in this ca

Re: [pgadmin-hackers] [pgAdmin4][Patch][RM_2482]: Query tool/ Edit grid panel should have meaningful title

On Tue, Jun 13, 2017 at 10:08 PM, Shirley Wang wrote: > Awesome!! This is super helpful :) > > Does this affect a new query window (currently the title is 'Query - > untitled')? > ​Yes, in this case the title of query window will be Query - [db_name] on [server_name]. It was showing 'Query - unti

Re: [pgadmin-hackers] [pgAdmin4][Patch][RM_2482]: Query tool/ Edit grid panel should have meaningful title

Hi PFA patch. On Tue, Jun 13, 2017 at 9:54 PM, Dave Page wrote: > Hmm, this seems to have broken the feature tests. Can you look at that > ASAP please? I think it's because the tab text has changed. > ​Yes, now it will search for 'Query -' ​instead of 'Query-1'. > > On Tue, Jun 13, 2017 at 11:

Re: [pgadmin-hackers] [pgAdmin4][Patch][RM_2482]: Query tool/ Edit grid panel should have meaningful title

Awesome!! This is super helpful :) Does this affect a new query window (currently the title is 'Query - untitled')? On Mon, Jun 12, 2017 at 10:25 PM Surinder Kumar < surinder.ku...@enterprisedb.com> wrote: > Hi > > Changes: > > 1) When Query tool is opened, right now - panel title is displayed a

Re: [pgadmin-hackers] [pgAdmin4][Patch][RM_2482]: Query tool/ Edit grid panel should have meaningful title

Hmm, this seems to have broken the feature tests. Can you look at that ASAP please? I think it's because the tab text has changed. On Tue, Jun 13, 2017 at 11:34 AM, Dave Page wrote: > Thanks, patch applied. > > On Tue, Jun 13, 2017 at 6:24 AM, Surinder Kumar > wrote: >> Hi >> >> Changes: >> >> 1

Re: [pgadmin-hackers] [pgAdmin4][Patch][RM_2482]: Query tool/ Edit grid panel should have meaningful title

Thanks, patch applied. On Tue, Jun 13, 2017 at 6:24 AM, Surinder Kumar wrote: > Hi > > Changes: > > 1) When Query tool is opened, right now - panel title is displayed as "Query > - 1 ", instead it should display Query - [db_name] on [server_name] as in > pgAdmin3. > > 2) When Edit grid is opened

[pgadmin-hackers] [pgAdmin4][Patch][RM_2482]: Query tool/ Edit grid panel should have meaningful title

Hi Changes: 1) When Query tool is opened, right now - panel title is displayed as "Query - 1 ", instead it should display Query - [db_name] on [server_name] as in pgAdmin3. 2) When Edit grid is opened for table, the panel title should display Edit Data - [server_name] - [db_name] - [table_name]