Re: [pgadmin-hackers] Control for selecting multiple columns [pgadmin4]

2016-03-22 Thread Dave Page
Thanks - applied. On Tue, Mar 22, 2016 at 10:10 AM, Harshal Dhumal < harshal.dhu...@enterprisedb.com> wrote: > Hi, > > PFA patch for MultiselectControl. > > Issue: Fixed issue when parsing undefined data as json. > > > -- > *Harshal Dhumal* > *Software Engineer * > > > > EenterpriseDB

Re: [pgadmin-hackers] Control for selecting multiple columns [pgadmin4]

2016-03-22 Thread Harshal Dhumal
Hi, PFA patch for MultiselectControl. Issue: Fixed issue when parsing undefined data as json. -- *Harshal Dhumal* *Software Engineer * EenterpriseDB On Mon, Mar 21, 2016 at 11:35 AM, Harshal Dhumal < harshal.dhu...@enterprisedb.com> wrote: > Hi, > > Here is

Re: [pgadmin-hackers] Control for selecting multiple columns [pgadmin4]

2016-03-21 Thread Harshal Dhumal
Hi, Here is updated patch -- *Harshal Dhumal* *Software Engineer * EenterpriseDB On Fri, Mar 18, 2016 at 9:37 PM, Dave Page wrote: > > > On Fri, Mar 18, 2016 at 11:41 AM, Harshal Dhumal < > harshal.dhu...@enterprisedb.com> wrote: > >> Hi

Re: [pgadmin-hackers] Control for selecting multiple columns [pgadmin4]

2016-03-19 Thread Dave Page
Hi I tried that, but get the attached error when testing. I'm on a clean tree, with the WIP tables patch (which, by the way, doesn't look much like Arun's design so is likely to need a lot of layout work). I've restarted, refreshed etc. [image: Inline image 1] On Thu, Mar 17, 2016 at 6:04 AM,

Re: [pgadmin-hackers] Control for selecting multiple columns [pgadmin4]

2016-03-19 Thread Dave Page
On Fri, Mar 18, 2016 at 11:41 AM, Harshal Dhumal < harshal.dhu...@enterprisedb.com> wrote: > Hi Dave, > > The error is at line 84 in primary_key.js (from screenshot). > > In primary_key.js it requires MultiSelectAjaxControl. I guess patch of > MultiSelectControl was not applied correctly. > > Can

Re: [pgadmin-hackers] Control for selecting multiple columns [pgadmin4]

2016-03-18 Thread Harshal Dhumal
Hi Dave, This seems to be some dependency issue. Can you please send me a screenshot of debugger console with js error stack. Regards, Harshal -- *Harshal Dhumal* *Software Engineer * EenterpriseDB On Thu, Mar 17, 2016 at 10:33 PM, Dave Page

Re: [pgadmin-hackers] Control for selecting multiple columns [pgadmin4]

2016-03-15 Thread Dave Page
It seems to be missing the test dialogue? On Tue, Mar 15, 2016 at 8:47 AM, Harshal Dhumal < harshal.dhu...@enterprisedb.com> wrote: > Hi, > > PFA generalized updated patch for backform multiSelectControl. > > -- > *Harshal Dhumal* > *Software Engineer * > > > > EenterpriseDB

Re: [pgadmin-hackers] Control for selecting multiple columns [pgadmin4]

2016-03-15 Thread Harshal Dhumal
Hi, PFA generalized updated patch for backform multiSelectControl. -- *Harshal Dhumal* *Software Engineer * EenterpriseDB On Tue, Mar 8, 2016 at 1:04 PM, Harshal Dhumal < harshal.dhu...@enterprisedb.com> wrote: > Hi, > > PFA backform control for selecting

Re: [pgadmin-hackers] Control for selecting multiple columns [pgadmin4]

2016-03-08 Thread Harshal Dhumal
Hi Dave, Currently there is no test dialogue to test this control. Also Ashesh has suggested some changes. Once I complete those changes; I'll resubmit the patch along with test dialogue to test it. -- *Harshal Dhumal* *Software Engineer * EenterpriseDB On

Re: [pgadmin-hackers] Control for selecting multiple columns [pgadmin4]

2016-03-08 Thread Dave Page
Hi, Do you have a test dialogue or similar in which I can test this code? Ideally an addition to the test module would be good. Thanks. On Tue, Mar 8, 2016 at 7:34 AM, Harshal Dhumal < harshal.dhu...@enterprisedb.com> wrote: > Hi, > > PFA backform control for selecting multiple columns.(This

[pgadmin-hackers] Control for selecting multiple columns [pgadmin4]

2016-03-07 Thread Harshal Dhumal
Hi, PFA backform control for selecting multiple columns.(This control depends on column node.) Usage: { id: 'columns', label: '{{ _('Columns') }}', type: 'collection', group: '{{ _('Definition') }}', editable:true, canDelete: true, canAdd: true, control: Backform.MultiColumnSelectControl,