Re: [pgadmin-hackers] Fixed RM #1356

2016-06-20 Thread Adam Brusselback
Another that may be worth looking into is Vaadin Elements Grid (and possibly some of the other Vaadin Element components where applicable): https://vaadin.com/elements/-/element/vaadin-grid On Mon, Jun 20, 2016 at 4:42 AM, Dave Page wrote: > > > On Mon, Jun 20, 2016 at 6:41

Re: [pgadmin-hackers] Fixed RM #1356

2016-06-20 Thread Dave Page
On Mon, Jun 20, 2016 at 6:41 AM, Akshay Joshi wrote: > Hi Dave > > On Fri, Jun 17, 2016 at 9:00 PM, Dave Page wrote: > >> On Fri, Jun 17, 2016 at 4:25 PM, Ashesh Vashi >> wrote: >> > >> > On Jun 17, 2016 20:53,

Re: [pgadmin-hackers] Fixed RM #1356

2016-06-19 Thread Akshay Joshi
Hi Dave On Fri, Jun 17, 2016 at 9:00 PM, Dave Page wrote: > On Fri, Jun 17, 2016 at 4:25 PM, Ashesh Vashi > wrote: > > > > On Jun 17, 2016 20:53, "Dave Page" wrote: > >> > >> > >> > >> On Fri, Jun 17, 2016 at 4:04 PM, Akshay

Re: [pgadmin-hackers] Fixed RM #1356

2016-06-17 Thread Ashesh Vashi
On Jun 17, 2016 20:53, "Dave Page" wrote: > > > > On Fri, Jun 17, 2016 at 4:04 PM, Akshay Joshi < akshay.jo...@enterprisedb.com> wrote: >> >> Hi Dave >> >> On Thu, Jun 16, 2016 at 6:48 PM, Dave Page wrote: >>> >>> >>> >>> On Thu, Jun 16, 2016 at 1:43 PM,

Re: [pgadmin-hackers] Fixed RM #1356

2016-06-17 Thread Dave Page
On Fri, Jun 17, 2016 at 4:25 PM, Ashesh Vashi wrote: > > On Jun 17, 2016 20:53, "Dave Page" wrote: >> >> >> >> On Fri, Jun 17, 2016 at 4:04 PM, Akshay Joshi >> wrote: >>> >>> Hi Dave >>> >>> On Thu, Jun 16, 2016 at

Re: [pgadmin-hackers] Fixed RM #1356

2016-06-17 Thread Dave Page
On Fri, Jun 17, 2016 at 4:04 PM, Akshay Joshi wrote: > Hi Dave > > On Thu, Jun 16, 2016 at 6:48 PM, Dave Page wrote: > >> >> >> On Thu, Jun 16, 2016 at 1:43 PM, Akshay Joshi < >> akshay.jo...@enterprisedb.com> wrote: >> >>> >>> >>> On Thu, Jun

Re: [pgadmin-hackers] Fixed RM #1356

2016-06-17 Thread Akshay Joshi
Hi Dave On Thu, Jun 16, 2016 at 6:48 PM, Dave Page wrote: > > > On Thu, Jun 16, 2016 at 1:43 PM, Akshay Joshi < > akshay.jo...@enterprisedb.com> wrote: > >> >> >> On Thu, Jun 16, 2016 at 6:09 PM, Dave Page wrote: >> >>> >>> >>> On Thu, Jun 16, 2016 at 1:34

Re: [pgadmin-hackers] Fixed RM #1356

2016-06-16 Thread Dave Page
On Thu, Jun 16, 2016 at 1:43 PM, Akshay Joshi wrote: > > > On Thu, Jun 16, 2016 at 6:09 PM, Dave Page wrote: > >> >> >> On Thu, Jun 16, 2016 at 1:34 PM, Akshay Joshi < >> akshay.jo...@enterprisedb.com> wrote: >> >>> >>> >>> On Thu, Jun 16, 2016

Re: [pgadmin-hackers] Fixed RM #1356

2016-06-16 Thread Akshay Joshi
On Thu, Jun 16, 2016 at 6:09 PM, Dave Page wrote: > > > On Thu, Jun 16, 2016 at 1:34 PM, Akshay Joshi < > akshay.jo...@enterprisedb.com> wrote: > >> >> >> On Thu, Jun 16, 2016 at 5:47 PM, Khushboo Vashi < >> khushboo.va...@enterprisedb.com> wrote: >> >>> >>> >>> On Thu, Jun

Re: [pgadmin-hackers] Fixed RM #1356

2016-06-16 Thread Dave Page
On Thu, Jun 16, 2016 at 1:34 PM, Akshay Joshi wrote: > > > On Thu, Jun 16, 2016 at 5:47 PM, Khushboo Vashi < > khushboo.va...@enterprisedb.com> wrote: > >> >> >> On Thu, Jun 16, 2016 at 5:07 PM, Dave Page wrote: >> >>> >>> >>> On Thu, Jun 16,

Re: [pgadmin-hackers] Fixed RM #1356

2016-06-16 Thread Akshay Joshi
On Thu, Jun 16, 2016 at 5:47 PM, Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > > > On Thu, Jun 16, 2016 at 5:07 PM, Dave Page wrote: > >> >> >> On Thu, Jun 16, 2016 at 12:19 PM, Khushboo Vashi < >> khushboo.va...@enterprisedb.com> wrote: >> >>> >>> >>> On Thu, Jun

Re: [pgadmin-hackers] Fixed RM #1356

2016-06-16 Thread Khushboo Vashi
On Thu, Jun 16, 2016 at 5:07 PM, Dave Page wrote: > > > On Thu, Jun 16, 2016 at 12:19 PM, Khushboo Vashi < > khushboo.va...@enterprisedb.com> wrote: > >> >> >> On Thu, Jun 16, 2016 at 4:42 PM, Dave Page wrote: >> >>> >>> >>> On Thu, Jun 16, 2016 at 12:04

Re: [pgadmin-hackers] Fixed RM #1356

2016-06-16 Thread Dave Page
On Thu, Jun 16, 2016 at 12:19 PM, Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > > > On Thu, Jun 16, 2016 at 4:42 PM, Dave Page wrote: > >> >> >> On Thu, Jun 16, 2016 at 12:04 PM, Akshay Joshi < >> akshay.jo...@enterprisedb.com> wrote: >> >>> Hi Dave >>> >>> On

Re: [pgadmin-hackers] Fixed RM #1356

2016-06-16 Thread Khushboo Vashi
On Thu, Jun 16, 2016 at 4:42 PM, Dave Page wrote: > > > On Thu, Jun 16, 2016 at 12:04 PM, Akshay Joshi < > akshay.jo...@enterprisedb.com> wrote: > >> Hi Dave >> >> On Thu, Jun 16, 2016 at 2:42 PM, Akshay Joshi > .com> wrote: >> >>> >>> >>> On Thu,

Re: [pgadmin-hackers] Fixed RM #1356

2016-06-16 Thread Dave Page
On Thu, Jun 16, 2016 at 12:04 PM, Akshay Joshi < akshay.jo...@enterprisedb.com> wrote: > Hi Dave > > On Thu, Jun 16, 2016 at 2:42 PM, Akshay Joshi .com> wrote: > >> >> >> On Thu, Jun 16, 2016 at 2:35 PM, Dave Page wrote: >> >>> Thanks, patch

Re: [pgadmin-hackers] Fixed RM #1356

2016-06-16 Thread Akshay Joshi
Hi Dave On Thu, Jun 16, 2016 at 2:42 PM, Akshay Joshi wrote: > > > On Thu, Jun 16, 2016 at 2:35 PM, Dave Page wrote: > >> Thanks, patch applied. >> >> However, whilst I was testing, I saw just how slow the tool is: >> >> SELECT * FROM

Re: [pgadmin-hackers] Fixed RM #1356

2016-06-16 Thread Akshay Joshi
On Thu, Jun 16, 2016 at 2:35 PM, Dave Page wrote: > Thanks, patch applied. > > However, whilst I was testing, I saw just how slow the tool is: > > SELECT * FROM pg_attribute > > In a PEM database, returns 8150 rows. In pgAdmin 3, this is timed at 676ms > on my laptop. In

Re: [pgadmin-hackers] Fixed RM #1356

2016-06-16 Thread Dave Page
Thanks, patch applied. However, whilst I was testing, I saw just how slow the tool is: SELECT * FROM pg_attribute In a PEM database, returns 8150 rows. In pgAdmin 3, this is timed at 676ms on my laptop. In pgAdmin 4, the busy spinner runs for approx 5 seconds, then the whole UI freezes. I then

Re: [pgadmin-hackers] Fixed RM #1356

2016-06-15 Thread Akshay Joshi
Hi Please ignore the last patch. Attached is the latest patch. Please review it. On Wed, Jun 15, 2016 at 9:10 PM, Akshay Joshi wrote: > Hi > > On Wed, Jun 15, 2016 at 5:54 PM, Dave Page wrote: > >> >> >> On Wed, Jun 15, 2016 at 1:16 PM,

Re: [pgadmin-hackers] Fixed RM #1356

2016-06-15 Thread Akshay Joshi
Hi On Wed, Jun 15, 2016 at 5:54 PM, Dave Page wrote: > > > On Wed, Jun 15, 2016 at 1:16 PM, Ashesh Vashi < > ashesh.va...@enterprisedb.com> wrote: > >> On Wed, Jun 15, 2016 at 5:44 PM, Akshay Joshi < >> akshay.jo...@enterprisedb.com> wrote: >> >>> >>> >>> On Wed, Jun 15, 2016

Re: [pgadmin-hackers] Fixed RM #1356

2016-06-15 Thread Dave Page
On Wed, Jun 15, 2016 at 1:16 PM, Ashesh Vashi wrote: > On Wed, Jun 15, 2016 at 5:44 PM, Akshay Joshi < > akshay.jo...@enterprisedb.com> wrote: > >> >> >> On Wed, Jun 15, 2016 at 5:25 PM, Dave Page wrote: >> >>> Hi >>> >>> On Wed, Jun 15, 2016

Re: [pgadmin-hackers] Fixed RM #1356

2016-06-15 Thread Ashesh Vashi
On Wed, Jun 15, 2016 at 5:44 PM, Akshay Joshi wrote: > > > On Wed, Jun 15, 2016 at 5:25 PM, Dave Page wrote: > >> Hi >> >> On Wed, Jun 15, 2016 at 11:27 AM, Akshay Joshi < >> akshay.jo...@enterprisedb.com> wrote: >> >>> Hi >>> >>> I have fixed

Re: [pgadmin-hackers] Fixed RM #1356

2016-06-15 Thread Akshay Joshi
On Wed, Jun 15, 2016 at 5:25 PM, Dave Page wrote: > Hi > > On Wed, Jun 15, 2016 at 11:27 AM, Akshay Joshi < > akshay.jo...@enterprisedb.com> wrote: > >> Hi >> >> I have fixed RM #1356 "Query tool enhancement". I have added the logic to >> preferences which checks the min/max

Re: [pgadmin-hackers] Fixed RM #1356

2016-06-15 Thread Dave Page
Hi On Wed, Jun 15, 2016 at 11:27 AM, Akshay Joshi < akshay.jo...@enterprisedb.com> wrote: > Hi > > I have fixed RM #1356 "Query tool enhancement". I have added the logic to > preferences which checks the min/max value before setting it. If value > given by user is less than min value then set it

[pgadmin-hackers] Fixed RM #1356

2016-06-15 Thread Akshay Joshi
Hi I have fixed RM #1356 "Query tool enhancement". I have added the logic to preferences which checks the min/max value before setting it. If value given by user is less than min value then set it to min value and if value is greater then max value then set it to max value. For "items_per_page"