Re: [pgadmin-hackers] Issue with SlickGrid

2017-05-05 Thread Sarah McAlear
Hi Murtuza! 1) > Individual cell selection is not visible, > This will be useful to user when user wants to use "By Selection" & > "Exclude Selection" filter option. > (Even if active cell is not visible to user, above filters are working > though when we click on any cell) Good catch. We'll

Re: [pgadmin-hackers] Issue with SlickGrid

2017-04-27 Thread Dave Page
Thanks Joao. Murtuza, can you review this please? On Thu, Apr 27, 2017 at 4:49 PM, Joao Pedro De Almeida Pereira < jdealmeidapere...@pivotal.io> wrote: > Hi Hackers, > > We found that the latest version of SlickGrid fixes the scrollbar issue. > We have upgraded it to the latest version in our

Re: [pgadmin-hackers] Issue with SlickGrid

2017-04-27 Thread Murtuza Zabuawala
No, we didn't. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Thu, Apr 27, 2017 at 4:42 PM, Joao Pedro De Almeida Pereira < jdealmeidapere...@pivotal.io> wrote: > Hello Murtuza, > Thanks for the explanation. Based on what you said it

Re: [pgadmin-hackers] Issue with SlickGrid

2017-04-27 Thread Joao Pedro De Almeida Pereira
Hello Murtuza, Thanks for the explanation. Based on what you said it looks like a bug in the library, have you guys considered sending a PR to it? Thanks On Thu, Apr 27, 2017, 2:46 AM Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > +++ > Reference: >

Re: [pgadmin-hackers] Issue with SlickGrid

2017-04-27 Thread Murtuza Zabuawala
+++ Reference: https://www.postgresql.org/message-id/CAKKotZRjqbKAZev81Zk78nikDVXqLKEDV5r%2BsW8Me31Gpzrm_A%40mail.gmail.com -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Thu, Apr 27, 2017 at 12:09 PM, Murtuza Zabuawala <

Re: [pgadmin-hackers] Issue with SlickGrid

2017-04-27 Thread Murtuza Zabuawala
Hello Joao, Yes, We made some changes in SlickGrid library when we integrated it into Query tool. *Issue:* Last row from the query result set was not displaying correctly in query tool when we have scrollbar in grid. The row hight/width pixel size calculations is done inside SlickGrid

[pgadmin-hackers] Issue with SlickGrid

2017-04-26 Thread Joao Pedro De Almeida Pereira
Hello Hackers, While doing some changes to the Query Results we found out that there was a issue with Slick grid. The issue that we found was with the CellSelectModel, behaved differently when pressing Ctrl and Command(Mac). We created a PR with the