Re: [pgadmin-hackers] PATCH: PGADMIN 4 - FTS templates node

Thanks - committed. On Thu, Apr 7, 2016 at 2:47 PM, Sanket Mehta wrote: > Hi, > > Sorry about that issue, > > Its resolved now. > > PFA the right patch with this mail. > > > Regards, > Sanket Mehta > Sr Software engineer > Enterprisedb > > On Thu, Apr 7, 2016 at

Re: [pgadmin-hackers] PATCH: PGADMIN 4 - FTS templates node

Hi, Sorry about that issue, Its resolved now. PFA the right patch with this mail. Regards, Sanket Mehta Sr Software engineer Enterprisedb On Thu, Apr 7, 2016 at 2:39 PM, Dave Page wrote: > Hi > > On Mon, Mar 28, 2016 at 10:01 AM, Sanket Mehta >

Re: [pgadmin-hackers] PATCH: PGADMIN 4 - FTS templates node

Hi On Mon, Mar 28, 2016 at 10:01 AM, Sanket Mehta wrote: > Hi Dave, > > I have found out the root cause of this issue. > > This issue is occurring at your side as you are using python 2.7 so in that > case sql query returned from sql template is of type 'unicode'.

Re: [pgadmin-hackers] PATCH: PGADMIN 4 - FTS templates node

Hi Dave, I have found out the root cause of this issue. This issue is occurring at your side as you are using python 2.7 so in that case sql query returned from sql template is of type 'unicode'. And in __init__.py file we have checked if the sql query is of string type then only we would

Re: [pgadmin-hackers] PATCH: PGADMIN 4 - FTS templates node

Hi, Sorry its misunderstanding from my side. That node refresh on tree issue has been resolved. Patch is attached with this mail. Please do review it. Regards, Sanket Mehta Sr Software engineer Enterprisedb On Mon, Mar 14, 2016 at 7:27 PM, Dave Page wrote: > On Mon, Mar

Re: [pgadmin-hackers] PATCH: PGADMIN 4 - FTS templates node

On Mon, Mar 14, 2016 at 1:52 PM, Sanket Mehta wrote: > Hi Dave, > > I have incorporated your changes. > I have also tried to reproduce the Issues that you have mentioned. > find the response inline. > > Also find revised patch having your suggested changes attached

Re: [pgadmin-hackers] PATCH: PGADMIN 4 - FTS templates node

Hi Dave, I have incorporated your changes. I have also tried to reproduce the Issues that you have mentioned. find the response inline. Also find revised patch having your suggested changes attached with this mail. Please do review it and let me know in case anything is missing. Regards,

Re: [pgadmin-hackers] PATCH: PGADMIN 4 - FTS templates node

Hi, PFA the patch for fts template after *replacing collectionNodeModule with SchemaChildModule* in __init__.py Apart from that, there was an error while updating the name of fts template which I have resolved in the same. Please do review it and let me know in case of any changes. Regards,

Re: [pgadmin-hackers] PATCH: PGADMIN 4 - FTS templates node

Hi Dave, All comments are resolved. PFA the revised patch. Regards, Sanket Mehta Sr Software engineer Enterprisedb On Thu, Feb 25, 2016 at 7:37 PM, Dave Page wrote: > Hi > > On Tue, Feb 23, 2016 at 1:44 PM, Sanket Mehta < > sanket.me...@enterprisedb.com> wrote: > >> Hi, >>

Re: [pgadmin-hackers] PATCH: PGADMIN 4 - FTS templates node

Hi On Tue, Feb 23, 2016 at 1:44 PM, Sanket Mehta wrote: > Hi, > > PFA the revised patch for fts template node which includes dependency and > dependent route handling code. > Please do review it and if found proper please do commit it. > - When creating a new

Re: [pgadmin-hackers] PATCH: PGADMIN 4 - FTS templates node

Hi, PFA the revised patch for fts template node which includes dependency and dependent route handling code. Please do review it and if found proper please do commit it. Regards, Sanket Mehta Sr Software engineer Enterprisedb On Thu, Jan 28, 2016 at 7:21 PM, Sanket Mehta

[pgadmin-hackers] PATCH: PGADMIN 4 - FTS templates node

Hi, I have created patch for "FTS Template" node in pgadmin4. Please do review it and let me know in case anything is missing. Regards, Sanket Mehta Sr Software engineer Enterprisedb diff --git a/web/pgadmin/browser/server_groups/servers/databases/schemas/fts_templates/__init__.py