Re: [pgadmin-hackers] Re: Server side cursor limitations for on demand loading of data in query tool [RM2137] [pgAdmin4]

Hi Dave, Please find attached patch where I have added timeout of 2 seconds before selecting object menu in connect to server function. Note: Apply this patch on top of previous patch for on demand loading feature. -- *Harshal Dhumal* *Sr. Software Engineer* EnterpriseDB India: http://www.ent

Re: [pgadmin-hackers] Re: Server side cursor limitations for on demand loading of data in query tool [RM2137] [pgAdmin4]

Sounds good, thanks. On Thu, Jun 15, 2017 at 9:54 PM, Harshal Dhumal wrote: > Hi > > On Fri, Jun 16, 2017 at 2:07 AM, Dave Page wrote: >> >> Hi >> >> On Thu, Jun 15, 2017 at 9:30 PM, Harshal Dhumal >> wrote: >> > Hi Dave, >> > >> > Please find attached updated patch. >> > >> > On Thu, Jun 15, 2

Re: [pgadmin-hackers] Re: Server side cursor limitations for on demand loading of data in query tool [RM2137] [pgAdmin4]

Hi On Fri, Jun 16, 2017 at 2:07 AM, Dave Page wrote: > Hi > > On Thu, Jun 15, 2017 at 9:30 PM, Harshal Dhumal > wrote: > > Hi Dave, > > > > Please find attached updated patch. > > > > On Thu, Jun 15, 2017 at 3:58 PM, Dave Page wrote: > >> > >> Hi > >> > >> On Wed, Jun 14, 2017 at 11:36 PM, Har

Re: [pgadmin-hackers] Re: Server side cursor limitations for on demand loading of data in query tool [RM2137] [pgAdmin4]

Hi On Thu, Jun 15, 2017 at 9:30 PM, Harshal Dhumal wrote: > Hi Dave, > > Please find attached updated patch. > > On Thu, Jun 15, 2017 at 3:58 PM, Dave Page wrote: >> >> Hi >> >> On Wed, Jun 14, 2017 at 11:36 PM, Harshal Dhumal >> wrote: >>> >>> Hi Dave, >>> >>> Please find rebased patch for RM2

Re: [pgadmin-hackers] Re: Server side cursor limitations for on demand loading of data in query tool [RM2137] [pgAdmin4]

On Wed, Jun 14, 2017 at 6:21 PM, Ashesh Vashi wrote: > On Wed, Jun 14, 2017 at 6:19 PM, Dave Page wrote: > >> Hi, >> >> Sorry - it's drifted out again, I suspect because of the work Ashesh >> has been doing. Can you rebase please? Check with Ashesh first though, >> in case he's about ready to co

Re: [pgadmin-hackers] Re: Server side cursor limitations for on demand loading of data in query tool [RM2137] [pgAdmin4]

On Wed, Jun 14, 2017 at 6:19 PM, Dave Page wrote: > Hi, > > Sorry - it's drifted out again, I suspect because of the work Ashesh > has been doing. Can you rebase please? Check with Ashesh first though, > in case he's about ready to commit another big change. > I am not. :-) -- Thanks & Regards,

Re: [pgadmin-hackers] Re: Server side cursor limitations for on demand loading of data in query tool [RM2137] [pgAdmin4]

Hi, Sorry - it's drifted out again, I suspect because of the work Ashesh has been doing. Can you rebase please? Check with Ashesh first though, in case he's about ready to commit another big change. Thanks. On Fri, Jun 9, 2017 at 10:08 AM, Harshal Dhumal wrote: > Hi, > > > Please find rebased p

Re: [pgadmin-hackers] Re: Server side cursor limitations for on demand loading of data in query tool [RM2137] [pgAdmin4]

Ignore this patch. Rebase and migration of feature tests and jasmine tests required. -- *Harshal Dhumal* *Sr. Software Engineer* EnterpriseDB India: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Thu, Jun 8, 2017 at 3:56 PM, Harshal Dhumal < harshal.dhu...@enterprisedb.com> wr

Re: [pgadmin-hackers] Re: Server side cursor limitations for on demand loading of data in query tool [RM2137] [pgAdmin4]

On Mon, May 15, 2017 at 7:40 PM, Harshal Dhumal < harshal.dhu...@enterprisedb.com> wrote: > Hi, > > On Sat, May 13, 2017 at 12:35 AM, Joao Pedro De Almeida Pereira < > jdealmeidapere...@pivotal.io> wrote: > >> We were only able to apply the patch on 1f903ba2 (were seeing patch does >> not apply du

Re: [pgadmin-hackers] Re: Server side cursor limitations for on demand loading of data in query tool [RM2137] [pgAdmin4]

Hi, On Sat, May 13, 2017 at 12:35 AM, Joao Pedro De Almeida Pereira < jdealmeidapere...@pivotal.io> wrote: > We were only able to apply the patch on 1f903ba2 (were seeing patch does > not apply due to sqleditor.js conflicts) > The javascript tests passed, but we were unable to copy rows or column

Re: [pgadmin-hackers] Re: Server side cursor limitations for on demand loading of data in query tool [RM2137] [pgAdmin4]

We were only able to apply the patch on 1f903ba2 (were seeing patch does not apply due to sqleditor.js conflicts) The javascript tests passed, but we were unable to copy rows or columns or cells when running the application. Could you run feature tests? Now that more functionality is being added t

Re: [pgadmin-hackers] Re: Server side cursor limitations for on demand loading of data in query tool [RM2137] [pgAdmin4]

Hi, -- *Harshal Dhumal* *Sr. Software Engineer* EnterpriseDB India: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Tue, May 9, 2017 at 1:08 AM, Sarah McAlear wrote: > Hi Harshal! > > We applied your patch and ran the Javascript tests and realized there are > 6 tests failing.

Re: [pgadmin-hackers] Re: Server side cursor limitations for on demand loading of data in query tool [RM2137] [pgAdmin4]

Hi Harshal! We applied your patch and ran the Javascript tests and realized there are 6 tests failing. After that we replicate the failures by hand and found the following issues: - Clicking in the checkboxes of the rows does not select the row anymore. - When copying and pasting (any) data, we r

[pgadmin-hackers] Re: Server side cursor limitations for on demand loading of data in query tool [RM2137] [pgAdmin4]

Hi Dave, -- *Harshal Dhumal* *Sr. Software Engineer* EnterpriseDB India: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Mon, May 8, 2017 at 4:49 PM, Dave Page wrote: > Hi > > This is fantastic! The speedup in the query tool is phenomenal with large > result sets. For 96K row

[pgadmin-hackers] Re: Server side cursor limitations for on demand loading of data in query tool [RM2137] [pgAdmin4]

Hi This is fantastic! The speedup in the query tool is phenomenal with large result sets. For 96K rows, I'm now seeing 1 second until I can browse the data, vs. 13 in v1.4 (and 22 secs in pgAdmin 3)!! Awesome work Harshal :-) Questions/comments: - Can we put the row number in the left-hand colum

[pgadmin-hackers] Re: Server side cursor limitations for on demand loading of data in query tool [RM2137] [pgAdmin4]

Hi, Here is patch for initial implementation of on demand loading of result set for query tool and datagrid. -- *Harshal Dhumal* *Sr. Software Engineer* EnterpriseDB India: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Tue, Apr 25, 2017 at 5:21 PM, Dave Page wrote: > Hi >

[pgadmin-hackers] Re: Server side cursor limitations for on demand loading of data in query tool [RM2137] [pgAdmin4]

Hi On Tue, Apr 25, 2017 at 8:41 AM, Harshal Dhumal < harshal.dhu...@enterprisedb.com> wrote: > Hi Dave, > > To implement feature #2137 we'll > need to use server cursor. However server cursor has some > limitation. > For eg. > 1. It cannot execute BEGI