Re: [pgadmin-hackers] Regarding issue 1241

2016-07-18 Thread Dave Page
Thanks - committed with minor tweaks! On Mon, Jul 18, 2016 at 10:32 AM, Harshal Dhumal wrote: > Hi, > > PFA patch for issue RM1241 > > Changes: 1. Altered variable control to make its UI consistence with > privileges and Security labels. > 2. Changed datamodel.js

Re: [pgadmin-hackers] Regarding issue 1241

2016-07-18 Thread Harshal Dhumal
Hi, PFA patch for issue RM1241 Changes: 1. Altered variable control to make its UI consistence with privileges and Security labels. 2. Changed datamodel.js to handle duplicate rows at datamodel level and not UI/Control level. (See variable control for example) -- *Harshal Dhumal* *Software

Re: [pgadmin-hackers] Regarding issue 1241

2016-06-15 Thread Ashesh Vashi
On Wed, Jun 15, 2016 at 7:24 PM, Dave Page wrote: > > > On Wed, Jun 15, 2016 at 2:08 PM, Ashesh Vashi < > ashesh.va...@enterprisedb.com> wrote: > >> On Wed, Jun 15, 2016 at 6:25 PM, Dave Page wrote: >> >>> On Wed, Jun 15, 2016 at 1:49 PM, Ashesh Vashi >>>

Re: [pgadmin-hackers] Regarding issue 1241

2016-06-15 Thread Dave Page
On Wed, Jun 15, 2016 at 2:08 PM, Ashesh Vashi wrote: > On Wed, Jun 15, 2016 at 6:25 PM, Dave Page wrote: > >> On Wed, Jun 15, 2016 at 1:49 PM, Ashesh Vashi >> wrote: >> > On Thu, Jun 2, 2016 at 1:59 PM, Dave Page

Re: [pgadmin-hackers] Regarding issue 1241

2016-06-15 Thread Ashesh Vashi
On Wed, Jun 15, 2016 at 6:25 PM, Dave Page wrote: > On Wed, Jun 15, 2016 at 1:49 PM, Ashesh Vashi > wrote: > > On Thu, Jun 2, 2016 at 1:59 PM, Dave Page wrote: > >> > >> > >> > >> On Tue, May 31, 2016 at 8:53 PM, Harshal

Re: [pgadmin-hackers] Regarding issue 1241

2016-06-15 Thread Dave Page
On Wed, Jun 15, 2016 at 1:49 PM, Ashesh Vashi wrote: > On Thu, Jun 2, 2016 at 1:59 PM, Dave Page wrote: >> >> >> >> On Tue, May 31, 2016 at 8:53 PM, Harshal Dhumal >> wrote: >>> >>> Hi Dave, >>> >>> Regarding

Re: [pgadmin-hackers] Regarding issue 1241

2016-06-15 Thread Ashesh Vashi
On Thu, Jun 2, 2016 at 1:59 PM, Dave Page wrote: > > > On Tue, May 31, 2016 at 8:53 PM, Harshal Dhumal < > harshal.dhu...@enterprisedb.com> wrote: > >> Hi Dave, >> >> Regarding Issue 1241 : >> >> We have added header section for

Re: [pgadmin-hackers] Regarding issue 1241

2016-06-02 Thread Dave Page
On Tue, May 31, 2016 at 8:53 PM, Harshal Dhumal < harshal.dhu...@enterprisedb.com> wrote: > Hi Dave, > > Regarding Issue 1241 : > > We have added header section for parameter tab deliberately so that we can > force user to select parameter name (and

[pgadmin-hackers] Regarding issue 1241

2016-05-31 Thread Harshal Dhumal
Hi Dave, Regarding Issue 1241 : We have added header section for parameter tab deliberately so that we can force user to select parameter name (and therefore parameter's data type) before adding new row. This is required because behavior of second cell