Re: [pgadmin-hackers] SSL detection bug is back under debian...
Le Jeudi 16 Octobre 2003 12:33, Raphal Enrici a crit : I can also provide one for you (I built it this morning). This was fast! I don't need SSL, it was just a bug report. Will update pgAdmin3 snapshot using apt-get later. Cheers, Jean-Michel ---(end of broadcast)--- TIP 4: Don't 'kill -9' the postmaster
Re: [pgadmin-hackers] SSL detection bug is back under debian...
Raphaël Enrici wrote: Dear Adam, Jean-Michel reported to me this morning that the SSL menu was empty under debian builds. I had a quick look to the build process and it seems that we still have -I -DSSL while in the make all-recursive. The attached patch should solve this pesky SSL bug once and for all. Let me know if you have any problems with it. ahp --- pgadmin3/acinclude.m4 2003-10-09 16:40:21.0 -0400 +++ pgadmin3.new/acinclude.m4 2003-10-16 08:23:32.0 -0400 @@ -93,8 +93,6 @@ fi ]) -CPPFLAGS=$CPPFLAGS -DSSL - # # Check for libpq libraries and headers # @@ -118,6 +116,7 @@ AC_LANG_SAVE AC_LANG_C AC_CHECK_LIB(pq, PQexec, [pgsql_cv_libpq=yes], [pgsql_cv_libpq=no]) +AC_CHECK_LIB(pq, SSL_connect, [pgsql_ssl_libpq=yes], [pgsql_ssl_libpq=np]) AC_CHECK_HEADER(libpq-fe.h, [pgsql_cv_libpqfe_h=yes], [pgsql_cv_libpqfe_h=no]) AC_LANG_RESTORE if test $pgsql_cv_libpq = yes -a $pgsql_cv_libpqfe_h = yes @@ -131,6 +130,11 @@ CPPFLAGS=$PGSQL_OLD_CPPFLAGS AC_MSG_ERROR([you must specify a valid pgsql installation with --with-pgsql=DIR]) fi + +if test $pgsql_ssl_libpq = yes +then +CPPFLAGS=$CPPFLAGS -DSSL +fi fi ]) ---(end of broadcast)--- TIP 1: subscribe and unsubscribe commands go to [EMAIL PROTECTED]
Re: [pgadmin-hackers] SSL detection bug is back under debian...
Adam H. Pendleton wrote: Raphaël Enrici wrote: Dear Adam, Jean-Michel reported to me this morning that the SSL menu was empty under debian builds. I had a quick look to the build process and it seems that we still have -I -DSSL while in the make all-recursive. The attached patch should solve this pesky SSL bug once and for all. Let me know if you have any problems with it. Adam, thank you for this fast released patch. I haven't tried it for now but AFAICS it does not seem to handle the fact that WX_HOME is undef after configure on my system. I think that the real problem comes from this. In fact, SSL was correctly detected but was ignored due to the fact that WX_HOME was empty which gave the '-I -DSSL'. Do you have any idea concerning this ? I'll try your patch tonight or tomorrow. regards, Raphaël ahp --- pgadmin3/acinclude.m4 2003-10-09 16:40:21.0 -0400 +++ pgadmin3.new/acinclude.m4 2003-10-16 08:23:32.0 -0400 @@ -93,8 +93,6 @@ fi ]) -CPPFLAGS=$CPPFLAGS -DSSL - # # Check for libpq libraries and headers # @@ -118,6 +116,7 @@ AC_LANG_SAVE AC_LANG_C AC_CHECK_LIB(pq, PQexec, [pgsql_cv_libpq=yes], [pgsql_cv_libpq=no]) +AC_CHECK_LIB(pq, SSL_connect, [pgsql_ssl_libpq=yes], [pgsql_ssl_libpq=np]) AC_CHECK_HEADER(libpq-fe.h, [pgsql_cv_libpqfe_h=yes], [pgsql_cv_libpqfe_h=no]) AC_LANG_RESTORE if test $pgsql_cv_libpq = yes -a $pgsql_cv_libpqfe_h = yes @@ -131,6 +130,11 @@ CPPFLAGS=$PGSQL_OLD_CPPFLAGS AC_MSG_ERROR([you must specify a valid pgsql installation with --with-pgsql=DIR]) fi + +if test $pgsql_ssl_libpq = yes +then +CPPFLAGS=$CPPFLAGS -DSSL +fi fi ]) ---(end of broadcast)--- TIP 1: subscribe and unsubscribe commands go to [EMAIL PROTECTED] ---(end of broadcast)--- TIP 8: explain analyze is your friend
Re: [pgadmin-hackers] SSL detection bug is back under debian...
Raphaël Enrici wrote: Adam, thank you for this fast released patch. I haven't tried it for now but AFAICS it does not seem to handle the fact that WX_HOME is undef after configure on my system. I think that the real problem comes from this. In fact, SSL was correctly detected but was ignored due to the fact that WX_HOME was empty which gave the '-I -DSSL'. Do you have any idea concerning this ? I'll try your patch tonight or tomorrow. I've been looking at this -I$(WX_HOME) code for some time now, and I can't figure out why it's there, or what it is supposed to do (I mean I know ostensibly what it's supposed to do, but that's obviously not what it's doing), so I've removed it. The following patch gets rid of the offender. If anyone experiences any problems, please let me know. ahp --- pgadmin3/src/Makefile.am2003-10-06 05:49:40.0 -0400 +++ pgadmin3.new/src/Makefile.am2003-10-16 09:54:11.0 -0400 @@ -162,5 +162,5 @@ ui/tr_TR/wxstd.mo \ ui/zh_CN/wxstd.mo -AM_CXXFLAGS = -DDATA_DIR=\$(pkgdatadir)/\ -Wall -g -I$(top_srcdir)/src/include -I$(top_srcdir)/src/agent/include -I$(WX_HOME) -AM_CPPFLAGS = -DDATA_DIR=\$(pkgdatadir)/\ -Wall -g -I$(top_srcdir)/src/include -I$(top_srcdir)/src/agent/include -I$(WX_HOME) +AM_CXXFLAGS = -DDATA_DIR=\$(pkgdatadir)/\ -Wall -g -I$(top_srcdir)/src/include -I$(top_srcdir)/src/agent/include +AM_CPPFLAGS = -DDATA_DIR=\$(pkgdatadir)/\ -Wall -g -I$(top_srcdir)/src/include -I$(top_srcdir)/src/agent/include ---(end of broadcast)--- TIP 4: Don't 'kill -9' the postmaster
Re: [pgadmin-hackers] SSL detection bug is back under debian...
Hi Adam. It is very Good.! It works very effectively in accordance with patch. I was tried with FreeBSD. regards, Hiroshi Saito - Original Message - From: Adam H. Pendleton [EMAIL PROTECTED] Raphaël Enrici wrote: Adam, thank you for this fast released patch. I haven't tried it for now but AFAICS it does not seem to handle the fact that WX_HOME is undef after configure on my system. I think that the real problem comes from this. In fact, SSL was correctly detected but was ignored due to the fact that WX_HOME was empty which gave the '-I -DSSL'. Do you have any idea concerning this ? I'll try your patch tonight or tomorrow. I've been looking at this -I$(WX_HOME) code for some time now, and I can't figure out why it's there, or what it is supposed to do (I mean I know ostensibly what it's supposed to do, but that's obviously not what it's doing), so I've removed it. The following patch gets rid of the offender. If anyone experiences any problems, please let me know. ahp ---(end of broadcast)--- TIP 9: the planner will ignore your desire to choose an index scan if your joining column's datatypes do not match
Re: [pgadmin-hackers] SSL detection bug is back under debian...
Thanks, patch applied. -Original Message- From: Adam H. Pendleton [mailto:[EMAIL PROTECTED] Sent: 16 October 2003 13:26 To: Raphaël Enrici Cc: [EMAIL PROTECTED]; pgadmin-hackers Subject: Re: [pgadmin-hackers] SSL detection bug is back under debian... Raphaël Enrici wrote: Dear Adam, Jean-Michel reported to me this morning that the SSL menu was empty under debian builds. I had a quick look to the build process and it seems that we still have -I -DSSL while in the make all-recursive. The attached patch should solve this pesky SSL bug once and for all. Let me know if you have any problems with it. ahp ---(end of broadcast)--- TIP 9: the planner will ignore your desire to choose an index scan if your joining column's datatypes do not match
