Re: [pgadmin-hackers] SystemObject show patch more.

2003-07-16 Thread Dave Page
It's rumoured that Hiroshi Saito once said: > From: "Andreas Pflug" <[EMAIL PROTECTED]> > >> Hiroshi Saito wrote: >> >> >Hi Andreas. >> > >> >The SystemObject expression of pgTable >> >It is OK? >> This is not necessary, as pgTable is a pgSchemaObject, and >> GetSystemObject is already handled ther

Re: Fw: [pgadmin-hackers] SystemObject show patch more.

2003-07-16 Thread Hiroshi Saito
From: "Andreas Pflug" <[EMAIL PROTECTED]> > Hiroshi Saito wrote: > > >>Hi Andreas. > >> > >>One more. > >>pgLanguage patch. > >> > >>Check it. > >> > >>I take a break until the night... > > At the moment, system languages aren't displayed because they don't have > a call handler. This could be

Re: [pgadmin-hackers] SystemObject show patch more.

2003-07-16 Thread Hiroshi Saito
From: "Andreas Pflug" <[EMAIL PROTECTED]> > Hiroshi Saito wrote: > > >Hi Andreas. > > > >The SystemObject expression of pgTable > >It is OK? > This is not necessary, as pgTable is a pgSchemaObject, and > GetSystemObject is already handled there. I am sorry. It may have distracted. Sigh... Reg

Re: [pgadmin-hackers] SystemObject show patch more.

2003-07-16 Thread Andreas Pflug
Dave Page wrote: -Original Message- From: Hiroshi Saito [mailto:[EMAIL PROTECTED] Sent: 16 July 2003 06:58 To: Hiroshi Saito Cc: [EMAIL PROTECTED]; Dave Page Subject: Re: [pgadmin-hackers] SystemObject show patch more. Hi Andreas. One more. pgLanguage patch. Check it. Hi

Re: [pgadmin-hackers] SystemObject show patch more.

2003-07-16 Thread Dave Page
> -Original Message- > From: Hiroshi Saito [mailto:[EMAIL PROTECTED] > Sent: 16 July 2003 06:58 > To: Hiroshi Saito > Cc: [EMAIL PROTECTED]; Dave Page > Subject: Re: [pgadmin-hackers] SystemObject show patch more. > > > Hi Andreas. > > One more.

Re: [pgadmin-hackers] SystemObject show patch more.

2003-07-16 Thread Andreas Pflug
Hiroshi Saito wrote: Hi Andreas. The SystemObject expression of pgTable It is OK? This is not necessary, as pgTable is a pgSchemaObject, and GetSystemObject is already handled there. Regards, Andreas ---(end of broadcast)--- TIP 9: the planner

Re: Fw: [pgadmin-hackers] SystemObject show patch more.

2003-07-16 Thread Andreas Pflug
Hiroshi Saito wrote: Hi Andreas. One more. pgLanguage patch. Check it. I take a break until the night... At the moment, system languages aren't displayed because they don't have a call handler. This could be fixed, making a GetSystemObject method necessary. Your code breaks user languag

Re: [pgadmin-hackers] SystemObject show patch more.

2003-07-16 Thread Hiroshi Saito
Hi Andreas. One more. pgLanguage patch. Check it. I take a break until the night... Regards, Hiroshi-Saito pgadmin3_patch7 Description: Binary data ---(end of broadcast)--- TIP 1: subscribe and unsubscribe commands go to [EMAIL PROTECTED]

[pgadmin-hackers] SystemObject show patch more.

2003-07-15 Thread Hiroshi Saito
Hi Andreas. The SystemObject expression of pgTable It is OK? Regards, Hiroshi-Saito pgadmin3_patch6 Description: Binary data ---(end of broadcast)--- TIP 8: explain analyze is your friend

Re: [pgadmin-hackers] SystemObject show patch

2003-07-15 Thread Hiroshi Saito
Hi Andreas. From: "Andreas Pflug" <[EMAIL PROTECTED]> > Dave Page wrote: (snip) > I'm just in the middle of applying them. While in general Hiroshi is > right, there are som bad implementations in it. Casting a pgCast to a > pgServer is a very bad idea... It was seen. - bool GetSy

Re: [pgadmin-hackers] SystemObject show patch

2003-07-15 Thread Dave Page
> -Original Message- > From: Andreas Pflug [mailto:[EMAIL PROTECTED] > Sent: 15 July 2003 09:04 > To: Dave Page > Cc: Hiroshi Saito; [EMAIL PROTECTED] > Subject: Re: [pgadmin-hackers] SystemObject show patch > > > Dave Page wrote: > > >Thanks, pa

Re: [pgadmin-hackers] SystemObject show patch

2003-07-15 Thread Andreas Pflug
Dave Page wrote: Thanks, patch applied. I'm just in the middle of applying them. While in general Hiroshi is right, there are som bad implementations in it. Casting a pgCast to a pgServer is a very bad idea... Regards, Andreas ---(end of broadcast)

Re: [pgadmin-hackers] SystemObject show patch

2003-07-15 Thread Dave Page
Thanks, patch applied. > -Original Message- > From: Hiroshi Saito [mailto:[EMAIL PROTECTED] > Sent: 15 July 2003 06:37 > To: Andreas Pflug; Dave Page > Cc: [EMAIL PROTECTED] > Subject: SystemObject show patch > > > Hi Dave. > > The range of the system object doesn't seem to be > appro

[pgadmin-hackers] SystemObject show patch

2003-07-14 Thread Hiroshi Saito
Hi Dave. The range of the system object doesn't seem to be appropriate. Or, are there other reasons of anything? Apply ptach if there are not some problems. But, may not be completely clear in this. Regards, Hiroshi-Saito pgadmin3_patch5 Description: Binary data ---(e