Re: [pgadmin-hackers] fix for RM1210 [pgadmin4]

2016-06-03 Thread Ashesh Vashi
On Fri, Jun 3, 2016 at 1:13 PM, Harshal Dhumal < harshal.dhu...@enterprisedb.com> wrote: > Hi Ashesh, > > I have used 'ajax_response' utility function (alias to make_response > pdadmin utility function) which has mime-type set to "text/json" which is > correct I guess in this case. > > Also I

Re: [pgadmin-hackers] fix for RM1210 [pgadmin4]

2016-06-03 Thread Harshal Dhumal
Hi Ashesh, I have used 'ajax_response' utility function (alias to make_response pdadmin utility function) which has mime-type set to "text/json" which is correct I guess in this case. Also I have check all other node to check if all of them are using correct function while returning sql. --

Re: [pgadmin-hackers] fix for RM1210 [pgadmin4]

2016-06-03 Thread Ashesh Vashi
On Fri, Jun 3, 2016 at 12:59 PM, Harshal Dhumal < harshal.dhu...@enterprisedb.com> wrote: > Hi, > > Issue: For column node it was showing wrong sql in sql tab > > -- Column: public.test_qmg.a -- ALTER TABLE > public.test_qmg DROP COLUMN a; ALTER TABLE public.test_qmg ADD COLUMN a > integer; > >

Re: [pgadmin-hackers] fix for RM1210 [pgadmin4]

2016-06-03 Thread Harshal Dhumal
Hi, Issue: For column node it was showing wrong sql in sql tab -- Column: public.test_qmg.a -- ALTER TABLE public.test_qmg DROP COLUMN a; ALTER TABLE public.test_qmg ADD COLUMN a integer; Fix: I have changed response to ajax response while returning SQL for column node. -- *Harshal

Re: [pgadmin-hackers] fix for RM1210 [pgadmin4]

2016-06-03 Thread Ashesh Vashi
Hi Harshal, Can you please describe the issue, and root cause, and how did you fix it? -- Thanks & Regards, Ashesh Vashi EnterpriseDB INDIA: Enterprise PostgreSQL Company *http://www.linkedin.com/in/asheshvashi* On Fri,

[pgadmin-hackers] fix for RM1210 [pgadmin4]

2016-06-03 Thread Harshal Dhumal
Hi, PFA patch for RM1210 -- *Harshal Dhumal* *Software Engineer* EnterpriseDB India: http://www.enterprisedb.com The Enterprise PostgreSQL Company diff --git a/web/pgadmin/browser/server_groups/servers/databases/schemas/tables/column/__init__.py