Thanks, applied.
When you get some spare time (after the webpacking work that I believe
you're doing), could you please add a feature test (or modify a suitable
existing one) to ensure the various script options work as they should?
Thanks again!
On Thu, Jun 15, 2017 at 11:55 AM, Surinder Kumar
Hi Dave,
Please find attached patch. It should work.
In previous patch I was unaware that i added untracked file to tracked.
On Thu, Jun 15, 2017 at 4:10 PM, Dave Page wrote:
> Hi
>
> Was this patch generated against a WIP branch? I get:
>
> (pgadmin4)piranha:pgadmin4 dpage$
Hi
Was this patch generated against a WIP branch? I get:
(pgadmin4)piranha:pgadmin4 dpage$ git apply
~/Downloads/fix_scripts_in_query_tool.patch
error: web/pgadmin/static/js/setup_connection.js: No such file or directory
On Thu, Jun 15, 2017 at 6:36 AM, Surinder Kumar <
Hi
PFA patch which fixes the issue Harshal reported.
Thanks,
Surinder
On Thu, Jun 15, 2017 at 3:52 AM, Harshal Dhumal <
harshal.dhu...@enterprisedb.com> wrote:
> Surinder,
>
> I guess this broke the script options (Create, Delete, Select, Insert,
> Update)
>
>
> VM4124 datagrid.js:440 Uncaught
Surinder,
I guess this broke the script options (Create, Delete, Select, Insert,
Update)
VM4124 datagrid.js:440 Uncaught TypeError: self.get_panel_title is not a
function at Object.success (VM4124 datagrid.js:440) at fire (
jquery-1.11.2.js:3143) at Object.fireWith [as resolveWith] (
Use a more sensible name for Query Tool tabs. Fixes #2482
Branch
--
master
Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=57d866f7b70996a82a881b20248c3285ab3a6900
Author: Surinder Kumar
Modified Files
--