Re: [pgadmin-hackers] variable scope issue in server js [pgadmin4]

2016-05-12 Thread Akshay Joshi
On Thu, May 12, 2016 at 7:47 PM, Harshal Dhumal < harshal.dhu...@enterprisedb.com> wrote: > Hi Akshay, > > Murtuza hasn't fixed it in all places. He missed in following tow functions > > connect_server and disconnect_server > > > Thanks - Committed > > > -- > *Harshal Dhumal* > *Software

Re: [pgadmin-hackers] variable scope issue in server js [pgadmin4]

2016-05-12 Thread Harshal Dhumal
Hi Akshay, Murtuza hasn't fixed it in all places. He missed in following tow functions connect_server and disconnect_server -- *Harshal Dhumal* *Software Engineer * EenterpriseDB On Thu, May 12, 2016 at 7:38 PM, Akshay Joshi

Re: [pgadmin-hackers] variable scope issue in server js [pgadmin4]

2016-05-12 Thread Akshay Joshi
Hi On Thu, May 12, 2016 at 5:05 PM, Harshal Dhumal wrote: > Hi, > > > PFA patch for server.js. Replaced ";" (semicolon) with "," (coma) in > variable declaration. > > Issue: This was changing scope of all the variables declared after ";" > (semicolon) from

[pgadmin-hackers] variable scope issue in server js [pgadmin4]

2016-05-12 Thread Harshal Dhumal
Hi, PFA patch for server.js. Replaced ";" (semicolon) with "," (coma) in variable declaration. Issue: This was changing scope of all the variables declared after ";" (semicolon) from *local* to *global* and therefore affecting all other *local variables *with same name at different place in