Re: Unified server/desktop config

2017-08-09 Thread Surinder Kumar
Sure, I will update. On Wed, Aug 9, 2017 at 11:17 AM, Dave Page wrote: > Please update the patch :-) > > -- > Dave Page > Blog: http://pgsnake.blogspot.com > Twitter: @pgsnake > > EnterpriseDB UK:http://www.enterprisedb.com > The Enterprise PostgreSQL Company > > On 9 Aug

Re: Can someone tell me what this code does ?

2017-08-09 Thread Murtuza Zabuawala
Yes, you are correct, at a moment that's all it does. On Tue, Aug 8, 2017 at 6:37 PM, Dave Cramer wrote: > Hi, > > I guess my question was a bit vague. I get that it loads drivers. But note > it does not actually put them anywhere. > > First it creates a dict > sets the

Re: [pgAdmin4][patch] update the alert style in the sub-navigation

2017-08-09 Thread Sarah McAlear
Hi Surinder! I am not able to see anything different from what I see on Master with or without the patch applied. I tried adjusting the preferences. I did update the dashboard.js to instantiate a new object, great idea! Thanks, Sarah On Wed, Aug 9, 2017 at 1:42 PM, Surinder Kumar <

Re: [gpAdmin4][patch] query history updates

2017-08-09 Thread Khushboo Vashi
Hi, The patch looks good to me. The feature test for the QueryToolJourneyTest still fails on my Ubuntu machine with/without this patch , but works on Mac. Thanks, Khushboo On Wed,

Re: [pgadmin4] unable to pull remote

2017-08-09 Thread Magnus Hagander
Hi! Did that actually fix it? I've noticed a couple of other jobs complaining about the git server, but so far I was under the impression that it was a specific upstream network that had issues. BUt if switching to http fixed it, then that's not it, and I have something else to investigate.

Re: [pgAdmin4][Patch]: Fixed RM #2603 - Import/Export File issues

2017-08-09 Thread Harshal Dhumal
On Fri, Aug 4, 2017 at 6:32 PM, Ashesh Vashi wrote: > Harshal, > > On Fri, Jul 28, 2017 at 4:00 PM, Dave Page wrote: > >> Ashesh, can you deal with this please? Thanks. >> >> On Thu, Jul 27, 2017 at 5:08 AM, Khushboo Vashi < >>

[pgadmin4] unable to pull remote

2017-08-09 Thread Sarah McAlear
Hi Hackers! We noticed that as of some time today (it worked this morning) we are unable to pull git.postgresql.org/git/pgadmin4.git. Is this a known issue? Our other repos seem to work fine still. Thanks, Sarah

Re: [pgadmin4] unable to pull remote

2017-08-09 Thread Harshal Dhumal
hi Change below url in your git config from *git://git.postgresql.org/git/pgadmin4.git * to *http://git.postgresql.org/git/pgadmin4.git * -- *Harshal Dhumal* *Sr. Software Engineer* EnterpriseDB India:

Re: [pgadmin4] unable to pull remote

2017-08-09 Thread Sarah McAlear
Great, thank you! On Wed, Aug 9, 2017 at 5:26 PM, Harshal Dhumal < harshal.dhu...@enterprisedb.com> wrote: > hi > > Change below url in your git config > from *git://git.postgresql.org/git/pgadmin4.git > * to >

Re: [pgadmin4] unable to pull remote

2017-08-09 Thread Magnus Hagander
Hi! Thanks for confirming! I have now also found and fixed the git:// URL issue so anybody else still using those should be back to working. But there is no reason for you to switch back. //Magnus On Wed, Aug 9, 2017 at 12:37 PM, Sarah McAlear wrote: > Hi! > > Yes, this

Re: [pgAdmin4][patch] update the alert style in the sub-navigation

2017-08-09 Thread Sarah McAlear
As discussed with Surinder, we have created a Redmine ticket for his 4th comment regarding the error message not showing up when the app can't be reached. This issue existed prior to this patch and should be prioritized. https://redmine.postgresql.org/issues/2640 Thanks! Matt & Sarah On Wed,

Re: [pgAdmin4][Patch]: Use the correct resultset type for Type module

2017-08-09 Thread Harshal Dhumal
On Wed, Aug 9, 2017 at 8:57 AM, Ashesh Vashi wrote: > On Thu, Aug 3, 2017 at 2:41 PM, Murtuza Zabuawala enterprisedb.com> wrote: > >> Hi, >> >> PFA minor patch to use fetch dict based data instead of 2d-array based in >> Type module as we are

Re: [pgAdmin4][patch] update the alert style in the sub-navigation

2017-08-09 Thread Surinder Kumar
​Hi, ​The updated patch looks good to me. On Wed, Aug 9, 2017 at 4:15 PM, Sarah McAlear wrote: > As discussed with Surinder, we have created a Redmine ticket for his 4th > comment regarding the error message not showing up when the app can't be > reached. This issue

Re: [pgAdmin4][Patch]: Allow user to cancel long running queries from dashboard

2017-08-09 Thread Murtuza Zabuawala
Hi, Please find the updated patch with new UI style in dashboard subnode control based on Chethana's design suggestion. @Shirley, Yes, DBA needs to click on the drop down to expand. - If we make whole row clickable then how are we going to identify if user is trying to expand the row or trying

Re: [gpAdmin4][patch] query history updates

2017-08-09 Thread Ashesh Vashi
On Wed, Aug 9, 2017 at 3:37 PM, Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > Hi, > > The patch looks good to me. > The feature test for the QueryToolJourneyTest still fails on my Ubuntu > machine with/without this patch >

Build failed in Jenkins: pgadmin4-master-python27 #279

2017-08-09 Thread pgAdmin 4 Jenkins
See Changes: [Ashesh Vashi] Some cosmetic changes. [Ashesh Vashi] Enable source maps for debugging purpose in all webpack modules (except [Ashesh Vashi] UX improvements of the history in the query

Re: [pgadmin4] unable to pull remote

2017-08-09 Thread Sarah McAlear
Hi! Yes, this did fix it for us, but we did use https instead. Thanks! Matt & Sarah On Wed, Aug 9, 2017 at 6:19 PM, Magnus Hagander wrote: > Hi! > > Did that actually fix it? > > I've noticed a couple of other jobs complaining about the git server, but > so far I was

pgAdmin 4 commit: On certain linux operating systems, Qt application ex

2017-08-09 Thread Ashesh Vashi
On certain linux operating systems, Qt application exits with an error message such as 'X Error: BadDrawable'. In order to resolve the issue, we need to let the Qt know not to load the MIT-SHM extension. Reference: https://iwf1.com/quick-fix-one-kdes-common-xorg-errors-x-error-baddrawable/

pgAdmin 4 commit: Some cosmetic changes.

2017-08-09 Thread Ashesh Vashi
Some cosmetic changes. - Loading 'pgadmin' as 'sources/pgadmin', as found under the 'sources' reference directory to be consistent with other files. - Removed the 'pgadmin' reference from the base.html template. - Renamed 'pgadmin.slickgrid.editors.js', and 'pgadmin.slickgrid.formatters.js'

pgAdmin 4 commit: UX improvements of the history in the query tool.

2017-08-09 Thread Ashesh Vashi
UX improvements of the history in the query tool. - Added copy button for query text. - Historical queries are binned/grouped by day. Patch By: Hao Wang, Sarah McAlear Branch -- master Details ---

pgAdmin 4 commit: Fixed some UX issue with the Import/Export tool.

2017-08-09 Thread Ashesh Vashi
Fixed some UX issue with the Import/Export tool. - Couldn't click on the filename control once gets an error. - Encoding is not in alphabetical order. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=c4ca781ce2863375e2ee9105304187d7e951b419

pgAdmin 4 commit: Enable source maps for debugging purpose in all webpa

2017-08-09 Thread Ashesh Vashi
Enable source maps for debugging purpose in all webpack modules (except for vendor, and codemirror). Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=33bd9d47825562974173c469e1d9aa30e7ce5a3b Author: Surinder Kumar

Re: [pgAdmin4][Patch]: Fixed RM #2603 - Import/Export File issues

2017-08-09 Thread Ashesh Vashi
On Wed, Aug 9, 2017 at 3:32 PM, Harshal Dhumal < harshal.dhu...@enterprisedb.com> wrote: > > On Fri, Aug 4, 2017 at 6:32 PM, Ashesh Vashi < > ashesh.va...@enterprisedb.com> wrote: > >> Harshal, >> >> On Fri, Jul 28, 2017 at 4:00 PM, Dave Page wrote: >> >>> Ashesh, can you deal

Re: [pgAdmin4[Patch][Webpacking]: Enable source maps in pgAdmin4 for development environment

2017-08-09 Thread Ashesh Vashi
On Wed, Aug 9, 2017 at 8:55 AM, Wenlin Zhang wrote: > Hi Surinder, > > This is great and useful. Looks good to me. Hope this can be committed > ASAP. > Thanks! Committed! -- Thanks & Regards, Ashesh Vashi EnterpriseDB INDIA: Enterprise PostgreSQL Company

Re: Unified server/desktop config

2017-08-09 Thread Surinder Kumar
Hi This patch includes the fix where this patch breaks when feature tests are run. Set builtins.SERVER_MODE if it is present in globals()['SERVER_MODE'] else set to None. Please find updated patch. Thanks, Surinder ​ On Wed, Aug 9, 2017 at 11:57 AM, Surinder Kumar <

Re: [pgAdmin4][patch] Fix feature tests failure

2017-08-09 Thread Wenlin Zhang
As Sarah discussed with Khushboo on slack (pgadminhackers.slack.com for those who would like to join) yesterday, these errors seem to occur only on her Ubuntu system. We have not replicated them on Mac. But they exist before this patch, also. We notice that copy/paste functionality is being

[pgAdmin4][Patch]: Add command under scripts to run webpack bundle in watch mode

2017-08-09 Thread Surinder Kumar
Hi Currently, whenever we are making a change in JS file, we have to re-run bundle script again to generate all bundles again, which takes time and it is pain for developers to watch it till finished. So Webpack `watch` option lets the Webapck watch for changes in the file and compiles only

Re: [PATCH] Work with newer Flask-Security.

2017-08-09 Thread Harshal Dhumal
Hi, I tested this change with Flask-Security 3.0.0 and 1.7.5 (we ship pgAdmin4 with 1.7.5) and with 2.7 and 3.0+. This is working as expected. Apart from this I also found some other issues with User management. I have created RM2641 for these issue

Re: Can someone tell me what this code does ?

2017-08-09 Thread Dave Cramer
So what is the policy of the project? Ideally the cruft should be removed. Would a patch doing so be committed? Dave Cramer On 9 August 2017 at 00:28, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Yes, you are correct, at a moment that's all it does. > > On Tue, Aug 8, 2017