pgAdmin 4 commit: Requests for statistics were not stopped even when Da

2017-07-31 Thread Ashesh Vashi
Requests for statistics were not stopped even when Dashboard panel is closed. It is a regression of webpack. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=bdefdf5d4ebf9495e2d877deff8d323e55816080 Modified Files --

Re: [pgAdmin4][Patch]: RM_2596 - Query tool not working in Desktop Runtime on Mac OS X

2017-07-31 Thread Ashesh Vashi
On Fri, Jul 28, 2017 at 12:42 PM, Surinder Kumar < surinder.ku...@enterprisedb.com> wrote: > Hi, > > I inspect the react code and in call stacks, found `process.env.NODE_ENV` > is undefined due to which 'SyntheticEvent.call' is not callable. > > So, to fix this, i add 'definePlugin' to plugins

Re: [pgAdmin4][Patch]: Dashboard requests don't stop even after closing the panel

2017-07-31 Thread Ashesh Vashi
> Dashboard. I have asked Murtuza to look into it. -- Thanks & Regards, Ashesh Vashi EnterpriseDB INDIA: Enterprise PostgreSQL Company <http://www.enterprisedb.com/> *http://www.linkedin.com/in/asheshvashi* <http://www.linkedin.com/in/asheshvashi> > > On Thu,

Re: Discussion on improving alertify notifications logic

2017-07-31 Thread Ashesh Vashi
On Mon, Jul 31, 2017 at 2:54 PM, Akshay Joshi wrote: > Hi All > > On Fri, Jul 28, 2017 at 1:51 PM, Dave Page wrote: > >> >> >> On Thu, Jul 27, 2017 at 2:41 PM, Akshay Joshi < >> akshay.jo...@enterprisedb.com> wrote: >> >>> Hi All >>> >>> As in

pgAgent commit: Added support two digits version for PostgreSQL/EDB Pos

2017-07-31 Thread Ashesh Vashi
Added support two digits version for PostgreSQL/EDB Postgres Advanced Server >= 10 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgagent.git;a=commitdiff;h=a7b82fb3d3bd3de3ce624d9e4b0da53cb9835c2d Modified Files -- CMakeLists.txt | 6 +-

Re: Code Folding in Code Mirror

2017-08-15 Thread Ashesh Vashi
On Tue, Aug 15, 2017 at 2:33 PM, Sarah McAlear wrote: > Ok, it does work for the cases defined. We misunderstood how it works. > Still, could we enable this everywhere? > Yes. > What is the reason not to? > I don't see any reason not to do it. -- Thanks, Ashesh > >

Re: [pgAdmin4][patch] extract generate_url function from node.js and collection.js

2017-08-11 Thread Ashesh Vashi
On Thu, Aug 10, 2017 at 1:15 PM, Violet Cheng <vch...@pivotal.io> wrote: > Hi hackers, > > We tried to extract and refactor generate_url function in node.js and > collection.js. Please see the patch attached. > Khushboo, Please review this one. -- Thanks & Regards,

pgAdmin 4 commit: [PostgreSQL 10] Fixed the Pause/Resume Replay of WAL

2017-07-14 Thread Ashesh Vashi
[PostgreSQL 10] Fixed the Pause/Resume Replay of WAL files for PostgreSQL 10. Fixes #2566 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=4eefc52748705e8ea0f0d2b2599dfc33b5a56b48 Modified Files --

Re: [pgAdmin4][Patch]: Fix RM #2566 Pause/Resume Replay of WAL files are not working with PostgreSQL 10

2017-07-14 Thread Ashesh Vashi
Thanks - committed! -- Thanks & Regards, Ashesh Vashi EnterpriseDB INDIA: Enterprise PostgreSQL Company <http://www.enterprisedb.com> *http://www.linkedin.com/in/asheshvashi* <http://www.linkedin.com/in/asheshvashi> On Fri, Jul 14, 2017 at 6:18 PM, Akshay Joshi <akshay.jo.

Re: Windows testing required: Updated runtime

2017-07-11 Thread Ashesh Vashi
On Tue, Jul 11, 2017 at 9:44 PM, Dave Page wrote: > > > On Tue, Jul 11, 2017 at 4:56 PM, Mike Surcouf wrote: > >> >No - PostgreSQL builds on Windows dropped GSSAPI in favour of SSPI some >> years ago. That functionality is provided by the underlying

Re: pgAdmin 4 commit: Revert "Ensure dependencies are packaged in the tarba

2017-07-11 Thread Ashesh Vashi
On Tue, Jul 11, 2017 at 1:54 PM, Dave Page wrote: > Revert "Ensure dependencies are packaged in the tarball" > > This reverts commit 6ad4a623c47154a2e3938805af52776039c23601. > > ENOCOFFEE error > ;-) > > Branch > -- > master > > Details > --- >

Re: [pgAdmin4]: Webpacking of static JS/CSS

2017-07-11 Thread Ashesh Vashi
On Tue, Jul 11, 2017 at 10:29 PM, Surinder Kumar < surinder.ku...@enterprisedb.com> wrote: > Robert, > > I have attached two patches: > > 1. webpack_bundles.patch > > 2. unvendor_files.patch > > in this email chain. > > If you didn't received those patches possibly due to large size of patch, >

Re: pgagent build issue on SLES 12

2017-07-10 Thread Ashesh Vashi
You can find the logs/temporary files in the CMakeFiles directory. On Jul 10, 2017 17:48, "Dave Page" wrote: > > > On Mon, Jul 10, 2017 at 12:59 PM, Devrim Gündüz wrote: > >> >> Hi, >> >> I'm trying to RPMify pgagent on SLES 12, but getting an error. Here

pgAdmin 4 commit: Do not dump the session data on the disk on every req

2017-07-25 Thread Ashesh Vashi
Do not dump the session data on the disk on every request. Session object is updated, everytime a request is being served, and that was forcing the session object dumped on the dist on every request. On windows, it was causing issues on slower system on startup. Because - windows file system

Re: [pgAdmin4]: Webpacking of static JS/CSS

2017-07-27 Thread Ashesh Vashi
at 10:33 AM, Surinder Kumar < >> surinder.ku...@enterprisedb.com> wrote: >> >>> Ok. I will send rebased patch. >>> >>> On Thu, Jul 27, 2017 at 10:32 AM, Ashesh Vashi < >>> ashesh.va...@enterprisedb.com> wrote: >>> >

Re: [pgAdmin4]: Webpacking of static JS/CSS

2017-07-27 Thread Ashesh Vashi
c' directory for most of the modules now. I had to remove some redundant javascripts from the template directory manually. -- Thanks, Ashesh > > Please find updated patch. > > Thanks, > Surinder > > On Thu, Jul 27, 2017 at 1:13 PM, Ashesh Vashi < > ashesh.va...@enterpri

pgAdmin 4 commit: Moved the javascripts of different modules from 'temp

2017-07-27 Thread Ashesh Vashi
Moved the javascripts of different modules from 'templates' to 'static' directory. Moving the javascripts for the following modules: - About - Browser nodes - Dashboard - FileManager - Vendor/snap.svg - Preferences - Settings - Backup - Datagrid - Debugger - Sqleditor - Grant Wizard

Re: [pgAdmin4]: Webpacking of static JS/CSS

2017-07-26 Thread Ashesh Vashi
On Thu, Jul 27, 2017 at 10:22 AM, Ashesh Vashi < ashesh.va...@enterprisedb.com> wrote: > Hi Surinder, > > 'delete_template_files.patch' is applied any more. > Please send the rebased patches. > > I have also noticed in the 'move_js_files_to_static_directory.patch', >

Re: Tree view icon samples

2017-06-28 Thread Ashesh Vashi
e know your > opinion now. > Please do. One more point: :-) Icons for some nodes are missing here. i.e. Partition table (introduced in 'Declarative Partition' patch), Materialized View, etc. -- Thanks, Ashesh > > Regards, > Chethana kumar > > On Wed, Jun 28, 2017 at 11:13 PM,

Re: [pgAdmin4][Patch][RM_2567] : Default privileges don't show on Properties tab for database.

2017-08-08 Thread Ashesh Vashi
Murtuza, Please review this one. -- Thanks & Regards, Ashesh Vashi EnterpriseDB INDIA: Enterprise PostgreSQL Company <http://www.enterprisedb.com> *http://www.linkedin.com/in/asheshvashi* <http://www.linkedin.com/in/asheshvashi> On Tue, Aug 1, 2017 at 3:23 PM, Atul

Re: [pgAdmin4][Patch]: Allow user to cancel long running queries from dashboard

2017-08-07 Thread Ashesh Vashi
On Mon, Aug 7, 2017 at 9:06 PM, Dave Page wrote: > > > On Mon, Aug 7, 2017 at 3:49 PM, Chethana Kumar < > chethana.ku...@enterprisedb.com> wrote: > >> Hi Dave, >> >> Could you comment on the new design update for subnode control ? >> >> Attached designs - >> >> 1.

Re: [pgAdmin4][Patch]: Use the correct resultset type for Type module

2017-08-08 Thread Ashesh Vashi
Harshal, Please review this one. -- Thanks & Regards, Ashesh Vashi EnterpriseDB INDIA: Enterprise PostgreSQL Company <http://www.enterprisedb.com/> *http://www.linkedin.com/in/asheshvashi* <http://www.linkedin.com/in/asheshvashi> > > -- > Regards, > Murtuza Z

Re: [gpAdmin4][patch] query history updates

2017-08-09 Thread Ashesh Vashi
ge-id/flat/CAEawo3JKQFuVeSK-xw9wU4fUSY57KXU5GeXKcdCusQeHkjTykA%40mail.gmail.com>, > but works on Mac. > Committed the history patch. I've not yet looked at the feature test patch as of now. Thanks! -- Thanks & Regards, Ashesh Vashi EnterpriseDB INDIA: Enterprise PostgreSQL Compan

pgAdmin 4 commit: On certain linux operating systems, Qt application ex

2017-08-09 Thread Ashesh Vashi
On certain linux operating systems, Qt application exits with an error message such as 'X Error: BadDrawable'. In order to resolve the issue, we need to let the Qt know not to load the MIT-SHM extension. Reference: https://iwf1.com/quick-fix-one-kdes-common-xorg-errors-x-error-baddrawable/

pgAdmin 4 commit: Some cosmetic changes.

2017-08-09 Thread Ashesh Vashi
Some cosmetic changes. - Loading 'pgadmin' as 'sources/pgadmin', as found under the 'sources' reference directory to be consistent with other files. - Removed the 'pgadmin' reference from the base.html template. - Renamed 'pgadmin.slickgrid.editors.js', and 'pgadmin.slickgrid.formatters.js'

pgAdmin 4 commit: UX improvements of the history in the query tool.

2017-08-09 Thread Ashesh Vashi
UX improvements of the history in the query tool. - Added copy button for query text. - Historical queries are binned/grouped by day. Patch By: Hao Wang, Sarah McAlear Branch -- master Details ---

pgAdmin 4 commit: Fixed some UX issue with the Import/Export tool.

2017-08-09 Thread Ashesh Vashi
Fixed some UX issue with the Import/Export tool. - Couldn't click on the filename control once gets an error. - Encoding is not in alphabetical order. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=c4ca781ce2863375e2ee9105304187d7e951b419

pgAdmin 4 commit: Enable source maps for debugging purpose in all webpa

2017-08-09 Thread Ashesh Vashi
Enable source maps for debugging purpose in all webpack modules (except for vendor, and codemirror). Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=33bd9d47825562974173c469e1d9aa30e7ce5a3b Author: Surinder Kumar

Re: [pgAdmin4][Patch]: Fixed RM #2603 - Import/Export File issues

2017-08-09 Thread Ashesh Vashi
On Wed, Aug 9, 2017 at 3:32 PM, Harshal Dhumal < harshal.dhu...@enterprisedb.com> wrote: > > On Fri, Aug 4, 2017 at 6:32 PM, Ashesh Vashi < > ashesh.va...@enterprisedb.com> wrote: > >> Harshal, >> >> On Fri, Jul 28, 2017 at 4:00 PM, Dave Page <dp...@pg

Re: [pgAdmin4[Patch][Webpacking]: Enable source maps in pgAdmin4 for development environment

2017-08-09 Thread Ashesh Vashi
On Wed, Aug 9, 2017 at 8:55 AM, Wenlin Zhang <wzh...@pivotal.io> wrote: > Hi Surinder, > > This is great and useful. Looks good to me. Hope this can be committed > ASAP. > Thanks! Committed! -- Thanks & Regards, Ashesh Vashi EnterpriseDB INDIA: Enterprise

Re: [PATCH] Work with newer Flask-Security.

2017-08-07 Thread Ashesh Vashi
Harshal, Please take a look at it. -- Thanks & Regards, Ashesh Vashi EnterpriseDB INDIA: Enterprise PostgreSQL Company <http://www.enterprisedb.com> *http://www.linkedin.com/in/asheshvashi* <http://www.linkedin.com/in/asheshvashi> On Mon, Aug 7, 2017 at 6:46 PM, Wouter van K

Re: [gpAdmin4][patch] query history updates

2017-08-04 Thread Ashesh Vashi
Khushboo, On Thu, Aug 3, 2017 at 9:03 AM, Hao Wang <haow...@pivotal.io> wrote: > Hi Hackers, > > Here is a patch for query tools history UX improvements: > >- Add copy button for query text >- Historical queries are binned by day > > Please review it.

Re: Add basic function search

2017-08-04 Thread Ashesh Vashi
em on the file system. Right? -- Thanks, Ashesh Vashi > > > Sorry for the writing I do with google translate > > -- > José Mercedes Venegas Acevedo > cel Mov RPC 964185205 > > Member of the PHP Documentation Group (Spanish) >

Re: [pgAdmin4][PATCH] Refactor and change of implementation of keyboard_shortcuts function dependencies

2017-08-04 Thread Ashesh Vashi
ctrl + / >for Windows) > > This is consistent with other IDEs and the way commenting is implemented. > Please review it, and let us know your comments. -- Thanks & Regards, Ashesh Vashi EnterpriseDB INDIA: Enterprise PostgreSQL Company <http://www.enterprisedb.com/>

Re: [pgAdmin4][Patch]: Fixed RM #2603 - Import/Export File issues

2017-08-04 Thread Ashesh Vashi
Harshal, On Fri, Jul 28, 2017 at 4:00 PM, Dave Page wrote: > Ashesh, can you deal with this please? Thanks. > > On Thu, Jul 27, 2017 at 5:08 AM, Khushboo Vashi < > khushboo.va...@enterprisedb.com> wrote: > >> Hi, >> >> Please find the attached patch to fix the RM #2603:

Re: [pgAdmin4][patch] update the alert style in the sub-navigation

2017-08-06 Thread Ashesh Vashi
Surinder, Please take a look at this patch. If I recalls correctly, this patch is related to styling of the 'tabs' shown on the main window. Wenlin - please correct me if my understanding is wrong. -- Thanks & Regards, Ashesh Vashi EnterpriseDB INDIA: Enterprise PostgreSQL Company &

Re: Unified server/desktop config

2017-08-07 Thread Ashesh Vashi
On Mon, Aug 7, 2017 at 3:59 PM, Dave Page <dp...@pgadmin.org> wrote: > Anyone? > Surinder - please give this one priority. -- Thanks & Regards, Ashesh Vashi EnterpriseDB INDIA: Enterprise PostgreSQL Company <http://www.enterprisedb.com/> *http://www.linkedin.com

Re: [pgAdmin4][Patch][RM_2567] : Default privileges don't show on Properties tab for database.

2017-08-17 Thread Ashesh Vashi
nity.postgresrocks.net/] > <https://community.postgresrocks.net/> > > On Tue, Aug 8, 2017 at 3:25 PM, Atul Sharma <atul.sha...@enterprisedb.com> > wrote: > >> makes sense. Thanks for the solution. >> >> Please find attached revised patch. >> &

Re: pgAdmin4: Random failure of FTS test cases due to improper random string creation

2017-08-17 Thread Ashesh Vashi
On Fri, Aug 11, 2017 at 1:24 PM, Navnath Gadakh < navnath.gad...@enterprisedb.com> wrote: > Hi Dave, > > Please find the attached patch for UUID creation issues with test > objects for FTS configurations, FTS dictionaries and FTS parsers. > Previously(refer email with subject "Build

Re: PATCH: pgagent connection string parsing

2017-08-20 Thread Ashesh Vashi
On Aug 21, 2017 10:52, "Thomas Krennwallner" <tk+pg...@postsubmeta.net> wrote: On Mon Aug 21, 2017 06:50:03AM +0530, Ashesh Vashi wrote: >On Aug 20, 2017 22:48, "Thomas Krennwallner" <[1] tk+pg...@postsubmeta.net> >wrote: > > %

Re: PATCH: pgagent connection string parsing

2017-08-20 Thread Ashesh Vashi
Please use LD_LIBRARY_PATH environment to inform pgAgent to use the libpq, it is compiled with. -- Thanks, Ashesh Vashi -- Thanks, Ashesh Sun Aug 20 18:24:34 2017 : DEBUG: Clearing all connections Sun Aug 20 18:24:34 2017 : DEBUG: Connection stats: total - 1, free - 0, deleted - 1 During my c

Re: [pgAdmin4][patch] extract generate_url function from node.js and collection.js

2017-08-17 Thread Ashesh Vashi
On Wed, Aug 16, 2017 at 4:20 PM, Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > Hi, > > The patch looks good to me. > >> Thanks, > Khushboo > > On Fri, Aug 11, 2017 at 12:08 PM, Ashesh Vashi < > ashesh.va...@enterprisedb.com> wrote: > >

pgAdmin 4 commit: Extract the generate_url(..) function from node.js, a

2017-08-17 Thread Ashesh Vashi
Extract the generate_url(..) function from node.js, and collection.js Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=d527769bf8251595bf3adfcbd9c2a58e0ab1cc92 Author: Violet Cheng Modified Files --

pgAdmin 4 commit: Fixes #2567 - Use the proper database connection to f

2017-08-17 Thread Ashesh Vashi
Fixes #2567 - Use the proper database connection to fetch the default prileges in the properties tab of the database. Reviewed by: Murtuza Zabuawala Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=e6223c9a490ead577e5c6f3058e6db51d0d2c5b7

pgAdmin 4 commit: Moved the javascripts of the following browser node m

2017-06-22 Thread Ashesh Vashi
Moved the javascripts of the following browser node modules to the 'static' directory from 'templates' in the respective module directory: - Server Group - Server - Database - Schema - Cast - Event trigger - Extension - Foreign data wrapper - Language - Catalog Object - Collation - Domain

Re: [pgadmin-hackers] Re: Server side cursor limitations for on demand loading of data in query tool [RM2137] [pgAdmin4]

2017-06-27 Thread Ashesh Vashi
On Tue, Jun 27, 2017 at 6:33 PM, Dave Page <dp...@pgadmin.org> wrote: > Thanks - patch committed! > > Awsome job :-) > Woohoo! -- Thanks & Regards, Ashesh Vashi > > On Tue, Jun 27, 2017 at 3:26 AM, Harshal Dhumal < > harshal.dhu...@enterprisedb.com> wrot

Re: [pgAdmin4][PATCH] Refactor and change of implementation of keyboard_shortcuts function dependencies

2017-08-21 Thread Ashesh Vashi
On Wed, Aug 16, 2017 at 8:55 AM, Violet Cheng <vch...@pivotal.io> wrote: > Hi, > > Is there any update on these patches? Will it be committed soon? > Dave - would please take care of this? -- Thanks & Regards, Ashesh Vashi EnterpriseDB INDIA: Enterprise Po

Re: [pgadmin4][Patch] Greenplum specific DDL and Dashboard display

2017-08-21 Thread Ashesh Vashi
ok at it. -- Thanks & Regards, Ashesh Vashi EnterpriseDB INDIA: Enterprise PostgreSQL Company <http://www.enterprisedb.com/> *http://www.linkedin.com/in/asheshvashi* <http://www.linkedin.com/in/asheshvashi> > > On Mon, Aug 21, 2017 at 8:50 AM, Jing Li <jin...@pivotal.io&

Re: PATCH: pgagent connection string parsing

2017-08-21 Thread Ashesh Vashi
On Mon, Aug 21, 2017 at 1:41 PM, Dave Page <dp...@pgadmin.org> wrote: > > > On Mon, Aug 21, 2017 at 6:24 AM, Ashesh Vashi < > ashesh.va...@enterprisedb.com> wrote: > >> >> >> On Aug 21, 2017 10:52, "Thomas Krennwallner" <tk+pg...@posts

Re: Next release

2017-08-25 Thread Ashesh Vashi
On Fri, Aug 25, 2017 at 12:16 PM, Surinder Kumar < surinder.ku...@enterprisedb.com> wrote: > Hi > On Fri, Aug 25, 2017 at 1:03 AM, Dave Page wrote: > >> >> >> On Thu, Aug 24, 2017 at 8:28 PM, Harshal Dhumal < >> harshal.dhu...@enterprisedb.com> wrote: >> >>> >>> >>> -- >>>

pgAdmin 4 commit: Using the proper python syntax to fetch the default b

2017-08-25 Thread Ashesh Vashi
Using the proper python syntax to fetch the default binary path for different servers types. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=b1ad89fb4a772c0b396cb8907a1a1ce5973bc82e Author: Harshal Dhumal

Re: fix keyerror problems

2017-08-25 Thread Ashesh Vashi
On Sat, Aug 26, 2017 at 12:24 AM, Dave Cramer <davecra...@gmail.com> wrote: > See attached patch > I have already committed a patch for the same. But - improved the syntax as per Harshal's suggestion. -- Thanks & Regards, Ashesh Vashi EnterpriseDB INDIA: Enterprise PostgreS

pgAdmin 4 commit: Fix the feature tests failuers.

2017-08-25 Thread Ashesh Vashi
Fix the feature tests failuers. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=5dd375dd2081c126b7b3b9f0dba21976d2a45a1f Author: Wenlin Zhang Modified Files --

pgAdmin 4 commit: Fixes #2560 - View is not fully qualified in Trigger

2017-08-25 Thread Ashesh Vashi
Fixes #2560 - View is not fully qualified in Trigger definition. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=d3babd78aa9f337344480f56359f9eab66d9b56a Author: Murtuza Zabuawala Modified Files

Re: [pgAdmin4][patch] Fix feature tests failure

2017-08-25 Thread Ashesh Vashi
_of_view' added later by Hao Wang in commit: 5141debae7e08d205e813dd9fc52b737a9f18184. -- Thanks & Regards, Ashesh Vashi EnterpriseDB INDIA: Enterprise PostgreSQL Company <http://www.enterprisedb.com/> *http://www.linkedin.com/in/asheshvashi* <http://www.linkedin.com/in/asheshvashi>

Re: [pgAdmin4][Patch]: Add command under scripts to run webpack bundle in watch mode

2017-08-25 Thread Ashesh Vashi
Thanks - committed! -- Thanks & Regards, Ashesh Vashi EnterpriseDB INDIA: Enterprise PostgreSQL Company <http://www.enterprisedb.com> *http://www.linkedin.com/in/asheshvashi* <http://www.linkedin.com/in/asheshvashi> On Wed, Aug 9, 2017 at 6:51 PM, Surinder Kum

pgAdmin 4 commit: Add package run scripts to allow to run the webpack i

2017-08-25 Thread Ashesh Vashi
Add package run scripts to allow to run the webpack in watch mode, also added '--progress' option to make it more interactive. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=f711336a6b96b6a893605cd28beb6486d186975d Author: Surinder Kumar

Re: [pgAdmin4][PATCH] Fix trigger's reversed engineered SQL for View

2017-08-25 Thread Ashesh Vashi
On Fri, Aug 18, 2017 at 1:18 PM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi, > > PFA minor patch to fix the issue where view is not fully qualified in > Trigger definition. > RM#2560 > Thanks - committed! -- Thanks, Ashesh > > -- > Regards, > Murtuza Zabuawala >

Re: [pgadmin4][Patch] Greenplum specific DDL and Dashboard display

2017-08-25 Thread Ashesh Vashi
gadmin4][Patch] Greenplum specific DDL and Dashboard >> display >> To: Teng Zhang <tezh...@pivotal.io> >> Cc: Ashesh Vashi <ashesh.va...@enterprisedb.com>, pgadmin-hackers < >> pgadmin-hack...@postgresql.org>, Dave Page <dp...@pgadmin.org>, Jin

Re: pgAdmin 4 commit: Greenplum specific DDL and Dashboard display changes.

2017-08-25 Thread Ashesh Vashi
_module_preference > self.register_preferences() > File > "/Users/dpage/git/pgadmin4/web/pgadmin/browser/server_groups/servers/__init__.py", > line 172, in register_preferences > ServerType.register_preferences() > File > "/Users/dpage/git/pgadmin4/

Re: pgAdmin 4 commit: Fix the feature tests failuers.

2017-08-25 Thread Ashesh Vashi
n execute > self.error_handler.check_response(response) > File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site- > packages/selenium/webdriver/remote/errorhandler.py", line 193, in > check_response > raise exception_class(message, screen, stacktra

Re: pgAdmin 4 commit: Greenplum specific DDL and Dashboard display changes.

2017-08-25 Thread Ashesh Vashi
On Fri, Aug 25, 2017 at 9:14 PM, Ashesh Vashi <ashesh.va...@enterprisedb.com > wrote: > On Fri, Aug 25, 2017 at 8:30 PM, Dave Page <dp...@pgadmin.org> wrote: > >> I believe this patch has broken my installation. When I try to run now, I >> get: >> >>

pgAdmin 4 commit: Define the utility path lable, and help message for t

2017-08-25 Thread Ashesh Vashi
Define the utility path lable, and help message for the Greenplum database server, shown in the preferences dialog. Also, fixed the issue, when server type is not defined in the DEFAULT_BINARY_PATHS, in the configuration. Branch -- master Details ---

Re: [pgAdmin4][Patch]: RM_2596 - Query tool not working in Desktop Runtime on Mac OS X

2017-08-31 Thread Ashesh Vashi
On Tue, Aug 29, 2017 at 5:55 PM, Surinder Kumar < surinder.ku...@enterprisedb.com> wrote: > Hi Ashesh, > > Can you please review this patch please? > Thanks - committed! -- Thanks & Regards, Ashesh Vashi EnterpriseDB INDIA: Enterprise PostgreSQL Company <http://www.e

pgAdmin 4 commit: Define the proper NODE_ENV environment during running

2017-08-31 Thread Ashesh Vashi
Define the proper NODE_ENV environment during running the webpack. Using the webpack.DefinePlugin during the development build too, not just in production build. Fixes #2596. Also - passing option 'warning: false' for UglifyJsPlugin, which will not show warning messages on the console during the

pgAdmin 4 commit: Miscellaneous fixes for icon sizing issue, missing tr

2017-09-11 Thread Ashesh Vashi
Miscellaneous fixes for icon sizing issue, missing tree nodes to be webpacked, etc. - Fixed the background-size for the svg icons to 20x20 px such that it does not adjust it's size when a context menu height is different due to length of the node label, also - it allows us to fix the issue of

Re: pgAdmin4 - Tree view icons for final reveiw

2017-09-11 Thread Ashesh Vashi
Hi Dave, Please find the attached patch for not showing icons for menu items. I have not completely removed it, but - commented the code (will remove it in final patch). Please review, and commit it (if it looks good to you). -- Thanks & Regards, Ashesh Vashi EnterpriseDB INDIA: Enterp

Re: pgAdmin4 - Tree view icons for final reveiw

2017-09-11 Thread Ashesh Vashi
On Mon, Sep 11, 2017 at 1:46 PM, Ashesh Vashi <ashesh.va...@enterprisedb.com > wrote: > Hi Dave, > > Please find the attached patch for not showing icons for menu items. > I have not completely removed it, but - commented the code (will remove it > in final patch). >

pgAdmin 4 commit: Using the svg icons for domain constraint, and server

2017-09-11 Thread Ashesh Vashi
Using the svg icons for domain constraint, and server browser nodes. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=f79b7f26b1faa9f6df63ee024b247f8b686c9438 Author: Chethana Kumar Modified Files

pgAdmin 4 commit: Rename the SecurityGroupUnderSchema to SecurityGroupS

2017-09-11 Thread Ashesh Vashi
Rename the SecurityGroupUnderSchema to SecurityGroupSchema, and redefined in the database (instead of schema) javascript module, as it is also used by the foreign-server node too. Reported by: Neel Patel Branch -- master Details ---

pgAdmin 4 commit: Replacing existing browser tree node png icons with t

2017-09-10 Thread Ashesh Vashi
Replacing existing browser tree node png icons with the svg icons. Made it compatible with the pgAdmin 4 color combination. TODO:: Icons for the following nodes are in PNG format. - Domain Constraint (Only the invalid icon) - pgAgent Job Steps - Green Plum database server - Server (Only

pgAdmin 4 commit: Changes in the stylesheets to support the svg icons f

2017-09-10 Thread Ashesh Vashi
Changes in the stylesheets to support the svg icons for the browser tree nodes. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=4018562bc7d52f2a03a18a27365dc0043d44a568 Modified Files --

Re: pgAdmin4 - Tree view icons for final reveiw

2017-09-11 Thread Ashesh Vashi
On Mon, Sep 11, 2017 at 1:25 PM, Dave Page wrote: > Hmm, scrub the revert - it looks like you just fixed a bunch of the issues. > K. > > The main thing I think that remains as an issue is the colouring on the > headers and menus - the former of which needs fixing somehow, the

pgAdmin 4 commit: Fixed the jasmine tests regression due to changes in

2017-09-18 Thread Ashesh Vashi
Fixed the jasmine tests regression due to changes in the webpacking implementation. Branch -- WEBPACK_DEVEL Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=0eb01384aaeeedc63edfbfc2e897684c914d58e0 Modified Files -- web/karma.conf.js

pgAdmin 4 commit: Add capability to print the javascript console errors

2017-09-18 Thread Ashesh Vashi
Add capability to print the javascript console errors, and warnings on stderr (standard error) for the feature tests. Branch -- WEBPACK_DEVEL Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=3c259043df8007866ba1aa5f1a6b053d2809c38d Modified Files

pgAdmin 4 commit: Updating the packing, and ci test scripts as per chan

2017-09-18 Thread Ashesh Vashi
Updating the packing, and ci test scripts as per changes in the webpack implementation. Branch -- WEBPACK_DEVEL Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=2ce6b5e87113d8418e74cacadff910bcd8758782 Modified Files -- Make-MinGW.bat | 2

pgAdmin 4 commit: Moved the webcabin-docker in the 'web/pgadmin/static/

2017-09-17 Thread Ashesh Vashi
Moved the webcabin-docker in the 'web/pgadmin/static/vendor' directory to resolve a possible issue, when we created webpack reference for vendor. webcabin-docker uses the jquery.1.11.1 as hard dependency, and latest jquery for 1.11.2 is available as npm, and which is used by us. Webpack

pgAdmin 4 commit: Extending the tools, and miscellaneous javascript mod

2017-09-17 Thread Ashesh Vashi
Extending the tools, and miscellaneous javascript modules from the browser tools. Branch -- WEBPACK_DEVEL Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=a050a169cb4182aeb71567c6efe3d45d1b7ae7ef Modified Files --

pgAdmin 4 commit: Enable webpackaging the pgadmin javascript files in d

2017-09-17 Thread Ashesh Vashi
Enable webpackaging the pgadmin javascript files in different small modules, which can be referred from other modules. We can have two types of webpack modules. 1. Reference (using the dll plugin of webpack) This type of webpack module can be referred from the other webpack modules. And, it

pgAdmin 4 commit: Moving the sqleditor specific javascript/jsx files in

2017-09-17 Thread Ashesh Vashi
Moving the sqleditor specific javascript/jsx files into the 'pgadmin/tools/sqleditor/static' directory. NOTE: This has broken the compilation with the current webpack implementation, which will be fixed in the upcoming commits. Branch -- WEBPACK_DEVEL Details ---

pgAdmin 4 commit: Handle the executor nodes, which are unknown to the E

2017-09-17 Thread Ashesh Vashi
Handle the executor nodes, which are unknown to the Explain module, gracefully by showing the 'ex_unknown.png' for such nodes. Reported by: Murtuza Refs #2706 Branches WEBPACK_DEVEL master Details ---

pgAdmin 4 commit: No longer using the 'get_own_javascripts' method for

2017-09-17 Thread Ashesh Vashi
No longer using the 'get_own_javascripts' method for refering the javascript modules exposed through a module, instead added them in the webpack (shim) configuration directly. Instead - exposed a new method - 'get_javascript_entries' to be used later by the new implementation of the webpack

pgAdmin 4 commit: Do not run javascript bundler, when BUILD_JSMODULES i

2017-09-17 Thread Ashesh Vashi
Do not run javascript bundler, when BUILD_JSMODULES is set to False in the config file. In that case - we should run the webpack in wait mode in a separate console/terminal/command-prompt. Branch -- WEBPACK_DEVEL Details ---

pgAdmin 4 commit: Expose the register_module_initializer, and register_

2017-09-17 Thread Ashesh Vashi
Expose the register_module_initializer, and register_module in the pgAdmin javascript module to allow to register any javascript modules as part of any javascript module entry, and initialize them. Branch -- WEBPACK_DEVEL Details ---

pgAdmin 4 commit: Resolve the correct path when building the webpack mo

2017-09-19 Thread Ashesh Vashi
Resolve the correct path when building the webpack module from a particular path. Branch -- WEBPACK_DEVEL Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=738575abad39e36ea384634837b75a2130e88b71 Modified Files -- web/webpack/utils.js | 2 +- 1 file

pgAdmin 4 commit: Handle the executor nodes, which are unknown to the E

2017-09-14 Thread Ashesh Vashi
Handle the executor nodes, which are unknown to the Explain module, gracefully by showing the 'ex_unknown.png' for such nodes. Reported by: Murtuza Refs #2706 Branch -- master Details ---

pgAdmin 4 commit: Fix filtering of system schemas so pg_* is hidden but

2017-09-18 Thread Ashesh Vashi
Fix filtering of system schemas so pg_* is hidden but pg* is not. Fixes #2709 Branch -- WEBPACK_DEVEL Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=ca1dd9d15fbd04dde153c1c5221386a13e0f8d9a Author: Murtuza Zabuawala

pgAdmin 4 commit: Support React v15.5 and later where the code fails to

2017-09-18 Thread Ashesh Vashi
Support React v15.5 and later where the code fails to run because React's PropTypes is no more part of React Module. Branch -- WEBPACK_DEVEL Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=4035fab6e7d1bcbd84115a963072b3de5be25485 Author: Surinder Kumar

pgAdmin 4 commit: Fix menu left-hand margin.

2017-09-18 Thread Ashesh Vashi
Fix menu left-hand margin. Branch -- WEBPACK_DEVEL Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=3485f5b607d11188c83d0b4d2841b93808da50a6 Author: Murtuza Zabuawala Modified Files --

pgAdmin 4 commit: Changed array representation and formatting for the d

2017-09-18 Thread Ashesh Vashi
Changed array representation and formatting for the data types in Query Tool and View Data. Fixes #2671 Branch -- WEBPACK_DEVEL Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=79e6e11668e7762f1f2759091eb109cbfa9f4932 Author: Harshal Dhumal

pgAdmin 4 commit: Replace the "Roboto" font family with "Open Sans" for

2017-09-18 Thread Ashesh Vashi
Replace the "Roboto" font family with "Open Sans" for alertify dialogs. Branch -- WEBPACK_DEVEL Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=0b5b684652293ba85138f0d9d02f9cab5d8e37f6 Author: Atul Sharma Modified Files

pgAdmin 4 commit: Ensure builtins.SERVER_MODE is set in the WSGI wrappe

2017-09-18 Thread Ashesh Vashi
Ensure builtins.SERVER_MODE is set in the WSGI wrapper. Branch -- WEBPACK_DEVEL Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=9c1a28121da2012b80dabea4457a9d7b75c2218c Author: Dave Page Modified Files -- web/pgAdmin4.wsgi | 8

pgAdmin 4 commit: Support Flask-Security 3.0

2017-09-18 Thread Ashesh Vashi
Support Flask-Security 3.0 Branch -- WEBPACK_DEVEL Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=4853f25c1433196c3c99925429754083c17941ed Author: Harshal Dhumal Modified Files -- web/pgadmin/__init__.py | 2 +- 1

pgAdmin 4 commit: Fix tablespace move prompt message. Fixes #2708

2017-09-18 Thread Ashesh Vashi
Fix tablespace move prompt message. Fixes #2708 Branch -- WEBPACK_DEVEL Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=28f97f957f0062245cb462d0c042217d34ddb734 Author: Murtuza Zabuawala Modified Files --

pgAdmin 4 commit: Fix error message regexp in the query tool that could

2017-09-18 Thread Ashesh Vashi
Fix error message regexp in the query tool that could fail in some cases. Fixes #2700 Branch -- WEBPACK_DEVEL Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=5cc068f2bf6d0cf5f5aec1a18f8eed6b44145ea7 Author: Murtuza Zabuawala

pgAdmin 4 commit: Fix for Exception when the server is restarted. Fixes

2017-09-18 Thread Ashesh Vashi
Fix for Exception when the server is restarted. Fixes #2713 This issue was caused because we recently added session_write_delay in session. So session won't be written/updated to disk from memory until specified seconds are elapsed. However we must forcefully write/update session to disk if

pgAdmin 4 commit: Remove unused import that was causing a hard error on

2017-09-18 Thread Ashesh Vashi
Remove unused import that was causing a hard error on Windows Branch -- WEBPACK_DEVEL Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=c4855abd4ff586c4136ed750f2249a45011fa585 Author: Dave Page Modified Files --

pgAdmin 4 commit: Fix disable trigger menu option. Fixes #2707

2017-09-18 Thread Ashesh Vashi
Fix disable trigger menu option. Fixes #2707 Branch -- WEBPACK_DEVEL Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=c6c9ae9853ce53c5cbb147f7c319378f3891977d Author: Murtuza Zabuawala Modified Files --

pgAdmin 4 commit: Correct alignment of the X button on dismissable aler

2017-09-18 Thread Ashesh Vashi
Correct alignment of the X button on dismissable alerts. Branch -- WEBPACK_DEVEL Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=64be708b8d281216194d1cf0869953d1ded0eb44 Author: Murtuza Zabuawala Modified Files

pgAdmin 4 commit: Fix View Data option and column config for Foreign Ta

2017-09-18 Thread Ashesh Vashi
Fix View Data option and column config for Foreign Tables. Fixes #2691 Branch -- WEBPACK_DEVEL Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=c9897d46debb22061a2044954852da9fa8e5eb2e Author: Akshay Joshi Modified Files

  1   2   >