Re: [pgAdmin4][Patch]: Dashboard requests don't stop even after closing the panel

2017-07-28 Thread Dave Page
Ashesh, can you deal with this please? Thanks. On Thu, Jul 27, 2017 at 6:20 AM, Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > Hi, > > If we close the Dashboard tab even then the requests don't stop. This is > the regression of web-packing of browser.js file. > Please find the

Re: [pgAdmin4][Patch]: RM_2596 - Query tool not working in Desktop Runtime on Mac OS X

2017-07-28 Thread Dave Page
Ashesh, can you deal with this please? Thanks. On Fri, Jul 28, 2017 at 8:12 AM, Surinder Kumar < surinder.ku...@enterprisedb.com> wrote: > Hi, > > I inspect the react code and in call stacks, found `process.env.NODE_ENV` > is undefined due to which 'SyntheticEvent.call' is not callable. > > So,

Re: [pgAdmin4][Patch]: Allow user to cancel long running queries from dashboard

2017-07-28 Thread Murtuza Zabuawala
Hi Dave, PFA patch to display additional information from pg_stat_activity table using subnode control. RM#2597 Please review. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Tue, Jul 25, 2017 at 10:56 AM, Shirley Wang

Re: [pgAdmin4][Patch]: Allow user to cancel long running queries from dashboard

2017-07-28 Thread Dave Page
On Fri, Jul 28, 2017 at 12:24 PM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi Dave, > > On Fri, Jul 28, 2017 at 4:11 PM, Dave Page wrote: > >> Hi >> >> I took a quick look at this and have a couple of thoughts: >> >> - Instead of the "edit" icon to open

Re: [pgAdmin4][Patch]: Allow user to cancel long running queries from dashboard

2017-07-28 Thread Dave Page
Hi I took a quick look at this and have a couple of thoughts: - Instead of the "edit" icon to open the subnode, we should use something more appropriate - a "properties" icon perhaps. - There seems to be a lot of different shades of grey on there (maybe a subnode design in general that just

Re: [pgAdmin4][Patch]: Fixed RM #2603 - Import/Export File issues

2017-07-28 Thread Dave Page
Ashesh, can you deal with this please? Thanks. On Thu, Jul 27, 2017 at 5:08 AM, Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > Hi, > > Please find the attached patch to fix the RM #2603: Import/Export File > issues. > > Fixed Issues: > 1. Couldn't click on the File Control once gets

[pgAdmin4][Patch]: RM_2596 - Query tool not working in Desktop Runtime on Mac OS X

2017-07-28 Thread Surinder Kumar
Hi, I inspect the react code and in call stacks, found `process.env.NODE_ENV` is undefined due to which 'SyntheticEvent.call' is not callable. So, to fix this, i add 'definePlugin' to plugins for `dev` environment in `webpack.config.js`. Initially it was added only for `production` environment.