Re: Build failed in Jenkins: pgadmin4-master-python33 #507

2018-03-07 Thread Khushboo Vashi
On Wed, Mar 7, 2018 at 11:13 PM, Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > Hi Dave, > > Please find the patch to fix this. > I have fixed this issue in the StartRunningQueryTest class, this test > class changes the behaviour of the methods through MagicMock and due to > this this

Re: pgAdmin 4 commit: Support EXPLAIN on Greenplum. Fixes #3097

2018-03-07 Thread Khushboo Vashi
Hi Joao, In the test_start_running_query.py, 2 static methods (is_begin_required_for_sql_query and is_rollback_statement_required) of StartRunningQuery class were used directly without @patch. Due to this, in all the cases, the original value of them doesn't restore. To fix this, I have sent the

Build failed in Jenkins: pgadmin4-master-python33 #510

2018-03-07 Thread pgAdmin 4 Jenkins
See Changes: [Dave Page] Make the poll query test a little more robust. -- [...truncated 610.86 KB...] SynonymAddTestCase (Default Node URL)

ACI Tree

2018-03-07 Thread Robert Eckhardt
Hackers, We have multiple end users who have in excess of 10 thousand of tables in a single schema. Currently this causes pgAdmin to choke. The major issue we are seeing is that the ACI tree is unsupported and it seems to be the backbone of pgAdmin 4. Is anyone else having this issue? Is there

Build failed in Jenkins: pgadmin4-master-python27 #512

2018-03-07 Thread pgAdmin 4 Jenkins
See Changes: [Dave Page] Allow admins to disable the use of Gravatar if they choose. Fixes #3037 [Dave Page] Make the poll query test a little more robust. --

Build failed in Jenkins: pgadmin4-master-python36 #504

2018-03-07 Thread pgAdmin 4 Jenkins
See Changes: [Dave Page] Make the poll query test a little more robust. -- [...truncated 610.70 KB...] 1 test failed: TestPollQueryTool

Re: Build failed in Jenkins: pgadmin4-master-python33 #507

2018-03-07 Thread Khushboo Vashi
Hi Dave, Please find the patch to fix this. I have fixed this issue in the StartRunningQueryTest class, this test class changes the behaviour of the methods through MagicMock and due to this this test case is failing. Thanks, Khushboo On Wed, Mar 7, 2018 at 10:34 PM, Khushboo Vashi <

Build failed in Jenkins: pgadmin4-master-python35 #511

2018-03-07 Thread pgAdmin 4 Jenkins
See Changes: [Dave Page] Ensure all messages are retrieved from the server in the Query Tool. -- [...truncated 605.33 KB...]

Re: [pgAdmin4][RM#3037] Allow user to disable Gravatar image

2018-03-07 Thread Dave Page
Hi On Mon, Mar 5, 2018 at 8:12 AM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi, > > PFA patch to disable Gravatar image in Server mode. > > Requirments & Issues: > - For security reasons. > - For systems which do not have internet access. > - Hangs pgAdmin4 while loading

Build failed in Jenkins: pgadmin4-master-python27 #510

2018-03-07 Thread pgAdmin 4 Jenkins
See Changes: [Dave Page] Ensure all messages are retrieved from the server in the Query Tool. -- [...truncated 605.98 KB...]

Build failed in Jenkins: pgadmin4-master-python26 #637

2018-03-07 Thread pgAdmin 4 Jenkins
See Changes: [Dave Page] Ensure all messages are retrieved from the server in the Query Tool. -- [...truncated 608.99 KB...]

Build failed in Jenkins: pgadmin4-master-python36 #501

2018-03-07 Thread pgAdmin 4 Jenkins
See Changes: [Dave Page] Ensure all messages are retrieved from the server in the Query Tool. -- [...truncated 605.34 KB...] 1 test failed:

pgAdmin 4 commit: Ensure all messages are retrieved from the server in

2018-03-07 Thread Dave Page
Ensure all messages are retrieved from the server in the Query Tool. Fixes #3094 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=d3c303e4559966de038263f7a2c5e0969947aae9 Author: Khushboo Vashi Modified Files

Re: pgAdmin 4 commit: Ensure we pick up the messages from the current query

2018-03-07 Thread Dave Page
Thanks - patch applied. On Tue, Mar 6, 2018 at 2:57 PM, Joao De Almeida Pereira < jdealmeidapere...@pivotal.io> wrote: > Hello Khushboo, > Thanks for the changes here. Now everything looks good, and the tests all > pass. > > Thanks > Joao > > On Tue, Mar 6, 2018 at 5:09 AM Khushboo Vashi < >

Build failed in Jenkins: pgadmin4-master-python33 #507

2018-03-07 Thread pgAdmin 4 Jenkins
See Changes: [Dave Page] Ensure all messages are retrieved from the server in the Query Tool. -- [...truncated 605.81 KB...]

Re: Build failed in Jenkins: pgadmin4-master-python33 #507

2018-03-07 Thread Dave Page
Khushboo, can you look at this ASAP please? It passed tests on my machine, but Jenkins isn't happy. Thanks. On Wed, Mar 7, 2018 at 2:01 PM, pgAdmin 4 Jenkins wrote: > See 507/display/redirect?page=changes> > >

Build failed in Jenkins: pgadmin4-master-python34 #501

2018-03-07 Thread pgAdmin 4 Jenkins
See Changes: [Dave Page] Ensure all messages are retrieved from the server in the Query Tool. -- [...truncated 605.26 KB...] 272 tests passed 1

Re: [pgAdmin4][RM#2989] To fix the issue in Table node

2018-03-07 Thread Murtuza Zabuawala
On Wed, Mar 7, 2018 at 6:12 PM, Dave Page wrote: > Hi > > On Tue, Mar 6, 2018 at 4:06 PM, Joao De Almeida Pereira < > jdealmeidapere...@pivotal.io> wrote: > >> Hi Murtuza, >> >> The code change works, and I passed the patches through our pipeline and >> everything is green. >>

Re: [pgadmin4][patch] GreenPlum function statistics through an exception

2018-03-07 Thread Dave Page
Thanks, applied. On Mon, Mar 5, 2018 at 2:25 PM, Joao De Almeida Pereira < jdealmeidapere...@pivotal.io> wrote: > Hi Hackers, > You can find attached the resolution for issue 3176. > When trying to retrieve the statistics from a function in a GreenPlum > database an error is displayed, To fix

Re: [pgAdmin4][RM#2989] To fix the issue in Table node

2018-03-07 Thread Dave Page
Hi On Tue, Mar 6, 2018 at 4:06 PM, Joao De Almeida Pereira < jdealmeidapere...@pivotal.io> wrote: > Hi Murtuza, > > The code change works, and I passed the patches through our pipeline and > everything is green. > Personally I would love this bug fixes to have refactored the function > into

Re: [pgAdmin4][RM#3037] Allow user to disable Gravatar image

2018-03-07 Thread Murtuza Zabuawala
Hi Joao, On Tue, Mar 6, 2018 at 10:56 PM, Joao De Almeida Pereira < jdealmeidapere...@pivotal.io> wrote: > Hello, > > I just sent a video that talks exactly about this, in the journey to have > a more maintainable code and easier to navigate, we sometimes increase > complexity for a period of

Re: [pgAdmin4][RM#3175] Fix PEP-8 issues

2018-03-07 Thread Dave Page
Thanks, applied! On Mon, Mar 5, 2018 at 4:23 PM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Thanks Joao for reviewing. > > > On Mon, Mar 5, 2018 at 8:58 PM, Joao De Almeida Pereira < > jdealmeidapere...@pivotal.io> wrote: > >> Hi Murtuza, >> >> Looks good, and all tests are

pgAdmin 4 commit: PEP8 fixes. Fixes #3175

2018-03-07 Thread Dave Page
PEP8 fixes. Fixes #3175 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=06ff05762e9bba0dd298c540afaf352dad747b28 Author: Murtuza Zabuawala Modified Files -- web/pgadmin/browser/__init__.py

pgAdmin 4 commit: Disable function statistics on Greenplum. Fixes #3176

2018-03-07 Thread Dave Page
Disable function statistics on Greenplum. Fixes #3176 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=d1ab47c10c910f8cad1247f8520c47cb01bee072 Author: Joao Pedro De Almeida Pereira Modified Files --

Re: [pgAdmin4][RM#2989] To fix the issue in Table node

2018-03-07 Thread Murtuza Zabuawala
Hi Dave, PFA updated patch. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Wed, Mar 7, 2018 at 6:14 PM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > > On Wed, Mar 7, 2018 at 6:12 PM, Dave Page

Re: Build failed in Jenkins: pgadmin4-master-python33 #507

2018-03-07 Thread Khushboo Vashi
Hi Dave, On Wed, Mar 7, 2018 at 7:34 PM, Dave Page wrote: > Khushboo, can you look at this ASAP please? It passed tests on my machine, > but Jenkins isn't happy. > > I have tried to reproduce the issue with many combination but couldn't reproduce it. With the help of logs, I

Re: [pgAdmin4][RM#3037] Allow user to disable Gravatar image

2018-03-07 Thread Murtuza Zabuawala
Hi Dave, PFA updated patch. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Wed, Mar 7, 2018 at 7:20 PM, Dave Page wrote: > Hi > > On Mon, Mar 5, 2018 at 8:12 AM, Murtuza Zabuawala

pgAdmin 4 commit: Make the poll query test a little more robust.

2018-03-07 Thread Dave Page
Make the poll query test a little more robust. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=1136e37cf0d96f0a9f2a08f0ea24b390dc9914b1 Author: Khushboo Vashi Modified Files --

Build failed in Jenkins: pgadmin4-master-python36 #503

2018-03-07 Thread pgAdmin 4 Jenkins
See Changes: [Dave Page] Allow admins to disable the use of Gravatar if they choose. Fixes #3037 -- [...truncated 611.66 KB...] 1 test failed:

Re: Build failed in Jenkins: pgadmin4-master-python33 #507

2018-03-07 Thread Dave Page
Thanks, applied. Lets see what happens. On Wed, Mar 7, 2018 at 4:37 PM, Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > Please find the attached updated patch. > This should work. > > > On Wed, Mar 7, 2018 at 9:46 PM, Dave Page wrote: > >> >> >> On Wed, Mar 7, 2018

Build failed in Jenkins: pgadmin4-master-python33 #509

2018-03-07 Thread pgAdmin 4 Jenkins
See Changes: [Dave Page] Allow admins to disable the use of Gravatar if they choose. Fixes #3037 -- [...truncated 612.25 KB...] 288 tests passed

Build failed in Jenkins: pgadmin4-master-python34 #503

2018-03-07 Thread pgAdmin 4 Jenkins
See Changes: [Dave Page] Allow admins to disable the use of Gravatar if they choose. Fixes #3037 [Dave Page] Make the poll query test a little more robust. --

Re: Build failed in Jenkins: pgadmin4-master-python33 #507

2018-03-07 Thread Dave Page
It still seems to be failing :-( https://jenkins.pgadmin.org/job/pgadmin4-master-python26/lastFailedBuild/consoleFull On Wed, Mar 7, 2018 at 4:50 PM, Dave Page wrote: > Thanks, applied. Lets see what happens. > > On Wed, Mar 7, 2018 at 4:37 PM, Khushboo Vashi < >

Re: Build failed in Jenkins: pgadmin4-master-python33 #507

2018-03-07 Thread Khushboo Vashi
On Wed, Mar 7, 2018 at 10:33 PM, Dave Page wrote: > It still seems to be failing :-( > > :( > https://jenkins.pgadmin.org/job/pgadmin4-master-python26/ > lastFailedBuild/consoleFull > > On Wed, Mar 7, 2018 at 4:50 PM, Dave Page wrote: > >> Thanks, applied.

Build failed in Jenkins: pgadmin4-master-python35 #513

2018-03-07 Thread pgAdmin 4 Jenkins
See Changes: [Dave Page] Allow admins to disable the use of Gravatar if they choose. Fixes #3037 [Dave Page] Make the poll query test a little more robust. --

Build failed in Jenkins: pgadmin4-master-python26 #640

2018-03-07 Thread pgAdmin 4 Jenkins
See Changes: [Dave Page] Allow admins to disable the use of Gravatar if they choose. Fixes #3037 [Dave Page] Make the poll query test a little more robust. --

Re: Build failed in Jenkins: pgadmin4-master-python33 #507

2018-03-07 Thread Dave Page
Hi On Wed, Mar 7, 2018 at 3:10 PM, Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > Hi Dave, > > On Wed, Mar 7, 2018 at 7:34 PM, Dave Page wrote: > >> Khushboo, can you look at this ASAP please? It passed tests on my >> machine, but Jenkins isn't happy. >> >> I have

Re: [pagdmin][patch] Update jasmine #3182

2018-03-07 Thread Dave Page
Thanks, applied. On Tue, Mar 6, 2018 at 8:56 PM, Joao De Almeida Pereira < jdealmeidapere...@pivotal.io> wrote: > Hi Hackers, > > Attached you can find the patch that updates the version of jasmine to 3.0 > > Thanks > Joao > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake

Build failed in Jenkins: pgadmin4-master-python36 #502

2018-03-07 Thread pgAdmin 4 Jenkins
See Changes: [Dave Page] Update Jasmine to v3. Fixes #3182 [Dave Page] Insert rows correctly when a table has OIDs and a Primary Key in -- [...truncated 611.65

Re: Build failed in Jenkins: pgadmin4-master-python33 #507

2018-03-07 Thread Khushboo Vashi
On Wed, Mar 7, 2018 at 9:23 PM, Dave Page wrote: > Hi > > On Wed, Mar 7, 2018 at 3:10 PM, Khushboo Vashi < > khushboo.va...@enterprisedb.com> wrote: > >> Hi Dave, >> >> On Wed, Mar 7, 2018 at 7:34 PM, Dave Page wrote: >> >>> Khushboo, can you look at this

Re: Build failed in Jenkins: pgadmin4-master-python33 #507

2018-03-07 Thread Dave Page
On Wed, Mar 7, 2018 at 4:13 PM, Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > > > On Wed, Mar 7, 2018 at 9:23 PM, Dave Page wrote: > >> Hi >> >> On Wed, Mar 7, 2018 at 3:10 PM, Khushboo Vashi < >> khushboo.va...@enterprisedb.com> wrote: >> >>> Hi Dave, >>> >>> On

pgAdmin 4 commit: Update Jasmine to v3. Fixes #3182

2018-03-07 Thread Dave Page
Update Jasmine to v3. Fixes #3182 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=e7316e2181c256ee33d0958043e6cb1147949647 Author: Joao Pedro De Almeida Pereira Modified Files -- web/package.json

Re: [pgAdmin4][Patch]: RM #3135 - [Web based] Syntax error displayed when user try to insert data on table where primray key is in captial letters and table contains OIDS

2018-03-07 Thread Dave Page
Thanks - applied. On Wed, Mar 7, 2018 at 4:30 AM, Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > > > On Tue, Mar 6, 2018 at 8:35 PM, Joao De Almeida Pereira < > jdealmeidapere...@pivotal.io> wrote: > >> Hello Khushboo, >> >> All tests pass on CI, and the code looks good. The only

Build failed in Jenkins: pgadmin4-master-python26 #638

2018-03-07 Thread pgAdmin 4 Jenkins
See Changes: [Dave Page] Update Jasmine to v3. Fixes #3182 -- [...truncated 608.92 KB...] Detach partition from existing

pgAdmin 4 commit: Insert rows correctly when a table has OIDs and a Pri

2018-03-07 Thread Dave Page
Insert rows correctly when a table has OIDs and a Primary Key in uppercase. Fixes #3135 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=ae5c13188d51d6bdb023c320c2be148ddad8eb55 Author: Khushboo Vashi

Build failed in Jenkins: pgadmin4-master-python34 #502

2018-03-07 Thread pgAdmin 4 Jenkins
See Changes: [Dave Page] Update Jasmine to v3. Fixes #3182 [Dave Page] Insert rows correctly when a table has OIDs and a Primary Key in -- [...truncated 611.81

Build failed in Jenkins: pgadmin4-master-python33 #508

2018-03-07 Thread pgAdmin 4 Jenkins
See Changes: [Dave Page] Update Jasmine to v3. Fixes #3182 [Dave Page] Insert rows correctly when a table has OIDs and a Primary Key in -- [...truncated 612.37

Re: [pgAdmin4][RM#2989] To fix the issue in Table node

2018-03-07 Thread Dave Page
Hi On Wed, Mar 7, 2018 at 2:59 PM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi Dave, > > PFA updated patch. > > Using your example on the ticket, I added a "character varying (32)" column with NOT NULL to the table. When I then edit the column, and turn off NOT NULL

Build failed in Jenkins: pgadmin4-master-python27 #511

2018-03-07 Thread pgAdmin 4 Jenkins
See Changes: [Dave Page] Update Jasmine to v3. Fixes #3182 [Dave Page] Insert rows correctly when a table has OIDs and a Primary Key in -- [...truncated 612.44

pgAdmin 4 commit: Allow admins to disable the use of Gravatar if they c

2018-03-07 Thread Dave Page
Allow admins to disable the use of Gravatar if they choose. Fixes #3037 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=abf0b1a7ae0b57cf08ca196adc641f66868e20e5 Author: Murtuza Zabuawala Modified Files

Re: Build failed in Jenkins: pgadmin4-master-python33 #507

2018-03-07 Thread Khushboo Vashi
Please find the attached updated patch. This should work. On Wed, Mar 7, 2018 at 9:46 PM, Dave Page wrote: > > > On Wed, Mar 7, 2018 at 4:13 PM, Khushboo Vashi < > khushboo.va...@enterprisedb.com> wrote: > >> >> >> On Wed, Mar 7, 2018 at 9:23 PM, Dave Page

Build failed in Jenkins: pgadmin4-master-python26 #639

2018-03-07 Thread pgAdmin 4 Jenkins
See Changes: [Dave Page] Insert rows correctly when a table has OIDs and a Primary Key in -- [...truncated 615.50 KB...]

Build failed in Jenkins: pgadmin4-master-python35 #512

2018-03-07 Thread pgAdmin 4 Jenkins
See Changes: [Dave Page] Update Jasmine to v3. Fixes #3182 [Dave Page] Insert rows correctly when a table has OIDs and a Primary Key in -- [...truncated 611.77