Re: [pgadmin4][patch] Initial patch to decouple from ACI Tree

Hi Joao, On Tue, May 15, 2018 at 8:33 PM, Joao De Almeida Pereira < jdealmeidapere...@pivotal.io> wrote: > Hello Ashesh, > > These are our comments to the patch: > > >- > >Can you explain the reasoning behind the change you did on the >canCreate function? > > I do agree as Akshay ment

Re: [pgAdmin4][Patch] Feature #3204 Notify/Listen not working in version 2.1

Hi Hackers, On Tue, May 15, 2018 at 9:52 PM, Akshay Joshi wrote: > Hi Joao > > On Tue, 15 May 2018, 19:36 Joao De Almeida Pereira, < > jdealmeidapere...@pivotal.io> wrote: > >> Hi Akshay, >> >> This patch is flaky; it doesn't always pass the tests in our pipeline. >> >> =

Diffs as images

All, Please don't send images to show code changes. It's unnecessary when you could just send a diff file, and just increases the amount of bandwidth and storage used in peoples mailboxes and the archives, but worse, can eat into bandwidth allowances for those using mobile devices, particularly an

pgAdmin 4 commit: Use VCINSTALLDIR instead of VCDIR, as that is set by

Use VCINSTALLDIR instead of VCDIR, as that is set by Visual Studio Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=7a1d9c750a2662d9cc693268f481babdf9f8b450 Modified Files -- Make.bat | 14 +++--- 1 file changed, 7 insertions

pgAdmin 4 commit: Assume Yarn and Node are always in the path

Assume Yarn and Node are always in the path Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=4496a97a975f98ca125e7e1f26debbf36afd7419 Modified Files -- Make.bat | 18 +- 1 file changed, 1 insertion(+), 17 deletions(-)

[pgAdmin4][RM#3307]User interface unable to connect to database running on port range 1-1024

Hi Hackers, PFA patch to allow server port number below 1024 till 1 in Create Server dialog. Thanks and Regards, Aditya Toshniwal Software Engineer | EnterpriseDB Software Solutions | Pune "Don't Complain about Heat, Plant a tree" diff --git a/web/pgadmin/browser/server_groups/servers/static/js/s

pgAdmin 4 commit: No need to define PGADMIN4_USE_WEBKIT any more.

No need to define PGADMIN4_USE_WEBKIT any more. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=246c434b61830d94744bca37fbf89b64fa120027 Modified Files -- Make.bat | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

pgAgent commit: Refactored the connInfo and DBconn and use of PQconninf

Refactored the connInfo and DBconn and use of PQconninfoParse() for parsing the connection string replacing our own version parsing logic. Reviewed by Ashesh, also modified it to take care of the removal of wxWidgets dependency change. Branch -- master Details --- https://git.postgresql.

pgAgent commit: Removed the third party library wxWidgets dependency. Y

Removed the third party library wxWidgets dependency. Yay :-) Using boost instead of wxWidgets for several cross platform functionalities. Reviewed by: Akshay Joshi & Ashesh Vashi Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgagent.git;a=commitdiff;h=1573bcc8333d26d

pgAdmin 4 commit: PYTHON_VERSION is set automatically. Use it to condit

PYTHON_VERSION is set automatically. Use it to conditionally fix the backports module. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=ae03b7c226188f347dfcc9346cc37b50cb965094 Modified Files -- Make.bat | 9 +++-- 1 file change

Re: [pgAdmin4][RM#3307]User interface unable to connect to database running on port range 1-1024

Hi Aditya, Looks good to us! Sincerely, Anthony & Victoria On Wed, May 16, 2018 at 7:24 AM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Hackers, > > PFA patch to allow server port number below 1024 till 1 in Create Server > dialog. > > Thanks and Regards, > Aditya Toshniw

Re: Diffs as images

Understood. Thanks for bringing this to our attention. On Wed, May 16, 2018 at 6:52 AM Dave Page wrote: > All, > > Please don't send images to show code changes. It's unnecessary when you > could just send a diff file, and just increases the amount of bandwidth and > storage used in peoples mail

pgAdmin 4 commit: PGDIR isn't needed in the path and we shouldn't have

PGDIR isn't needed in the path and we shouldn't have random Mingw paths hard-coded. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=6d33542b2476e853a3a41081a9743cf7d86557e6 Modified Files -- Make.bat | 2 +- 1 file changed, 1 inser

Re: [pgAdmin4][Patch] Feature #3204 Notify/Listen not working in version 2.1

Hey, The code looks great! The tests all passed as well. Sincerely Anthony and Victoria

[pgadmin] Prefer CSS selectors to XPath selectors in feature tests

Hey all, We've noticed that our feature tests make extensive use of xpath with the selenium api. It's well documented that css selectors are easier to read and more efficient. I think we should start to favor these if we have not considered so already. http://bugsareinthegaps.com/what-is-the-best

Re: PATCH: pgagent connection string parsing

[Adding pgadmin-hackers list...] Hi Team, Using the mutex around the logging code too to avoid overlapping log message. Please review it, and let me know your concern. Implementation details: - Moved 'MutexLogger' class, which was used by the connection management code only, in the include/misc.

pgAdmin 4 commit: Rough cleanup of the environment setup

Rough cleanup of the environment setup Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=9f8f1e89727ec93d9fcd5da4f953ae64898a78f1 Modified Files -- Make.bat | 91 ++-- 1 file

pgAdmin 4 commit: Further cleanup of the environment setup

Further cleanup of the environment setup Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=76749efb12decaef8591dd7a6df0fa416a6e7c38 Modified Files -- Make.bat | 21 + 1 file changed, 9 insertions(+), 12 deletions(-

Re: [pgadmin4][patch] Initial patch to decouple from ACI Tree

export function canCreate(pgBrowser, childOfCatalogType) { return canCreateObject.bind({ browser: pgBrowser, childOfCatalogType: childOfCatalogType, }); } With respect to the above code: this bind pattern looks good and seems like the idiomatic way to handle this in JavaScript. On a li

pgAdmin 4 commit: Further cleanup of the environment setup

Further cleanup of the environment setup Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=765e0d03be71da07f504a3b41fb845d59a555f5c Modified Files -- Make.bat | 51 ++- 1 file changed, 2

pgAdmin 4 commit: Fix a couple of find/replace errors.

Fix a couple of find/replace errors. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=bd356ff9fa442e244ece107d56e8e3bb2ed30116 Modified Files -- Make.bat | 21 ++--- 1 file changed, 10 insertions(+), 11 deletions(-)

Re: [pgadmin4][patch] Use ESLinter options instead of using Javascript

Hey all, we'd definitely like some feedback on this patch. Does does it not apply cleanly? Do we need to resend it? Thanks Anthony On Mon, May 14, 2018 at 3:47 PM Anthony Emengo wrote: > Apologies, here's a redo that should apply cleanly on top of master > > Anthony && Joao > > On Mon, May 14,

Re: [pgadmin4][patch] Use ESLinter options instead of using Javascript

Hi Anthony, The code looks good to me and working fine. Thanks, Khushboo On Wed, May 16, 2018 at 9:23 PM, Anthony Emengo wrote: > Hey all, we'd definitely like some feedback on this patch. Does does it > not apply cleanly? Do we need to resend it? > > Thanks > Anthony > > On Mon, May 14, 2018

Re: [pgadmin4][patch] Use ESLinter options instead of using Javascript

On Thu, May 17, 2018 at 11:05 AM, Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > Hi Anthony, > > The code looks good to me and working fine. > > Thanks, > Khushboo > > > On Wed, May 16, 2018 at 9:23 PM, Anthony Emengo > wrote: > >> Hey all, we'd definitely like some feedback on this p

pgAdmin 4 commit: Using the '.eslintignore' config file for excluding t

Using the '.eslintignore' config file for excluding the temporary, vendor specific, and templates files, instead of writing our own logic to do so. Patch by: Anthony & Joao Reviewed by: Khushboo Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=